The 2nd Monitor

Duga

12:00 PM

[Zomis/CodeReview-Shield] Zomis created repository

skiwi

@Duga Is it going to protect us?

Duga

@dewe [CodeReview](codereview.stackexchange.com) might be better suited for this, they offer critique and suggestions to improve code that's already working. I might be misunderstanding your question though, so please read their site tour before asking there. — SuperBiasedMan just now

RubberDuck

Anyone around to talk dependency injection?

nhgrif

Does someone want some Objective-C upvotes on Code Review?

9

Q: BiDirectional Dictionary (and its Mutable friend can come too)

I've attempted to implement a 1-to-1 dictionary in Objective-C. I'm probably missing some convenient methods that one might commonly want to use. These are both declared in the same .h file and implemented in the same .m file. I think if much more code is added to either of these, splitting th...

This pre-Swift 1.2 question's code has room to add Objective-C-Nullability annotations:

9

A: How to create class methods that conform to a protocol shared between Swift and Objective-C?

In Objective-C, we were always passing around pointers, and pointers could always be nil. Lots of Objective-C programmers made use of the fact that sending a message to nil did nothing and returned 0/nil/NO. Swift handles nil entirely differently. Objects either exist (never nil), or it is unk...

RubberDuck

More specifically, how to deal with tons of dependencies bubbling up through the classes?

And the massive constructors that ensue....

nhgrif

12:06 PM

Example?

( a simple one... I'm not that familiar with this concept of "dependency injection" and I've never had massive constructors...)

RubberDuck

Okay, so I have this plugin architecture.

Where there's a single point of entry into a class that is responsible for doing a little bit of work, but mostly, just delegates to other presenters that know about how each piece of the system works.

Which was great. It kept all of the business logic nice and neatly separated.

But now I've ended up with this terribly monster ctor. One sec will paste it in.

skiwi

@RubberDuck You want to inject some stuff?

What about autowiring things? The Spring MVC in Java has an @Autowired annotation that removes the need for injecting it in the constructor

RubberDuck

public SourceControlPresenter(
    VBE vbe,
    AddIn addin,
    IConfigurationService<SourceControlConfiguration> configService,
    IChangesView changesView,
    IUnsyncedCommitsView unsyncedCommitsView,
    ISettingsView settingsView,
    IBranchesView branchesView,
    ICreateBranchView createBranchView,
    IDeleteBranchView deleteBranchView,
    IMergeView mergeView,
    ISourceControlView view,
    IChangesPresenter changesPresenter,
    IBranchesPresenter branchesPresenter,
    ISettingsPresenter settingsPresenter,

@skiwi go on. How does that work? I'm sure there's something similar in the C# world.

skiwi

@RubberDuck Let me dig up an example

RubberDuck

ok

skiwi

12:11 PM

@RubberDuck Holy mother of cows!

RubberDuck

Yeah... I know

It all bubbled up to the top and now I don't know what to do with it.

skiwi

@RubberDuck What about don't touch it?

nhgrif

Well

skiwi

How many of those classes exist in your application?

Should there always be only one, or can there actually be multiple?

RubberDuck

@skiwi certainly an option. It is the entry point.

Entry point. There's only one of each and they get created just outside of this class and injected in.

skiwi

12:13 PM

That's your candidate for an Autowiring/Beans architecture

So... I have this

@Controller
@MessageMapping("/api/user")
class UserController {
    UserService userService

    @ControllerMethod
    @MessageMapping("/create_user")
    def createUser(CreateUserMessage createUserMessage) {
        try {
            userService.createUser(*createUserMessage.values())
            def builder = new JsonBuilder()
            builder {
                success true
            }
        } catch (CreateUserException ex) {
            def builder = new JsonBuilder()
            builder {

Here the UserService userService is autowired via Grails/Groovy (but it uses Spring MVC in the backend)

I have an UserService class and Grails automatically creates an instance of that on startup and saves it as a Spring Bean

A Spring Bean is a class/instance you can always inject in your application

RubberDuck

so.... where the heck does userService actually come from?

skiwi

@RubberDuck Nobody knows...

But I can define my own class if I want to do so

I could have defined it in my resources.groovy file as:

beans = {
    userService(UserService)
}

(UserService in Groovy is UserService.class in Java)

But Grails is configured to automatically beanify everything in the controller directory (and a few more)

Duga

No , no ! I would like you to tell me if this is a good way of doing it ! Actually, here is the source code on codereview : codereview.stackexchange.com/questions/95275/… — MattMatt 42 secs ago

Captain Obvious

0

Q: Unit testing a homework assignment

I wrote NUnit tests for class CharGrid from this homework assignment. I am a beginner with C# and NUnit. My goal here is DRY: I want to keep the testing code as short and simple as possible. In addition, want to run every test independently, as opposed to having a single method with a lot of as...

beginner unit-testing homework nunit

skiwi

Oops... found this gem

> My role in this project was also to resolve conflicts if they would happen because using this system alone does not guarantee that everyone will go as it should, someone should be taking care of that.

Yes... I wrote that

RobH

12:21 PM

@RubberDuck - you could create some parameter objects. E.g. group all of your views together into an ISourceControlViews object with a CreateBranchView property, a DeleteBranchView property etc. Then simplify your constructor to take the aggregate instead

skiwi

@RubberDuck What kind of C# framework are you using right now?

RubberDuck

@RobH that's not a bad idea. Could simplify things a bit. I had considered it before, but it felt like moving the problem.

Maybe it's not. Could be a useful abstraction I suppose.

@skiwi Plain old class objects.

@RobH welcome to the 2nd monitor btw! You write great answers. It's nice to "meet in person".

skiwi

@RubberDuck Uh... no framework?

RobH

:) thanks. I ocassionally lurk here without actually saying anything. The joys of being at work

skiwi

I need to find some inspiring figure about Version Control for this write-up...

I hate mandatory figures

RubberDuck

12:26 PM

@skiwi Nope. Pure DI up till now. Just installed Ninject to see if it will help, but I can't see how it really will. Maybe if I do what RobH said too...

skiwi

@RubberDuck But I mean for the MVC part? Or how is the application structured?

RubberDuck

Oh... Winforms.

So, it's MVP flavored MVC. No framework.

RobH

@RubberDuck - If you use StructureMap you can use a convention to scan all your asssemblies and autowire single implementations of interfaces

RubberDuck

Thanks. Will look into it.

skiwi

@RubberDuck Ok...

Captain Obvious

12:29 PM

0

Q: Fade and eye detection algorithms for opencv

i'm working on face and eye detection (no recognition needed) using opencv , and i've found some algorithms that i can use : Viola–Jones object detection framework : This algorithm is implemented in OpenCV as cvHaarDetectObjects(). https://en.wikipedia.org/wiki/Viola%E2%80%93Jones_object_detect...

opencv

skiwi

(btw. What's this Nth Monitor?)

rolfl

@skiwi QPaysTaxes and Ethan were prattling on like a couple of seagulls squabbling over some french fries. It was annoying and inconsiderate, so they were moved over to there.

4

skiwi

@rolfl Some specific event or you mean what they're doing for a week already?

Ugh, how do I explain version control to 16 year olds of general public?

rolfl

They crossed the line a while ago, but this part is where I figured I could step in and explain it without "grey areas":

in The Nth Monitor, 8 hours ago, by QPaysTaxes

Thanks, but I already have a girlfriend...

nhgrif

What's "SNR"?

skiwi

12:40 PM

@nhgrif Signal to Noise Ratio

rolfl

Signal to Noise Ratio

Mast

That ^^

skiwi

@rolfl I also had that feeling, but it's difficult to address it

rolfl

They were like two peope talking loudly to each other on cell phones on the same bus.... that's about as close as I can get to an analogy .... and, they now have their own bus

nhgrif

And they're the only ones on that bus. And they're still talking to each other loudly on their phones?

skiwi

12:44 PM

They are calling eachother on their phones, or talking to someone else?

rolfl

each other

skiwi

Okay... that's yeah, well, no words for that

Mast

Reminds me of a certain group of regulars in the local supermarket, yelling like there's 200m between them while they're standing next to each other.

rolfl

and everyone else on the bus is irritated, but too polite to tell them to shut up .... and they say: well, "noone else is talking, so we may as well".

but their conversation is not about general-interst things, or specific bus needs

@skiwi Version control is the string you use when you walk in to a maze and need to find your way out again

2

Mast

Perhaps I'm too curious, when when is something considered 'not general-interest'? I could think of a couple of examples, but I suppose there's a line somewhere.

rolfl

12:48 PM

it tells you where you have been, what you have done before, and, if you are a group of people, it allows you to explore different paths as individuals, and merge them back together.

@Mast That's the hard part.... there is a line somewhere.... but, if the conversation is only of interest to the two people talking, then it is no longer "general discussion"

If the conversation could be held in a different room, and no-one in this room would miss it, then it does not beong here.

2

Mast

Of-course, but does that mean as long as at least 3 people are interested in the conversation it's still valid? It can't be that simple.

rolfl

No, it's not that simple.

that's the problem.

And, it goes in swings and round-abouts.

spyr03

"I was shopping today, there is a sale on in blah" vs "I was shopping today, I got a tshirt"?

Would that be an example?

Mat's Mug

@Mast if it makes a circle where it's happening because nobody's talking and then nobody's talking because it's happening, the line was crossed.

rolfl

so, it has swung too far in to the banalities of the lives and transgressions of people, and it is time to clamp down, and maybe go too far in the other direction.... to define the limits.

nhgrif

12:52 PM

@Mast That's the problem. When there was only one teenager in the room, there was never 3 or more people interested in talking about teenager things. Now there are 3 or more teenager regulars.

There are far more non-teenager regulars that don't want to hear about teenager non-sense and silliness.

rolfl

I think labeling it as "teenager" issues is an injustice.

nhgrif

Maybe.

rolfl

Even if it was a tutorial between two or a few people, they would get a new room

nhgrif

Depends on how in-depth and on-going it was.

rolfl

Yes, which is why this issue is complicated

nhgrif

12:55 PM

But the distinction I'm trying to make is that if two people are going on-and-on about something programming related, I could skim the conversation or pay half attention, and I might accidentally learn something.

rolfl

there's a big grey area, but, it was pretty black/white with QPaysTaxes and Ethan at the point I stepped in.

@nhgrif Yes, or you could see they were in a different room, and then go in to there and listen.

Mast

Hard part there would be defining when it's a short occurrence and when it's a 'going on and on'

nhgrif

Right, but if they were talking about programming stuff and nothing else was going on, I wouldn't be that bothered. I'd count almost any programming conversation as "signal" and not "noise"

rolfl

Not if they are just chatting to fill the space.

Mast

There was a conversation earlier today about electrics and LAN parties of which I later realized it may have been an edge case.

skiwi

12:57 PM

@rolfl So everything related to code is per definition of interest, even if only two people are talking, kind of?

nhgrif

Hmm... then rolfl, you're going to explain with much more depth what you mean exactly then...

skiwi

For the record, I think it was a good decision

nhgrif

Are you saying that you and I couldn't have an hour long conversation about iOS development in this chat room (assuming it wasn't interfering with anyone else... no one else was chatting, etc.)? I've never seen anyone have a problem with cross-conversation chat or interrupting an on-going conversation. As a general rule, if you and I were bothered by the interruptions, we'd go to another room to continue our conversation uninterrupted.

But if there were no interruptions and we were discussing something unquestionably on-topic for the site... is it really a problem for two people to go back & forth for so long?

I agree on moving those two out, yes, but I'm completely confused by what you're saying...

rolfl

6 hours ago, by QPaysTaxes

...Man, people like copy/pasting from Wikipedia without attribution

Spouting out on irrelelvant crap just to create conversation

Quill

That was actually a discussion about my tag edit spree

@rolfl Yeah, it got fairly bad

Sometimes the line is a little blurry and you gotta know when to step out

My rule: If in doubt, step out.

Captain Obvious

1:04 PM

0

Q: Recognizing number representation (and convert to decimal) from the base prefixes?

Here is what appears to be a fairly easy problem: Write a program that prompts the user to enter several integers in any combination of octal, decimal, or hexadecimal, using the 0 and Ox base prefixes; interprets the numbers correctly; and converts them to decimal form. Then your program...

c++ converting

rolfl

5 hours ago, by QPaysTaxes

@Mast Does ice cream count as meat?

Quill

@skiwi Like drafting assessments in high school, I guess

2 mins ago, by Quill

@rolfl Yeah, it got fairly bad

nhgrif

So

Hmm, perhaps its best to just resign myself to not understanding.

Quill

@nhgrif nhgrif while programming is more ontopic than ice cream meat, sometimes it might be best to make a temp room

Depends on the potential size of the conversation

rolfl

I feel like I am picking on @QPaysTaxes - and perhaps I am, but he's using this chat room as his own personal twitter-flood, relating and retelling every event of his life.

skiwi

1:07 PM

@rolfl Maybe some kind of rule of thumb could be that you are of course free to come here and ask code review/programming related questions, but you cannot really joke around until you're an accepted member?

It does create a nuance of that we have a group in here... not sure if we should avoid that, or just face reality?

nhgrif

Because I think these particular examples are unfair.

Quill

It's not a matter of picking on, or unfairness.
It's a matter of topic and relevance

rolfl

@nhgrif I jsut scanned this morning's transcript

Unfortunately, previous transcripts are so large and full of general mayhem that there's too much to go through ;-)

nhgrif

Sure, but did you read the conversation leading up to the comment?

Quill

There's a level of detail you should go into things about, and discussing your life like you would with a familiar friend should not be done here.

I think we need to define General in 'General discussion about Code Review -> codereview.stackexchange.com'

nhgrif

1:09 PM

As far as I'm concerned, if "does ice cream count as meat?" is the problem, then how is Quill's "isn't it 4 am there? you should sleep?" (which started down the path to "does ice cream count as meat?") okay?

Quill

To be fair, he sleeps, chat can return to topic

nhgrif

If Quill's comment about the time & sleeping is okay, then why isn't the line back when QPays mentioned having caffeine?

And if that's okay, then why isn't the line at Mast recommending meat over caffience?

rolfl

Here: chat.stackexchange.com/transcript/8595/2015/6/28

note the flow of the conversation, someone says something, QPaysTaxes responds with a witty 1-liner.

next person, next 1-liner

son on, and so on and so on,

it's a peanut gallery

each time also slightly diverting the conversation too

Quill

It's a bit chatty, to be honest, it should be If you having something to contribute, then contribute, but a one liner not worth anything below five stars shouldn't be posted

A joke is relevant here and there, but not as a constant

nhgrif

@rolfl So you're saying it's not black & white, but a gray area.

rolfl

1:12 PM

very grey.

it is not just one incident, but a collection, and profusion of them too

nhgrif

I don't know what "very gray" means.

I agree.

Vogel612

chat in general is a very very grey area

nhgrif

but it's not black & white

Vogel612

@nhgrif it almost never is....

Malachi

@rolfl he accepted my answer without giving us any further information on the database structure ►► codereview.stackexchange.com/q/95231/18427

rolfl

1:13 PM

yes, it is somewhere between #000001 and #ffffffe

3

Quill

Perhaps enforcing nth monitor as a thing, with 2nd monitor being from comments everyone can appreciate

Malachi

Monking

rolfl

breakfast .... something useful!

Vogel612

finally?!

nhgrif

Who is to judge what "everyone appreciates"

Quill

1:16 PM

That is grey, also

@rolfl, perhaps you should make a temp room when you're all online next and discuss/lay down the law with them

skiwi

@Quill I don't see a reason to change a lot, we've been fine up til now, I'd change nothing that hurts the people who have been around since... forever

Mat's Mug

@Quill meta 2nd monitor

Quill

@Mat'sMug If it comes to that

Captain Obvious

0

Q: Longest Increasing Subsequence in javascript

As i am learning Dynamic programming, so i have written down some code for Longest Increasing Subsequence. I would like to know have i missed any case or any area of improvement in the terms of optimization/programming style. /** * LIS = Longest increasing subsequence. * Input = [10, 22, 9, 33...

javascript performance dynamic-programming

Quill

I think the phrase give them an inch and they'll take a yard applies too

Mat's Mug

1:21 PM

Not on meta lol, I mean that discussions about The 2nd Monitor technically belong in a room about The 2nd Monitor

Quill

@Mat'sMug Yes, I figured

also a lot of sites have normal site rooms and meta rooms

often named similar things

Vogel612

meh.

the problem is, killing idle chatter categorically makes a chatroom die

after all chat is intended to be the "third place"

main for "business", meta for "about business" and chat for ... "the rest" or something like that

2

Quill

They're getting increasingly banned lately too

Q while I've been idling at least four to five and Ethan twice or so

Vogel612

hrmph.. this is devolving into a mudslinging...

skiwi

@Quill What's that?

Quill

1:25 PM

@skiwi Being kick/muted from offensive chat posts

Vogel612

auto kick-mute?

Mat's Mug

Kick-muted is gentle

I mean a "ban" is something more serious

Malachi

@Quill you guys have been banned from chat?

Vogel612

ban is actually worse than a suspension, since a ban is permanent

Quill

@Malachi Not me, and sorry @all, I meant to say kickmuted

Vogel612

1:27 PM

but that's technicalities...

Malachi

you can't run for Moderator..... it would unban you from those rooms

Quill

@Vogel612 I like them as people and they're becoming good answerers, so it's not like I want to sling mud and I don't think @rolfl does either.

Malachi

oh in that case, Carry on...

lol jk

Quill

It's a dangerous line to tread ...

Mat's Mug

@Malachi that's why candidates must be in good standing ;-)

Quill

1:32 PM

What do you think @Mat'sMug, you were <lurk>ing earlier

Mat's Mug

I think moderating chat is harder than many things

5

I agree with @rolfl and I'm glad he stepped in.

And yes, maybe it's time to take a swing into the opposite direction. I don't think killing this chatroom is going to happen.

Quill

Should these two questions be combined, they're part of the same solution, and without the other they could probably be closed for missing code

Vogel612

@Quill no why?

Malachi

@Mat'sMug Hold up, Wait a minute, what happened, how far back to I have to go in chat?

Vogel612

a model implementation can stand on it's own

Quill

1:40 PM

@Vogel612 Thanks for the clarification :-)

Vogel612

@Malachi depends. today 6:12 ..

@Quill working != runnable

Quill

1 hour ago, by rolfl

@skiwi QPaysTaxes and Ethan were prattling on like a couple of seagulls squabbling over some french fries. It was annoying and inconsiderate, so they were moved over to there.

There being here:

The Nth Monitor

Conversations that don't quite fit in The 2nd Monitor

Malachi

@Quill gotcha, I did catch a little bit of that

Donald.McLean

Greetings, Programs.

Captain Obvious

0

Q: Code for Gmail Data Analysis

I am using Imaplib to fetch data from Gmail and getting the number of Emails Each day. I am going to login using imaplib two times for fetching Emails for INBOX as well as for OUTBOX(Sent mail). Is it possible that I have to login only once and get result as I need? from imaplib import IMAP4_SSL...

python-2.7

0

Q: Please check the code quality of the OOP beginner

I'm new in OOP but I enjoy it. I have started with oop around 1 week ago and I would like to ask you to check my code and give me some tip's and advice's but also tell me what I'm doing completely wrong.I'm giving you code of my User Class, Switch Class,Init and Views/login.php (I'm using there ...

php oop

nhgrif

1:48 PM

@Vogel612 Exactly...

I'm still just entirely confused by what's been said about what happened...

Quill

I just made a bunch of suggestions and statements and rolfl went quiet, ask him what's happening if you want absolute

nhgrif

No, no, no. Please for the love of everything, don't use things like π for variable names... — nhgrif 31 secs ago

Vogel612

@Donald.McLean Greetings, User

Quill

> I also Know that my code is not protected against SQL Injection

Honesty, at least

Malachi

@Donald.McLean You've Got Mail!

Donald.McLean

1:55 PM

@Malachi I like that movie too.

Captain Obvious

0

Q: PHP session_set_saver_handler with session timeout

I have developed a class that utilises the session_set_saver_handler function so I can store sessions within my DB. The class works just as I would like. However, my only concern is the way I have approached the session timeout. Current the _read() function code looks like; /** * Read ...

php oop session

3

Q: Shielding your CodeReview on Github

In response to a feature-request on meta, I spent a few hours today creating the feature in php. This adds a 'review shield' to your GitHub repository (or wherever else you want it). It looks like the following: To use it, use something like this: [![Code Review](http://www.zomis.net/codere...

php pdo stackexchange svg

0

Q: Tokenizing a simple mathematical expression

So, I decided to learn TypeScript for... reasons. I decided to start off with a simplish exercise that I generally do for this sort of thing - parsing and evaluating a mathematical expression (numbers and +-/*). All I've written so far is a tokenizer/lexer but looking for feedback now before I wr...

parsing typescript

Quill

@CaptainObvious This is really really cool

skiwi

Hahaha, I needed to include a figure in this assignment, so I pulled some random figure of decentralized version control, and it got accepted

The Nth Monitor

Transcript for