I am looking for a simple code review Eclipse plugin to review Java or others files from Maven/SVN project with an export on a Excel sheet.
Do you know about such tool ?
@Donald.McLean Does the code work? How can you tell if the user hasn't told you what its supposed to do? Or worse, if there are two or more languages, two or more files, what's context and what's up for review?
A question with two or more languages requested for review is too broad. A question with two languages, but one provided as context for the other isn't too broad, but if there's no description of what the question is about, it's unclear which part is up for review.
Objective C Bridge
// ZoomableImageViewManager.m
// loaddocs
//
// Created by William Chu on 6/29/15.
// Copyright (c) 2015 GoConvoy. All rights reserved.
//
#import "ZoomableImageViewManager.h"
#import "RCTViewManager.h"
#import "UIImageView+AFNetworking.h"
@implementation ZoomableImageV...
We take a string as input that must contain only 'A', 'C', 'G', and 'T'. For instance, "AACCC" should return the Map that looks like this: Map('A' -> 2, 'C' -> 3, 'G' -> 0, 'T' -> 0). More detail can be found in a gist with specs
This is my solution:
class DNA(code: String) {
val nucleotides ...
We only have 3 custom close reasons. There is no guarantee that we'll get more once the graduation process is complete. Lots of graduated sites have just 3 custom reasons.
I don't know Scala so I can't fully inspect other problems it might have, but I certainly wouldn't call that unclear..
@Vogel612 Just because someone incorrectly close voted in this case doesn't mean that the "unclear" close vote isn't perfectly applicable in tons of cases.
if it is unclear what the code is supposed to be doing, then the question is unclear, you can't review the code and possible change what the code does because we don't know what they user wants it to do
@nhgrif I usually comment on those to see if the user really wants to put effort in, then I downvote, and then see what happens. if I can see what the code is doing right away.
Questions shouldn't be left open indefinitely until we're tired on waiting for the user to fix them. They should be closed if they are off-topic. If the user edits it back to being on-topic, reopen it.
I'm reasonably new here but wondered why this question got put on hold?
The OP asks for a review of the code he had provided as the answer to another post on this site. (He includes a link to the original post.)
His request seems to fall within this discussion of what is a code review and I wou...
@nhgrif if it is unclear and not necessarily wrong, I would rather give the user a little bit of time to clean it up than to shut them down and make them cry. Programmers are Fragile
You could add a description (because you just had a code dump) that makes your question even further off-topic (feature request, broken code, not working, whatever)
@rolfl yeah, I didn't like doing it in PHP, but I think PHP might actually be one of the best tools for the job (ugh, I can't believe what I'm saying...)
@Mat'sMug Thanks, I wonder how you're gonna use this in RubberDuck though, I have a feeling the README of your github repo will be filled with these...
@rolfl time is 4:34 p.m. I ain't sleeping now! I am preparing food though.
room topic changed to The 2nd Monitor: General discussion about Code Review site -> codereview.stackexchange.com [addicted-to-cr] [just-saying-hi] [kick-the-trolls] [monkey-business] [my-code-is-compiling] [nice-people-room]
room topic changed to The 2nd Monitor: General discussion about Code Review site -> codereview.stackexchange.com Idle chatter moved to the Nth monitor, and violators will be kicked [addicted-to-cr] [just-saying-hi] [kick-the-trolls] [monkey-business] [my-code-is-compiling] [nice-people-room]
On a personal note, your code is really clean, the idea is brilliant, and I really hope to see it implemented soon.
Your code is well implemented and structured, but there's syntax points that could be improved.
I see a lot of basic if-else statements, if you're into ternaries, using them re...
But what i am trying to say is.. This is a public room that people like myself can join and chat in, how does someone new know that they can't have general chatter
No... @rolfl ... The content is either on or off topic... You can't just to decide to start kicking people for stuff that has always been acceptable just because there is more of it now.
If any socializing is offtopic, all of it is. Make the topic and tags of the room reflect that and enforce it more strictly from now on. And don't get lax about it. Don't punish people based on your mood at the time...
@nhgrif I'd say that it seems like people who have been around here for a long time have more "privileges" than newcomers... I think we're all interested to learn a bit more about the person behind the name, but we don't need to hear all details of a single day of a person that's just dropping by and we have no connections with whatsoever
I expect it will work as follows: I set an overly strict tolerance for what is on topic, and people get irritated when they can't idly chatter. They will take their chatter to some other room, the bridge, tavern, whatever. Over time the threshold will loosen up again, and in a year or so we will have to wash-rinse, and repeat
So, I am sending idle chatter to the Nth room, and then people will realize that the important and useful stuff is actually better in the 2nd monitor, and it is because there is no crap in the 2nd that it works.
Don't get me wrong, I love the fact that this site is far less, uh, stuck-up (in a good way?) than SO/MSO can be (despite the occasional craziness). Maybe it's because we're short of a moderator, but I feel like some meta-discussions (and sometimes even on the main site) would get the involved pe...
Exactly what is considered strictly off-topic there?
Anyone can assume the obvious: NSFW (Not Safe for Work) are off topic, and should be flagged.
Anything else?
@nhgrif Don't confuse the lack of enforcement of standards with the lack of standards. COnsider it like the speed limits... sometimes the cops have to step in and fine people. Does not mean the limit has changed, just that over time people have been excessively abusive of the limits
According to the Talk in Chat privilege page:
When should I visit chat?
for real time collaboration
to meet the fellow members of your community in a more social environment
for less structured, casual (but still roughly on-topic) conversation
As this primarily pertains to th...
The chat rooms are a tool for the site to chat about the site. If they stop becoming useful, or if things start getting in the way of site activity, or become a distraction to the site, then it is the duty of a moderator to bring things back in line.
This room is the official channel of the site, and its purpose has become dilued by the overly social nature of it.
As such, I have to reign it in.
Any arguments about that open a meta post.
Feel free to discuss it further once the meta post is up, and then it is back to being duscussions about the site, etc.
I love the concept of this site. Between Code Review and StackOverflow I believe everyone will have excellent resources on their quest to become efficient programmers.
Below is my code for handling a parsing system to look at every users profile page and determine their job classification based ...
Is the Copy-Swap Idiom implemented here correctly?
//Copy swap Idiom.
#include <iostream>
using namespace std;
class MyClass
{
private:
int x;
int y;
int z;
private:
void Swap(const MyClass & rhs) throw ()
{
x = rhs.x;
y = rhs.y;
z = rhs.z;
}
pub...
The revised "Be Nice Policy" states:
Don't be a jerk. .... Inappropriate language or attention. Avoid vulgar terms and anything sexually suggestive. Also, this is so not a dating site.
When a clarification about how this applies to Chat room on the Stack Exchange (Stack Overflow) sites, the...
Update: Thanks for all the additional feedback below. We incorporated a lot of your suggestions, and this is going live (as http://meta.stackexchange.com/help/be-nice).
We're also looking at ways to get this in front of more new users when they sign up, to help them start off on the right foot...
There is one other project I wish I had time for. An "internet beverage database" - for people to rate/review bottled beverages such as beer and cider.
I'm implementing a plus method that should work this way:
1 plus 2 // 3
"a" plus "b" // "a and b = ab"
Here is my implementation:
object MyMath {
implicit class MyMath(a: Any) {
def plus(b: Any) = {
(a, b) match {
case (s: String, s2: String) => s"$s and $s2"
...
@skiwi This is why Scala is one of the most popular platform for creating "domain specific languages".
@skiwi There are downsides to everything. The main problem with the flexibility of some of the Scala syntax is very familiar to anyone with C++ experience - operator overloading gone wild.
Just because you can do something, doesn't mean that it isn't a really bad idea.
I'm having a hard time understanding what happened here this morning while I was away, but perhaps monkey-business and just-saying-hi should be moved to this new chatroom if we (suddenly?) want this room to be all business.
I have an Asteroids clone I'm working on and I want to see if my object pooling is written correctly. The code works I just want to know if there is anything else I need to change to make it more efficient.
My first class is my ObjectPoolManager.cs. This holds the bullets and the asteroids.
p...
Let's say I have a table like this:
Value rank OtherCols....
1 1
1 2
1 3
1 4
2 1
2 2
2 3
2 4
I want to select value, othercols where the order is the min for the group.
You could do:
SELECT value, otherCols
FROM theTable T
WHERE rank = (
S...
I want to run multiple asynchronous functions and use their results in a final function that is called after all async functions finished.
For example reading 2 files at the same time and doing something with both results after reading is complete
This is what I have so far:
function callback...
I have this function in a class:
/** * Creates an appropriate instance of a Parsable implementation depending * upon the header of the file. * * @param file the path of the file from which to create a Parsable. * @return the created Parsable. */ private Parsable createParsable(Path file) { Toml ...
Related but not a duplicate: How far off-topic can we get in 'the 2nd monitor'?
Today was a complicated day in the history of the 2nd monitor.
On one side there appears to be consensus something went wrong which should be handled. On the other side there appears to be disagreement about how muc...
Related but not a duplicate: How far off-topic can we get in 'the 2nd monitor'?
Today was a complicated day in the history of The 2nd Monitor.
On one side there appears to be consensus something went wrong which should be handled. On the other side there appears to be disagreement about how muc...