Sergey Zolotarev

Mon 07:46
* by "here" I mean "on Software Engineering" (not in this chat)
Mon 07:45
Can I ask naming advice here? If not, do you have other platforms in mind that would be a better place for such questions?
Oct 14, 2024 05:58
This question would not be a good fit for the site, would it?

> If you saw a Java type titled `StringConverter` or `Converter<String>`, what would you immediately assume: that it converts strings to other types, or that it converts other types *to* strings?
Apr 29, 2024 12:21
Is it on-topic to ask this question? Are there other SO websites more suitable for it?

> I am currently collaborating on a mature desktop application in Java. I used to develop server applications and therefore am accustomed to Spring. I understand that desktop applications are fundamentally different, in particular start-up time matters. However, no matter how slowly Spring bootstraps, it is still a separate responsibility to create and configure your app's objects. Do desktop apps still need that separation of concerns and rely on some DI framework (maybe, something faster than Spring)?
Mar 20, 2024 05:12
Hi. I read the tour but still not sure what's on topic here. I wanted to ask, how can you approach comparison of two class instances if the class has at least one lambda field? That is, we can compare state, not behavior. Should I try to map behavior to state and compare those states instead (ignoring lambdas)? Are there other approaches? Would such a question be on topic?
 
Sep 3, 2024 15:38
More than 20 years since the project was started, they finally realized tests may give them a competitive advantage. No way! I was ahead of all that
Sep 3, 2024 15:38
But one of the reasons I do refactor is to make our classes testable! They are not, at the moment! I do write tests too, if it's possible. I'm the one who wrote first ever tests for our key module used in more than a dozen others. I didn't have to, they didn't pay or commend me for that. Not some old hand but me, a newbie. Guess what, then some weeks later the lead comes along and says, "You know, we need tests for certification, let's write some tests for the sake of formality". It was quite amusing for me
Sep 3, 2024 15:38
I'm totally on board with you when it comes to documentation. But here's the thing: it's either standards or no standards. You can't have mess in one place and order in another. Mess propagates, permeates throughout. If you believe I have better luck advocating for a better documentation, think again
Sep 3, 2024 15:38
"Refactoring risks introducing new bugs" Any changes risk introducing new bugs if tests are not sufficient (even bugfix changes). Refactoring is not special in that regard
Sep 3, 2024 15:38
Refactoring is not a what, it's a how. It's how you reduce the risk of bugs and streamline feature development
 
Sep 3, 2024 08:38
Facebook wasn't "first to market"
Sep 3, 2024 08:38
When Microsoft tries to succeed in more competitive environments, it often fails (Windows phones, browsers, emails). The key to their success is not product quality but separation of customers and users (users don't choose Windows, they have it preinstalled by hardware manufacturers) and not trying too hard to comply with anti-trust laws. The first part is also relevant for our company. When that's the case, user satisfaction is not as strongly linked to the company's financial success
Sep 3, 2024 08:38
There's a relationship between a software company's financial success and its code quality. It's sad it's understudied: folks like me would be able to make a much stronger case with more data at hand (though, I bet, some would still refuse to accept that fact). Your juxtaposition of commercial success and refactoring is, I believe, wrong
 

Charcoal HQ

Where smoke is detected, diamonds are made, and we break thing...
May 16, 2024 08:48
@Cow I haven't posted it on SE yet
May 16, 2024 07:22
Is a question like this on topic? Is it on topic elsewhere on SE, if not?

> Are DI frameworks like Spring applicable to desktop applications (e.g. in Java)? They noticeably increase startup time (irrelevant in server apps), but DI is still a separate responsibility
 

 The 2nd Monitor

General discussion about codereview.stackexchange.com - Welcom...
Mar 17, 2024 15:31
@Mast Are periods important? I never include them at the end of paragraphs. Is it a violation of Code Review's style guide? Or should I pay no attention to your edit?
Mar 17, 2024 15:25
@Mast I haven't made any contributions yet (only posted a few issues). I'm about to start doing it and wanted to take advice from more experienced developers. I understand your skepticism, but I am in no way going to flood repositories with half-assed PRs
Mar 17, 2024 14:18
@Mast so I picked the right strategy, didn't I (keeping everything the guy in the video said in mind)?
Mar 17, 2024 13:32
Mar 17, 2024 13:30
Anyway, I decided I have to start contributing to open source (Spring, for instance), but then I saw a video on YouTube who was very vehement in his discouragement of open-source contribution a way to get a job. This puzzle has to have a solution, doesn't it? What are my options?
Mar 17, 2024 13:30
I thought it's some Russian thing that has to do with low competition in the economy (why would they hire more expensive and less honest devs, it does't seem reasonable), but then I was told it's at least as bad in Western countries, if not worse (which, I know, could be another lie)
Mar 17, 2024 13:30
It objectively seems to be the only hurdle: all the other folks I studied with, who lied about their years of experience (it's not a baseless accusation, they openly said so), got invited to interviews, got employed. Of the hundreds of people I studied with only three, including me, tried to do it fair and square, all of them failed
Mar 17, 2024 13:30
@Mast :65355335 since it's a chat, I guess I'm safe to ask it. I hope I don't impose. What's your specific advice to a guy who struggles to land a developer job (me)? I believe my skills and knowledge are up for the task, but they never get to be assessed since I'm never invited to interviews (where I could seize the chance to shine)
Mar 17, 2024 12:59
@Mast are you absolutely sure?
Mar 17, 2024 12:57
The HTML page is humongous, I could post it separately (along with JS and CSS)
Mar 17, 2024 12:56
The thing is it's actually one project. I did it a year ago, it's quite old-fashioned (controllers returning HTML-views, that kind of thing). You can't run two things separately
Mar 17, 2024 12:52
Can I split a project into two posts (backend, frontend)? I removed everything I could, but it still doesn't fit into the character limit
Mar 4, 2024 01:15
How do I enable a dark theme? I don't see that button on Code Review. SO has it. Does it mean the feature doesn't exist yet?
Feb 27, 2024 00:58
@SᴀᴍOnᴇᴌᴀ should it be 30 days old AND have a negative score AND no answers? Or 30 days old AND (a negative score OR no answers)?
Feb 27, 2024 00:53
@Peilonrayz oh, don't rub it in. I didn't know back then what I could post on this site. Frankly, I'm still not 100% sure. Should I post really tiny projects? I rarely get reviews lately. I guess it's because my more recent projects are relatively big. However, they are miniscule by any production standards, let's admit it
Feb 27, 2024 00:44
Does Code Review have some "vacuum" mechanism that would delete my posts if they don't get any reviews in a certain period?
Feb 17, 2024 20:57
@Mast is it an admission that markup languages are not real languages?
Feb 17, 2024 18:11
Is it appropriate to post a README for review? Anyone can do check it out, even if they don't know Java. It's short, even shorter than my AuthenticationWebFilter
Feb 15, 2024 14:27
@pacmaninbw I was just told that I wouldn't see my gateway reviewed because it was too big (even though it fit into the character limit). So I figured there was some informal limit to how big projects can be here
Feb 15, 2024 14:22
*too big to review
Feb 15, 2024 14:19
1
Q: AuthenticationWebFilter with no hard-coded dependency on a specific authentication scheme

SergeyI decided to share with you a portion of my gateway project. It's an authentication filter that (unlike Spring's own AuthenticationWebFilter with its hardcoded inlines) is unaware of any particular authentication scheme and provides more flexibility in that regard. I have only one concrete Authen...

Feb 15, 2024 14:18
Do you mean it's still big too review?
Dec 30, 2023 11:43
How do I get in touch with Code Review support? I can't get to meta, it throws a 500 error if I authenticate and then try visit the site (it doesn't if I don't authenticate). Regular Code Review is available
Aug 4, 2023 22:31
Besides, if I need to know which exact methods I need to mock, it seems my tests are strongly coupled with tested methods' implementations. For example, f I decide to retrieve information about a logged user's username some other way in the future, my test may fail because I only mock getPrincipal(). How is it actually supposed to be done?
Aug 4, 2023 22:31
public class UserServiceImplTest {
    private final UserDao userDaoMock = Mockito.mock(UserDao.class);
    @Test
    public void testGetAllExceptLoggedUser() {
        User testUser1 = new User();
        testUser1.setUsername("testUser1");
        User testUser2 = new User();
        testUser1.setUsername("testUser2");
        Mockito.when(userDaoMock.findAllExceptLoggedUser("testUser1"))
                .thenReturn(List.of(testUser2));
        UserService userService = new UserServiceImpl(userDaoMock);
 

 Language Overflow

This is the main chat room for ell.stackexchange.com. Welcome!
Feb 8, 2024 03:18
@ColleenV thank you! Why is 1 less good? Is it grammatical?
Feb 7, 2024 03:16
@ColleenV One
Feb 7, 2024 01:56
4. "The definition of a scheme is extended to include the characters separating it from the authority."
Feb 7, 2024 01:55
3. "A definition of a scheme is extended to include the characters separating it from the authority."
Feb 7, 2024 01:55
2. "The scheme's definition is extended to include the characters separating it from the authority."
Feb 7, 2024 01:55
1. "A scheme's definition is extended to include the characters separating it from the authority."
Feb 7, 2024 01:54
Which of these are grammatical? Which of those that are grammatical are the most idiomatic?
Feb 7, 2024 01:54
/**
 * Utility class for validating URI schemes and paths. Though overall it respects the
 * RFC 3986 specification, this class takes the liberty of diverging from it in the following
 * ways:
 * <p>
 * 1. A scheme's definition is extended to include the characters separating it from the authority,
 * specifically a colon and two forward slashes.
 * For example, in {@code example.com} the scheme would be {@code http://}, not {@code http}.
 * The latter would <em>not</em> be considered a valid scheme by this class
Feb 7, 2024 01:53
Consider this Javadoc:
 

 The Heap™ – Consultancy ©®

General on- and off-site discussion for dba.stackexchange.com....
Aug 20, 2023 12:17
How do lock mode types (such as pessimistic write) and isolation levels (such as repeatable read) relate to each other?