The 2nd Monitor

Duga

00:13

REFRESH! There are 6537 unanswered questions (91.5661 answered)

Duga

01:04

possible answer invalidation by CafféSospeso on question by CafféSospeso: codereview.stackexchange.com/posts/289499/revisions

Captain Obvious

0

Q: My Attempt of Generic Macros and abusing the C-Preprocessor

First my appologies. My mental faculties currently leave rather a lot to be desired, which is exactly why I've spend an inordinary amount of time on this pet project of mine, testing myself if you will. I find it incredible difficult to wrap my head around things I used to be able to do in my sle...

Duga

possible answer invalidation by CafféSospeso on question by CafféSospeso: codereview.stackexchange.com/posts/289499/revisions

Duga

07:00

The question is fine, but that doesn't change the fact that it's a broad question that invites opinion-based answers that are situational to design requirements, so it's off-topic here. It would be better to ask at softwareengineering.stackexchange.com or if you build some minimal example code for the various approaches outlined, you could potentially ask on codereview.stackexchange.com ... questions on Stack Overflow are expected to be about a specific problem, typically focused on actual code. Hand-wavey stuff like "how to abstract graph traversal" is too broad. — paddy 33 secs ago

Captain Obvious

08:26

0

Q: Is the gps library initalised in a pythonic and safe way

My python GPS project is developed on Windows10 but target platform will be RPi. I want to ensure that the GPS functions are only run on the correct platforms and that the GPS daemon client is used in a pythonic safe way. Let me explain: On *nix systems I will be accessing a gps via the gpsd serv...

python

Captain Obvious

09:11

0

Q: Unordered list styling

Unordered list styling developed around nth-child() css selector and @media rule for responsive design. <!DOCTYPE html> <html lang="en"> <head> <meta charset=utf-8> <style type="text/css"> .centered { bottom: 0; left: 0; margin: auto; position: absolute; right: 0; top: 0; } .sized { height: 90%; ...

html css

Duga

10:38

Please take the tour and read How to Ask. Code Review may be a better fit (but also review their help center before posting). — jonrsharpe 1 min ago

Captain Obvious

11:04

0

Q: Trie, Graph Visualization and Auto-Completion in C

Given a list of strings (say a text file containing some C symbols: c-symbols.txt), the program can: Generate a graph of the underlying trie (-p/--prefix can be specified to inspect a specific prefix subtree) with Graphviz dot: » time ./trie --prefix at --svg c-symbols.txt ./trie --prefix at...

c data-visualization trie autocomplete

Duga

11:18

This question might be more suitable for our sister site Code Review. — InSync 20 secs ago

Captain Obvious

11:50

1

Q: recursive_invocable and recursive_project_invocable Concept Implementation in C++

This is a follow-up question for A recursive_find_if Template Function with Unwrap Level Implementation in C++. I am trying to make some constrains on Proj and UnaryPredicate in recursive_all_of, recursive_find_if, recursive_any_of and recursive_none_of template functions. The recursive_invocable...

c++ recursion template c++20 constrained-templates

Mast

12:12

Monking

Captain Obvious

0

Q: What would a good code of this look like? or is it good enough?

import sys from pyfiglet import Figlet import random figlet = Figlet() list = figlet.getFonts() def main(): if len(sys.argv) == 1: text = input("Input: ") randomfont = random.choice(list) calling random to choose a random fon...

python

0

Q: Advent of Code 2023 day 1: Trebuchet (Part 2)

Task: The task involves analyzing a calibration document containing lines of text. Each line represents a calibration value that needs to be recovered by extracting the first and last digits (which may also be spelled out as words) and combining them into a two-digit number. The goal is to find t...

c++ beginner programming-challenge

Duga

12:45

The 499b84ac-1321-427f-aa17-267ca6975798 is the App ID of Azure DevOps. The scope can also be requested like 499b84ac-1321-427f-aa17-267ca6975798/{requiredScope}, for example, 499b84ac-1321-427f-aa17-267ca6975798/vso.build. vso.code_write grants the ability to read, update, and delete source code, access metadata about commits, changesets, branches, and other version control artifacts. Also grants the ability to create and manage pull requests and code reviews and to receive notifications about version control events via service hooks. — Ziyang Liu-MSFT 44 secs ago

pacmaninbw

13:57

@Duga Commented and rolled back.

Captain Obvious

0

Q: Code outputs differently in cses.fi judge compared to when I run on my computer

Regardless of my messy code and whether or not the logic has flaws, I would like to know why when I run my code with the test cases "AA" and "CBPPBFCFAA" I get the right output "AA" and "PFCBAABCFP" However when I submit the code to cses, these inputs give wrong answers (empty) and "PFCBBCFP" The...

c++

Sergey Zolotarev

14:18

Do you mean it's still big too review?

1

Q: AuthenticationWebFilter with no hard-coded dependency on a specific authentication scheme

I decided to share with you a portion of my gateway project. It's an authentication filter that (unlike Spring's own AuthenticationWebFilter with its hardcoded inlines) is unaware of any particular authentication scheme and provides more flexibility in that regard. I have only one concrete Authen...

java authentication

*too big to review

pacmaninbw

@SergeyZolotarev If it fits into the space for characters, it is not too big. It is a long question and it will take time for someone to answer it. I can't review it since I don't know Java.

Sergey Zolotarev

@pacmaninbw I was just told that I wouldn't see my gateway reviewed because it was too big (even though it fit into the character limit). So I figured there was some informal limit to how big projects can be here

Duga

If this is not about experiencing a bug and just in need of a review: Maybe a case for Code Review Stack Exchange. In the end you'll have to confront code correctness, readability, maintainability and performance. Those are mainly concerns of the company and colleagues you have. Random strangers on the internet can always show you what could be done. Doesn't have to be best practice to someone else or even be the same way next year. — Peter Pointer 25 secs ago

pacmaninbw

@SergeyZolotarev The larger the question the less likely it is to be answered. Someone may be interested and answer. It takes about 2 hours to review 100 lines of code properly. A day or more for a question of this size isn't too long.

Mast

14:39

@SergeyZolotarev Who told you that?

Is that based on your meta on character limits?

1

A: Increase character limit to 75k

status-declined I will collect the (now removed) comments in this answer, since I agree with them all. The last one is my own. In short, I don't see any support for it. You state: I have to exclude some code and instead store it elsewhere and provide a link. Please read our FAQ - Can I put my c...

Such big projects are not easy to review. Doesn't mean they don't get reviewed at all, but the likelihood is lower.

Unfortunately Java code is very verbose. I rarely review them, but others do.

Duga

15:24

For code reviews you can go to: codereview.stackexchange.com — Reyno just now

Welcome to Stack Overflow! @Reyno the question needs work before it's suited to Code Review. You could have pointed the asker at A guide to Code Review for Stack Overflow users, as some things are done differently over there - e.g. we need a good description of the purpose of the code to give context, and question titles should simply say what the code is for (the question is always, "How can I improve this?"). It's important that the code works correctly; include the unit tests if possible. — Toby Speight 58 secs ago

Sᴀᴍ Onᴇᴌᴀ

17:16

Monking

Sᴀᴍ Onᴇᴌᴀ

17:42

@pacmaninbw I don't really know swift yet that did not hold me back from reviewing Martin R's Swiftly Turning Wheels code

Duga

If your code runs without error and produces the correct result then you'll get better feedback on performance, style, technique if you repost your question over at the Code Review StackExchange. — Woodford 55 secs ago

skiwi

Monking

Captain Obvious

0

Q: How to optimize the work of classes in the code for calculations and modeling?

There is a code that performs calculations of parts of fuel injectors. There are two classes in which the basic calculations take place, they are called LiquidJetInjector and GasJetInjector, respectively. The Reynolds class stores constants for calculations. The SimilarCalculations class is a cla...

python python-3.x calculator

Captain Obvious

21:17

0

Q: Assistance identifying iterator bug for basic orderbook implementation

I am a second year cs student in uni with ambitions to work on trading systems, as a personal project I have been working on a basic orderbook implementation using FIFO order matching. I am having an issue with matching partially filled orders. Please see below for the implementation: dll.hpp /* ...

c++ beginner

Duga

23:32

The comment section is not the appropriate place for your code. There is an Edit facility, please use it. Whilst doing that, please add what the specific issue is with your code, any output, and sufficient information for us to reproduce your reported problem. "Is there a better way" is not a programming issue, it is a request which may attract opinion, and could very likely belong on Code Review. — Compo 27 secs ago

Transcript for