Charcoal HQ

Andy

16:01

@CaffeineAddiction, do you have a container currently running with smokey (on windows)?

ArtOfCode

@Undo got it

Andy

If so, can you run: python -W default::Warning -m pytest test

CaffeineAddiction

one moment

SmokeDetector

[ SmokeDetector | MS ] Offensive answer detected: How do I increase the max number of frames? by sdwas on blender.SE

tpu- by Undo

[ SmokeDetector | MS ] Few unique characters in body: My form won't submit? by user3516838 on stackoverflow.com (@dorukayhan)

J F

@SmokeDetector v

SmokeDetector

16:06

Conflicting feedback on My form won't submit?.

fp- by Yvette

J F

@YvetteColomb It’s vandalism. I just reverted it.

Yvette Colomb

didn't see edit soz

SmokeDetector

Conflicting feedback on My form won't submit?.

Glorfindel

@SmokeDetector v

SmokeDetector

Conflicting feedback on My form won't submit?.

J F

16:08

@YvetteColomb Could you remove your feedback?

CaffeineAddiction

@Andy i.sstatic.net/8B7oj.png

Andy

Hm. Ok. I have another issue to resolve then. i.imgur.com/PysHkpF.png

SmokeDetector

New metasmoke user 'kjetil b halvorsen' created

CaffeineAddiction

@Andy yah, I just did a git pull from Master ... all pass

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, pattern-matching website in body: Three-Bottle-274 x 300 That’s exactly why you’ve gravitated by kengewinter on graphicdesign.SE

tpu- by Glorfindel

Andy

16:18

@CaffeineAddiction ok. I'll fight with it a little later then.

Thanks for the help so far

Undo

GD isn't a three-flag-threshold site, right?

Must not be

Glorfindel

@Undo nope, just plain old six.

SmokeDetector

[ SmokeDetector ] SmokeDetector started in standby mode at rev fd55eb4 (SmokeDetector: Auto blacklist of malesupplement\.ca by Glorfindel --autopull) (running on Undo's Raspberry Pi)

ArtOfCode

16:35

there are a lot of emails backing up in that account

SmokeDetector

[ SmokeDetector | MS ] Bad keyword with email in answer: Responsive web design using HTML5/PHP/Bootstrap3.3.4 by Sward on codereview.SE

naa- by Glorfindel

Undo

Any objections to merging #539?

ArtOfCode

lack of objection

Undo

Let's try it, then. Gotta do this in the right order.

SmokeDetector

16:50

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body, repeated URL at end of long post: Indeed, even your by julimbal83 on superuser.com

Undo's Raspberry Pi received failover signal.

tpu- by Undo

Undo

!!/location

SmokeDetector

@Undo teward/Aurora

@Undo Undo's Raspberry Pi

Undo

!!/standby teward

SmokeDetector

Restart: API quota is 9950.

[ SmokeDetector ] SmokeDetector started in standby mode at rev fd55eb4 (SmokeDetector: Auto blacklist of malesupplement\.ca by Glorfindel --autopull) (running on teward/Aurora)

Undo

!!/pull

SmokeDetector

16:52

[ SmokeDetector ] SmokeDetector started in standby mode at rev fd55eb4 (SmokeDetector: Auto blacklist of malesupplement\.ca by Glorfindel --autopull) (running on Undo's Raspberry Pi)

Undo

... gotta merge first

ArtOfCode

tends to help

Undo

@SmokeDetector this again >:(

ArtOfCode

I'm sure someone said something about right order

Andy

did that library get installed?

Undo

16:53

On my Pi, yes

Andy

ok

SmokeDetector

teward/Aurora received failover signal.

CI on 2860085 succeeded. Message contains 'autopull', pulling...

Undo

Well, maybe. TldIOError: [Errno 13] Permission denied: '/usr/local/lib/python2.7/dist-packages/tld/res/effective_tld_names.dat.txt'

nonononono

SmokeDetector

[ SmokeDetector ] SmokeDetector started in reverted mode at rev fd55eb4 (SmokeDetector: Auto blacklist of malesupplement\.ca by Glorfindel --autopull) (running on teward/Aurora)

Restart: API quota is 1776.

[ SmokeDetector | MS ] Link at end of answer: Error occurred in deployment step 'Recycle IIS Application Pool': Object reference not set to an instance of an object by Peter on sharepoint.SE

fp- by J F

Undo

Well, at least the reverter still works

Andy

16:56

@Undo does that error contain a full stack trace? Did it fail when running update_tld_names()?

Undo

TldIOError: [Errno 13] Permission denied: '/usr/local/lib/python2.7/dist-packages/tld/res/effective_tld_names.dat.txt'
2017-02-23 16:56:28.669026 UTC
  File "ws.py", line 47, in <module>
    from bodyfetcher import BodyFetcher

  File "/media/sda1/SmokeDetector/bodyfetcher.py", line 1, in <module>
    from spamhandling import handle_spam, check_if_spam

  File "/media/sda1/SmokeDetector/spamhandling.py", line 3, in <module>
    from findspam import FindSpam

  File "/media/sda1/SmokeDetector/findspam.py", line 8, in <module>

yes

Pretty sure it's a pip issue, though

Thomas Ward

grabs a phaser

might've pinged first

Andy

It's always ominous when Google returns no results

SmokeDetector

New metasmoke user 'Nicolai Weitkemper' created

Undo

@ThomasWard Trying to get it running on my Pi so that I can give you a one-liner to run

Andy

16:59

@ThomasWard on Aurora, you need to install the tld package: pip install tld should do it

Thomas Ward

Except I already have TLD installed because of another thing

@Andy it's already been present

Andy

Sweet

Thomas Ward

because of another library i have running there that pulled it as a dep

Undo

!!/errorlogs 100

SmokeDetector

  File "/usr/local/lib/python2.7/dist-packages/websocket/_socket.py", line 80, in recv
    bytes_ = sock.recv(bufsize)

  File "/usr/lib/python2.7/ssl.py", line 756, in recv
    return self.read(buflen)

  File "/usr/lib/python2.7/ssl.py", line 643, in read
    v = self._sslobj.read(len)


error: [Errno 104] Connection reset by peer
2017-02-22 19:07:25.528474 UTC
  File "/home/smokey/SmokeDetector/excepthook.py", line 48, in run_with_except_hook
    run_old(*args, **kw)

  File "/usr/lib/python2.7/threading.py", line 754, in run

Undo

17:00

!!/location

@ThomasWard ^ Smokey doesn't think so

Andy

Is it running 0.7.8 @ThomasWard?

SmokeDetector

[ SmokeDetector ] SmokeDetector started in reverted mode at rev fd55eb4 (SmokeDetector: Auto blacklist of malesupplement\.ca by Glorfindel --autopull) (running on teward/Aurora)

Restart: API quota is 1715.

Thomas Ward

!!/stappit

SmokeDetector

Goodbye, cruel world

Thomas Ward

@Andy of tld?

Andy

17:01

yes

Thomas Ward

@Undo you have to kill nocrash.py too

Andy

Awesome

Thomas Ward

@Undo the core issue is it's python within python

so the python env isn't updated

Andy

SHA1 is dead

Thomas Ward

oop hang on

Undo

17:02

@ThomasWard Even though we're running it through the shell?

Thomas Ward

ahhh one of those 'can't reach it' errors

@Undo yep.

I wonder how it's opening

J F

@Andy What’s git use?

Andy

sha1

Thomas Ward

oh i know why

@Undo i know why

@Andy ^

it's probably trying to write to the file

which is locked by the system

hang on gonna attach a debugger here

Andy

update_tld_names() does write a file. That call is needed one time to get the TLDs and then anytime new TLDs are created

SmokeDetector

17:04

[ SmokeDetector ] SmokeDetector started at rev 2860085 (Undo1: Merge pull request #539 from AWegnerGitHub/branch_username_similar_link --autopull) (running on Undo's Raspberry Pi)

Andy

If needed, we can pull it out of findspam.py and run it manually.

SmokeDetector

Restart: API quota is 9943.

Thomas Ward

@Andy Look at the file path lol

Andy

But, it does need to be run at least once

Undo

Got it to work

Thomas Ward

17:04

if anyone actually reads you'd know it's in a system-locked dir

Undo

Installing it as pip install --user -r requirements.txt is fine

Andy

@ThomasWard r-reads? what is this wizardry?

Thomas Ward

fak slow indexer

gotta wait for indexer to load up

Andy

Heh. PyCharm?

Thomas Ward

@Andy my guess is that's the core problem, in which case we'll never be able to run the 'update' portion

Undo

17:07

2 mins ago, by Undo

Installing it as pip install --user -r requirements.txt is fine

Thomas Ward

@Andy did you notice the debugger stuff I shoved in :P

mine's installed as a system lib though

Undo

What happens if you also install it as a user lib? Any way to force Smokey to use the user one?

Andy

Let's just wrap the function in a try/except. Once it's been run once it doesn't need to be run at every restart (though, semi-regularly would be nice)

Thomas Ward

@Undo only by an explicit import probably

let me test

@Andy I'd be happy to wrap it in a try/except, though our instructions will need rewritten heh

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 2860085 (Undo1: Merge pull request #539 from AWegnerGitHub/branch_username_similar_link --autopull) (running on teward/Aurora)

Restart: API quota is 1712.

Thomas Ward

17:10

so it's working on Aurora now, but only because I forced it to user mode

@Undo the python path is painful - unless we change it we can't override local vs. system

I'd much rather put a try/except around it to have it yell at the beginning

during nocrash.py

but as a line written to error logs as a warning

now if only I can find where it triggers :P

Undo

That'd work, then

Andy

Per user packages should already be preferred over system packages: python.org/dev/peps/pep-0370

@ThomasWard The top of findspam

Thomas Ward

@Andy yes but I was tracing either way

@Undo I'll commit that shortly

ignore anything about Overlord running - it's just attached to the debugger

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 2860085 (Undo1: Merge pull request #539 from AWegnerGitHub/branch_username_similar_link --autopull) (running on teward/Aurora)

Restart: API quota is 1653.

[ SmokeDetector | MS ] Username similar to website body: LD+JSON Non-Scannable Email Address by zach newberry on stackoverflow.com

fp- by J F

J F

!!/location

SmokeDetector

17:20

@JF teward/Aurora

@JF Undo's Raspberry Pi

Ferrybig

!!/rev

SmokeDetector

@Ferrybig 2860085 (Undo1: Merge pull request #539 from AWegnerGitHub/branch_username_similar_link --autopull)

Undo

!!/standby Pi

SmokeDetector

Undo's Raspberry Pi is switching to standby

[ SmokeDetector ] SmokeDetector started in standby mode at rev 2860085 (Undo1: Merge pull request #539 from AWegnerGitHub/branch_username_similar_link --autopull) (running on Undo's Raspberry Pi)

New metasmoke user 'Evil Genius' created

M.A.R.

@SmokeDetector Now they shall take over MS

Thomas Ward

17:28

who wants to know the evils they introduced

looks at @Andy with an evil glare

SmokeDetector

CI on 3695d89 succeeded.

Thomas Ward

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 3695d89 (Thomas Ward: Proper try/catch on update_tld_names, import certain exceptions Directly.) (running on teward/Aurora)

Thomas Ward

what Flake8 didn't catch, PyCharm did.

@Andy tld.exceptions. doesn't exist

SmokeDetector

Restart: API quota is 1576.

Thomas Ward

17:29

it's tld.util.[ExceptionName]

I've imported the exceptions specifically, from there

we'd have other evil errors if those exceptions were ever reached in the way you had it.

J F

Is it OK if I join the websiteers team?

Undo

aye

J F

@Art ^

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body, repeated URL at end of long post: in addition to the nonattendance of assembling data, may make by Coledalo on workplace.SE

J F

sd k

M.A.R.

17:37

@SmokeDetector K

ArtOfCode

@JF looks like Undo added you

J F

Thanks :) took a few minutes for the email to send.

CaffeineAddiction

Damn, usercount has doubled since last week

J F

I’ve figured out how to make charcoal-se.org use Jekyll which lets us write the pages in Markdown. The only differences are that I’ve added permalinks to all of the headings and the quotes are “fancy” instead of "boring." OK to push?

Magisch

17:53

Anyone knows wildcard for chat search

Like search for all posts by X in room Y

ArtOfCode

@Magisch there ain't one

@JF if we can keep the existing style, yeah

J F

@ArtOfCode Yep. Style will be the same.

ArtOfCode

push away

J F

18:06

afk

Pushed.

SmokeDetector

18:19

API quota rolled over with 1245 requests remaining. Current quota: 9999.

stackoverflow: 1638
askubuntu: 508
superuser: 452
unix: 247
drupal: 226
electronics: 193
math: 182
travel: 169
english: 168
mathoverflow.net: 145
dba: 145
salesforce: 144
gis: 137
magento: 127
wordpress: 121
meta: 119
webapps: 118
apple: 114
sharepoint: 109
physics: 104
gaming: 101
es.stackoverflow: 96
academia: 93
worldbuilding: 91
rpg: 89
security: 88
ell: 84
stats: 82
ru.stackoverflow: 81
money: 79
scifi: 77
movies: 77
chemistry: 76
workplace: 75
tex: 74
mathematica: 69
history: 61
graphicdesign: 58

J F

I’ll add a mobile version for the website in a few minutes.

quartata

@SmokeDetector Ooh let's see if this works

Hrm. There's no way to test both body and username at the same time.

J F

[feature-request] !!/test-json {"type": "question", "username": "user123", "body": "asdf", "title": "Hi!!!1one"}

quartata

Yeah, that would be cool.

@ArtOfCode @Undo

Andy

@quartata Test where?

In the code? It is doing it here

do you mean there isn't a command to test a post via chat?

Undo

18:29

@Andy To test multiple parts of a post at a time

I.e. we don't have a way to test your filter

Andy

ah, via chat commands

quartata

Yeah.

Andy

Gotcha. No, I didn't build that. Throw an issue on github

Undo

That kind of thing might be better handled through metasmoke; not sure how easy it'd be to devise a robust chat syntax

J F

4 mins ago, by J F

[feature-request] !!/test-json {"type": "question", "username": "user123", "body": "asdf", "title": "Hi!!!1one"}

Andy

18:31

@JF Throw an issue on github

Undo

@JF Needs custom chat parsing, but could probably be done

J F

@Andy Charcoal-SE/SmokeDetector#546

SmokeDetector

[ SmokeDetector | MS ] Username similar to website body: Correct Flexbox prefix for Explorer by nicklas bryntesson on stackoverflow.com (@dorukayhan)

fp- by J F

quartata

Awkward.

Well it does work....

Andy

\o/

quartata

18:42

@Andy :P

Andy

100% false positive rate

at 2 posts, that's not much, but still not a great start

quartata

I think it's just bad luck honestly.

I don't see things like those posts a lot

Thomas Ward

my guess is that'll be one of those filters we end up disabling

if only because the matching criterion for it is rare

quartata

It might be worth turning off on Wordpress

Glorfindel

And on Stack Overflow

quartata

18:45

Since that'll be a lot of personal websites

We could improve it by ignoring given names

Andy

shrugs It brought improvements to Smokey.

quartata

Like, needs to be dictionary nouns or whatever

Undo

Maybe disable for questions?

Andy

@quartata No. Names are a difficult thing: kalzumeus.com/2010/06/17/…

@Undo Could work.

quartata

Yeah, that's a good idea.

Any legitmate answer that trips it is NAA anyways most likely.

Give it a week anyways though?

Andy

18:48

@Undo, based on the sample data I used from the issue those were all on answers not questions, so that sounds like a good idea

Undo

Yeah, you should be able to cut out a lot of false positives by ignoring questions.

quartata

@JF I don't know if this is possible, but could you make Coal do whatever the native "application needs your attention" shake thing is on pings

Like on OS X how the app jumps up and Ubuntu how it shakes in the dock

J F

@quartata I can do it on macOS, and it doesn’t look Electron supports bouncing the icon in the dock on Ubuntu.

quartata

Darn.

I sometimes miss pings when listening to music, and obviously there's no (1) I can see

J F

@quartata It should put the number of new messages as an icon badge.

@JF test

Mithrandir

18:55

@quartata enable desktop notifications

quartata

@Mithrandir I have it set to ping on any message in Coal.

That would get annoying fast

J F

@quartata It only notifies on pings.

quartata

Oh, OK then.

J F

Besides, coal currently bounces the dock icon for every message.

quartata

Just doesn't on Ubuntu huh :/

stupid electron

ArtOfCode

18:57

oh hey, and I got an ubuntu live usb out of this morning's reinstall too, and it actually works for once

J F

@quartata You could ask for it.

quartata

eh

I don't like Electron enough to help them out in any way

Undo

huh, that's a new CI error

quartata

?

ArtOfCode

what, not liking Electron? :P

Undo

18:58

travis-ci.org/Charcoal-SE/SmokeDetector/builds/204700468

Andy

@Undo I'm looking at it. I guess it was to much to ask for that my simple change would work like the complicated one did :)

quartata

!!/alive?

SmokeDetector

@quartata Of course

Undo

Now that I think about it, I don't know if we have a way to restrict a check to only answers

quartata

!!/rev

SmokeDetector

18:59

@quartata 3695d89 (Thomas Ward: Proper try/catch on update_tld_names, import certain exceptions Directly.)

quartata

@Undo Really?

Andy

We do it for "link found at end of answer" checks

ArtOfCode

that's just the post type getting inserted into link at end of {}

Andy

All I added was 'questions': False like some of the reasons around here

I didn't look an see if that does what I assumed it did.

Undo

ohhhh

Andy

19:01

give me a minute to look at this CI error though

Undo

CI is failing because it expected those test cases to be matched, but they aren't because of the question check

It's not a syntax issue, it's a test issue

Andy

Heh. The comment in the code give it away too:

> # If we want to test answers separately, this should be changed

claps for whoever put that there

Undo

Probably Manish or FOX back in the day

Andy

git blame says it was Fox

J F

My reading of the blame says hichris1234

Andy

19:05

Hm...so, I have a fix, but involves touching every single test in the test_regex to add another boolean to the tuples

Basically, it moves is_answer to the tuple

quartata

I wish the post body on MS was in markdown.

Andy

Victory!

With that PR, the username similar to website check will be only on answers. Additionally, we can now unit test question and answer patterns independently

SmokeDetector

New metasmoke user 'Mark Omo' created

CI on c94c66a succeeded.

Undo

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev c94c66a (Undo1: Merge branch 'pr/547') (running on teward/Aurora)

Restart: API quota is 9616.

Undo

19:18

... what just happened

Andy

Did you merge into the PR and then merge the PR into master?

Undo

bah. Don't touch Smokey, Github Desktop did something evil

SmokeDetector

CI on 47ba864 succeeded.

CI on d60ed41 succeeded.

ArtOfCode

reasons I use git commands

quartata

the heck

how on earth

J F

19:31

How’s this look (mobile site)?

Undo

There. That was fun.

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev c94c66a (Undo1: Merge branch 'pr/547') (running on teward/Aurora)

Restart: API quota is 9519.

Undo

what

oh right, probably not a fast forward

@ThomasWard I irritated Git, at some point you can force it back on the current deploy ref. Pretty sure it's complaining about fast forwards; I did some nasty things to the tree.

maybe I should just stay away from the SCMs today

We should be okay for now; just won't be able to pull anything new for a while.

Jan Dvorak

@JF The red looks like an error message

J F

@JanDvorak It’s the same colors as the desktop one.

Should I change them to something different?

Jan Dvorak

19:36

It looks like an error message on desktop, too :-)

Mithrandir

Yes.

J F

What color should I change it to?

Jan Dvorak

light brown

Mithrandir

Dark purple...

ArtOfCode

Needs to be something that stands out. Blues, for information?

Glorfindel

19:38

@JF charcoal.

2

Thomas Ward

@Undo stop messing up git

J F

DuckDuckGo says #B8F3FF. How’s that sound?

^ ?

Mithrandir

Great

rene

it is not red which was the issue raised ...

J F

Pushed: charcoal-se.org

Jan Dvorak

19:45

I still see red. (also, I don't like the blue either)

ArtOfCode

@JanDvorak hard-reload, it's cached

@JF the :hover state is still red

...and the :visited state

presumably also :active

Jan Dvorak

CTRL+F5 doesn't cut it

ArtOfCode

@JanDvorak ctrl-shift-r in Chrome

Thomas Ward

nuke your actual browser cache and try again

ArtOfCode

@ThomasWard Hard-reload is effectively the same thing

it nukes the related elements of the browser cache and re-fetches

SmokeDetector

19:48

[ SmokeDetector | MS ] Few unique characters in answer, offensive answer detected, repeating words in answer: Cannot open AR archive file! by user658140 on askubuntu.com (@ThomasWard)

tpu- by J F

J F

Any suggestions for another color then?

quartata

sd - autoflagged?

SmokeDetector

1. [:35636783] <skipped>
2. [:35636777] That post was automatically flagged, using flags from: rene, ByteCommander, JonasCz.

Jan Dvorak

@JF diarrhea brown

ArtOfCode

@JF blue is fine, but the other link states need to mirror it

J F

19:50

@ArtOfCode Should fix itself eventually (I pushed a fix)

@JanDvorak Hex?

ArtOfCode

hang on, lemme temporarily disable Cloudflare caching

Jan Dvorak

#EECCAA would do

hold on... booting up Gimp

ArtOfCode

...yeah, let's go with the blue. It's the contextually correct color, too.

Jan Dvorak

If we go with blue, perhaps pick the bootstrap-info-* set then?

Byte Commander

What about #C0FFEE ?

;-)

Jan Dvorak

19:53

Or that

how about #00C0A1 (AKA #coal)?

ArtOfCode

@JanDvorak yeah, that'd be fine

J F

Vote for a color

Jan Dvorak

What brown would I be voting for there?

J F

@JanDvorak The one you suggested.

Jan Dvorak

Frankly, I can go in either way, so I retracted my vote

SmokeDetector

19:59

New metasmoke user '7ochem' created

J F

@Mithrandir are you opposed to the Bootstrap blue?

Transcript for