Charcoal HQ

Undo

10:00 PM

sigh

Andy

@Undo I voted to undelete.

Undo

@ArtOfCode I did a thing, metasmoke.erwaysoftware.com/flagging/conditions/2/edit

ArtOfCode

@Undo clever shit

that's gonna take me ages to work out :)

Undo

Need to do some DB optimization on it, but it's fairly simple.

NobodyNada

nice!

Undo

10:02 PM

@ArtOfCode Fun fact: You can render JavaScript from Rails and the client will happily run it

ArtOfCode

@Undo so 99.86% accurate, and we're still flagging multiple posts per day (assuming cross-network)... that's impressive

Undo

@ArtOfCode This is also not even looking at weight

ArtOfCode

just reason count and rep?

Undo

aye

NobodyNada

that's impressive!

Undo

10:04 PM

Counting rep also gets us into a slightly more modern era, where we're more accurate anyway.

ArtOfCode

well that's pretty good

now what if you weight each reason by a round-to-nearest-integer of it's tp percentage, @Undo?

Undo

@ArtOfCode ugh, those queries are... like really expensive

Probably need to cache it on the reason model if we're going to do that

ArtOfCode

@Undo also one-off, though

Undo

Or nightly

ArtOfCode

set the weight now, once, and then update every now and then

or that

NobodyNada

10:06 PM

don't you already have the numbers of true and false positives? what more is there when calculating the weight?

Undo

@NobodyNada It's just doing it inline that gets expensive

also complicated

ArtOfCode

99.97% accuracy at 4 reasons, and we're still flagging plenty posts per day

Undo

Interesting that it goes down at 5 reasons

by just a little bit

ArtOfCode

6 reasons hits 100.00%

Undo

still a few every day

Thomas Ward

10:09 PM

this may sound like a stupid question, but what's "code admin" mean on MetaSmoke, again?

Undo

@ThomasWard Means !!/blacklist works

ArtOfCode

@ThomasWard people who can use blacklist without PR

Thomas Ward

ah, cool. :)

Undo

also, where are you seeing that?

Thomas Ward

@Undo Tools > User Data

Undo

10:10 PM

Oh, okay

ArtOfCode

yeah, that includes a list of roles

Thomas Ward

yup

angussidney

Most of them also have push access on GH

ArtOfCode

all of 'em, I think

at least as part of the Smokey team rather than org-wide

though actually very few people have org-wide push access, I think

angussidney

Magish doesnt

ArtOfCode

10:15 PM

oh yeah, he was the one special case

angussidney

There will probably be more cases like that if we start to increase security

Thomas Ward

sd why

Undo

sd f

Thomas Ward

@SmokeDetector f

NobodyNada

sd 3remove f

Undo

10:16 PM

whatever

angussidney

I don't think Ashish or Kyll need anything except blacklist

Undo

yeah, we can start tightening that down

ArtOfCode

Yeah, that'd make sense

Thomas Ward

Only a handful of us will actually need commit access for any reason. I mean, I have commit access to Smokey, but i'm not an abuser, and I always want anything I add spot-checked ;)

(lookit, the review system is great!)

ArtOfCode

I'm sure there's a button somewhere to require review on pull requests

Kyll

10:17 PM

@angussidney Indeed yeah, the write rights was mainly to update the blacklist

angussidney

I still use my code access for other stuff regularly, so I'll keep my access if the rest of you are fine with that

ArtOfCode

team pruned

Undo

Which one's Kyll?

angussidney

What do you mean, 'which one'?

ArtOfCode

aralun

already gone

Undo

10:21 PM

@angussidney trying to find his GH username

Wouldn't have guessed that for a long time

angussidney

You could have had a look at the profile pics :)

Kyll

... Or ask me, really =p

Undo

@SmokeDetector Maybe a false positive?

@Kyll Ohai!

Kyll

Plop!

NobodyNada

> A last means that in this case? Tell me please. This link is not entirely clear: preply.com/question/chto-oznachaet-last

ArtOfCode

10:22 PM

@SmokeDetector f

Undo

@NobodyNada Looks like an NAA

NobodyNada

sd n

yeah

the link seems to confirm it

SmokeDetector

[ SmokeDetector | MS ] Link at end of answer: How do I test my connection to a given site? by timfredo on superuser.com

ArtOfCode

@Undo have you got time to set up weighting now?

NobodyNada

@SmokeDetector doesn't answer the question, but could be an attempt

Undo

10:23 PM

@ArtOfCode Next window is probably in about an hour, need to do some Physics labs

if you want to, go for it

NobodyNada

If there's anything I can help with, I can in about an hour

I don't know Ruby though

ArtOfCode

@Undo I was debating whether I had time, but probably not

@NobodyNada that's probably a limiting factor, really

given that the entire thing is Ruby

well

Undo

@NobodyNada Art didn't either until... what, a few months ago?

I learned Ruby on a consulting project. It's really not that hard.

ArtOfCode

@Undo look up my first MS commit, and I learned it about a week before that

mid-January this year

NobodyNada

I could git clone MS and try to figure it out

Undo

10:26 PM

@NobodyNada Note that if you're on Windows, it's a little bit harder.

NobodyNada

I'm on Mac

ArtOfCode

^

as in much harder

Undo

@NobodyNada oh, then it's fine. Clone away.

ArtOfCode

as in you need a Linux VM to be anywhere near productive

Undo

"a little bit"

I can walk you through getting it set up.

I wonder if it works without a db dump

ArtOfCode

10:27 PM

@Undo Yes, now that we have seeds

Undo

@ArtOfCode Oh, sweet. You've tested them from scratch?

ArtOfCode

the only thing that didn't before now was not having a SmokeDetector record, but you can seed that in now

@Undo yeah, once about a month ago

Undo

yay

ArtOfCode

should be able to git clone, bundle install, db:schema:load, db:migrate, db:seed and you're ready to go

NobodyNada

I know how to do the git clone part, but that's about it :p

Undo

10:29 PM

@NobodyNada cd into the metasmoke directory

NobodyNada

done

Undo

What's ruby --version say?

I forget what's bundled with OS X these days

NobodyNada

ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]

thanks for helping!

Undo

good enough, probably

NobodyNada

I can update it with Homebrew

Undo

10:30 PM

actually, it requires 2.2.2+

SmokeDetector

naa- by DavidPostill

ArtOfCode

probably want 2.3.0

Undo

@NobodyNada I'd recommend using rvm instead, makes things a little cleaner

ArtOfCode

seems to be more stable than the 2.2.x series

Undo

rvm.io

gpg --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3

\curl -sSL https://get.rvm.io | bash -s stable --ruby=2.3.3

NobodyNada

10:31 PM

installing, thanks!

ArtOfCode

(yes the backslash is significant)

no idea what it does, but things break if you don't include it

NobodyNada

Stack Overflow says it prevents the command from being aliased

SmokeDetector

[ SmokeDetector | MS ] Repeating characters in answer: Break inner foreach loop and continue outer foreach loop by Jeffrey Sall on stackoverflow.com (@dorukayhan)

tpu- by Undo

Undo

Calling that abusive/nonsense

SmokeDetector

Restart: API quota is 2449.

Ferrybig

10:38 PM

@Undo would installing ruby on rails be easier on windows 10, now that it comes with a subsystem for ubuntu? (its like a full blown ubuntu environment in windows, including sudo)

NobodyNada

it failed to install it:

> There was an error while trying to resolve rubygems version for 'latest'.
Halting the installation.

> /Users/jonathan/.rvm/bin/rvm: line 66: shell_session_update: command not found
bash: line 850: shell_session_update: command not found

Undo

@NobodyNada What's the error?

whut

NobodyNada

which is strange, since running shell_session_update works just fine in the terminal

Undo

What command did you run?

NobodyNada

I'll try running the command again, and if that doesn't work I'll just use Homebrew.

\curl -sSL get.rvm.io | bash -s stable --ruby=2.3.3

Undo

10:40 PM

hrmph

Yeah, go ahead and just use Brew. Won't hurt anything

NobodyNada

I just ran the installer again; it completed in about a second and it works now

ArtOfCode

@Ferrybig yes, if that's in production now

NobodyNada

ruby -v:

ruby 2.3.3p222 (2016-11-21 revision 56859) [x86_64-darwin16]

Undo

dat'll work

gem install bundler next

NobodyNada

done

Undo

10:41 PM

You have some kind of awesome Internet connection

@NobodyNada bundle install, it should fail for some reason

Always does, then we just track down what it wants

ArtOfCode

I dunno, worked first time for me when I did a fresh clone

NobodyNada

@Undo I think it's being faster than it usually is right now

Undo

@ArtOfCode Yeah, you already had the Nokogiri dependencies and such installed

ArtOfCode

true

NobodyNada

it says I need to install mysql; I'm doing that right now with Homebrew

Undo

10:45 PM

You're having a suspiciously smooth time of it

NobodyNada

I think bundle install succeeded, but it gave me a bunch of information about Passenger and about configuration files

Undo

@NobodyNada About restarting it with touch?

You can ignore that stuff

NobodyNada

yeah, that's what it is; thanks!

Undo

When you installed MySQL through Brew, did you follow up on mysql_secure_installation and such?

NobodyNada

no; I didn't pay any attention

I probably should have

Undo

10:50 PM

There should be some instructions that Brew threw at you, follow those to get MySQL set up

(it's possible to just use SQLite, but MySQL works better)

NobodyNada

Should I install "VALIDATE PASSWORD PLUGIN"?

Undo

@NobodyNada Never heard of it, but it probably wouldn't hurt

your choice, leaving it off is probably fine

NobodyNada

okay, done

Undo

Did Brew give you a root password for it?

NobodyNada

I set up a password

Undo

10:54 PM

kk

So now mysql -u root -p and it'll ask you for your password

NobodyNada

ok

Undo

Once you're in, CREATE DATABASE metasmoke;

NobodyNada

ok

Undo

Followed by CREATE USER 'metasmoke'@'localhost' IDENTIFIED BY 'password';

Change password if you want, it doesn't matter much

NobodyNada

k

Undo

10:56 PM

Then GRANT ALL PRIVILEGES ON 'metasmoke'.* TO 'metasmoke'@'localhost';

FLUSH PRIVILEGES;

NobodyNada

> ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''metasmoke'.* TO 'metasmoke'@'localhost'' at line 1

Undo

ugh

just a sec

GRANT ALL PRIVILEGES ON `metasmoke`.* TO `metasmoke`@`localhost`;

perhaps

(backticks)

NobodyNada

that worked; thank you!

Andy

Could all of these steps get put in the MS wiki ?

Undo

@Andy I think we're generating one right now

Andy

10:58 PM

Woot

Undo

@NobodyNada Now cntrl-d to exit MySQL

NobodyNada

ok

Undo

Inside the metasmoke folder (cli):

cd config; cp database.sample.yml database.yml

Open database.yml in your editor of choice.

Replace the development: section with something like this:

development:
  adapter: mysql2
  database: metasmoke
  encoding: utf8
  username: metasmoke
  password: yourpass
  host: 127.0.0.1
  port: 3306

Replacing yourpass with... your password, of course

NobodyNada

ok

Undo

Now, hypothetically, this should work:

In the metasmoke root, run:

Nope, not that (unless it worked, then it's fine)

rails db:create

rails db:seed

NobodyNada

11:02 PM

that worked

ArtOfCode

you're gonna want schema:load in between those two @Undo

Undo

@ArtOfCode seed doesn't load it for you?

Let's test it. @NobodyNada rails c

ArtOfCode

not that I've noticed

Undo

Then ap Post.last

NobodyNada

it gave me a console thing, after spitting out a warning:

/Users/jonathan/Desktop/Metasmoke/config/initializers/appconfig.rb:1: warning: already initialized constant AppConfig
/Users/jonathan/Desktop/Metasmoke/config/environments/development.rb:19: warning: previous definition of AppConfig was here
Loading development environment (Rails 5.0.0.1)
irb(main):001:0>

Undo

11:04 PM

yup

ArtOfCode

normal

Undo

ap Post.last in there

NobodyNada

  Post Load (0.3ms)  SELECT  `posts`.* FROM `posts` ORDER BY `posts`.`id` DESC LIMIT 1
#<Post:0x007fc28b5ed170> {
                        :id => 1,
                     :title => "Test Post",
                      :body => "Test Post",
                      :link => "//stackoverflow.com/a/40291627",
        :post_creation_date => Thu, 15 Dec 2016 22:02:16 UTC +00:00,
                :created_at => Thu, 15 Dec 2016 23:02:16 UTC +00:00,
                :updated_at => Thu, 15 Dec 2016 23:02:16 UTC +00:00,

Undo

yeah, so it worked.

Sweet

NobodyNada

great! thank you!

Undo

11:04 PM

rails s to start the webserver

(short for rails server, as c is short for console)

NobodyNada

I'll start learning Ruby soon and start working on it

ArtOfCode

and you should have a functioning metasmoke on localhost:3000

NobodyNada

I can't make any promises about how much I can do or if I can work on it at all, but if I have time and want to work on it, what would you like me to do?

Undo

And therein lies the issue :P

I don't know of any good beginnerish tasks we have

Maybe @Art does

ArtOfCode

hm

NobodyNada

11:07 PM

Maybe I'll try to debug that issue that's open on GitHub

I don't have a populated database though

Undo

It's a database issue that has the ability to make you go completely nuts, but if you like you can play with it.

ArtOfCode

I tend to just ignore Unicode issues :)

Undo

@NobodyNada In that console, run Post.create(:body => "My name is jeff😂😂😂😂😂😂😂😂😂😂😂😂😂😂😂😂😂😂😂😂") and it should repro.

ArtOfCode

they're like pluralization bugs, except Jeff will hit you with two giant S's because two-byte characters

Undo

@ArtOfCode four bytes :(

NobodyNada

11:08 PM

lol

Undo

We handle two bytes fine. It's the four byte ones that get us

ArtOfCode

@Undo two two-bytes, actually

NobodyNada

thanks for the help!

ArtOfCode

the emoji and the skin tone mod

Undo

No problem ;)

As a super-high-level overview of how Rails works: Models store data, controllers get that data in response to requests, then they pass it to views which render the data in a human-friendly way.

NobodyNada

11:10 PM

so MVC then?

Undo

Yeah

ArtOfCode

yep

metasmoke is actually pretty complex these days... way more than the babby project it was when I started working on it

Undo

Scope creep ;)

Someone decided to go adding ignored users to it. I still don't know how that works :P

Works good, though

ArtOfCode

admin tools, feedback invalidation, deletion logs, ignoring feedback, read api, write api, roles, dev tools

all things that have happened this year

Undo

year's not over. Automatic flagging.

ArtOfCode

11:13 PM

@Undo it's not working at all at the moment, I don't think

Ignored users are the easy bit, anyway, you wait till someone makes you need to understand the API bitmasks

Undo

I think we have a bus factor of one on that

ArtOfCode

Oh hey, a Routemaster.

</london>

@Undo tl;dr: take ASCII characters in as the filter param, take their character ordinal, convert that to binary, concat the lot, and use that to represent which DB fields are "on" and should be returned

Undo

'character ordinal'

Sounds like something the Russians would use to hack an election

ArtOfCode

the DEC column in that

same as ord('c') in Python or 'c'.ord in Ruby

Undo

Huh

ArtOfCode

11:18 PM

so if you have filter = 'abcd' then you get 97, 98, 99, and 100 as the ordinals

convert those to binary and concat

you get 01100001011000100110001101100100

which means you should return the second, third, eighth and so on fields

you get to determine which those are, which is the purpose of the massive list in the AppConfig file

Our database is bigger than that and filter strings are a lot longer, but that's the general idea

Undo

11:31 PM

hrmph

SmokeDetector

11:49 PM

[ SmokeDetector | MS ] Offensive answer detected: Usage, pros and cons for binary search tree, 2-3 tree and B-tree by fffffffffffffff on stackoverflow.com (@dorukayhan)

[ SmokeDetector | MS ] Offensive body detected: Why are you such an a**hole today by Rus on superuser.com

tpu- by NobodyNada on Usage, pros and cons for binary search tree, 2-3 tree and B-tree [MS]

tpu- by NobodyNada

Transcript for