I am creating an app in Unity3D and it is my first time coding in c#.
I use the following code to parse a JSON file hosted on my server and use the information to render prefabs within my scene:
// Parses the json Object
JSONParser parser = new JSONParser();
AssetData assetData = parser.Par...
It doesn't make much sense to have a connection pool to be used by just one servlet. Usually, the connection pool is shared by the entire webapp. Furthermore, much of the setup can be accomplished by configuration rather than with code. It is certainly bad practice to hard-code connection stri...
HTML:
Since the the navigation is the only thing inside your <div class="footer">, how about moving the class to the ul?
Instead of using span's there, you can add the » to a pseudo-element (see the CSS part)
CSS:
For your arrows, you should use pseudo-elements:
.footer a:after {
...
When chaining constructors, it's customary to call the parent class constructor first, then perform the subclass-specific initialization. Here, it makes little difference since you're just setting a bunch of variables, but in more complex situations you could run into problems doing things in th...
Well the first condition could be reversed, immediately reducing the nesting level:
if (string.IsNullOrEmpty(customerpay) || string.IsNullOrEmpty(warrantypay) || string.IsNullOrEmpty(maintanceplan))
{
return;
}
// rest of conditions
This code looks like sample code, but I'll say it anyway:...
HTML:
For prototyping, you should include the # for links to actually trigger link behavior in browsers: <a href="#">Link</a>
Instead of placing <span>>></span> in your HTML, you should use…
If you page is not dynamically generated, you may consider using the CSS properties width and heig...
HTML:
In addition to your existing viewport meta tag, I suggest adding the width value:
<meta name="viewport" content="width=device-width, initial-scale=1.0">
Also moving the tag before you load your stylesheets and the title code help your performance. MDN on using the viewport meta tag.
A ...
If you are using GCC, we can use the typeof()(C99) keyword to get rid of one of the arguments. Also, add a do-while so the macro to be used in contexts where it would otherwise be problematic.
#define SWAP(a, b) do { typeof(a) t; t = a; a = b; b = t; } while(0)
You could also use an exclusi...
Let's improve the function step by step, focusin on readability as well as on the algorithm itself.
I believe the type of the function is not what it should be. We get a list of characters, and we should produce a list of lists:
pack1 :: [Char] -> [[Char]]
pack1 xs = foldl (\acc x -> if not(nu...
I could get rid of your startQuote variable, I reduced the number of i CONTAINS '"' comparasions by 1.
array function convertRow(required string lstRow) {
var arResult = [];
var arTemp = ListToArray(arguments.lstRow, ',', true);
var quoteMode = false;
for (var i in arTemp) {
...
Your problem is not with the loop construct - nor is it with GOTOs. Your problem is you are avoiding some tools that can make your code better.
Here's an example.
enum Validator {
IsNotComment("Skipping commented line in file.") {
@Override
boolean isValid(String s) {
...
I find it strange that the zero-length line problem has not yet been pointed out:
for(String line : lines) {
if(line.charAt(0) == '#') {
....
The code above assumes a non-empty line in all cases, otherwise you get IndexOutOfBoundsException.
This is the sort of issue that should...
A puzzle I was given. Apparently my solution is not efficient enough:
def pivot(arr)
results = []
arr.each_with_index do |n,index|
last = arr.size - 1
sum_left = arr[0..index].inject(:+)
sum_right = arr[index..last].inject(:+)
results << index if sum_left == sum_right
...
There's one small bug in your code here:
memcpy(foo_addr, shellcode, sizeof(shellcode));
This copies the contents of shellcode, but being a string literal, shellcode includes a null terminator and sizeof(shellcode) is equal to 30, not 29. You should replace this line with:
memcpy(foo_addr, sh...
Below is the code for the whole program. I can't figure out why the code skips the if statement. The if statement in question has been bolded.
#include <iostream>
#include <string>
struct salesData
{
std::string isbn;
unsigned numSold = 0;
double revenue = 0.0;
};
int main()
{
salesData data1...
I have two functions to count the number of set '1' bits in the first offset bits of either a 64 bit number, or a bitmap struct.
After some profiling, particularly the latter is quite a bottleneck in our system.
What can we do to make it faster?
#define POPCOUNT16(x) __builtin_popcount(x)
#def...
You need to configure your Minecraft server. From the Minecraft wiki:
Configuring the Minecraft server
Configure the server by editing the server.properties file, the
format for which is explained here. Be certain to edit the file with
a text editor that does not add formatting (...
I'm working on a jQuery plugin for a client. Instead of finding one that was already out there I wanted to practice writing plugins since I hadn't in awhile. This plugin grabs all the images in a UL, creates a overlay for the page, and puts them in a image zoomer that gets opened when a user cl...
Since you haven't provided a queue implementation, I assume you're using std::queue. If so, make sure you're not using using namespace std and are using std:: where necessary.
For this line:
for(BaseFilterMap::const_iterator it = m_Filters.begin(); it != m_Filters.end(); it++)
It may be more...
Like @Corbin said, there is little that can be done to improve the efficiency of your code. But there are a few things I can do to improve the code quality.
You list define a lot of priorities in your header file.
#define VERY_HIGH_PRIORITY 4
#define HIGH_PRIORITY 3
#define NORMAL_PRIORITY 2
...
Use the global keyword to make globals accessible from inside of methods and functions:
class KD_sql
{
public static function get_recipes()
{
global $dbh; // *** ADD THIS ***
$qry = $dbh->query('SELECT * FROM recipes');
$get = $qry->fetchAll();
return $g...I'm not sure on how much more efficient this will make your code, but you can add the register keyword to your code to indicate that a variable will be heavily used and that you recommend it be kept in a processor register if possible.
register int32 count;
The bulk of your code looks fine, I have made what are (In my opinion) a few usability enhancements, but take it or leave it as you see fit.
I don't think you can really make the xml processing any less ugly.
Comments are inline
<?php
/**
* Weather class
*/
class Weather
{
// lets defi...
My attempts always return false :(
package main
import (
"fmt"
"math/big"
)
func main() {
i := new(big.Int)
j := i.ProbablyPrime(2)
fmt.Println(j)
}
Can anyone let me know what I am doing wrong?
Is there any better way of printing it?
public class PercentPrinter {
/**
* @param args
*/
public static void main(String[] args) {
for (int i = 0; i < 100; i++) {
if (i == 0)
System.out.print("percent completed: " + i + " %");
try {
Thread.sleep(5...
I have a model object class like this
public class EventInterestsResponse
{
public string id { get; set; }
public int sortOrder { get; set; }
public string name { get; set; }
public string categoryName { get; set; }
public string categoryId { get; set; }
}
And I am using i...
Looking for code review, clever optimizations, good coding practices. If question is unclear drop by a comment, I will clarify asap. Unit testing has been a visual inspection and concluded expectations match.
public final class RotateNinetyInPlace {
private RotateNinetyInPlace() {}
pri...
I like your usage of Guava, and overall your code seems really good. I might actually use it myself somewhere.
The code could use some more Javadoc though, especially on the class itself and the constructor. Explaining those callerPageSize and sourcePageSize parameters is very important.
Possib...
I have created a blog. A specific group member can chat in that blog. Each comment has a dynamically created linkbutton ("edit"->text)
Upon clicking on the edit linkbutton, I want a dialog box to pop up. I tried a lot but unable to proceed. Please help.
Following is the piece of code on how I a...
I have an entity 'RegistrationForm' which has a OneToMany-relationship with 'SurveyAnswer'.
An answer can either have a collection of 'FormOptions' (when the answer is of type 'MULTIPLE_CHOICE') or a 'content' represented by a string (type TEXT-FIELD, TEXTAREA etc.).
Below is a function insi...
