Robert C. Martin in his Clean code states that functions should do only one thing and one should not mix different levels of abstraction. So I started wondering whether the code below meets these requirements (I assume the answer is negative). Which one is better?
public void run() {
isRunni...
There was a question asked here recently:
What are the fantasy secret hats you'd wish to get?
It would be neat to see some of those community-created hat ideas included next year.
This function is intended to remove leading and trailing whitespace from a string. How can it be made more efficient? For example, can the two for loops be combined into one?
string trim(string str)
{
int i = 0;
for (char c : str)
{
if (!isspace(c))
break;
...
I'm working on an algorithm to determine if a std::string has all of the same character. Here is what I have:
bool string_has_all_of_the_same_chars(const std::string& s) {
return std::all_of(s.begin(), s.end(), [&s](char ch) { return ch == s[0]; });
}
Are there any improvements that can be...
When I tested your function with this string input:
" c a t "
I got no output. This could mean that substr() isn't returning anything to trimmed.
Moreover, you're right that this can be done with just one loop. There are many ways to write such a function, but here's one method I ca...
Given the following piece of code, can it be done better:
public object DistanceFrom(
IEnumerable<Coordinate> coordinates) {
IEnumerable<DbGeography> addresses = coordinates.Select(
c =>
DbGeography.FromText(String.Format("POINT ({0} {1})", c.Longitude, c.Latitude)));...
I don't quite understand what I'm doing and what I'm doing wrong.
Please help me to fix/finalize my code.
I am supposed to create at least 3 Student objects with input data of your choice to initialize all the data fields of a Student object using the constructors of the classes.
Declare an...
I have the following questions for the below code:
Is there a simpler implementation of an on-screen counter?
I made CountTimer inner class since it's tightly coupled with the GUI part anyway. What would be the best way to uncouple them?
package count_timer;
import java.awt.*;
import java....
While trying to learn more about arrays in C, I tried to write some code that did the following:
- Read a stream of numbers from the stdin and store them in an array
Print the array in the order the numbers have been stored, i.e. Print the original array
Print the array in reversed order.
Sort...
Currently building my personal site using Jekyll, inuitcss and GitHub Pages. I'd like to hear your thoughts on the markup of my blog page and its post pages.
What do you think about handling logo's like this? Also I'm not sure about the headings. The page-title probably should be part of the mai...
I got this SP, If anyone can improve it, I changed variable names for some reason, SQL Server 2000 I am working on
USE [DBName]
ALTER PROCEDURE [dbo].[Table_GetSomething]
@name nvarchar(50),
@Cooltree nvarchar(10),
@aID int,
@bID int = 0
AS
BEGIN
-- SET NOCOUNT ON added t...
I have a conditional check in my HTML, that returns a value when the variable is set to TRUE or FALSE. Unfortunately, I hardcoded the variable to TRUE and it still returns the value that belongs to FALSE.
This is my code:
<tr>
<td>Vermelding op Funda?</td>
<td style="background-...
Two difference scenario in bash program,
First
Here i am breaking loop in function testFunc.
#!/bin/bash
function testFunc {
if [ some condition ] ; then
break
fi
}
while [ 1 ]
do
testFunc
done
Second :
In this case, testFunc will return some value, and handling the l...
Background
A User Interface provides people with the ability to rearrange rows of an HTML <table> element using jQuery's sortable API. I have exposed a stored procedure to facilitate updating the database to reflect the user-defined order. The function prototype is declared as:
item_move(p_item...
First attempt was done here:
My second attempt (now using jslint to make sure the spacing is correct and have incorporate the majority of the feedback from previous attempt).
/*
* Export single function that creates the passportControl object
* The function has two parameters:
* app: ...
I once had a piano teacher. I asked him how he did certain things with the keys, what his brain was doing while he performed a certain technique, and how he managed to process it as quickly as he did. He looked at me strangely for a moment and then finally answered, "I'm so far beyond even thin...
This is much more "Functional" than my first attempt:
def combineStrings(strs: List[String], maxLen: Int)
: List[String] = {
import scala.collection.mutable.StringBuilder
strs.map(_.trim).filter(_.nonEmpty)
.aggregate(List[StringBuilder]())({ (lbs, s) =>
s.length match...
I have a DOM library that I've broken up into multiple parts. I will likely put these parts in internal IIFE's as modules.
This is the wraps module.
The reason I wrapped these functions is so that I could build them out later. Currently they don't provide any functionality beyond the native c...
Your first excerpt is fine, and it is better than your second. Your second excerpt is worse because of the deeper nesting. (Also, if you were to choose nesting anyway, I'd invert the conditions to put the shorter code branch first to reduce mental workload when reading the code.)
Consider why ...
A different way is to let these pairs be represented by a class, which itself has a static factory method that will return null on failure.
public final class Pair {
private String key;
private String value;
public Pair(key, value) {
this.key = key;
this.value = valu...
I can't quite figure out the best way to approach this. I have two jquery objects that both are used to
set cookies. I then parse the JSON and set a cookie that is either the users height or the users weight.
This works fine but I feel like there is an extreme amount of redundant code here that c...
Question: When should I deploy my assemblies into the GAC?
Answer: Never
Actual, honest, Real Answer: Hardly Ever
Discussion
Only drop things into the GAC when multiple apps on the machine will use the assembly, and when the assembly is foundational (likely to be used by multiple apps...
I just want to make sure that my Rolling (Moving) Average class is understandable and reasonably thread safe.
My main questions are:
Is having totalCounts as a long just for a potential edge case overkill?
Is checking to see if the number of observed counts is 1 (and thus, just return the obse...
On your questions:
There are some oddities in your code, for example, the use of non-blocking
sockets.
Detecting disconnected clients is difficult. I'm not that familiar with
UNIX-domain sockets, but I imagine they are much the same as Internet-domain
sockets. You probably need either to set ...
I have below type of codes in one function
public void func()
{
if (!string.IsNullOrEmpty(customerpay) && !string.IsNullOrEmpty(warrantypay) && !string.IsNullOrEmpty(maintanceplan))
{
if (customerpay == "Include" && warrantypay == "Include" && maintanceplan == "Incl...
Define a macro swap(t, x, y) that interchanges two arguments of type t.(Block structure will help.)
The ideea is that a variable defined in a block structure exists only inside the block structure. So, I can create a temporary variable without affecting the code.
Here is my solution:
#incl...
If you are using gcc, we can use the typeof() keyword(1) to get rid of one of the arguments. Also, add a do-while so the macro to be used in contexts where it would otherwise be problematic.
#define swap(a, b) do { typeof(a) t; t = a; a = b; b = t; } while(0)
You could also use an exclusive...
Well the first condition could be reversed, immediately reducing the nesting level:
if (string.IsNullOrEmpty(customerpay) || string.IsNullOrEmpty(warrantypay) || string.IsNullOrEmpty(maintanceplan))
{
return;
}
// rest of conditions
This code looks like sample code, but I'll say it anyway:...
You could do it like this:
public void func()
{
if (string.IsNullOrEmpty(customerpay) || string.IsNullOrEmpty(warrantypay) || string.IsNullOrEmpty(maintanceplan))
return;
if (customerpay != "Include" && warrantypay != "Include" && maintanceplan != "Include")
return;
...
