The solution to your problem (given in the example): Select the contents of your for block Refactor -> Extract method Inspect program to make sure nothing broke Inspect the new generated method to see if it's ugly If ugly, select ugly parts, go to #2 If you can't select them because they are to...

I'm not sure if this is any better and it might depend on how many if statements or different categories you have whether it's worth it. But an alternative could be something like: var categoryLabelValues = new Dictionary<string, string>() { {"11", "Branche"}, {"22", "Udvikl...

Some random thoughts: Callback is one word, I'd name the class PrintCallback (lowercase b). If these methods are called from separate threads you need proper synchronization. Is it have to be static? Static variables, singleton classes usually makes testing harder because their global state - t...

Right, first: short answers to your 4 questions: Is this proper OOP? No, there are several issues Or what can I do to improve this class? A few things, we'll get to that in a moment. Do I need to make it more abstract? You may want to look into that What can I do to make the _parse_weather_xml ...

Here's an answer out of left-field, but it may give you some inspiration. If I were doing this in Haskell I would write it as a pipeline of maps and folds on a list. I don't know much about Java, but could you rewrite your function as several smaller functions each of which acts on an iterator ...

Since I don't have high enough rep to comment, I'll post this instead... fyi: @import vs http://stackoverflow.com/questions/7199364/import-vs-link I'd keep the same master stylesheet if it were me. EDIT: <h1> or <img> as a logo? Debate on... short answer, It depends on the context of the web...

first issue: you hardcode 8 as the number of bits per sizeof unit: portability says it should be CHAR_BIT which may be something else on some architectures second issue: both members of int80 are signed, only hi should be while lo can be unsigned if you can guarantee that offset is between 0 an...

this sounds like a good candidate for a printf: always print a fixed amount of backspaces. always print a fixed-size % value. Finally, when monitoring things this way you always have a fencepost problem. Your work is the space between the fenceposts, and the fenceposts are the messages you wr...

1. Introduction You have made this question unnecessarily difficult for us because: You have not specified what the function countlower does. You should always write a docstring for a function, specifying what it does, what arguments it takes, and what it returns. (And test cases are always ap...

You can use NSPredicate: NSArray* productsToDelete = [allLocal filteredArrayUsingPredicate:[NSPredicate predicateWithFormat:@"NOT (productId IN %@)", allRemoteIds]]; for(Product* product in productsToDelete) { [product delete]; } This will for sure improve readability of your code. I'm not...

There's no documentation. What does this code do and how am I supposed to use it? There are no test cases. Since the hashlib module has a sha1 function, it would be easy to write a test case that generates some random data and hashes it with both algorithms. For example: import hashlib from ran...

What should our logo and site design look like?

Standing on the shoulders of @rolfl… I would prefer to use a carriage return to return the cursor to the beginning of the line, as it's a bit less fragile than backspacing. public static void main(String[] args) { // Java's Printwriter.format() doesn't tell you how many characters // it...

Blog markup The site title should be a h1. Use an ul for the navigation links. Or, if you don’t want that, use at least a div element for each link, or a textual separator between each link. The page title (+ the content under its scope) needs be enclosed in a sectioning element (probably sect...

Little Stuff One line functions that are only used once such as scrollLeft and scrollRight should get inlined. Functions that create divs like getThumbs could be called createThumbs instead To your point, there is no good reason to have any functions outside of $.fn.imagezoom = function(base, o...

I haven't worked with Facebook's API using queries like this, but I know SQL inside and out, and this screams INNER JOIN to me. var joinedQuery = "SELECT Photo_Tag.pid,Photo_Tag.xcoord,Photo_Tag.ycoord,Photo.src_big FROM photo_tag AS Photo_Tag INNER JOIN photo AS Photo ON Photo_Tag.pid = Photo.p...

The OdbcConnection is not thread-safe in any way, therefor it needs a locking mechanism. My observation is that the OdbcConnection does send it's received commands down into the Connector. If this is happening in a multi-threaded environment, the sequence of commands is interrupted and you'll re...

What you did well on: Your program is easy to read. You are allocating memory, even though it is unsafe in certain cases (other answers have addressed this, so I won't cover it). You prepare for some corner cases. Things you could improve: You are returning 0 when your program runs into a...

I had for some days the fantasy of getting a grinch hat. I know there is a hat when you only do upvotes in a day and believed it could make sense to have the same kind of hats for downvotes only. It would be the grinch hat. The programmer that ruined christmas. What are the fantasy secret hats y...

I had for some days the fantasy of getting a grinch hat. I know there is a hat when you only do upvotes in a day and believed it could make sense to have the same kind of hats for downvotes only. It would be the grinch hat. The programmer that ruined christmas. What are the fantasy secret hats y...

The Robot Get caught by the bot detection software and fail pass the CAPTCHA human test.

It was first used as an interjection in the 19th century: “They marched, and I amongst them, to face the enemy – heads up – step firm – thus it was – quick time – march!” Then, at the beginning of the 20th century, it began to be used adjectivally, as in: “He was always right on the job, and loo...

As far as I can understand, default: comment.replace(i, 0, "\\"); makes case '\\': comment.replace(i, 0, "\\"); break; useless.