I wrote the following Fizz Buzz program. How can I improve it or make it more efficient?
public class FizzBuzz
{
public static void main(String[] args)
{
System.out.println("--------Fizz Buzz program-------------");
for(int num=1;num<=100;num++)
{
if(num%3==0)
...
you have a lot of if statements in your SQL, this screams at me that you are doing something in your SQL that should be done in the application, and that this SQL should be separated into two distinct stored procedures.
the benefits
faster stored procedures
use an actual coding language to d...
You are correct in suspecting that the try/catch is not necessary. Generally speaking, Caesar ciphers are implemented using modular arithmetic. We can determine if a character is alphabetical by simply checking if alphabet contains that character; anything else (whitespace, digits, punctuation, e...
A few improvements I notice right off the bat
newtype vs. data
replace single field data declarations with newtype. newtype has no runtime overhead.
data GrayscalePixel = GrayscalePixel Int
-- becomes
newtype GrayscalePixel = GrayscalePixel Int
Use StateT
A common pattern in your code (ex. p...
What do we think of:
Short answers (for example, "I suggest you use [hyperlink to this standard API] instead.")
Code-only answers (for example, an improved version of the code in the OP)
Such answers could be improved (e.g. by adding an explanation of why the suggestion is helpful).
Is it re...
I am not Well Versed in MySQL Syntax, but it looks to me like the Table Declarations are a little redundant with the DROP TABLE if it exists and then CREATE TABLE if it doesn't exist.
seems to me like the SQL Engine is going to do an extra search to see if the table exists when we already know t...
Short answers (for example, "I suggest you use [hyperlink to this standard API] instead.")
Link-only answers I like not. These are (or at least has been, but I believe they are still) discouraged on StackOverflow and often converted to comments (I've flagged a bunch of these). Links can become o...
I'm working with Codeigniter and I have a JQuery file to add some funtionalities. But I think I'm doing it in a wrong way.
$(function() {
var list = '../indoamericana/intranet/employeesList/';
var home = '../indoamericana/administrar/callHome/';
var profile = '../indoamericana/user/'...
Here is a method I have in my ApplicationController, but it's "ugly" and needs some cleanup.
def user_root_path
return root_url unless user_signed_in?
return admin_root_url if current_user.admin?
return contributor_dashboard_url if current_user.athlete_contributor? && !current_use...
These dependencies can't be fixed by naming. They are a symptom of some fundamental design problems. If you're having trouble finding methods, that's
a symptom of an overly coupled design.
You have a class names that really sound like methods in a completely different class.
Without knowing m...
There is a lot that can be simplified. AppendLine() instead of Append() with Environment.NewLine, object initializer syntax, etc.
ws = new XmlWriterSettings is never used.
Also, StringReader is also an IDisposable resource and should therefore be wrapped in using.
I've also put the very short ...
As far as I can tell, this code seems pretty easy to follow, especially with the comments. Here are several things that stood out to me:
Since you haven't provided your own queue implementation, I assume you're using std::queue. If so, remove using namespace std and use std:: where necessary....
Ruby allows -1 as an index that means last, so you don't have to calculate it at all.
Calculating the whole left_sum every time is repeating work since it is always the previous left_sum + arr[index-1] (except for when index = 0). Similarly the right_sum is always the previous right_sum - n.
Yo...
What you did well on:
Your program is easy to read.
You are allocating memory, even though it is unsafe in certain cases (other answers have addressed this, so I won't cover it).
You prepare for some corner cases.
Things you could improve:
You are returning 0 when your program runs into a...
For a while now I have been considering the formatting of css files to maximise their usability by other coders and I think that this would be perfect place to get some feedback on the rules I try to apply when writing a css file.
The rules I have been honing are as follows:
Start general and ...
def getProxiesLstFromDB():
global g_proxies
# insert to status page links table
proxies_list = g_db["proxies_list"]
proxies_list_records = proxies_list.find()
print_to_log("get proxies list from db")
for proxies_list_record in proxies_list_records:
if proxies_list_...
I tend to have a class with my constants in there matching the enum in the database
For example
class Model_MyData {
// because it is an ENUM in the database, I use text names rather then numbers.
const TYPE_BUILDS = 'BUILDS';
const TYPE_ISO = ISO';
const TYPE_INSTALLER = 'INSTALLER';
...
Can't seem to find one, so trying to build a very simple but fast implementation. Thought I would post on SO for review/feedback, and so that others can just copy/paste for their own use.
I'm using a Dictionary and LinkedList, with a non-granular lock. Basic benchmark included below:
public cl...
I'd like to gather a list of boilerplate comments (AKA canned responses) for Ask Ubuntu which can be used in combination with the awesome Pro-forma comments userscript.
Post suggestions too, you are not required to use the script.
Please wrap your comments into a code-block for easier copying.
When the user visits the web page and hovers over an album artwork, the title of the piece and the artist name appears. It leaves when the mouse leaves.
I have achieved this with the following code:
HTML:
<img id="pic1" src=" ">
<div class="info1">
<div class="name">artist</div>
<div...
I've got a conditional that sets a cookie based on if a selector exists. There are other places in the code where I do something similar if the selector exists. If the selector exists I either add "nfl" or "nfl-" (notice the dash) to various attributes on the page. I'm trying to remove as much co...
I've got a conditional that sets a cookie based on if a selector exists. There are other places in the code where I do something similar if the selector exists. If the selector exists I either add "nfl" or "nfl-" (notice the dash) to various attributes on the page. I'm trying to remove as much co...
I'm not sure if this is a bug or not, but it doesn't look like the Android app is displaying accepted answers correctly.
The first red circle looks like it would have an accepted answer, but it doesn't (at the time of posting this).
The other circles are displaying correctly; the questions ...
