The 2nd Monitor - 2016-01-07 (page 6 of 6)

« first day (978 days earlier) ← previous day next day → last day (3053 days later) »

8:05 PM

Agreed

Captain Obvious

8:19 PM

0

Q: Delphi: precise timings with low jitter via RDTSC (for x86 and x64)

The Win32 API has a so-called 'high performance counter' (QueryPerformanceCounter() and friends) but often it is neither precise enough nor reliable enough, do to high jitter. The low resolution is no surprise since the value is often derived by shifting off the 10 low bits of the CPU's time st...

performance timer delphi

0

Q: Chaining fillRects for a single render

I'm trying to create a canvas project inspired by this gif where colors of an image are averaged and animated. Thus far I have all of the functionality working but it only performs well with a large cell size, meaning using fewer fillRects. Is there any way to chain these fillRects together an...

javascript performance canvas

Hello all

@Mat'sMug i have this on a shirt

@Phrancis why did you link me java code? 0.o

@Phrancis related: meta.stackexchange.com/q/138755/197901

Captain Obvious

0

Q: Personal Portfolio for Free Code Camp

I recently finished the Build a Personal Portfolio Webpage project for Free Code Camp, here, I would be very grateful if anyone would be willing to offer any advice on the design of the website or on HTML, SCSS, or jQuery coding practices.

jquery html5 sass

Is there a chat room for programmers?

TFS has built in support for code reviews (TFVC) or pull requests (git). — DaveShaw 40 secs ago

8:30 PM

@Gustavo6046 if you mean the se site: that's The Whiteboard

@DanPantry Oh I saw you had commented on my answer to the Mr Watson HNQ, just wanted to show you updated code

if you mean a place where you can dump your problems... nope

I made a questionManager() method for it, which I feed is a lot more elegant, then the question methods just return a boolean

Nevermind what I was going to ask. I didn't found the answer in Google but I think I found an alternative...

Pre-monking

8:34 PM

Pre-monking?

I'm not at work yet :P (long drive ahead)

Naming shirt meta seems to be going well

0

A: Code Review — Top User Swag!

I don't want to seem ungrateful in any way, but would it be possible to have a choice between a Code Review mug and the Code Review Rubber Duck? I just see myself using a mug more than a rubber duck, and I don't have kids to give it to.

@Quill Indeed! And I'm getting code review advice on my tag line suggestion lol.

pedantic-people-site

@Mat'sMug I don't get it: meta.codereview.stackexchange.com/posts/6466/revisions

lol

Oh wait.

8:43 PM

it's intentional

he got me as well

guys is it relevant to post code review of 200 line class? it's a custom Array class in java that i designed for my needs

its pretty basic though

@someFolk sounds okay to me

there's no size limit on posts

soo... are we gonna be mad about how we didn't get mentioned on the podcast??

I am trying to implement some sorting algorithm in C++. The first step alone forced me to implement an array view type and some strange new iterator type.

And I'll need to implement some hybrid bastard between a list and a tree for the second part.

@Vogel612 well technically...

@Vogel612 There is. I reached it twice.

8:52 PM

@Morwenn it's been upped...

Oh :o

to 65k (and a bit)

instead of 30k

Integer limit, ok x)

@Mat'sMug "designs" ...

@Morwenn int16, though

soon you'll be able to tweet your CR post instead of just linking to it

8:55 PM

@Vogel612 @200_success mentioned it the other day and I would say yes

The podcast, that is

to be fair, they restrict it to an hour, but I'd say design-independent grad could even be a whole additional podcast...

Yeah, in the second last podcast they mentioned two sites fully through grad

Or I might be remembering wrong

Either way, design-grad is usually mentioned

soo.. @Pops do you think you could pull some strings to get the "freshly" graduated sites onto the podcast?

This includes anime, electronics and the whole design-independent bunch...

I'm surprised he hasn't been on the podvast yet

KIDS!? No way that my kids, even if I would have had some, would get to play with my rubber duck! — Simon Forsberg McFeely ♦ 4 mins ago

9:00 PM

A podcast episode about beta sites wouldbe pretty cool

Naruto answer; accepted non-selfie answer with 0 score: Formatting some data about some airlines php

Ripe zombie; open question with answers, at least one answer having score 0, no answer having score > 0: Scheduling a response callback java unit-testing android

And they could mention Lifehacks issues and sites like PPCG which are hopeful

about to post my first code review, theres any example format to follow?

Nope! However you like

@RoboSanta urk.. this should really include some explanation

9:01 PM

Just make sure to explain your reasoning :-)

sure do

Although if you're interested, take a look at the highest voted Q&As for inspiration / see how they're crafted

I would suggest janos' work, Joseph the Dreamer's work, Eric Lippert's work for that; they're all usually structured differently, but high-quality nonetheless

@someFolk The best questions usually have a title that describes what the code does in a few words, then include a good plain English explanation of what the code is for (and context, e.g. the "how" and "why", if applicable), then of course the code

@Phrancis I think he meant code review as answer ;-)

23 mins ago, by some Folk

guys is it relevant to post code review of 200 line class? it's a custom Array class in java that i designed for my needs

9:10 PM

ah, nevermind then

Captain Obvious

0

Q: Python 2.7.10 "or" statement error

I am making a quiz game for my school project. The language I'm using is Python 2.7.10, however, when testing what I have done so far, I get the error "Invalid syntax" and marks the "or' in the code, check the code below and inform me of any errors I have made in the code. And the invalid syntax ...

@someFolk usually people start with a description of what the code is doing, why some design decisions were taken, what concerns they have, followed by the code itself, usually each code file in its own code block (topped with a short description of the code file's purpose) - icing on the cake is a catchy title that roughly describes what problem your code is solving

oh wow

    q2 = raw_input ("What era of time did Leonardo Da Vinci live in?: ")
    if q2 == "C": or q2 == "c"
        print "You must have played Assassin's Creed 2"

@CaptainObvious @Mat'sMug feel free to accompany a CV with that comment ;-)

I don't CV, I just C :)

well that's even better ;)

9:14 PM

You guys have CV privs, I shouldn't be hammering posts like that

^^

well whatever :P

The system is well enough designed that mods should only need to intervene in exceptional cases, IMHO (not complaining or anything, you mods are great :)

Just received the newsletter. Guess what, Dr.Watson is at the top...

Whoever said titles aren't everything....

Good grief ;p

Ah well, I got plenty of rep out of that one, no complaints

9:22 PM

Can you use SASS in StackSnippets?

The closest to SASS I heard of was spelled SSAS. No clue, try it out!

@Quill you ain't got a compiler I daresay

to be honest the code in this question just looks like normal CSS

0

Q: Personal portfolio template design

I recently finished the build a personal portfolio webpage project for a free Code Camp, here, I would be very grateful if anyone would be willing to offer any advice on the design of the website or on HTML, SCSS, or JavaScript coding practices. (function($) { $(document).ready(function() ...

jquery html5 sass

@Quill so you basically don't need to compile?

yep, it's css

is SASS compiled? I didn't know that

9:28 PM

@Vogel612 Not sure... a lot of the technical details probably wouldn't be very interesting, for example. Perhaps we could be better about mentioning that graduations occurred at least, though.

In any case I passed it along.

Yeah I think SASS compiles to regular CSS in the end

stress on "compiles"

@Pops Thanks for that, Pops

@Quill else it wouldn't be different from CSS would it?

@Vogel612 so in that case, the yet-not-compiled-SASS should be included in the question

9:29 PM

> Once you start tinkering with Sass, it will take your preprocessed Sass file and save it as a normal CSS file that you can use in your web site.

sass-lang.com/guide

SASS to be exact is a preprocessor so it's really there just to make writing and maintaining CSS better

If you want SASS reviewed, include it in the question. — Quill 8 secs ago

Captain Obvious

0

Q: Binary Search Tree algorithm: please help find a mistake

I have the following code to test whether the binary tree is the Binary Search Tree. However, it gives a false negative. I can not find a mistake in my code. Could anybody help me spot it? public boolean isBST(BinaryNode node){ if(node==null) return true; if(node.left!=null && node.left...

java algorithm tree binary-search

@CaptainObvious nope

I'm afraid this question does not match what this site is about. Code Review is about improving existing, working code. Code Review is not the site to ask for help in fixing or changing what your code does. Once the code does what you want, we would love to help you do the same thing in a cleaner way! Please see our help center for more information. — Quill 9 secs ago

9:45 PM

What have you tried? Are there errors with the example code snippet you have pasted? Have you read the docs for either of the crates you have used? Stack Overflow isn't a code-writing service. If your code works but you wish to improve it, then Code Review might be a better location for your question. What about other questions about splitting a vector into parts for parallel processing; how does this question differ? — Shepmaster 49 secs ago

9:56 PM

haha I was waiting for that one

ERRRRRR MERRRRRR GERHHHHHHDDDDDD!!!!!!! IT'S A RUBBERDUCK! — RubberDuck 42 mins ago

@Mat'sMug I think he made comments like that earlier ^^

@Phrancis Would using SASS make working with CSS easier or way more complex?

it-depends but I'd say the bigger the CSS code base, the more it would make it easier to maintain

@someFolk Is that question still actual? I think there's a meta about that.

12

Q: Checklist or General Directions on how to write a good CR-ish answer

This question is intended to be the counterpart of: Checklist for how to write a good Code Review question Getting started with CodeReview: New users often seem to have problems to understand, what exactly is expected from a CR-Answer. Many come from Stackoverflow, others maybe from Programmer...

discussion answers

It makes CSS more modular, so it reduces the amount of copy-pasting and of find-replacing

@Quill Not entirely true:

19

A: How much can an answer be subject to opinion?

There are all kinds of problems that can be pointed out in a code review. Good answers point out Genuine bugs Security holes Misconceptions Inefficiencies in the algorithm Inefficiencies in expression Poor use of data structures Violations of accepted programming practices Advice to understand...

@Phrancis So write it vanilla at first and see if it makes it easier when it becomes big?

10:02 PM

Well I could see it be very useful if you're just starting a new site design as well

There are so many frameworks around for web development, it's hard to see which ones actually make sense to use for a particular project.

@Phrancis Yea? What problem does it solve for new sites?

.message {
  border: 1px solid #ccc;
  padding: 10px;
  color: #333;
}

.success {
  @extend .message;
  border-color: green;
}

Here is an example using the @extend directive

So, you move things you'd otherwise do in jQuery to pre-processing for the CSS?

Sure

That would probably be helpful for the performance.

10:04 PM

$font-stack:    Helvetica, sans-serif;
$primary-color: #333;

body {
  font: 100% $font-stack;
  color: $primary-color;
}

@Mast well formatting wise I'm right, content wise you're right

Another example, this time declaring variables

You can also import SCSS/Sass files into other SCSS/Sass files, which you can use to organize things better

I really should be using something like that for the Cardshifter site, come to think of it

don't forget there's selector nesting as well

nav a {
   /* foo */
}
nav li {
   /* bar */
}

becomes

Captain Obvious

1

Q: Accessing files in a child directory in Python 2.7.x

I have written the below script for use in Python 2.7.x. In essence, I want the script to access a folder contained within the directory the script is and then add all files contained within to a list. I'm then looking to open these files using the csv module and process each line for now. My sc...

python python-2.7

nav {
    a {
        /* foo */
    }
    li {
        /* bar */
    }
}

10:08 PM

Yeah that's pretty cool

Right.

I didn't know you could nav in CSS.

I reviewed the question we were talking about anyway and left a comment on his question saying I'll review the SCSS if he adds it

You can CSS on all HTML elements, even those you make yourself, AFAIK

^ that

HTML is like XML, the browser knows the rendering rules for each element

but you can make your own and render them however you like

Right.

10:11 PM

Hey @Phrancis you're an audio engineer by hobby or trade aren't you?

Do you know any good sites to get sample sounds from? I'm working on a JavaScript project that needs some good sample tracks

Remember that ant simulating project?

@Quill Both, yes

@Quill Sound effects or music?

music

I'm doing a simple data format for rhythm games

like

freemusicarchive.org

github.com/Gustavo6046/MyAntSim

10:14 PM

@Gustavo6046 I'm not sure it's a good idea to version bin/....

Although for something like a rhythm game I would expect a MIDI or other such data format (where tempo and rhythm elements are just data points in the file) rather than audio

<single time="44" column="1" />
<long start="44" end="54" column="2" />

@Gustavo6046 Your variable naming could use some love.

Captain Obvious

0

Q: "Drone Racer" now shipping in your local area

This question is a follow-up of this one; where I present a software to plan and manage drone races. I might come with a new question about the SQL part in a few days as well. Since then, on top of the changes in documentation that I made in my own answer, I included the gettext module and chang...

python python-3.x console factory-method i18n

@Phrancis thanks, it should be pretty cool once it's done

10:17 PM

I already done the classes, now I only have to give instructions to the ants and replace the coordinates in the classes by Tile objects.

@CaptainObvious that's pretty cool

user image

wtf why is that rendering the SO survey as a CR icon

@Quill looks fine for me

@Quill ~~caching bug I guess~~ same here. feel free to post a bug on MSE

what's with my code then?

If it is working, feel free to post it as a review.

If it is missing critical functionality, you might want to write that first so it doesn't get closed as stub code.

10:28 PM

haha

> More than 30 answers posted to this question – Community♦ 4 mins ago
More than 10 answers posted to this question in the past 7 days – Community♦ 7 hours ago

> I have never been on Stack Overflow. I just love taking surveys.

It's probably already been reported on MSE but yeah

possible answer invalidation by Joe Wallis, thefragileomen on question by thefragileomen: codereview.stackexchange.com/posts/116165/revisions

user image

While coding, while writing documentation, whenever it's not going as smooth as planned alcohol is applied.

And it works.

takes another sip of Scotch whisky

That survey is onto me.

If you just went through what I went through, you would be rip, roaring drunk.

10:34 PM

When I link to a project with multiple files in CR, and they ask me to include code embedded in the OP, which code should I show?

Which file?

you post everything you want answers to look at

You are supposed to include all relevant code in the question.

linked code is just to provide additional context

0

Q: C++ Ant SImulating Program

This program is some classes that enable precise ant simulation inspired by SimAnt. It doesn't do it off the batch; there must be code that instructs the ants to follow scent tiles in particular and react to the food. Since this program has multiple files, it must be shown in GitHub. (sidenote:...

are you serious

That doesn't mean all the code in the project, just the relevant code to the section being reviewed.

Preferably, whole classes.

10:35 PM

shit, seconds late

may end up in reopen queue

hopefully

I edited it late, I mean. After your close

oh

like 13 seconds too late

Wut

10:38 PM

Please take a look at the on-topic help centre and the How to post a good question guide — Mast 30 secs ago

I'm so confused.

How relaxed should my email regex be?

9

Q: Given a herd of horses, how do I find the average horn length of all unicorns?

The question above is an abstract example of a common problem I encounter in legacy code, or more accurately, problems resulting from previous attempts at solving this problem. I can think of at least one .NET framework method that is intended to address this problem, like the Enumerable.OfType<T>...

design object-oriented functional-programming

@EBrown return string.Contains("@")

@Mat'sMug That's not a regex.

regex is not a solution

3

10:40 PM

prompt("are you an email? (tell the truth please)");

Right now I have: ([^\s]+@[^\s]+\.[^\s]+)

And I think that's as in-depth as I should go.

you are making assumptions that will be proven wrong at one point or another

@Mat'sMug Well it needs to be a regex, as I have to parse it out of this string.

best of luck

there's existing ones better than you can write with a simple one, use those, don't write your own

don't waste your time -> use an existing one

10:42 PM

(?:[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*
| "(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21\x23-\x5b\x5d-\x7f]
| \\[\x01-\x09\x0b\x0c\x0e-\x7f])*")
@ (?:(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?
| \[(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}
(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?|[a-z0-9-]*[a-z0-9]:
(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21-\x5a\x53-\x7f]
| \\[\x01-\x09\x0b\x0c\x0e-\x7f])+)
\])

I don't know, my current one seems to work alright.

@Mat'sMug I've used that one before, and it seems a little clunky to me.

Why are you trying to parse an e-mail address anyway?

it's RFC5322-compliant

It's for a spam filter.

I need to know how many emails were mentioned in the string so that I can flag it appropriately.

Why should a spam filter check whether an e-mail address even is an e-mail address?

10:43 PM

Because this filter only works on a string.

@EBrown Do what Mug said. Count the @ symbols

It's not an email spam filter.

Captain Obvious

-2

Q: C++ Ant Simulating Program

This program is some classes that enable precise ant simulation inspired by SimAnt. It doesn't do it off the batch; there must be code that instructs the ants to follow scent tiles in particular and react to the food. Since this program has multiple files, it must be shown in GitHub. (sidenote:...

If I want to send a colleague a list of 20 e-mail addresses, the filter better not block it.

@CaptainObvious CBR

@Mast It won't, not directly, at least.

10:44 PM

I will find the server responsible, I will put it on fire (SysOps be damned) and I will make sure it never happens again.

Alternatively, use the regex that Microsoft made, note however that it's quite complex

@Phrancis Everything Microsoft made is quite complex and works only half of the time.

Or, as we said years ago: "Bugs come in through open Windows."

4

@EBrown, CBR?

@Gustavo6046 Can Be Reopened.

Fixed.

10:47 PM

reopened

so refreshing items in the home page doesn't take the on-hold status off reopened posts

although, it could be improved by adding a bit of description of what each file is meant to accomplish, and more importantly what concerns you have about the code (although "interested in any & all feedback" is implied in all CR questions)

@Gustavo6046 You need to use headers, man.

I tried once to use headers. It resulted in a lot of errors.

like "redefinition of class"

Time to add this email regex and test it out in production.

10:51 PM

lol^^

chants Test in production! Test in production!

@CaptainObvious If I had nothing better to do I'd write a couple of comments in an answer.

user image

2

LOL @Phrancis! Irony at its finest! Thanks for the fix on my answer!

@EBrown Centraal Bureau Rijvaardigheidsbewijzen?

10:52 PM

0

Q: Bulletin box icon appears as site icon instead of Stack Overflow

In the community box at the moment is a link to a Stack Overflow Developer Survey, however viewing this box on sites other than Stack Overflow, it uses the site's icon instead. The cause is on the favicon icon div: Instead of a class of favicon-<sitename>, it should be favicon-stackoverflow.

bug design favicon community-bulletin

@Mast Can Be Reopened, I said that once. :P

It also happens to be the abbreviation of the Dutch DMV.

Well that's pretty awesome.

Lol

112

Q: Didn't get the job (or did I?!?!) but in limbo - what are you guys doing to pro actively move employers to provide feedback?

Much needed feature request...especially for the job seekers. Scenario, you've applied for a job via the jobs link on SO. You wait..and wait..and wait..and wait..and continue waiting. You search for this same job and the UI presents you with this: The mail icon simply signifies that you've ...

feature-request jobs

I just added the description for each file.

10:58 PM

@Quill That would have been an annoying bug to find ;)

Monking

yeah... FAIL indeed

monking @EthanBierlein

I still have reached my question limit :/

in SO*

Just give it some time.

I am really banned, didn't you see?

11:01 PM

@Gustavo6046 Don't worry, I was banned back when it was quite tricky to get unbanned. It is supposedly easier now.

I just left my account alone for a year.

Captain Obvious

0

Q: Repetative object attribute definition

How to define an object which holds repatative information has been something on my mind for quite a while, so hoping that someone can inform me on how this should be done (what's generally accepted, strongly typed, efficient, complaint with some styling, etc). I'm using Javascript here, but woul...

@Gustavo6046 I'm going to take a stab at your question, and see what I can review.

@EthanBierlein Try the naming.

@EthanBierlein HEADERS!

So I've decided to do two-pass email parsing.

Pass 1: uses /([^\s]+@[^\s]+\.[^\s]+)/g

@EBrown what happened with your ungarbler?

11:05 PM

@Gustavo6046 Still working on it.

Pass 2: uses /[a-z0-9!#$%&'*+/=?^_{|}~-]+(?:\.[a-z0-9!#$%&'*+/=?^_{|}~-]+)*@(?:[a-z0-9](?:‌[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?/g

Pass 2 will only be run if pass 1 finds stuff.

That should help eliminate some of the performance concerns.

@EBrown If you want to simplify it, I would suggest giving yourself limits on edge cases, saying "I don't care for emails with xyz characters" that aren't normal

@Quill Yeah, I think I'll make a couple changes to pass 1 to help restrict it further.

Really, I don't care about spacing marks. Anything else could be an email address.

For memory there was a massive page with valid emails and not valid emails

And the world goes.

TTQW

11:08 PM

Hello.

And it waves at @EBRown the onw that invented the best spam filter of the world.

@TheCoffeeCup hi

@Quill Hi

did you get a swag email?

Yep!

11:10 PM

What... the... fLIp... why did they accept that answer??

I mean, they have the right to... but it's really not very good

<afk>

yeah... uh, that's how you know you have a noob @Phrancis

lemme google it

they probably didn't understand your changes man

You had a good answer, @Phrancis.

@Phrancis I thought your answer was mine, as I saw the orangeish avatar and thought, "I don't remember writing this."

11:13 PM

> "Java? I don't remember EVER writing this..."

lol

@Quill Indeed.

> C# is 4 coolz, java is for foolz

now give me my grammy

@Quill I disagree.

I like Java in some cases.

just don't flag it as offensive

11:15 PM

But I hate having to support the damn thing.

I don't want some sore Java developers to hit valid

We have a Java Applet for work that is designed by a third-party, and we have to support it (thanks Government mandates) and it is horrible.

(Not that all Java applets are horrible, but this one definitely is.)

Man our SysAdmin needs to fix this damn Network Drive problem.

Like 15 times a day I get a message saying the network drive is unavailable.

string.Concat( "{\"success\":", outputResult.ToString().ToLower(), ", \"imageName\":\"", imageName, ".jpg\", \"outputMessage\":\"", outputMessage, "\"}" );

@Quill Noo, no no no.

apparently serialising an object is too much work

11:18 PM

He said a badword

Use the DataContractJsonSerializer.

github.com/EBrown8534/Framework/blob/master/Evbpc.Framework/…

That's to deserialize, I don't think I have a serialize example.

I gtg now, it's almost dinner time!

@Quill don't post it then, you know?

it was a joke man chill out

I do know it was intended as joke... it just wasn't even remotely funny

and that you have to ask people to not flag it shows it's probably a step over that line in the sand already

11:27 PM

Almost TTGH.

If anyone has any WPF experience, this question could use you.

@Hosch250 ^

TTQWAGH

safe travels

@EthanBierlein You have C++ experience?

Some, yes.

I know enough to do some reviews.

11:31 PM

@EBrown Those commands are identical. What is the obj you are passing in?

@Mast he got a c++ textbook from secret santa IIRC

I'm very sure you can set that to the 1 item that is different and combine those.

@EthanBierlein So do I, but I prefer to leave the reviews to the experts. Perhaps I'm just being too cautious though.

I have written a fair bit of C++, but it takes 10 years to learn the darn language...

I'll take a crack at it later, but it looks really good already.

@Hosch250 I think Heslacher mentioned that in his answer

11:34 PM

I think it can be simplified even further.

bool foo = true;
Console.WriteLine(foo.ToString());

how come that returns True even though it's true when defined

If this is working code, then Code Review might be a better place to post this question. — Richard Scriven 49 secs ago

You should post this code at codereview.stackexchange.com for some further input. — Loki Astari 33 secs ago

I still haven't even received my SO swag... :/

@Quill Because "True" is what the bool type is defined to return from the ToString() method when it has a true value?

It could just as easily be defined to return "Yes"

@nhgrif yeah, a recent meta post in november said two weeks but apparently not

I did a rough calculation and something like maximum 680 users get swag from that event

not to mention the five or six beta sites gone into graduation and receiving swag

I asked JNat about tracking, and he's going to get back to me (probably)

@nhgrif fair enough, makes sense

Back

just posted in meta

My first meta post, I hope it doesn't get as tragic as my tragic Q&A :)

Captain Obvious

11:45 PM

0

Q: Would one use the User object to cache some security related information?

I am having users which are admins for one or many Store entities. With Spring Security I am already checking if a user is logged in, but of course, this does not prevent a user to send me some requests with wrong IDs. For example: A user has a store that has some items with IDs 1, 2, 3. But the...

security database cache spring

1

A: Accepting reviews (opinions) instead of facts that work

The asker should mark as accepted the answer which they found most constructive.

CR isn't about opinions.

Reviews are opinions.

it's a personal opinion on which answer is best @Gustavo6046, like @nhgrif says.

Reviews aren't necessarily opinions

Reviews contain opinions. Stack Overflow answers also contain opinions. Both also contain facts.

Consider this Stack Overflow answer:

2

A: Can't set nil to an optional property with custom setter in Swift

What you have here is a computed property. Swift properties can either be computed or stored. We can observe value changes in our stored properties by using didSet and willSet but here we still have a stored property. In your case, since you have overridden set and get*, you don't have a store...

11:47 PM

If I say,

foo = thing(3 + 3)

you can say, that's incorrect syntax in Python, and that's not opinion, that's PEP8

Lots of opinion in that Stack Overflow answer.

Actually, PEP8 (I believe) is a style guide.

Incorrect syntax is broken code anyway, and gets closed when detected.

There's a difference between will-not-compile syntax and goes-against-the-standard syntax.

^ nhgrif word's exactly; what I posted is compilable syntax, but not PEP8 valid

but then people can argue PEP8 is the opinion of the creators of Python, so opinion/fact aren't necessarily measurable

Opinion vs Fact isn't really a valid measurement of quality here

"accepted best practice" and "other improvements" can easily fall into the category of opinion. I don't think it's useful to try making the case that Code Review answers don't contain a large amount of opinion.

Whether or not a particular piece of code conforms to accepted best practice could be fact. The best practice in itself could very easily be opinion.

11:51 PM

41 mins ago, by Phrancis

What... the... fLIp... why did they accept that answer??

@Quill PEP8 is more than an opinion.

The question of readability is frequently a matter of opinion.

that's the question in discussion by the way

@Mast well, yeah, like I said. Opinion isn't really a measurable thing

They're rules set by the creators of Python

Guidelines.

Opinions can also be backed up by facts.

Captain Obvious

0

Q: Should this client class implement the same interface as the strategy classes?

I'm reading through the example of the Strategy Pattern on Wikipedia: https://en.wikipedia.org/wiki/Strategy_pattern#C.23 In this example there's an ICalculate interface, which is implemented by each kind of class that can do a calculation. Next there's a CalculateClient which can also do a c...

11:54 PM

-1

Q: Accepting reviews (opinions) instead of facts that work

When should a answer be "accepted" since in Code Review it is a opinion review, and not a fact-based answer that points to a problem in a code (or something like that), and any opinion can be good enough? For example, user A says a opinion and user B says another in their reviews. But which one ...

discussion accepted-answer

Is StackExchange another feed?

yes, a meta feed

Speaking of Python, I wore my rPi shirt to work today

Hi @Phrancis

Just noticed that downvote in my meta ;_;

@EBrown lol

Hey again

we're discussing about opinions vs facts vs Accepted answers

11:58 PM

@Gustavo6046 Probably since there are already a lot of questions about which answer you should accept. A downvote can indicate as much as 'OP did not perform any research'.

Downvote as you want, I almost forgot about that detail ;_;

« first day (978 days earlier) ← previous day next day → last day (3053 days later) »

Transcript for

Jan '167

The 2nd Monitor

General discussion about codereview.stackexchange.com - Welcom...

addicted-to-cr here-be-pedants just-saying-hi monkey-business my-code-is-compiling nice-people-room

join this room
about this room

00:00

06:00

12:00

18:00

all times are UTC

site design / logo © 2024 Stack Exchange Inc; legal

mobile