The 2nd Monitor

Mat's Mug

16:00

OP gave a checkmark, but this question can definitely use another answer:

7

This is a game that is supposed to be based on strategy and guessing. The letters need to match in a ABCD fashion on each button on buttons[0] - buttons[3] ... and buttons[n] - buttons[n] in each square, kind of like a matrix, although there is no matrix math involved. This is how the game star...

EBrown

@RubberDuck RSA

Captain Obvious

1

Q: A selection pattern for C++11

In simulating physical equations (such as fluid dynamics) it is common to write an application that deals with 1, 2, and 3 dimensions. A common C/Fortran approach is to make all vectors (for example) have a size of 3, and then to carry around a global constant to say how many elements are valid. ...

c++ c++11 design-patterns template-meta-programming

RubberDuck

@Mat'sMug I might get to it. Starred it.

EBrown

@Mat'sMug You already picked apart everything.

Mat's Mug

@EBrown @RubberDuck I purposely left out the part about each button's behavior being hard-coded and lacking a data structure

Malachi

16:13

@Mat'sMug oh wow

Heslacher

@Mat'sMug laziness ???

EBrown

@Mat'sMug I'll leave that bit out too.

Heslacher

;-)

Mat's Mug

@Heslacher totally

;-)

Malachi

maybe not.....

Heslacher

16:14

@Mat'sMug I just know you. I always so often needed to clean your code .

Mat's Mug

...thanks?

Heslacher

just kidding

Mat's Mug

there's a large bit of truth: when I tackle a complex problem, it happened more than once that I hadn't "split the problem" enough, and wrote massive ugly half-assed unmaintainable code filled with bugs. There's a reason @RubberDuck never dared looking at RD's parser/resolver code, and there's a reason @Hosch250 had to refactor my "Rename Identifier" implementation ;-)

Heslacher

We all do that

skiwi

@Mat'sMug You should really upgrade @RubberDuck to support analyzing C# code

Mat's Mug

16:19

@skiwi s/upgrade/rewrite

there's @JeroenVannevel's project for that :)

skiwi

@Mat'sMug /s/rewrite/upgrade/

Jeroen Vannevel

Keep an eye open. It will be released in two months at a store near you

EBrown

@skiwi /s/upgrade @RubberDuck/replace RubberDuck with something/

Mast

@Mat'sMug I think we all have that problem one way or another. We forget to write it good on the first try.

But hey, nothing wrong with rewrites :-)

skiwi

Eh right, I shouldn't have used that mention there :P

Mat's Mug

16:21

this is why CR is such a gem of the Internetz

skiwi

Because I think @RubberDuck can already analyze C# code, just RubberDuck cannot do it

EBrown

@skiwi Fixed.

Phrancis

in The Heap™ - Consultancy ©®, 16 mins ago, by Paul White

We're turning into Code Review :)

Mat's Mug

@skiwi @RubberDuck can analyze C# code, it's Rubberduck that can't

Ismael Miguel

@skiwi Wow, I never knew that removing an @ would change the functionality of a whole code

Mat's Mug

16:22

@Phrancis that should be a good thing

EBrown

I don't know why you would want RubberDuck to analyze c# code anyway.

Mat's Mug

@IsmaelMiguel it's not the @, it's the "D" -> "d"

EBrown

We have a dozen other utilities for that.

Mast

@EBrown Feel free to add some to this post if you feel any are missing:

9

A: Tools for format and error checking in your programming language

C# StyleCop (free) It can be run from inside of Visual Studio or integrated into an MSBuild project. ReSharper (commercial) A paid Visual Studio extension (possibility for open-source "community" license though) with a free 30-day trial. FxCop (free) Can be run standalone, but later versions...

Ismael Miguel

@Mat'sMug He wrote RubberDuck. Maybe the @ is what gives C# analizying capabilities to everything?

EBrown

16:23

@Mast I notice that VSDiagnostics by @JeroenVannevel is not on it.

Jeroen Vannevel

It shouldn't be

Shit's broken yo

Mat's Mug

It's Rubberduck, with a small "d". The CR user known as "the duck" is RubberDuck, with a capital "D"

EBrown

@JeroenVannevel You should probably filter that, people around here are flag happy.

@Mat'sMug Pedantic. ;)

Jeroen Vannevel

People who flag me are doodoos.

3

EBrown

@JeroenVannevel I wouldn't say that either. Someone might hear.

Zak

16:26

you know @RubberDuck I've just realised what you remind me of. My cousin had a personal Superman-style Rubber Duck which he used as a monopoly piece called SuperDucky. It looked just like your duck, but with a cape :)

Heslacher

No he will not. He blocked Jeroen

EBrown

@Heslacher Starred so that he can see it.

Ismael Miguel

@Mat'sMug So, changing capitalization of a letter gives C# analyzing powers?

Mast

@JeroenVannevel Fix it & add it

@EBrown We ain't thát flag happy

Jeroen Vannevel

550 unit tests and something borks up in runtime. I'll look back at it after I made a site for it

skiwi

16:27

@Mat'sMug But why?

Mat's Mug

@IsmaelMiguel "Rubberduck" is a COM add-in for the VBA IDE. "RubberDuck" is a CR user that reviews C# and VBA code

EBrown

@Mast Bull----.

Mat's Mug

@skiwi because TM

Ismael Miguel

@Mat'sMug It was a failed joke. A joke that I'm poking with a stick to see if it does something

Zak

@EBrown I'm going to flag that for implied obscenity :p

Vogel612

16:28

Monking...

EBrown

@Zak Yeah I'll probably get auto-suspended again.

Mat's Mug

hi @Vogel612!

Zak

@EBrown oh, when did that happen before?

EBrown

@Zak When I posted a link to "It's Friday B---es".

Because apparently Rebecca Black is acceptable but a song that they play on the radio is not.

Vogel612

It's awesome and strange to work something without computers after 3 years of doing so.

RubberDuck

16:30

@EBrown hey now! No replacing m3!

EBrown

@RubberDuck My bad. ;)

RubberDuck

@Zak A cape! Ohhhhhhhhhhh..... That's better than a hat!

bbiab. Need a walk before I finish writing these tests.

Ismael Miguel

@Vogel612 Greetings

Mast

@EBrown Odd

Ismael Miguel

@EBrown Tove lo - Talking Body isn't acceptable here

And it plays on radio as well

EBrown

16:38

@Mast Nope. Not odd.

That's just how The 2nd Monitor works.

@IsmaelMiguel Yeah well next time I see Rebecca Black here it's getting flagged.

A Red Herring

Well, I mean, the difference between Rebecca Black and your song is that your song has a curse in it.

EBrown

@ARedHerring So? You don't have to click it.

2

A Red Herring

lol

a curse in the song name

EBrown

Hell, last time I posted it a mod approved it.

A Red Herring

People ca't choose when tey are offended shrug

(I didn't report it)

(just pointing out the obvious difference)

EBrown

16:40

But apparently more than one person found it offensive.

So I'll just keep that in mind from now on.

A Red Herring

i don't really think "its friday b**tches" is comparable to rebecca black, personally, lol

RubberDuck

Rebecca Black is offensive for entirely different reasons...

4

EBrown

@ARedHerring Last time this happened it didn't get auto-removed for flags.

A Red Herring

I'm not saying it should hvae been removed.

EBrown

But that's OK. It's no excuse!

A Red Herring

16:44

I'm just explaining how someone might take more offense to that than rebecca black

EBrown

@ARedHerring Not worth bothering of, anymore.

Personally, I don't care.

If people find it truly offensive they are free to do as they wish.

It would just be more polite to ask someone to remove it rather than flag spam it.

Malachi

you guys are funny

EBrown

But, I guess that's what Etiquette.SE is for.

RubberDuck

Good grief. Can't we talk about code or something? Lol

Mat's Mug

^^

too-much-meta

durron597

16:47

@rolfl You there?

Mat's Mug

hi @durron597!

Captain Obvious

0

Q: My own version of a search binary tree

I wrote my own version of a search binary tree in Java. Could someone kindly review it? public class Tree { private Node root; public Node find(int id) { Node current = root; while(current != null) { if (current.getId() == id) // Node fou...

java data-structures

durron597

@Mat'sMug Hi

Mat's Mug

@CaptainObvious missing "Looking for code review, optimizations and best practices" and a green avatar

durron597

rolfl reviewed my code, told me it was terrible, I went back and made a version and I want a double check that the newest version trying to incorporate both answers is not terrible

Mat's Mug

16:51

does it work?

durron597

I dunno, maybe your policy is to just make a completely new question, but the code is so simple I don't want to waste everyone's time

3

Q: Class to manage updates coming in from another thread

Managing updates from other threads into Swing is a hard problem. In MVC design, if you don't want to have the Presenter be responsible for Thread safety, you can end up with deadlock issues, and also too many little tasks getting started; not great. I have written a class designed to manage th...

java multithreading swing concurrency

I just want to know if this fixed version has a race condition or not

EBrown

We need to increase our answer ratio.

Mat's Mug

if the code changed quite a bit, and you implemented the recommendations you got, feel free to post a follow-up :)

18

A: How to post a follow-up question?

I think that such question should clearly state that it is a follow-up question to a previously asked question. A good follow-up question should include, in my opinion: Which question it is a follow-up to What changes has been made in the code since last question Why a new review is being aske...

@EBrown that's been 1.8 forever.

EBrown

@Mat'sMug It was much higher in the past.

Mat's Mug

what past?

EBrown

16:54

Hell, it was 1.9 a month or so ago.

Ismael Miguel

@EBrown Rebecca Black doesn't say "F*ck".

Mat's Mug

really?

EBrown

I've seen it at 2.5+.

@Mat'sMug Yeah.

Ismael Miguel

But you're free to flag it

Mat's Mug

not 2.5 on this site

EBrown

16:55

@Mat'sMug I have so! :P

@IsmaelMiguel I thought we ended this discussion?

Zak

@EBrown do you happen to recall roughly when?

Hosch250

@Mat'sMug I never refactored it.

Mat's Mug

ah

Hosch250

I would like to, but I don't know what you have going there.

EBrown

@Zak No, but there was an A51 screenshot (that I saw somewhere) that had CR at 2.5 or so for "answer ratio."

Hosch250

16:56

Like, what minor bugs you have covered that I don't know about and didn't test for.

Mat's Mug

I haven't done as much RD as I wanted to lately.

Hosch250

@Mat'sMug Nobody has.

Mat's Mug

TFL, later

Hosch250

See you.

Ismael Miguel

@EBrown It wasn't a discussion. And I think that was the closing statement.

EBrown

16:57

@IsmaelMiguel The closing statement was already made many minutes ago, you are just trying to continue (as usual) a pointless discussion. I suggest you drop it.

Ismael Miguel

I'm not the one who's keeping it up

As I said: flag it if you wish

Vogel612

dammit you guys, you both shut up or I'll get you both a time out.

5

EBrown

@Vogel612 This is what irritates me of this chat room. No one here is actually on the same page for anything, so we just string arm until we get what we want.

Ismael Miguel

@Vogel612 That won't be needed

Vogel612

I don't care what the hell happened and I am not in the mood to read it out of the transcript

Ismael Miguel

17:00

Nothing important

Zak

Very trivial

Vogel612

this whole thing sounds damn pointless to me, so I'll stop it before you both go rampant

Hosch250

Just a bunch of song nonsense and flags.

TopinFrassi

@EBrown You're wrong! (Ok, I'm out. :p)

Hosch250

OK, let's discuss something else.

TopinFrassi

17:01

Anyone has tried the new C# features?

Hosch250

How about the old holy war of comparisons?

@TopinFrassi Sort of.

EBrown

@TopinFrassi Which ones? There are several.

Ismael Miguel

New features?

Hosch250

Auto-properties, methods without bodies...

TopinFrassi

^

Ismael Miguel

17:02

Didn't those exist before?

Vogel612

Auto-Properties are new?

TopinFrassi

I didn't get to try it, we're not upgrading where I'm working

EBrown

Readonly properties, string interpolation, null-method/property accessing, etc.

All of those are awesome.

TopinFrassi

There's now auto read-only properties

something like that

EBrown

I.e. foo?.Bar will only evaluate Bar if foo is not null.

Hosch250

17:02

And you don't need to make a backing field for a default value.

EBrown

@TopinFrassi Those are nice.

Hosch250

Yep, I absolutely love that.

TopinFrassi

Do you feel like it makes your job easier or is it just cool to use?

EBrown

The string interpolation bit $"({_x},{_y})" instead of string.Format("({0},{1})", _x, _y) is nice.

@TopinFrassi It's less code.

Hosch250

@TopinFrassi Job easier by far.

EBrown

17:03

So it's a lot more manageable.

TopinFrassi

Less code = easier job. :p

EBrown

(I wouldn't say easier, but quicker.)

Hosch250

I can make my null reference check with one if condition, instead of 2-10.

(Not that I've ever put 10 in one if before.)

TopinFrassi

Yeah, that feature is sure helpful, but I was wondering about the other ones. They seem to put lambdas everywhere now, which I like. But I'm not sure everyone's ready for this!

EBrown

@TopinFrassi Lambda's are handy. And they are very readable.

But again, that's a personal feeling.

Hosch250

17:05

I've only noticed more lambdas in a few places.

Mainly, methods with one line.

Mat's Mug

@Vogel612 auto-properties were introduced in C# 3.0 IIRC

Vogel612

IOW ages ago

Hosch250

@Mat'sMug They were improved in C# 6.0, though.

EBrown

@Mat'sMug Let me find it in this Jon Skeet e-Book.

Duga

What specifically are you having a problem with? Are you asking for a code review? — 31eee384 44 secs ago

Mast

17:06

@Duga Much better.

EBrown

@Mat'sMug Auto-implemented properties were introduced in C#3.0 according to Jon Skeet.

Hosch250

You know, I logged in to SE to see if Personal Finance & Money didn't have something on DuPont analysis.

RubberDuck

@EBrown it's my main motivation for wanting to get to C#6

EBrown

@RubberDuck I really like it. It's very handy, and quick to use.

TopinFrassi

That's indeed pretty cool!

EBrown

17:10

You can also use the null-conditional operator on indexing.

Duga

@Deke Maybe you can ask about specific issues you have with your solution. If we don't know what you want to fix about it, this is just a code review. — 31eee384 38 secs ago

EBrown

I.e. collection?[index].

TopinFrassi

You mean : list?[0] ??

EBrown

Yeah.

Captain Obvious

17:23

1

Q: Class managing queuing updates from another thread, Version 2

This is an updated version of: Class to manage updates coming in from another thread Changes: I removed the race condition, I believe Removed the need for checking for InterruptedException, and therefore a LOG in this class Added a lock to ensure that all updates are properly processed Removed...

java multithreading swing concurrency

EBrown

Also, I don't think this is a duplicate, it's actually pretty different:

-1

Q: count Null/counts in a csv file using python code

f= open('C:/python27/Company_Data.csv', 'r+') import sys nonecount={} try: for line in f.readlines(): for none in f.read().split(): if none not in nonecount: nonecount[none] = 1 else: nonecount[none] += 1 except: e=sys.info()...

python python-2.7

Vogel612

→ 83 messages moved to The Nth Monitor

Phrancis

@Mat'sMug Could you re-open SQL Helpline and make me owner? I've been meaning to have a place for talking SQL without bugging everyone else here

Zak

@user975326 welcome to Code Review

*waves

TopinFrassi

Hello!

EBrown

17:30

Well, nevermind.

I see why it's marked, now.

user975326

Hi, this is the first time I've used the chat!

Mat's Mug

in SQL Helpline, 12 secs ago, by Stack Exchange

Mat's Mug has unfrozen this room.

@user975326 Welcome to The 2nd Monitor!

Zak

@user975326 you're doing better than I did my first time

Mat's Mug

(be warned: it's addictive)

Zak

Aug 21 at 9:31, by Zak

Hi. I have no idea where I am or how I got here :) can anybody help?

user975326

17:31

haha I bet

Duga

Are you saying you have a working script and you are just wondering if there is a better way to do it? codereview.stackexchange.com — Mathletics 27 secs ago

Zak

god, was that only 3 weeks ago?

CommitStrip

http://www.commitstrip.com/en/2015/09/04/when-your-colleague-uses-some-random-code-he-found-online/
CommitStrip - Blog relating the daily life of web agencies developers
When your colleague uses some random code he found online
CommitStrip
1441387633

Mat's Mug

in SQL Helpline, 28 secs ago, by Stack Exchange

Mat's Mug has added Phrancis to the list of this room's owners.‌

Ismael Miguel

@Zak The first time I read it I was thinking "Oh, great... We have a troll..."

Zak

17:32

really?

Ismael Miguel

Yeah

user975326

I'm going to sit and see how things work out here :)

Phrancis

@Mat'sMug thx

Zak

@user975326 that's cool.

Ismael Miguel

@user975326 That should take about 6-8 weeks to learn

Mat's Mug

17:33

lol

Zak

@user975326 For reference, @Duga is a chatbot which tells us whenever anyone on SO mentions Code Review in a comment

and @captain obvious posts all the new CR questions

user975326

Like do you discuss posts - or just general programming problems?

Mat's Mug

depends

Ismael Miguel

Both

Zak

It really, really depends :)

rule #1

Mat's Mug

17:35

sometimes we even discuss how on/off-topic Rebecca Black is

Zak

Site business comes first

TopinFrassi

I know I'm sticked to the C# features, but I'm looking for what Microsoft might implement in C# 7 and there's quite a lot of very nice things. I just looked at no#1 and I'm already waiting for it : github.com/dotnet/roslyn/issues/2136

Hosch250

As a general rule, we don't discuss anything in particular.

Kind of early, C# 6.0 just came out.

Zak

rule #2: when there is no site business going on. Whatever you wanna talk about really

user975326

sure sounds reasonable

Ismael Miguel

17:36

As long as it isn't too personal

Vogel612

@Mat'sMug please don't pour oil into the fire

Mat's Mug

as long as it's at least remotely about CR

Zak

If it drifts really off-topic, a conversation may get moved to another room

Ismael Miguel

And to specific

TopinFrassi

@Hosch250 I know, but I like new stuff.. :p

Zak

17:37

other than that, have fun

Ismael Miguel

Don't forget: be-nice

Zak

there was a great bit earlier where we sat around making up puns based off of pokemon names crossed with the various memes here in the 2nd

Mat's Mug

wut

Zak

1 sec, I'll go find it

Mat's Mug

17

Q: Welcome to The 2nd Monitor!

So, you have found your way to the CodeReview.SE main chat room, The 2nd Monitor, perhaps for one of these reasons: You were invited or "pinged" by a site moderator or other user to discuss a post on the main CodeReview.SE site; You visited CodeReview.SE for the 1st or Nth time, and noticed the...

discussion chat new-users

52

Q: What's a Zombie? And what are the many other memes of Code Review?

What is a Zombie? Why are Code Reviewers so violent and talking about killing Zombies all the time? And what ammo are they talking about? What is a TS? What does RSA mean? And what other Code Review-specific memes are there? (As the number of memes grows and grows, and Malachi's wish to vote fo...

discussion fun

IntensifierDescriptorMan

17:39

Does anyone here use F# at all? I've noticed that there's very little activity on the tag.

Zak

The pokemon puns started right here

6 hours ago, by Mast

I was about to make a herring joke, but those have probably been done to death by now.

Dan Lyons

I do from time to time

Hosch250

@IntensifierDescriptorMan @EthanBierlein has a little.

Dan Lyons

I would probably use it even more if it was a first class language in the IDE :/

Hosch250

Reed Copsey in the WPF room at SO does a lot.

Captain Obvious

17:41

1

Q: Passing JSON object through loop to be used in JQuery Dialog- Is there a better way?

I'm wondering if there is a better (cleaner?) method than my current implementation. I'm currently encoding a PHP SimpleXMLObject (USPS Tracking API) to JSON and looping through said JSON object via Javascript to operate the front-end. Examples from my current implementation below: Function to ...

javascript jquery oop

IntensifierDescriptorMan

Okay, cool. Just wondering. With the little I've done I'm quite impressed with it. Going back to C#, I wanted to continue writing in the same style.

Never thought functional languages were that different until I tried them.

Dan Lyons

it makes me wish C# had pattern matching

IntensifierDescriptorMan

I think what I really liked is the succinctness. It's a real problem I have, as I sometimes make code less readable because it's shorter.

I have a ternary addiction

Dan Lyons

I don't use them all that often anymore - many were eliminated when ?? came around, and many more when .? did

IntensifierDescriptorMan

@DanLyons I can't wait till we upgrade to C#6 so I can use that operator.

TopinFrassi

17:47

@DanLyons Check the list I posted a little earlier about possible C# 7, they say they strongly think about implementing it

Dan Lyons

@TopinFrassi yeah, I've been keeping tabs on the design notes :) That and making tuples first class are my two most anticipated C#7 items.

TopinFrassi

The tuples do look very nice indeed

Mat's Mug

tuples, first-class citizens? wtf is going on with the world?

Jeroen Vannevel

take everything in the C# 7 list with a grain of salt

a huge grain of salt

Many C# 6 features were scrapped even after already releasing some in the beta/RC

Ismael Miguel

No idea

TopinFrassi

17:52

@JeroenVannevel Yeah I guess, but it's cool to see what people think about

Dan Lyons

true, though the C#7 list is a bit more open, since all the issues are public discussion in github now

Mat's Mug

> var t = new (int sum, int count) { sum = 0, count = 0 };

Jeroen Vannevel

C# 6 was the first release that didn't revolve around a major theme but merely addressed a bunch of individual issues

Mat's Mug

looks like an anonymous type with a constructor

Jeroen Vannevel

I expect C# 7 to be a coherent change again

Dan Lyons

17:52

github.com/dotnet/roslyn/issues/2136

Mat's Mug

public (int sum, int count) Tally(IEnumerable<int> values)
{
    var s = 0; var c = 0;
    foreach (var value in values) { s += value; c++; }
    return (s, c); // target typed to (int sum, int count)
}

if this goes live, I'm switching to Java.

Ismael Miguel

That is getting close to python

Mat's Mug

it reeks

TopinFrassi

@Mat'sMug Why don't you like it?

Mat's Mug

because it's just a formalized anonymous type.

Jeroen Vannevel

17:55

I don't know, I think it has some applications

Mat's Mug

you don't return an anonymous type

Jeroen Vannevel

Like the TrySomething(out) idiom

Ismael Miguel

I think it looks bad

TopinFrassi

Well, in some cases it can be good. But it will be abused

Mat's Mug

^^

Dan Lyons

17:55

a better example would be how F# handles TryGetValue on dictionary: you can have it return a tuple of (bool found, T value) instead of dealing with out parameters

Mat's Mug

what's the problem with Tuple.Create anyway?

Ismael Miguel

But I can see it's usefullness

Dan Lyons

then pattern match the tuple

Jeroen Vannevel

Tuple has unnamed values

What the hell is Value1 and Value2

Mat's Mug

so let's return an anonymous type instead

just ...no.

and the suggestion is to make them a struct, on top of that. bleh.

Ismael Miguel

17:57

But it says (int, int)

Jeroen Vannevel

You'd want it to be a class?

TopinFrassi

Well now, in C#6 they made something about the out values which is kinda good, if IRC

Jeroen Vannevel

Struct makes sense

Mat's Mug

a mutable struct doesn't.

TopinFrassi

^

Jeroen Vannevel

17:58

the struct isn't mutable

the containing elements might be

I don't think there's anything wrong with that

TopinFrassi

I think that this tuple thing should be read-only

Mat's Mug

^

Jeroen Vannevel

@TopinFrassi you mean the inline out declaration?

That was scrapped

TopinFrassi

Oh D: I didn't get to use C#6, I thought that was in

Jeroen Vannevel

maybe in a next release

Transcript for