The 2nd Monitor

EBrown

15:04

Now I need to remember my GitHub login...

Heslacher

@EBrown Username: EBrown password: god

;-)

EBrown

@Heslacher I know for a fact that wasn't the username...lol

Dan Pantry

@EBrown Username: God password: god

EBrown

Got it, first try. :)

Username is EBrown8534.

Dan Pantry

Mine is danpantry... im very original

EBrown

15:07

"Great repository names are short and memorable. Need inspiration? How about curly-tatertot."

Heslacher

How about utils ;-)

EBrown

Framework. :)

Mat's Mug

XnaForms

Dan Pantry

no-history

EBrown

@Mat'sMug Well there's a project for that.

Mast

15:08

@EBrown I've often seen 'octupus' somewhere included in their suggestions.

4

Dan Pantry

That, for some reason, reminded me about the quote about C++ @Mast

EBrown

@Mat'sMug I'm down to MIT and GPL V3 for licenses...

Vogel612

@Mast comes from the logo

Mat's Mug

I'd stay away from GPL if I were you

Vogel612

that again is a reference to the merge-strategey IIRC

Mast

15:09

@Vogel612 I got that ^^

Vogel612

@Mat'sMug nobody likes GPL

Morwenn

I used to use LGPL but recently switched to MIT.

Mast

@EBrown I unlicense everything I don't care about and MIT the rest.

Morwenn

Still GPL for applications though.

Jeroen Vannevel

What's wrong with GPLv3? That's the one I default to on github

EBrown

15:10

@Mast I care greatly about this.

200_success

@Vogel612 Done (write access to user granted).

Mast

@EBrown MIT it is.

Jeroen Vannevel

tldrlegal.com/license/gnu-general-public-license-v3-(gpl-3)

EBrown

@JeroenVannevel MIT means they can change anything and keep it private, right?

Dan Pantry

@EBrown choosealicense.com

EBrown

15:11

@DanPantry Still having trouble deciding...lol

Vogel612

@EBrown want something NC then??

Mast

@EBrown As long as they provide attribution, yea.

EBrown

@Mast But GPLv3 means they have to share improvements, right?

Mast

@EBrown GPLv3 means they need a lawyer to know for sure what they can and can't do.

4

Mat's Mug

Rubberduck is only under GPL because it's using code that's been released under GPL

Dan Pantry

15:12

@EBrown tldr is if they make a derivative work they have to also release it under GPL

> The GPL (V2 or V3) is a copyleft license that requires anyone who distributes your code or a derivative work to make the source available under the same terms.

Mast

I'm not really a license guy, but I spend some time on opensource.SE.

Morwenn

@EBrown LGPL requires people to share improvements but means that the project can still be used in commercial products.

EBrown

@Morwenn I think that might be my best bet then.

I want this to be a continually-evolving thing.

Dan Pantry

what are you trying to do exactly? do you want it to be OSS but always have attribution to you?

do you want to allow it to be used in closed source projects?

EBrown

@DanPantry Ideally. They should be allowed to use it in anything, but any improvements they make directly do it should be shared.

Dan Pantry

15:14

@EBrown sounds like LGPL

Morwenn

Well yeah, sounds like LGPL.

EBrown

That's what it looks like: choosealicense.com/licenses/gpl-2.0

Dan Pantry

no, thats GPL, which is different

the GPL forbade any use in commercial software

Mat's Mug

usually people in the open-source community will fork your project, improve it, and then make a PR when they feel their changes are ready to get merged into the "main" repo

EBrown

Wtf.

I hate licenses.

Here it is.

Mat's Mug

15:16

lol, parts of Rubberduck are under MIT

Morwenn

@EBrown Licenses hate you too.

EBrown

"GNU LGPL v3.0"

Well, MIT has most of what I want.

Except source-disclosure.

Morwenn

Parts of my most recent project are under "whatever, I took this somewhere else and it looked license-compatible".

Dan Pantry

MIT is "do whatever"

@EBrown thats' the one you want

and LGPL is "you can use this in commercial products, but if you make any improvements you must share them"

Morwenn

@DanPantry "Do whatever but don't sue me"

3

Dan Pantry

15:17

@Morwenn well, yes, this.

It is the equivalent of saying, "here's a cape that enables you to fly. I am not responsible if you die from falling"

If you want to let people use it but be obligated to share their improvements then you want LGPL

EBrown

I think I'm going with MIT.

Just because it's a pain in the ass to force them to share improvements.

Dan Pantry

You'll find the less restrictive your licence the more people will want to contribute

Mast

@DanPantry It's saying: "Here's a cape. I'm not sure if it's fit to be used for anything at all, but if you try don't sue me."

Dan Pantry

I release everything under MIT because, well, that's the default licence that npm selects for me. ¯\_(ツ)_/¯

@Mast i.imgur.com/YqFx59u.gif

Duga

chumekoff, now that @mudasobwa has identified your problem, consider posting your working code at SO's sister-site Code Review. There you will get useful advice on improving your code — Cary Swoveland just now

Morwenn

15:21

You'll find nobody wants to contribute, whatever the license.

7

Dan Pantry

There are the pessimists and the optimists :p

EBrown

@DanPantry And the realists.

Mast

And the misanthropes.

Dan Pantry

And my axe.

Morwenn

Mast

15:23

And my bow.

An darn, Morwenn was quicker.

Dan Pantry

@Morwenn that is fantastic

Morwenn

@DanPantry It made me laugh more than I should have the first time I read it.

Dan Pantry

@Morwenn I snorted. I do not snort.

Mast

LOTR: "And My Axe!"

►

Dan Pantry

The 2nd Monitor ft. LOTR

EBrown

15:26

Holy sh--.

It worked.

GitHub has my code.

@Mat'sMug github.com/EBrown8534/Framework

Morwenn

@EBrown Now write a nice README.md.

EBrown

@Morwenn Working on it.

Morwenn

I think that there is a correlation between the number of stars on my repositories and the length of their README.

Heslacher

@Malachi !

goal reached

200_success

Congratulations, @Heslacher!

5

Malachi

15:29

@Heslacher oh no you didn't!

Heslacher

thanks @200_success

@Malachi I did !

Vogel612

@EBrown Framework is so wonderfully descriptive!

(soz for double ping)

EBrown

@Vogel612 Yeah, I'm working on a better title. :)

If I can think of one.

Morwenn

What does it do?

EBrown

It's a framework for replicating a lot of the System.Drawing, System.Windows and System.Windows.Forms operations in XNA.

Malachi

15:34

@Ebrown @spyr03, I answered that question and added a bit to it, but I have to get some work done now, ▼▼▼

3

A: CRAFT412 gaming website, now with divs and spans

First thing that you need to do is take care of your indentation so that it is easier to read.   <!DOCTYPE html> <html>  <link href="css/styles.css" rel="stylesheet" type="text/...

EBrown

@Malachi Yeah, already saw and upvoted. :)

Malachi

mutter 523 rep behind @Heslacher mutter mutter mutter

Morwenn

@EBrown Don't worry then, they couldn't find a decent name either.

Figthing Real Acronyms Mad Enough With Other Random Knuths

Here you go: FRAMEWORK

At least, take a shitty acronym.

Vogel612

@Malachi I feel there's a reason lots of Copyright notices are inline, and I think a span is the better choice over p

other than that, nice review

Malachi

@Vogel612 really that footer should be a Menu element with a list, don't you agree?

Vogel612

15:39

meh, lists don't usually play out nicely with horizontal floating

because they are a pain...

Dan Pantry

@Malachi change <div class='bottom-footer'></div> to <footer></footer>

EBrown

The nice thing is, I abstracted Evbpc.Framework and Evbpc.Framework.Windows to a form that you could easily write a wrapper of it for any C#/VB.NET graphics library.

Malachi

@DanPantry I did, didn't I?

Dan Pantry

@Vogel612 ul li, ol li { display: inline-block; padding: 0; margin: 0; } ul, ol { padding: 0; list-style: none; margin: 0; }

Malachi

@DanPantry at the very end of my review

Dan Pantry

15:40

PITA or not, it's more semantically correct

@Malachi NVM! I only saw the before of the before/after

Malachi

:)

Dan Pantry

the footer should have a ul, or dl, for those social media instead of those span IMO

Malachi

I figure baby steps for this reviewee

EBrown

@Morwenn Better on the README.md?

Dan Pantry

Fair enough

EBrown

15:42

I should really change my Gravatar...

Dan Pantry

bit disappointed no one mentioned not using id for styling which he might be

Morwenn

@EBrown Yes, far better ^.^

EBrown

:)

Dan Pantry

@EBrown make the included projects a list :p

EBrown

@DanPantry Aye, I could do that.

Morwenn

15:44

> And that, my friends, is how developers started to spend more time documenting their projects than actually coding.

EBrown

@Morwenn I already have crappy XML docs everywhere.

I.e.: github.com/EBrown8534/Framework/blob/master/…

Morwenn

@EBrown I don't. My doc is either in Markdown or RST depending on the project.

Dan Pantry

@Morwenn there's a dialect of CoffeeScript called literate coffeescript in which you do actually spend more type writing docs than code

s/type/time

EBrown

I should remove some of the irrelevant comments in my docs. I.e.: "I spent a lot of time typing out this class. I just started typing and typing, and I didn't stop typing."

Malachi

0

Q: should we use a [tag:follow-up] when [tag:follow-up]ing a review?

I am looking at creating a follow-up tag, but thought that I should get everyone's opinion on it before I start tagging things sporadically here and there. So, Code Review, what do you think?

Dan Pantry

15:46

@EBrown lol

Morwenn

@EBrown I gave up commenting things in code. Inline documentation is always rather ugly and doesn't allow the free-form documentation you'd like to read from a user point of view.

3

I only put block of comments inside functions when I need to actually document how they work.

EBrown

@Morwenn That's why I use the built in XML docs in Visual Studio: type /// in a CS file and it inserts a structured comment for API viewing.

Dan Pantry

I only comment inline when I'm explaining why im doing something

my test suite can describe my code for me -shrug-

EBrown

I.e. for this file, intellisense shows "Represents a form (collection of <see cref="Control"/>s) to be used for display in a project. This class should not be directly inherited, as it is infrastructure for other, more graphics related, projects. You should, instead, inherit a form that is shipped with the related Graphics Library extension for your project." for the hover-over.

Morwenn

@EBrown Yeah, but the doc is still generated from the code, right? So how your doc looks still depends on the structure of the code.

EBrown

15:47

@Morwenn Not sure what you mean here.

Dan Pantry

@EBrown I think you and @Morwenn are talking about two levels of documentation

EBrown

@DanPantry I do as well.

Dan Pantry

@EBrown is referring to individual functions, @Morwenn to how a process works

(right?)

Morwenn

morwenn.github.io/POLDER/evaluation.html

^ This is how I document stuff now. v

morwenn.github.io/POLDER/gray.html

EBrown

@Morwenn You can generate pages like that from the XML documentation attached to a class/object/etc.

Dan Pantry

15:50

> It may sound quite philosophical, but that’s it.

Malachi

@Vogel612 I agree with you, the paragraph tag has added white space and the span does not. it should be a span.

Hosch250

@Malachi I disagree.

Morwenn

@EBrown At some point it starts to make the code unreadable because there's too much documentation in it.

2

Malachi

@Hosch250 why?

EBrown

@Morwenn Well, maybe.

Dan Pantry

15:50

Hosch250

It provides less information than the current way of doing it.

Dan Pantry

nooooooooo

Morwenn

Also, sometimes, you only want to say "this group of functions work like that" but commenting every function is useless and produces way too much useless documentation.

Dan Pantry

@Morwenn our technical lead in work is adamant that every method must be commented

Malachi

@Hosch250 we are still talking about the footer copyright, right?

Dan Pantry

15:51

And that we must use hungarian notation... sFoobar_in for a string named Foobar that's a parameter

Morwenn

@DanPantry When you orverload operators for mathematical classes, what the methods do is obvious.

Dan Pantry

@Morwenn The majority of us are .NET, and I'm JavaScript. No operator overloading here.

Malachi

FYI, I will AFK in about 8 minutes

RubberDuck

He must go @DanPantry.

Hosch250

@Malachi No, the follow-up tag.

Dan Pantry

15:52

@RubberDuck His people need him.

Morwenn

For example, documenting every function in this group wouldn't help anyone while the "group documentation" is helpful.

Dan Pantry

@Morwenn I agree

I wish JavaScript had a literate option like CoffeeScript

RubberDuck

he's coding in 1985...

Dan Pantry

In Literate CoffeeScript, the default mode is markdown. You have to enter four spaces to be able to start typing code.

A lot like how StackOverflow works, actually...

Stack Exchange

-1

Q: Should we use a [follow-up] tag when posting a follow-up?

I am looking at creating a follow-up tag, but thought that I should get everyone's opinion on it before I start tagging things sporadically here and there.

feature-request tags

Morwenn

15:53

@DanPantry I understand that. I just wanted to highlight that documenting every function wasn't always helpful :)

Malachi

@Hosch250 The post would still have to link to the other question

Hosch250

Then it is utterly redundant.

Malachi

a question using Brainf**k is obviously that, why tag it also?

how is it utterly redundant?

we tag with programming-challenge when that is obvious

or the game when we already know it is a game

Hosch250

Well, I just don't like it.

Malachi

I have to get coffee before the team meeting...

Hosch250

15:56

Is anyone likely to subscribe to follow up questions?

6

Malachi

it is a weird tag. I bet SO won't have one like that

@Hosch250 I would

Heslacher

TTGH see you

Hosch250

I could specialize it game questions, but I don't see how a follow-up tag helps.

See you, @Heslacher.

EBrown

@Heslacher Later. :)

Legato

Greetings everyone.

I second Hosch.

Malachi

15:57

put this on hold I will be back...lol

Legato

Tags should only be created if it's conceivable that people would actually follow them.

@Malachi You don't "already know" anything is anything until you go through the question itself. The purpose of the tag is to indicate such before, lets users direct to things of particular interest.

Mast

3

A: Should we use a [follow-up] tag when posting a follow-up?

No. Use a standard box instead: A [previous version](link) of this code has been posted on Code Review before.

Morwenn

@Hosch250 Subscribe?

Hosch250

@Morwenn You can subscribe to tags. They appear highlighted in yellow.

EBrown

I subscribe to c#, .net, vb.net and asp.net.

Hosch250

16:02

I don't subscribe on CR, but I follow WPF on SO.

Morwenn

Well yeah but there's no follow-up tag, right?

Hosch250

-2

Q: Should we use a [follow-up] tag when posting a follow-up?

I am looking at creating a follow-up tag, but thought that I should get everyone's opinion on it before I start tagging things sporadically here and there.

discussion tags

Mast

@Morwenn Not yet.

But I can understand why @Malachi feels the need for one.

However, it opens the door for a whole can of worms.

It's not how tags start.

Hosch250

@Malachi If you want to follow follow-up questions, I can write an SEDE query for you.

Morwenn

I don't know. Tags are mostly useful when you look for things. I see no point in looking for follow-ups in general.

Vogel612

16:05

aside from the fact that follow-up is a bad meta-tag

Mast

@Hosch250 What's keeping you from writing one anyway ^^

Vogel612

it cannot stand alone, it's not helping categorization...

Hosch250

@Mast Because it would likely never be used?

Mast

@Hosch250 Sure, I like queries. I use them all the time.

I'm not very good at writing them, but hey.

Hosch250

OK.

I'm not very good at it either.

EBrown

16:08

I need a better name for this GitHub repo.

Captain Obvious

0

Q: Microsoft Logo Animation v2

I updated my animation of the Microsoft's logo. It's available on CodePen. Overall, I am quite satisfied with it now apart from one thing. I cannot seem to figure out how to stop the animation so the logo looks correct. I tried setting the delay to 6000ms = 6s = length of the animation, but it l...

javascript jquery html css animation

0

Q: Longest subsequence valid parentheses

This is an extension of the question which I thought of: Given a string containing just the characters '(' and ')', find the length of the longest valid (well-formed) parentheses substring. For "(()", the longest valid parentheses substring is "()", which has length = 2. Another exampl...

java algorithm

Malachi

16:27

116 posts tagged tic-tac-toe

Jeroen Vannevel

@SimonAndréForsberg: @Duga needs to be looked at

@SimonAndréForsberg chat.stackexchange.com/transcript/message/23501459#23501459

Malachi

I added more content to the meta post

Duga

this should really be on code review SE tbh — Sammaye 1 min ago

EBrown

@JeroenVannevel Do you ever use one project in multiple solutions?

Malachi

codereview.stackexchange.com/search?q=follow a search shows the words "follow up" end up in the title quite a bit

Jeroen Vannevel

16:35

Do you mean having the source in multiple solutions? Or just using it as a reference?

Malachi

@EBrown like a .dll?

EBrown

@JeroenVannevel Well, creating the project in solution A, and then "Add Existing Project" in solution B.

@Malachi Not really.

So, the source is in both, that is.

Malachi

that is sort of what you are doing when you add one project to another, isn't it?

Jeroen Vannevel

No, haven't done that yet

Hosch250

Umm, I never have.

Jeroen Vannevel

16:36

Seems like that's when you give it its own solution and you just reference it from the other ones

EBrown

It seems to be working quite well.

Hosch250

I can see a bad developer doing that, but I likely wouldn't ever.

EBrown

@JeroenVannevel Well I have it in a "root" solution, but I add it as an "existing project" in the other solution so that I can reference it easier.

And it's working...well...actually.

Hosch250

In 99% of the cases they do that, I bet they want the same source code in both, so they should create a stand-alone package for it.

Jeroen Vannevel

That'll get you in trouble with version control though, I imagine

Hosch250

16:37

Otherwise, they have to maintain both simultaneously.

EBrown

@JeroenVannevel GIT is handling it quite well, as well.

@Hosch250 This updates the source in all the other projects when it is changed in one of them.

Hosch250

Oh, OK.

I thought it just duplicated it.

Jeroen Vannevel

Maybe when you work solo on it, but with multiple collaborators it just seems like it can be a mess really easily

EBrown

@JeroenVannevel Well right now the source control is still only attached to the one solution.

Jeroen Vannevel

forget to sync a repo once because you're working in the other one and there's a discrepancy already

EBrown

16:38

And the other solution doesn't recognize it.

So that could be an issue.

Jeroen Vannevel

Yeah, once you VC the other one you should expect these issues

EBrown

VC?

Jeroen Vannevel

this is a perfect use for a Github Organization

version control

EBrown

Ah, right. Well, I'm not VC'ing the other solution.

Only this one.

That has the original files in it.

Jeroen Vannevel

then it should be all fine and dandy

Mat's Mug

16:39

@Malachi I'm pretty sure there is already a meta post about a follow-up tag somewhere.. still trying to find it

EBrown

It seems to be so far, I'm actually quite impressed by it.

I just need to remember that Source Control is attached to the other solution.

Mat's Mug

ah, was an answer: meta.codereview.stackexchange.com/a/1200/23788 (deleted)

EBrown

GitHub is actually not being a pain in the rear for once.

Also, if anyone would like to code-review this solution, I'd appreciate it. :)

Mat's Mug

@EBrown soon you'll be saying "Gawd GitHub is awesome!!"

EBrown

@Mat'sMug Let's not get carried away. ;)

I still hate all source-control.

But, last time I used GitHub and Visual Studio it was a pita.

Hosch250

16:42

I love SC.

EBrown

Now, it's not too bad.

Mat's Mug

source control loves you

Malachi

@Mat'sMug I can't upvote that one

:)

Mat's Mug

I was sure you had

Legato

Is there a "How do I get the best experience out of CR?" post?

Hosch250

16:45

Yes.

Mat's Mug

35

Q: How to get the best value out of Code Review - Asking Questions

I have a project I am working on, and I would like some, or all of it reviewed, how can I ask for this review on Code Review in a way that produces the best possible value? This is not about a question being on-topic, or off topic. Rather, this is about making on-topic questions great qu...

discussion faq asking-questions

Legato

Thank you @Mat'sMug

Captain Obvious

0

Q: Creating a Symbol Toolbar with Angular

I have been given a requirement to create a symbol toolbar, a toolbar where each button represents a unique symbol. This is how the toolbar would work: 1) A user clicks inside a text field and enters data 2) The user would then click a symbol on the toolbar and it will be appended to that spe...

angular.js

EBrown

I joined GitHub in 2012...wow.

Mat's Mug

@EBrown feel free to browse some interesting repos out there

cough

in VBA Rubberducking, 1 hour ago, by Duga

[rubberduck-vba/Rubberduck] yadimon starred us

EBrown

16:47

@Mat'sMug I don't browse repo's. :) Except corefx.

I need to make my README.md better...lol

Yours is awesome, mine is crap. :P

Hosch250

I need to make my Resx Editor readme better.

And I need to make an ad for it.

EBrown

@Mat'sMug I "Starred" it, for whatever good that does.

I'll poke around in it at some point.

Should be interesting to see.

Mat's Mug

in VBA Rubberducking, 36 secs ago, by Duga

[rubberduck-vba/Rubberduck] EBrown8534 starred us

woohoo

EBrown

:P

Mat's Mug

BTW I'm watching you ;-)

EBrown

16:51

I see that. :) I should setup a room for this, not that anyone will actually contribute to it.

Mat's Mug

if you want you can hook up @Duga to your repo, and have her post all the notifications in that chatroom

EBrown

I haven't the foggiest on that.

It would likely be spam, as I commit often.

Mat's Mug

stuff like

in VBA Rubberducking, 1 hour ago, by Duga

[rubberduck-vba/Rubberduck] yadimon forked us into yadimon/Rubberduck

spamming your own chatroom is fine ;-)

Hosch250

Let's hijack the SO Trash room and have @Duga post things there.

Jeroen Vannevel

It's just very interesting/helpful to see what happens with the repo in realtime

EBrown

16:53

How do I hook up @Duga to it?

If I were to make one.

Hosch250

Just use the room number.

Jeroen Vannevel

it's what notifies me of finished builds and passed CI

Mat's Mug

repo settings > webhooks

Hosch250

http://stats.zomis.net/GithubHookSEChatService/hooks/github/payload?roomId=2663‌9

Just change the roomId value.

EBrown

@Mat'sMug Assume I don't know any of the information...lol

Mat's Mug

16:56

https://github.com/EBrown8534/Framework/settings/hooks

Duga

And the question is? By the way if you are looking for a code review here a better site : codereview.stackexchange.com — David Laberge 32 secs ago

Mat's Mug

"add webhook"

EBrown

@Mat'sMug I got that far. But, "Payload URL"?

Mat's Mug

that's the url @Hosch250 gave

EBrown

Aha.

Also, need to come up with a better name.

Hosch250

16:56

Only use a different room number.

That will post to the VSDiagnostics room.

Mat's Mug

Is that the VBA Rubberducking roomid? oh, nevermind

it's fine, VSDiagnostics had been spamming VBA Rubberducking for the longest time ;-)

Jeroen Vannevel

You're just salty because VSDiagnostics is more awesome and sexy than Rubberduck

EBrown

Ah well, I'll rename later if needed.

Hosch250

Just at the end of the day.

Mat's Mug

@JeroenVannevel you wish you could have called your project "Rubberduck" :p

Hosch250

16:58

Hehe, it is funny to see repo owners sparring.

Jeroen Vannevel

Pfft. I would've gone with Rubbergoose personally

4

Mat's Mug

lol

EBrown

I'm not really sure if I want a CR chatroom...

Mat's Mug

all right, gotta work a little. later @all

EBrown

Not enough traffic to really warrant it.

Transcript for