The other answers offer great advice, but I have some things to add pertaining to naming:
This doesn't sound like a good input prompt:
printf("Give me a number: \n");
Imagine, for a second, that the user briefly forgot what this program is for. If they see this prompt, they'll just input an...
(defn runprog []
(println "starting")
(reset! run true)
(while (true? @run)
(def line (read-line))
(def command (first (split line #" +")))
(def args (rest (split line #" +")))
(condp = (lower-case command)
DEPEND (apply add-sys-pa...
Congratulations to rolfl and 200_success!
I'm sorry to say I no longer have enough time to actively help moderate Code Review, but it has been amazing to watch all the community-driven initiatives to expedite graduation.
I am sticking around as a regular visitor of the site and I hope to contri...
Things you can improve
Variables/Initialization
Floating-point math is challenging in surprising places. It's easy to write down a reasonable algorithm that introduces 0.01% error on every step, which over 1,000 iteration turns the results into complete slop. You can easily find volumes fill...
I agree with Ollie; however, I'll provide you with a story.
I've been at this for quite a bit longer than you. A couple years ago I decided I needed a change of pace after having worked with startups for many years and signed on with a pretty large company in financial services. They had 1,000...
Java (aka never wins at codegolf) : 234 211 187 chars
public class M{public static void main(String[]s){for(final String a:s)new Thread(){public void run(){try{sleep(Long.parseLong(a));}catch(Exception e){}System.out.println(a);}}.start();}}
ungolfed:
public class M {
public static void m...
Solution to bounded knapsack 01 problem. Once again comprehensive description is difficult in this space, refer here. Looking for code review. optimizations and best practices.
final class Item {
private final int value;
private final int weight;
public Item (int value, int weight) ...
Counterfactual Regret Minimization is an algorithm that
can be used to find the Nash Equilibrium for games of incomplete information. I have tried to adapt the exercise from here:
http://cs.gettysburg.edu/~tneller/modelai/2013/cfr/index.html
to Clojure. You can see the original RPSTrainer.java...
I am trying to solve this Binary tree lever order traversal
Given binary tree {3,9,20,#,#,15,7},
3
/ \
9 20
/ \
15 7
return its bottom-up level order traversal as:
[
[15,7]
[9,20],
[3],
]
How can I improve the speed of the code below? It always gives me a time exceed ...
This one review will be a little bit tricky: I was trying to implement a template Vector struct in C11. Of course, templates don't really exist in C11, so I used a few macros to get the desired interface. Here is the implementation of the core features, trying to mimick those of the c++ std::vect...
I have datalayer code as below which is implementing an interface as:
Note: I have hand written this code on Notepad so it may be containing some typo errors, which You can gracefully ignore, I am searching for an approach here.
public interface ISimpleInterface{
void DosSomething(long someV...
There is a rather large amount of code here and a lot of macro trickery, so I shall refrain from attempting to comment on it all.
There are, however, a few things that immediately jumped out at me.
Don't use new as your allocating macro. That's extremely confusing, and it's going to make comp...
I have the following setup but I'm worried that using Manager and Model as a suffix might be frowned upon to other developers. I, personally, like it because it makes everything clear, visually, when working with the code as to what is what and also easily prevents naming conflicts when referenc...
