I recently added a feature to my application to serve arbitrary markdown documents from a directory. This is designed to allow authors to populate a folder full of help documents, and be able to view them without any code changes. However, because this is an MVC application, I needed a few extra ...
I have some triggers placing and sizing elements for video controls. It works well enough but mostly through trial and error and I am not sure if there is a better pattern:
The full source can be found here: http://jsfiddle.net/Xa93a/ and webpage: https://media.themetacity.com/3/
My biggest iss...
@rolfl I remember you said that you liked that my Sudoku Java 8 code was "a real use case", I can make you happy that I have come up with another real use case for Java 8 !
And I can actually use Java 8 on it because I don't plan on using that code for either Android or GWT ! Because it is quite processor-intense
Oh, I just realized, I can even use parallel streams!
Oh. let me take a moment and gather my thoughts ;-)
Right... emergency trip to the dentist with my daughter.... she bit hard on a popcorn kernel, and hurt a tooth .... great... then the dentist pulls it....
@rolfl or @skiwi Do you know of any simple way to repeat a String in Java 8 ? For example, achieving the string "---------------" (of variable size, of course)
In Java8 there are now new Strings on new char[] arrays too
pretty much, and then all the new code reuses the bigger string for their indent needs.
I am not sure how well it will perform now in Java8... you may find it easier to have a char[] array that is filled with the characters you want to use - and new String(DASHES, 0, length);
Help! So I have a 2d array like: row1 {-4,2,1} row2: {1, 4, 7} row3 {0, 12, 4} I want to loop through and print out only the rows that have ints greater than 0. So row2 would print ,but rows 1 & 3 would not because they have 0 & negative number. I'm trying to break out of my inner loop when I enc...
Help! So I have a 2d array like: row1 {-4,2,1} row2: {1, 4, 7} row3 {0, 12, 4} I want to loop through and print out only the rows that have ints greater than 0. So row2 would print ,but rows 1 & 3 would not because they have 0 & negative number. I'm trying to break out of my inner loop when I enc...
Alternatively, PaddedString.get(30) .... where PaddedString is a utility class that intrnally uses a ThreadLocal to provide the goods.... so is threadsafe, cached, and fast.
Indeed, mAvailableSounds was useless. I get rid of that and used mSoundPoolMap as a SparseIntArray instead. Flexbility wise, I created another class loading all my sounds. — FR073N22 mins ago
@rolfl Why the need for ThreadLocal? What state would be stored?
if($row['best']){
$id = $row['best'];
} elseif($row['average']){
$id = $row['average'];
} elseif($row['bad']){
$id = $row['bad'];
}
If row['best'] is null, I need $id to equal the 2nd best. If 2nd best is null, $id is equal to the next best.
Bug!
In your program, it's impossible to use any operator besides addition. As Code Review is not meant to be a code-bug-fixing site, I think you should try to fix this yourself. Hint: The bug is in your addActionButton method
Now, about your question. Yes, the template method is a good choice....
I need to create variable-length strings of dots/periods/full-stops to add to some text content, in a way that is similar to a formatted table-of-contents:
Chapter 1 .................................... 1
Section 1.1 ................................ 1
Subsection 1.1.2 ..........................
Yeah, I understand it is a serious question, which is why I will take my time in possibly coming up with an answer. Not entirely sure you will see an answer from me on that one, depends on the speed of @palacsint and others
Well in that case I see one thing already...
Your question received 3 votes in a short period of time, my recent calculator answer hasn't received any... jealous
I need to create variable-length strings of dots/periods/full-stops to add to some text content, in a way that is similar to a formatted table-of-contents:
Chapter 1 .................................... 1
Section 1.1 ................................ 1
Subsection 1.1.2 ..........................
I'm looking for some feedback on my implementation of the algorithm. How can I improve it? I ran into problems when calculating the larger prime numbers > 46349 due to integer overflow, but fixed that by using sqrt instead of pow.
#include<iostream>
#include<math.h>
using namespace std;
int mai...
In addition to the excellent analysis above, I could have improved my runprog function by following the advice given here:
http://codereview.stackexchange.com/a/45823
<math.h> is a C header. Use the C++ header <cmath>.
If you have a dynamically-allocated array with new, you must use delete at some point afterwards, otherwise you'll get a memory leak:
delete [] prime;
When comparing something with a bool, you don't need to explicitly use true or false.
For...
You have not implemented a sieve. See Wikipedia's pseudo code for the Sieve of Eratosthenes.
You need to check if reading in a number was actually successful:
if (!(std::cin >> number)) {
std::cerr << "Invalid number provided" << std::endl;
return EXIT_FAILURE;
}
(Note that you woul...
Yeah. Unfortunately std::vector<bool> is a bit of an abomination... But... Yeah....
a std::vector<int> will almost certainly take the same amount of space as an equal capacity new bool[] provided an int is the size of a word.
So I would probably go with an int vector rather than bool. std::vector<bool> is of those rare gross corners of C++ where magic happened that shouldn't have happened :/
Please evaluate this code and tell me if it is standard C++ coding:
#include <iostream>
#include "DivisionByZero.h"
using namespace std;
double checkQuotient(int numerator, int denominator){
if(denominator == 0)
throw DivisionByZero();
return static_cast<double>(numer...
I used a standard calculator design from Java. I wanted to expand it so I created a class to create buttons for different operations, like +, -, *, /. The original program didn't do this, they just made them individually without a template method. Do you think I should do it like this?
//The j...
good news, they days of the ugly black header bar on all SE sites are numbered – they are currently A/B testing a new feature that will help users customize the colour of that bar. Or something like that ;-)
I have been using this code for a while for a project at work. Actually I got it from a friends who got it from a book I am certain off. But either way it worked for my demonstration. But the other night I decided to sit down and see if I could make it into all functions and then to see about mov...
Please let me know your thoughts on the code below, please be brutal. Here is the question I solved:
Given a binary tree, return the zigzag level order traversal of its nodes' values. (ie, from left to right, then right to left for the next level and alternate between).
For example:
Given binar...
I have some triggers placing and sizing elements for video controls. It works well enough but mostly through trial and error and I am not sure if there is a better pattern:
The full source can be found here: http://jsfiddle.net/Xa93a/ and webpage: https://media.themetacity.com/3/
My biggest iss...
if($row['best']){
$id = $row['best'];
} elseif($row['average']){
$id = $row['average'];
} elseif($row['bad']){
$id = $row['bad'];
}
If row['best'] is null, I need $id to equal the 2nd best. If 2nd best is null, $id is equal to the next best.
Bug!
In your program, it's impossible to use any operator besides addition. As Code Review is not meant to be a code-bug-fixing site, I think you should try to fix this yourself. Hint: The bug is in your addActionButton method
Now, about your question. Yes, the template method is a good choice....
I'm looking for some feedback on my implementation of the algorithm. How can I improve it? I ran into problems when calculating the larger prime numbers > 46349 due to integer overflow, but fixed that by using sqrt instead of pow.
#include<iostream>
#include<math.h>
using namespace std;
int mai...
<math.h> is a C header. Use the C++ header <cmath>.
If you have a dynamically-allocated array with new, you must use delete at some point afterwards, otherwise you'll get a memory leak:
delete [] prime;
When comparing something with a bool, you don't need to explicitly use true or false.
For...
You have not implemented a sieve. See Wikipedia's pseudo code for the Sieve of Eratosthenes.
You need to check if reading in a number was actually successful:
if (!(std::cin >> number)) {
std::cerr << "Invalid number provided" << std::endl;
return EXIT_FAILURE;
}
(Note that you woul...
Please evaluate this code and tell me if it is standard C++ coding:
#include <iostream>
#include "DivisionByZero.h"
using namespace std;
double checkQuotient(int numerator, int denominator){
if(denominator == 0)
throw DivisionByZero();
return static_cast<double>(numer...
I used a standard calculator design from Java. I wanted to expand it so I created a class to create buttons for different operations, like +, -, *, /. The original program didn't do this, they just made them individually without a template method. Do you think I should do it like this?
//The j...
Please let me know your thoughts on the code below, please be brutal. Here is the question I solved:
Given a binary tree, return the zigzag level order traversal of its nodes' values. (ie, from left to right, then right to left for the next level and alternate between).
For example:
Given binar...
