« first day (947 days earlier)      last day (3063 days later) » 

2:00 PM
This question suites more for codereview.stackexchange.com .. Please post it there .. — hagrawal 40 secs ago
 
@RubberDuck That one.
 
B
No doubt
 
you guys like it nested too?
 
Why though?
 
2:00 PM
More readable.
 
I just don't like it error-prone
 
@EthanBierlein coworkers asked me to move to the 2nd one.
 
Remember the Apple SSL bug?
 
Which I'll gladly do, but I was curious how you guys feel.
@IsmaelMiguel this isn't an if statement.... brb
 
2:01 PM
I don't know the language but I prefer A without the extraneous whitespace.
 
Code Review is not a good place to ask how to do something in a different way, the code has to already work as intended. — Phrancis 10 secs ago
 
@RubberDuck Still, you can avoid needless mishappenings with some braces
@SuperBiasedMan It looks like C#
 
121
Q: using statement with multiple variables

Antony ScottIs it possible to make this code a little more compact by somehow declaring the 2 variable inside the same using block? using (var sr = new StringReader(content)) { using (var xtr = new XmlTextReader(sr)) { obj = XmlSerializer.Deserialize(xtr) as TModel; } }

Look at the first answer.
 
Yeah I think so (isn't that where using comes from?) I just mean I haven't coded in it, so I can't say for sure that it's safe etc. I'm answering based on how it looks.
 
@EthanBierlein It's the wrong question though. Reducing lines of code shouldn't be a goal on itself.
 
2:03 PM
Of course, I don't think that the second one would work in this context.
 
@Mast Unless it is Javascript
 
Web dev is the only exception. This is C#.
 
I know
 
@BruceKaufmann - I used a Scripting.Dictionary and got the whole process (350K rows) down to 45 seconds. Don't know if you want to post here in a new question or over at Code Review. — Jeeped 37 secs ago
 
From the question:
Does this use the one-liner-no-braces rule to scope the statements within each other, or actually compile into some sort of chain? — ssube Feb 22 '12 at 13:50
@MD.Unicorn Yes, exactly. This is intentional – this is the most concise way C# offers: removing the parentheses and omitting the indentation. Notice how the IDE offers explicit support for this (otherwise it would indent the second statement). — Konrad Rudolph Feb 22 '12 at 13:53
 
2:06 PM
That's so going to break things during maintenance...
 
No
It's not the same as the "no-braces-if-statement".
 
Morning!
 
Monking!
 
Greetings
 
Zak
This answer deserves more upvotes
2
A: How to call a macro from a button and pass arguments

QA CollectiveYes, you can assign a macro to a button (or other excel controls/menu actions) and pass constant OR variable arguments to it. In the 'Assign Macro' window (right-click on object and select 'Assign Macro'): Enclose the macro name in single quotes e.g. to pass 2 constants: 'Button1_Click("A str...

 
2:07 PM
@Zak Done
 
129
Q: Nested using statements in C#

SBurrisI am working on a project and have to compare two files and see if they match eachother excatly. My first draft before alot of error checking and validation came up with: DirectoryInfo di = new DirectoryInfo(Environment.CurrentDirectory + "\\TestArea\\"); FileInfo[] files = di.GetFiles(file...

Another example with the chained using statements.
In short, I'd say go with example A @RubberDuck
 
Hey @enderland!
 
The IDE may support and like it
 
@Mast hey
 
But it is harder to read in my opinion
 
2:09 PM
Yes, but the braces in this case are extraneous.
 
But that isn't the reason why I vote for B
 
And not needed.
 
I agree with that, but they also help to keep things readable
 
@enderland oooohhhh, shiny blue name
Over the time, has any of you had to use AOP in C# for some "read" production code (a.k.a not the AOP fizzbuzz lol)
 
@IsmaelMiguel I'd say example A is more readable. It's more clear to the reader that the using statements are all for the same scope.
And, if you need say, 6 different using statements, you don't want 6 levels of indentation.
 
2:11 PM
@TopinFrassi hahaha. I joined here earlier since people were wondering about scope of programmers.SE but then I left to go to work :P
 
@EthanBierlein But you won't want 6 using statements anyway
 
@enderland Yeah I saw that conversation :p It's a little difficult to scope but to this day, my 2 questions weren't closed, so I guess I got it ahah
 
@IsmaelMiguel Yes, but in some cases where the memory management of using statements is needed, like when you open files, then one may need more than that
 
@enderland Btw, I think you're doing really great work on Workplace, you're a valuable asset as a mod there!
 
For example, what if I need to open 7 different files?
 
2:13 PM
in my experience the biggest problem with scope for P.SE is people ask too broad of questions
 
Oh crap "Go Live 12/7/2015" for a customer, got some work to do
2
 
@enderland hey there!
 
@Phrancis Have fun, lol
 
I can't simply assign the opened file to some variable because if the program crashes, the open files aren't managed by the GC, I believe`.
 
this feels like a walk down VBA memory lane. LOL
4
 
2:14 PM
I asked one question on Programmers and it turned out to be a semi-cross-site duplicate.
 
@EthanBierlein So, what would you do? 14 usings?
 
Yes
And I'd rather not have 14 levels of indentation, so I'd write them like example A.
 
Indentation obfuscation.
 
I'm with you @EthanBierlein, but the team has spoken. Thank you for agreeing with me though! lol
 
Maybe they'll change their mind if the amount of usings goes up :P
 
Zak
2:16 PM
@EthanBierlein Can you not use the full complement of braces *without indenting?
 
@EthanBierlein Honestly, for lazyness, I would probably go with option A
 
I'm not that good with C#, but it looks like you're just hiding the level of indentation without actually solving the problem. Sounds like making it worse.
 
@RubberDuck Try to convince them that your way is better. Sell them your idea
 
@EthanBierlein that's what I'm thinking. 3 or 4 levels deep and they may feel different.
@IsmaelMiguel nah. Not a battle worth fighting. Besides, I have a hard time getting them to critique my code. Need to set a good example.
 
@RubberDuck solution: write horrible code
8
 
2:19 PM
@RubberDuck That is weird. My coworkers critique my code all the time!!! Oh, wait... I only have my boss :/
 
;)
 
@enderland Use mysql_* functions because your co-workers don't know PDO
3
 
@IsmaelMiguel Please don't!';DROP TABLE Users;--
 
@Phrancis Good think I convinced him to use mysqli_*
But it was an hard battle
 
2:23 PM
It is March 1st and the first day of DBMS school
The teacher starts off with a role call..

Teacher: Oracle?
"Present sir"
Teacher: DB2?
"Present sir"
Teacher: SQL Server?
"Present sir"
Teacher: MySQL?
[Silence]
Teacher: MySQL?
[Silence]
Teacher: Where the hell is MySQL
[In rushes MySQL, unshaved, hair a mess]
Teacher: Where have you been MySQL
"Sorry sir I thought it was February 31st"
4
 
LOL
 
I don't get it
 
1
Q: Pythonic way to determine whether a loop iterated at least one element in generator function

Richard NeumannI have a case in which I need to determine whether a for loop yielded at least one element. This is my current and working code: @property def source_customers(self): """Yields source customers""" for config in RealEstatesCustomization.select().where( RealEstatesCustomization...

0
Q: Factoryclass versus Factorymethod in POJO

sveriI have this java class, which is used to create JSON objects: public class DataType extends Displayable { @JsonProperty private final int dataType; @JsonProperty private final String className; @JsonProperty private int dimension; @JsonCreator private DataType...

 
@Mast its actually okay for today
 
@Mast lol
 
2:28 PM
 
But if you allow invalid dates, it is your fault
Besides, 31st February is an important day of the year
2
 
Zak
Damn, out of stars already
2
 
@Zak There, there... I've stared your message. Now you have 1
 
@IsmaelMiguel That's not how stars work.
 
2:34 PM
 
@Mast I know
@enderland Source?
 
@IsmaelMiguel picturequotes.com
 
I know, but where was that quote taken?
 
@IsmaelMiguel google. or do you mean the quote source? 2001 the Space Odyssey
 
@enderland Thank you.
 
2:36 PM
Odyssey is a word which has the weirdest spelling, ever
 
Anyone feels like killing a zombie?
 
@enderland 2001: A Space Odyssey
 
Zak
@enderland Petition for that to become the official logo of the 2nd Monitor
6
 
@Zak Just because you are out of stars, doesn't mean you have to make us all out of stars too
4
 
Speaking of which, small pet peeve of mine, but I hate it when someone says out loud "select star from sometable"
 
Zak
2:38 PM
@IsmaelMiguel And I would've gotten away with it too, if it weren't for you meddling kids ^^
 
Maybe one of the local mods will pin that graphic.
 
@Donald.McLean I can pin my own message. mod abuse? or not. no one will know!
wait you are a mod too. :P
 
@enderland God damn! You uncovered my non-evil plan!
 
I try not to be all mody in other sites chat rooms, except in an emergency.
 
@Phrancis Who does that?
 
2:40 PM
@IsmaelMiguel language please
 
@Phrancis ? what?
 
If your code already works and you just want some feedback, you should probably post it on codereview.stackexchange.com — sloth just now
 
Talking about mods, usually Mat's has joined us by now.
 
@Phrancis Did I said something wrong?
 
I guess not. Carry on
 
2:42 PM
@IsmaelMiguel Needless profanity. That's a bit of a grey area on SE.
 
You mean the "God damn" part?
 
Yeah
 
If you are offended I can delete it
 
Putting Brainfuck in question titles is not allowed, but fuck is perfectly legal. That's SE for you, don't try to make sense of it. So if somebody warns you about our language, just stop doing that and move on.
 
Just say "please"
@Mast I'm not. I just didn't knew it was that offensive
 
2:44 PM
 
@Mast what's up?
 
@IsmaelMiguel It is to some. Not to me personally, but, that said most of us would prefer not to get stuff getting flagged
 
@Mat'sMug Not much, except we had a whole lot of mods over here all of a sudden without doing anything wrong and I noticed none of our own had talked yet.
 
There's 1 mod here. And it was to talk about Programmers. :p
 
@Mast lol I am a regular in the p.se chat room and someone here asked for people to come and talk about that (same with Thomas) :P
if you guys are worried about that single comment I can tell you that you are at like the 99% percentile of chat rooms on SE and have nothing to worry about. lol
 
2:46 PM
@TopinFrassi enderland, Thomas, Donald, that's at least 3.
 
@Phrancis Do you want me to delete it?
 
@enderland We know we're not The Lounge, so we don't worry too often about it.
 
in The Whiteboard, 3 hours ago, by Zak
If any of the regulars are around, we're having a debate about your site's scope over in the 2nd Monitor and would love your input
that's at least the first two of your list :P
 
@enderland does anyone know what the scope of Programmers is?
 
@Mast Oh yeah well, Donald is a regular user here, Thomas seems gone and yeah, enderland is there :p
 
2:48 PM
@RubberDuck actually we're debating a specific question there right now. lol. :P
 
@IsmaelMiguel Nah it's fine, just try to keep profanity at a minimum :)
 
@RubberDuck If I can summarize, P.SE is about the activities of software engineering that aren't related directly to code writing.
 
@Mast also keep in mind that at this point a lot of chat users are mods from around the network, somewhere
 
(From the discussion above, I didn't pull this out of my hat :p)
 
I've tried to understand, but what I thought programmers was about... those kinds of questions don't seem to be well received.
 
2:49 PM
@enderland Would it be on topic to ask on programmers on techniques to split a wall of code with lots of common boilerplate?
 
I really thought it was supposed to be about design. Whiteboarding.
 
@IsmaelMiguel probably... but I would make sure it's a scoped question and not "how do I write good code" :)
 
2 hours ago, by Zak
user image
2
 
@Phrancis I try, but I didn't knew ghat one was bad
 
@enderland I know, everywhere I look on SE I see his comments.
 
2:50 PM
@enderland she* :p (?)
 
a question like, "what approach should I use when refactoring a large method with lots of common boilerplate?" and examples would likely be received well (though I suspect it's a dup)
 
@TopinFrassi The internet doesn't give about gender.
 
@enderland The question would be: I have this huge 20kb code and want to divide it in a decent way. Any techniques for that?
 
@IsmaelMiguel Stated like that it sounds broad.
 
@TopinFrassi yeah. idk. at this point I really don't like people who go with the "attractive/provocative female avatars" regardless of whether they are male, female, or a bot
@IsmaelMiguel also, if the answer is "it depends, need more information" it'll probably get closed (which is what my intuition tells me for that question, as written)
 
2:52 PM
@Mast Well then let's all refer to each other with "it" because I'm pretty sure girls/women/whatever would like to be referred by "she" :p
 
@Mast I suck at titles
That was the description of the content
 
@TopinFrassi My wife doesn't care.
 
9
Q: What would help when refactoring a large method to ensure that I don't break anything?

MainMaI'm currently refactoring a part of a large codebase with no unit tests whatsoever. I tried to refactor code the brute way, i.e. by trying to guess what the code is doing and what changes wouldn't change it meaning, but without success: it randomly breaks features all around the codebase. Note t...

 
@enderland Yeah I understand. I just think it's important to show that the SE community has place for women and that they can be well accepted. (I'm not implying you using "he" is against this). There was a blog post about this recently!
 
@enderland FWIW, that's not her. It is melissa benoist.
 
2:53 PM
@Mast Go on and call your wife "he" for a while to see what happens. :p
 
I also dislike the donate button on their profile....
 
@DanPantry yeah, he's used avatars like that before (I'm assuming "he" because nearly 100% of those sorts of avatars are by men, not women, ime)
 
@TopinFrassi On the internet, smartass...
 
@Mast Call your wife "he" over Facebook for a while to see what happens. :p
 
Stop using Facebook. Problem solved.
2
 
2:54 PM
@enderland I will read later, but my question is different. I have a libraty and I was suggested to split it but I have no idea how to do it without it having duplicated boilerplate code
 
@Mast [like]
 
The appropriate, English, gender-neutral term is "they." It can be both singular and plural.
 
Solves a whole lot of other problems as well.
 
@Mast Ahah, anyway, that's an whole other debate!
 
2:55 PM
Pssst, @RubberDuck isn't really a rubber duck either.
 
@Mast That's what he wants us to think
 
@Mast you sit on a throne of lies..
 
@DanPantry I've seen his Facebook, I'm pretty sure ^^
 
I really dislike that that gif moves from right to left
 
2:56 PM
@Ampt Yeah it's one weird graphic
 
Agreed.
I'm not really a nuclear fusion reactor either.
 
@IsmaelMiguel maybe I'm confused then, normally refactoring should reduce boilerplate code - not create more of it?
 
@enderland Refactoring can - initially - create duplication
And if you don't have any tests then you won't be sure what cruft to get rid of
 
Ah, that's true, your initial refactor might duplicate stuff until you can cull the other stuff
This is why a question like that needs more clarification though @IsmaelMiguel, oftentimes people post a question on P.SE that is way too unclear/broad because the details often do matter for a thing. like, why is there boilerplate code? do tests exist? are important to know what to do here
the bright side is, you aren't a drop-and-run person so even if it's not clear initially I would trust you to actually use the [edit] button that most seem incapable of. :(
 
Can you all take these discussions to the appropriate room(s)? Looks like half of it belongs in the Nth, and the other half in a Programmers room.
 
3:06 PM
hmmm, apparently there is no relevant discussion for this chat room here. ;)
 
Hmm, someone here doesn't understand how variables work...
Select * from VENDOR_MAPS where vm_vmtid=@vmtid
set @vmtid=''

------------------------------------------Relationship MAPPING------------------------------------------------
Select @vmtid = vmt_id from VENDOR_MAP_TYPES where vmt_name='Relationship'
 
@enderland Generally, we try to keep this room on topic to Code Review. Every-now-and-then we tolerate noise, but there seems to be an excess of it here.
 
enderland doesn't understand how variables work in SQL
I'm guessing "set" is incorrect?
 
No, set is OK. I don't see a point "reinitializing" the variable to an empty string, just to immediately assign it a value afterwards
 
oh
 
Zak
3:14 PM
@EBrown I thought it was "anything goes, subject to , until site business pops up".
 
@RubberDuck In general I would prefer the nested one, but the case of using multiple using ... is a special case, to me at least, where I think it scopes more clearly not to use nesting. In one of my earlier jobs we used 4-6 using ... clauses, due to unit testing, factory creation, helper class creation, and some more. To have indented those, would have left us with nothing for the actual code. So my preference for this particular case is clearly the non-nesting variant and one set of braces!
 
@Zak "Anything goes" is far from the main operational standpoint of The 2nd Monitor.
 
No site business, anything goes
user image
2
Anything
@holroy I agree, should definitely be non-nested. You're not introducing a new level of complexity as is the case with if, switch or any other construct in that area.
 
Zak
@EBrown Hence the "Until site business pops up".
 
0
Q: Python 3 Minesweeper

hampI just want some opinions/tips on how to improve. #importerar funktioner import string import random import time import pickle #skapar en grid def create_grid(size,lastcell,numberofmines): grid = [] for i in range(size): row = ['0']*size grid.append(row) mines = cre...

1
Q: Refactor code that manage many availability status

Beni MioI'm a junior who want to refactor a big method in my code. This method is tested, works but I few problem to refactor it: def self.authorized_status plugin_id, store_id, application_id, version, locale=nil if plugin_id.match /^(\w|-)+$/ I18n.locale = locale || :en # I think I can mo...

 
3:31 PM
@JeroenVannevel I am so going to run out of stars today.
@holroy I think they'll change their minds once they see one 6 deep.
 
Zak
Having a fixed, arbitrarily large input is not the same as a "dynamic" input.
> I put in the range of 50000, as i wanted it to be dynamic
 
@RubberDuck Me to!
 
0
Q: Converting fraction notation in strings to a Rational data type

Jonathan LefflerI've been messing around with a RationalInt type, using a simple int-based structure for the time being. I've created code to convert strings to the RationalInt type, but I'm not happy with it; it is too convoluted for comfort (though this second rewrite isn't as bad as the first rewrite, and th...

 
Edit question: Should I help out a new user having written comments in Swedish, and translate them into English?
 
.... no?
I'd shy away from editing the code.
 
3:33 PM
Some of his text are in Swedish as well
 
Edit his text into English, but not the code comments.
 
I'm contemplating on adding the English version with some marker to indicate that I've done this to help out the new guy
 
Zak
@holroy IMO, ask them first.
 
I've commented upon it, and gotten a response from another CR user to do it...
I think I leave it for now, to let the OP decide what he wants to do. And possibly a re-evaluation when @Duga complains on answer invalidation... :-)
 
@holroy I wonder if you solution for problem 5 can be written to avoid mutable. I'm curious if it can't be done recursively.
 
3:42 PM
@EBrown First of all, I'm sorry that my review mostly got to be alternate solutions. But I got carried away, and even though it is slightly off for most users, for you and me (as newcomers to F#) I felt it was somewhat useful! (Even though someone already has downvoted it!)
 
@holroy It was extremely helpful, you cut my execution time for Problem 5 down to several ms, from several seconds.
I'm just trying to make it more F#-like.
Because I don't like that mutable there.
 
@EBrown Most likely it should be doable, but I'm not quite sure how just now. The problem, as I see it, is that you kind of have to push values back to the top of the pipe line, and that I haven't seen any neat tricks on doing...
@EBrown Could it possibly be done with variant over Seq.reduce(). If the reduce function receives the previous list-value (i.e. the new prod) and the new value is the i it should be doable. I think. There you have something to think about... :-)
Something along the lines of seq { 1 .. 20 } |> Seq.reduce (fun acc new -> ... )
 
Yeah, I'm still trying to figure it out.
Also, you never actually use the top in problem 5.
 
@EBrown HeHe... Funny, I just saw it, and was going to comment upon it... ;-)
 
Refactoring requests for working code are offtopic here. Codereview is the right place for such questions — hindmost 43 secs ago
 
3:55 PM
@enderland Do you think this question would be a good fit for Programmers? If not, what is lacking?
0
Q: Factoryclass versus Factorymethod in POJO

sveriI have this java class, which is used to create JSON objects: public class DataType extends Displayable { @JsonProperty private final int dataType; @JsonProperty private final String className; @JsonProperty private int dimension; @JsonCreator private DataType...

 
@TopinFrassi I edited it, it should be better now
those "help me convince my colleague..." questions never go over well anywhere on SE
 
@enderland Yeah I understand that! But like, the main idea of the question would fit well on programmers?
 
aww you guys graduated
sure
it's a design question that is meaningfully scoped
 
1
Q: Unit Testing Express Middleware That Verifies Auth Tokens

Alex BookerI am writing an Express middleware component that'll run on Node 4, which has limited ES2015 support. The fundamental purpose of this component is to verify JSON web tokens, using the jsonwebtoken module. Here is said component: const jwt = require("jsonwebtoken"); module.exports = { ensure...

 
1
Q: One Question Per Question

BarryI voted to close this question as being "Too Broad," on account of the fact that it's actually five, independent questions. At the very least, an answer would have to address all five questions, so it's certainly unlikely to be answered "in a few paragraphs," unless you have a very liberal defini...

 
3:58 PM
@enderland Cool. I'll pass the word to the OP
@enderland Yeah! :D
 
now I can't auto edit things with my 400 rep :)
if you guys want to approve this edit - codereview.stackexchange.com/q/113150/20932
I'll drop a link in the P.SE chat to verify too
@TopinFrassi it can be migrated, too
just takes a mod
I flagged it
 
Cool, thanks
 
migrated
 
Thanks Mat!
 
When will people learn this is not how you use comments?
string::npos is just a simple static const size_type npos = -1;. You already declared ifstream fin;, use it instead of declaring again this (obviously, you must close the stream each time). while (exists = false || exists != true); has no sense - it means: while (exists = false || exists = false);. Same thing for the condition isTaken in the other while loop. Don't use system() functions, it brings your application less portable. Use '\n' instead of std::endl. In some case you can use sprintf with std::string.c_str(). You should also handle the exceptions. — Pr0kram3r 5 hours ago
 
4:13 PM
Spotify just gave this as the first song in my Spotify weekly:
I feel so judged right now
 
The question that comment is on is good though.
 
-2
Q: How to transform switch statement to if statement?

Emil ZaharievI was wondering if I can convert the following into a if statement rather than it being a switch statement. switch (type) { case PROJECT: case STORY: case DEVELOPER: createdItem = new AggregateItem(name, desc, value); break; case STORY_DEVELOPER: createdItem = new SingleItem(...

2
Q: Audio player for a website

aln447I'm fairly new to jQuery and have decided to make a jQuery audio player for a website. There are two versions of the way it selects the audio: Here Here I removed some basic, not connected with the player functions. What do you think of it? $(document).ready(function() { function secon...

 
0
A: One Question Per Question

Mat's MugArguments could reasonably be made for either side of this coin, so I'll take OP's side here and see where that takes us. Sure, it could be 5 independent posts. But this isn't the first to combine two or more Project Euler challenges into a single post, and I'm willing to bet it won't be the las...

I'm with @EBrown on that one
 
@Mat'sMug Thanks.
Apparently @Zak is as well.
 
if the person that downvoted me has also upvoted Zak's answer, that person needs another drink.
 
4:27 PM
I upvoted both.
 
Zak
@Mat'sMug Have an upvote to cancel it out
 
And @Heslacher has a good point there on the other side of the coin.
 
meeting, have a drink anyway
 
Am I right to assume that you are very new to Python? There are a huge amount of things to first correct in your demo code to even start speaking about MySQL. I believe the stackoverflow format will not be able to help you with this problem. You may try CodeReview instead (not 100% sure though), or follow some step by step PyGTK3 tutorials. — Cilyan 28 secs ago
 
Zak
@Mat'sMug Great minds think alike :)
 
4:28 PM
Perhaps I should have stated: "How am I doing as far as idiomatic ?" as the problem statement in my question.
Of course, it now has 4 CV's.
 
An answer that doesn't give idiomatic F# is not a good answer anyway
that should be implied
 
Meh, I'm not worried about it. If it get's closed all it does is prevent other people (who may have insight on the topic) from posting an answer.
 
If the code is working as intended then the OP is welcome to bring it over to Code ReviewZak 38 secs ago
 
Wow, 4 upvotes and closed. LOL
 
Zak
@EBrown If I had the rep, I would VTR.
 
4:31 PM
@EBrown not mine. I won't judge here because it is grey area IMO.
 
@Heslacher I will admit, it is very gray. But I don't think it warranted CV's.
@Zak No need, I already have an answer. If the close-voters want to prevent other people from answering, that's fine. (They haven't hurt me, only future readers.)
 
0
Q: Least Mean Square channel equalizer

Tom KealyI've written (and tested) a simple least mean square adaptive filter (https://en.wikipedia.org/wiki/Least_mean_squares_filter). The steps of the algorithm are $$ For n = 0, 1, 2, \ldots: $$ $$ x = [u(n), u(n+1), \ldots, n(n-p+1)]^T $$ $$ e(n) = d(n) - w(n)^Tx(n) $$ $$ w(n+1) = w(n) +...

 
Zak
My upvotes disappeared :(
 
@Zak It happens on meta. That's why there's no rep gained or lost to it.
@Barry If I posted five distinct questions at the same time, there would very likely be the same mistakes made throughout each. And that, in my opinion, is a waste of reviewers time. — EBrown 53 secs ago
 
^^
I just voted to re-open.
 
4:35 PM
That's the reason why I placed all five questions together.
 
Closing it was unwarranted.
 
@EthanBierlein don't do that while it is being discussed on meta.
 
I've made up my mind. I'm voting to re-open it regardless of what meta wants to decide.
 
@Zak Where's that question of yours you mentioned?
 
Zak
10
Q: Standard Methods in VBA

ZakSince I learnt about refactoring, I've been busy creating my own Module of Standard Methods. I feel it's about time they got a review of their own. Open to all aspects of advice but particularly interested in: Method Naming: Are they completely unambiguous about what the method does/returns? U...

 
4:38 PM
Aha.
 
woah wall of question
 
No kidding.
And yet, mine is the problem.
 
Zak
@EBrown IKR?
I mean, combined, you have a grand total of 41 lines of actual code
 
And they all do completely different things.
 
@Zak I can totally write 41 unrelated lines of code :p
 
4:40 PM
@Barry And waste even more time? Now you are forcing me to post a question, wait for a review, post another question (while there are probably still issues with the first one), wait for a review, etc. All your doing is prolonging the issue. — EBrown 3 mins ago
 
@SuperBiasedMan I know, I wrote that.
 
@SuperBiasedMan s/your/you're
 
Posting a question at a time slowly is fine though? Unless you're in a hurry to get all the answers at once what's the downside to waiting?
 
@SuperBiasedMan What is the downside to having them all at once?
 
Oh yeah I was pinging you to reply then quoted that first, confusing order.
 
Zak
4:41 PM
IMO, the purpose of CR is to understand how the OP currently codes and offer suggestions for improvement. Usually, this is in the context of a specific language/purpose. Whether the code presented all relates to one another is, IMO, irrelevant, because it all relates to the OP, which is what's important.
 
If I have working framework, but I'm looking for a potential refactor (because of lots of duplicated code), would that be a better fit for code review or programmers?
 
@NathanMerrill It depends. :p
 
Zak
@NathanMerrill Hi @NathanMerrill if it currently works, bring it here.
 
@Zak ^
 
Zak
If it isn't working yet. IT may be On-Topic for programmers, but I would ask in their chatroom first.
Programmers' site scope is notoriously difficult to navigate.
 
4:43 PM
@EBrown It's confusing and a bit messy to have them mixed. All the briefs are in one block separate from the actual code. It's not a big downside but I don't think the upside is worth it at all, personally.
 
@EBrown Dude, fix your attitude. CR isn't your on demand REVIEW MY CODEZ NOW!!! service. The metric should be what you should do to get the best quality reviews, not what costs you the least amount of time. Seriously, some posts on here don't get reviews for weeks or months and you're concerned about what... a couple minutes? — Barry 1 min ago
Now I'm mad.
 
Zak
@SuperBiasedMan IMO, it's actually perfectly clear. The code is messy, but that's the point of CR, no?
 
It was all civil up until this point.
 
Zak
@EBrown Can I recommend you cease interacting with Barry? we can handle that.
 
@TopinFrassi what does it depend on? If it works?
 
4:44 PM
@NathanMerrill It works, you want reviews on all/anything in it, you don't have multiple subproblems in it (apparently).
 
@Zak I think it's just inherently messy clumping the 5 together like that is all. You have to go back and forth to read what each challenge is, because you're checking code for 5 entirely different problems.
 
Zak
@NathanMerrill Does it achieve the outcome you want (even if, slowly, messily, etc.)?
 
@NathanMerrill Programmers is more about conceptual stuff. If you post your code here, you'll get review on tons of stuff that might not be related to your refactoring goal. On Programmers, (if you ask your question correctly) you'll get help on how to apply refactors. Something like that! :)
 
Simply ask yourself the following questions. To be on-topic the answer must be "yes" to all questions:

Is code included directly in my question? (See Make sure you include your code in your question below.)
Am I an owner or maintainer of the code?
Is it actual code from a project rather than pseudo-code or example code?
Do I want the code to be good code? (i.e. not code-golfing, obfuscation, or similar)
To the best of my knowledge, does the code work as intended?
Do I want feedback about any or all facets of the code?
 
4:45 PM
@Zak It's not one coherent brief being followed. Doesn't seem like there's clear consensus on if that's a problem yet tho.
 
Someone calm me down before I go ballistic.
Because I'm livid.
 
@NathanMerrill we don't do complete refactorings here. We can point out how you could refactor it and point to other flaws in your code but we won't refactor the code for you.
 
@EBrown Just downvote everything that you disagree with there, that should help. After all, it is meta.
 
@EthanBierlein No, that won't help. I don't give a flying fart about those answers, I do care about the insultive comments Barry has been posting.
 
Flag them, and move on?
I flagged the one @SuperBiasedMan man posted. It was rather rude, so it was deserving of a flag.
 
4:49 PM
@EthanBierlein As in, the one I quoted or was I rude in a comment?
 
The on you quoted
from Barry
This one:
Oh, well. It's gone now.
@Barry Fix yours. You seem to be under the impression that everyone is obligated to answer the entire question, which is not the case. Whether or not I get reviews is irrelevant, what is relevant is how it impacts the community. For something so simple and small as this, there is no advantage to making each of these a separate question. All that is accomplished by that is the review of tiny, independent points. What if I make three subtle, little, stylistic issues in three different posts? Instead of having one post to review different aspects, now there are three. — EBrown 1 min ago
Nice comment @EBrown :)
 
Ah ok. Just checking then.
 
user41796
@EthanBierlein He's currently suspended.
 
user41796
If this rooms thinks a constructive chat conversation can be had with him, I'll unsuspend him.
 
@GlenH7 EBrown or Barry?
 
user41796
4:51 PM
@TopinFrassi EBrown
 
@GlenH7 Really? Are you serious?
 
@Heslacher that wasn't my expectation :)
 
user41796
@EthanBierlein Yep. He made a comment that picked up quite a few flags which yields a suspension
 
I think it'll give him time to calm down, after he exploded in rage because he's been suspended
 
@NathanMerrill Just to clarify ;-)
 
user41796
4:53 PM
@TopinFrassi It's a 30 minute suspension from the earlier comment. If the room thinks that's sufficient to let him call down, then I won't do anything to alter what the system did.
 
@NathanMerrill about Programmers.SE you can read from this message. We had them invited today to know about how they define their scope.
4 hours ago, by Thomas Owens
So I heard you all are/were debating Programmers site scope? That's OK. We do that sometimes, too. Can I help clear anything up?
 
Well, in that case, I'm going to piss off as well. I, for one agree highly with him.
 
user41796
But if the room thinks a constructive conversation can be had right now with him, I'm happy enough to unsuspend him which will let him back into the chat room.
 
@GlenH7 I think it should stay this way. I've got nothing against him but he needed to calm down anyway, he said it himself
 
that ^^
 
user41796
4:55 PM
Okay, I'm good with that too. Wanted to give your community the option to decide.
 
@GlenH7 Thanks for passing by!
 
user41796
yw
 
user41796
@Heslacher I had dropped in earlier, but didn't realize it was a standing invitation. The impression I got once I dropped in was that the conversation had already moved on.
 
"I'm wondering what else or better way can be done to achieve indented goal?" This seems a bit broad...what do you mean by "better"? Fewer lines of code? More readable? Better performance? Since it looks like you have working code that you want critiqued, this might be a better fit for codereview.stackexchange.comThisSuitIsBlackNot 25 secs ago
 
Sure the conversation moved on but it was nice that you guys came along. Knowing/understanding the scope is good/difficult ;-)
 
user41796
4:59 PM
@Heslacher Programmers' scope can be notoriously hard to nail down.
 
that ^^^^
 
user41796
Loosely, it's about conceptual programming / design issues.
 

« first day (947 days earlier)      last day (3063 days later) »