On top of the comments already given : Keep things simple : while (playAgain == true) can be written while (playAgain) if (A) variable=false; else variable=true; can be written variable = !A; Do not repeat yourself : if you deal a lot with user input and checking values, make it a function you...

Assuming that setT5RadioGroup only sets a variable within the fragment: In your fragment, use RadioGroup[] radioGroups = new RadioGroup[10]; setTRadioGroup(int number, RadioGroup grp) { this.radioGroups[number] = grp; } In your activity, or whatever it is: for (int i = 0; i < rowids.lengt...

Both Josay and Max have given great answers. There are two things I would like to add. There is no need to carry the playagain boolean variable. You can simply: do { .... } while (playAgain()); There is a bug in your getObjective() method. You will never generate the 'max' value itself (u...

This is only a form/style review and not algorithm review, as I don't really know what some of your algorithms are supposed to do. There are some changes that I would do in your code. The first one would be replace the while loops for do while loops, and get rid of the flag go. In case of sqrt t...

Your assumption that the entire dataset is read in to memory is not necessarily accurate. The JDBC clients I have worked with (DB2, MS-SQLServer, Sybase, Oracle, etc.) each default to, or have an option to limit the size of the client-side buffer. You only have a small amount of data on the actua...

As you wrote in your comments, (.contains "str" "sub") is perfectly fine. it is indeed java interop - it runs the method contains on String object "str". two more comments, first, passing str as a var name isnt so good, since str is a function, so you should consider giving it a different name. ...

Overall it looks pretty good. A few pointers though... Try to indent your code properly. Most of it looks good but on a few places you have missed an indentation. e.g., do { setMax(); setObjective(); userGuess(); playAgain(); } while (playAgain == true); Don't consume nor fail silently on exc...

It looks pretty reasonable to me. A couple of points: You seem to be assuming that a function start with a letter. Functions CAN start with an underscore. Are you sure there is no such function that can be exploited? The regex in the section 'Invalid function calls' seems like it could be simpl...

The begin returned by maxSubArraySub can be wrong as we update start after we've found a good candidate for the maximal sum. This can lead to potential bugs (I am way too lazy to find an actual case where it makes a difference but that should be possible). The solution from http://en.wikipedia.or...

I would stop using the print >> sys.stderr and use the logging module. EDIT: Why i suggested the use of the logging module. The reason it is easier to put a timestamp in each message, and when you want to remove log messages, you won’t get them confused for real print() calls.

Thank you all for your feedback, I have now updated the form, please take a look at let me know if it is secure: Is this secure? Thank you!

I'm not sure i understand exactly why you have multiple contexts. If you keep to one context you can do one SaveChanges(). That should save you some time in storing data. Do all your SaveChanges() take equal amount of time? You could add a timer inside the contexts to print out a console mess...

I prefer it if classes manage their own state as much as possible: that makes it difficult to use them incorrectly. For example, in the code above you are able to 'forget' to call SetAsExecuted and can thus write a bug. So if ExecutedToday is a property of Service then it's better if Service ma...

As your code stands now it looks to me as if the timer has some responsibilities it shouldent have. My suggestion would be to either move all the timer information to your timer, including bigService.ExecutedToday and SetAsExecuted OR you move all that logic inside the service. I would go for th...

I'd name the class TimeOfDay to be absolutely clear about its purpose. Consider adding validation to the constructor (0 ≤ hour ≤ 23 and 0 ≤ minutes ≤ 59). Because before() and after() are predicates, I'd rename them to isBefore(TimeOfDay t) and isAfter(TimeOfDay t). I prefer getHours() over ho...

It is a matter of taste, so there is no 'better'. But more common seams to be time.getHours(); because often the conventions of JavaBean are used. If you work in a team, I would discuss the naming conventions to use with them.

how about this logic. if the first character or last character is a letter it's false then go through the array and look for the letters skip it if is a = or a + if it isn't a = or a + then check that the character before and after is a + so something like this. var simpleSymbols = func...

I heard about the previous site being closed. Is there not enough people that would take the time to answer questions? Is there not enough people willing to ask Questions? Is there not enough people willing to research to find answers? Or is it a Definition thing? Like what are good questions ...

Ok, before I set of, there are 2 things to keep in mind here: Code review has to be tough, to be good, so if this hurts your feelings - sorry, but I'm trying to help. The second thing is: Please, please, please try to adhere to the coding standards as defined by PHP-FIG (google them). Most, if no...

If this is SQL Server 2005 or later version, you could use CROSS APPLY: SELECT t.amount, a.A, b.B, c.C, d.D FROM atable AS t CROSS APPLY (SELECT t.amount*.1 AS A) AS a CROSS APPLY (SELECT a.A+3 AS B) AS b CROSS APPLY (SELECT b.B/2 AS C) AS c CROSS APPLY (SELECT c....

To obscure your E-mail from a spam bot but not from a user I use Google Captcha's, they are really cool. and you can either put a captcha on your input form, or you can put a captcha on your E-mail address Google Recaptcha is the place to go. if Google can't do it right, who can? it's a simp...

Use a framework. As already mentioned Using a framework provides so much for free. It provides everything you've not provided in your code above. For example: error/exception handling, markup generation, logging, filters, validators, security...the list is long. Completely remove the javascri...

From a once over: I am not a native English speaker but //Element to print HTML confused me, I thought you meant that element would be printed. Maybe //Print button selectors ? settings should be declared next to defaults, otherwise delete settings; is meaningless in destroy elems=$(settings.e...

Occupy Code R3view A while back I had favorited this query for StackOverflow. Now that CR is on the SEDE, I wondered how we'd compare: http://data.stackexchange.com/code%20review%20stack%20exchange/query/160464/how-rich-are-the-1-active-users With this week's data... SO's breakdown is: 27...

One thing you should know about exceptions is that you don't need to catch them immediately. The reason why code throws an exception in the exception in the first place is that it doesn't know how to handle the exception. Similarly, the one-higher subroutine (for example, your getIntFromUser me...

with the playagain boolean variable you should set it to false when you create the variable and then the loop can be a simple while(playagain) a lot of people prefer a while loop over a do while loop because you see what the condition is right out of the gate. EDIT: now that I read through the ...

GTB, 14 Executed from a TI-84 calculator [i;2.9sin(Xc;] Amplitude = 20, Period = 62, Pause = ~50

with the playagain boolean variable you should set it to false when you create the variable and then the loop can be a simple while(playagain) a lot of people prefer a while loop over a do while loop because you see what the condition is right out of the gate. EDIT: now that I read through the ...

One thing you should know about exceptions is that you don't need to catch them immediately. The reason why code throws an exception in the exception in the first place is that it doesn't know how to handle the exception. Similarly, the one-higher subroutine (for example, your getIntFromUser me...

Hang on a tick... there is a problem here that, weirdly nobody has noticed. I will admit that this is hardly ever used, but still: In a normal JS prototypal inheritance scenario, you would be able to pull stunts like these: var Animal = (function() { function Animal() { this.nam...

Remove these the inclusion of <stdlib.h> and <string>. You never use them. Use a consistent naming convention for variables. You have 3 different naming conventions being used: xRan choicei Array If you're working by yourself, pick one and stick to it. If you're working on a larger project, us...

Skip() is not optimized for IList<T>, it always enumerates the skipped elements. This means that your algorithm is O(n2) for no good reason. What you should do instead is to manually iterate just the required part of the input in each iteration using for. Something like: double sum = 0; for (int...

To throw you in at the deep end it would be good to start thinking more about an object-oriented design for your classes and interfaces. Think about re-usability of your code and how can encapsulate just enough useful behaviour in a class while keeping it as general as possible. Let's say it bec...

On top of the comments already given : Keep things simple : while (playAgain == true) can be written while (playAgain) if (A) variable=false; else variable=true; can be written variable = !A; Do not repeat yourself : if you deal a lot with user input and checking values, make it a function you...

Realizing that you are trying to make reusable code, I figured I would share my methodology, as I believe it will extend your structure here. I like to wrap everything into an object with functions appropriate to AJAX, and I added in your .overlay components: var ajax = { showProgressBa...

C# [152] Characters namespace System{class P{static void Main(){for(var i=0d;;){Console.Write("{0,"+(int)(40+20*Math.Sin(i+=.1))+"}\n",'|');Threading.Thread.Sleep(50);}}}} I could not get the Existing C# answer to Run and I couldn't downvote because I don't have enough Reputation it was miss...

First things first. I don't see a reason for why you didn't include a quantity property in your Item class. That being said I will review the code without that property in Item to be more similar to yours. I also think that you made a mistake in your Constructor. You probably would want to write:...

VB [236] not sure how you would count the tabs, I just took the count from Notepadd++ before I pasted here. newlines are mandatory, probably why no one likes using it for code golfing. Module Module1 Sub Main() Dim i While True Console.WriteLine("{0:" & (40 +...

The form seems to be OK, but mixing all of the code in one file is not a best-practice. UPDATE Some tips on code separation: I would suggest using any template system for html/php code separation. For example Smarty. Also, it would be easier for you to maintain your code if you follow the MV...

Why use inventory[i].item every time? For performance cache this: var x = inventory[i].item;

Here are several tips: Use OOP. This way you could start the session only once. Hash your passwords - this way no-one can steal it from the db. At least the chance is lower. Use MVC - separate your html from the php code. Move your db connect credentails to the .ini file - this way it could b...

No, I've noticed several issues. Make sure the stuff in assets/includes/ isn't world readable. e.g. is it possible to view this code by going to www.example.com/assets/includes/second-header.inc (substituting in your domain name of course)? Also, don't use rand() to generate tokens for secure ...

There should be something about a Singleton class that requires that it allow and present a single, globally available, instance. Otherwise, the pattern is being misused. The way your class is built, there's not really such a reason. You could have any number of instances, and they'd all work ...

This looks good. A synchronous call is always an async call plus a wait for the result. To make that clear, execute() should probably call executeAsync() instead of getHandle()

The form seems to be OK, but mixing all of the code in one file is not a best-practice. UPDATE Some tips on code separation: I would suggest using any template system for html/php code separation. For example Smarty. Also, it would be easier for you to maintain your code if you follow the MV...

List comprehension is a very neat way to construct lists in Python. For instance : stripped = [] for word in words: stripped.append(word.strip()) becomes stripped = [word.strip for words in word] (and then you can get rid of the stripped variable altogether in your code). The pythoni...

Here are some tips for your class: For the lines like the following, I suggest applying different formatting (to make it more readable). Please see below: $arguments = array_merge(array('UserName' => $this->username, 'Password' => $this->password), $arguments); to this $arguments = array_mer...

By using excessive markup for presentational purposes, the template is the exact opposite of clean. <span><i class="fa fa-phone"></i></span><span>{{{telefon}}}</span><br /> vs. <span class="fa fa-phone">{{{telefon}}}</span> <!-- span set to `display: block` with a `:before` pseudo element to ...

Perhaps a higher-level approach may get you to a better solution. The random generator methods (generateRandomEvenNumber() and evenNumber()) are mathematical in nature and really not specific to the game. They have no dependencies on the game class (e.g. they don't use fields) and they have no ...

What the function does is finds the primes in list1 and converts them to their equivalent a (i.e. 2 would be a2 which is 1,1). Then it takes the !NULL in list2 and searches if it is present in the converted list1 (converted to a list of two of 1,2,3, or 4). Finally it returns a logical list of tr...

UI code is usually kinda "messy" you could separate out the ActionListeners to new files if you want. Also I'd probably put Artist and Song Title into a class like public class SongData { private String artist; private String title; public SongData( String title, String artist ) { ...

Cleaning up a bad or ambiguous tag is a very annoying and disruptive process. While there are moderator tools for renaming and merging tags, there is no tool that helps splitting a tag or removing a bad tag and replacing it with useful tags. There are two ways one can currently clean up a tag, p...

I am working on a CoderByte problem in JavaScript. I have solved the problem below. Although I am trying to figure out if there is an easier way to do it? I am guessing RegEx will come up, although I don't have experience with that yet. From CoderByte: Using the JavaScript language, have t...

Here's a simple tree that can demonstrate a couple things: 5 / \ 3 7 / \ \ 1 6 8 minValue and maxValue are written so that the algorithm can catch the 6 that is out of place. And it seems like even the original versions of those functions are not doing that right. Your new al...

For an initial project you have done well. Take advice from those above with a grain of salt. The road ahead of you is long and fraught with peril! You need to keep your chin up and just chug away. The most important thing to take away from the advice below is how little you know and how mu...

how about this logic. if the first character or last character is a letter it's false then go through the array and look for the letters skip it if is a = or a + if it isn't a = or a + then check that the character before and after is a + so something like this. var simpleSymbols = func...

First of all, as mentioned by @user7212, use php filter_var() for email validation. Please see below for example: /** * Validate email * * @param string $email * * @return bool */ public static function email($email) { return filter_var($email, FILTER_VALIDATE_EMAIL); } Second, why n...

how about this logic. if the first character or last character is a letter it's false then go through the array and look for the letters skip it if is a = or a + if it isn't a = or a + then check that the character before and after is a + so something like this. var simpleSymbols = func...

I wrote this code for a review on CodeReview, but when I tried to plug it into the actual site it wouldn't come back false for letters in the middle of the string Example input: "+d+==e==+c++==3" it would function properly if there was a letter at the beginning or the end. is there something ...

Your revised changes to the isBST(Node) method are broken. You only check that all Nodes have a data value that is left < me < right. In other words, you check to make sure that each individual node has appropriate left and right values. As snetch points out though, the tree: 5 / \ 3 ...