Charcoal HQ

ArtOfCode

15:00

Both of those will have to remain in the database, unless we change the sign up process (which I can't do now, and I'm not going to do without consulting people). I can make it so that admins can't see them.

In progress...

Andy

Why do IPs need to be in the database?

ArtOfCode

@Andy they don't, but Devise puts them in there. I'm not sure if that can be changed, but it might be possible - @Undo?

Undo

@Andy Because they're there by default in Devise.

99% sure we could remove them, and probably should.

@ArtOfCode Yeah, last IP doesn't need to be in the db, much less in a page.

@Andy Email addresses aren't shown anywhere that I'm aware of now

Except if you don't have a username set, but I'm pretty sure everyone has that now and we require it on registration.

ArtOfCode

@Undo Review feedback, but I'm going to solve that one

Undo

This thing is supposed to be a dashboard, it should probably stay that way

With a few tools to hunt down bad feedback, but that's it.

@Andy I'm not either; at the very least emails and IPs should be nuked.

ArtOfCode

15:12

@Undo pushed, ready for deploy

Undo

@ArtOfCode k, I'm going to nuke IPs then deploy

ArtOfCode

@Andy @Marshmallow My apologies. Once this build is deployed, there's no personal info on display anywhere I can find, and I'll remove it if I find it anywhere. Please do call me out on it if I make mistakes like this :)

People are more valuable than tools.

Undo

heh, I think I managed to make almost all the test fail

ArtOfCode

@Undo excellent, what did you break? :)

hichris123

@Andy currently it's me, Undo, and ArtOfCode. I'd hope we don't need more admins - if the "workload" gets that high, boy have we gone of the meta deepend. ;) This is a simple tool, hopefully it doesn't become a bureaucracy.

Undo

15:17

@ArtOfCode Fixtures expecting there to be IP columns

ArtOfCode

@Undo Those sound fun. Time to rewrite some tests...

Undo

@ArtOfCode nah, just remove the line from the fixtures.

ArtOfCode

or that

Undo

deploying

deployed.

ArtOfCode

wow that's a lot of failed tests

Um... "remove IPs from dixtures"

Undo

15:20

heh.

tempted to amend that

 ap User
class User < ApplicationRecord {
                        :id => :integer,
                     :email => :string,
        :encrypted_password => :string,
       :remember_created_at => :datetime,
             :sign_in_count => :integer,
        :current_sign_in_at => :datetime,
           :last_sign_in_at => :datetime,
                :created_at => :datetime,
                :updated_at => :datetime,
               :is_approved => :boolean,
      :reset_password_token => :string,
    :reset_password_sent_at => :datetime,

That looks better

MS doesn't store IPs anymore, stupid default-trusting oversight on my part.

hichris123

Is username creation in the setup process? If not, that would be nice.

Undo

@hichris123 It is

ArtOfCode

Next job is to integrate review feedback and user feedback so it's all accessible under one username.

But... some other time

Undo

@ArtOfCode Before you jump into that, think about it for a while.

I've tried to figure out how to do that at least three times, couldn't come up with a good solution.

Literal username matching is dangerous.

ArtOfCode

@Undo It is - you'd just have to require everyone to use their SE username.

Undo

15:25

@ArtOfCode What happens when I change my chat username to be 'ArtOfCode', though?

ArtOfCode

@Undo everything dies

hichris123

Think about a certain @Marshmallow...

ArtOfCode

@Andy's suggestion of using the SE API to log users in is solid, and would let us solve that problem completely. Seems like it's a pretty major change, though.

Wai Ha Lee

@SmokeDetector f

Undo

@ArtOfCode Except that we don't have a good tie to the SE account ID either

My chat ID is 73046, but on SE that belongs to stackexchange.com/users/73046/pmatt

ArtOfCode

15:34

@Undo Ah, not from chat I suppose. Damn.

Well that's got a bone in it

Andy

Isn't there a formula to take the ID to a Chat ID?

modnewsletter.stackexchange.com/2015/02/…

Undo

@Andy We could do that.

Although it's one more layer of complexity, and we still haven't dealt with c.SO and c.mSE

Andy

Very basic idea (with absolutely no idea how MS is set up behind the scenes):

- User posts feedback. If we don't know who they are, look them up using the above link for the network the chatroom is on
- Store network/id association in DB. Next time, we can look them up based on the ID

Each user will have up to 3 associations (one per chat network)

The user model will then have a MS_user_id, c.so_id, c.se_id and c.mse_id

Everything MS does will be based on the ms_user_id. Lookups will occur based on the other three

@ArtOfCode is right that it will take some work, but I think this would be a decent way to link everything.

ArtOfCode

Sounds solid, in principle

Andy

You can save time by caching these values instead of looking up the ms_user_id with each feedback too

Undo

15:47

@Andy probably id, chat_stackoverflow_id, chat_stackexchange_id, etc. but yeah

Still seems like a lot of work for little reward.

Andy

I can think of a few:
1. Integration with SE (users can select whether or not to share data via the auth process)
2. Admins don't have to authorize/confirm user is real
3. IDs aren't going to change on you so when Marshmellow name changes in 2 weeks, all the data stays together
4. Email addresses aren't required

Undo

@Andy Ya know, emails might not be required anyway. Any reason we can't nuke them now?

ArtOfCode

@Undo they're used to log in, unless we start accepting usernames and enforce uniqueness

Undo

@ArtOfCode we can do that

ArtOfCode

That would be useful for showing review feedback, too - we can try(:username) rather than just "(From Review)"

Andy

15:53

@Undo You tell me. I don't know for sure

Undo

@ArtOfCode We can do that now.

ArtOfCode

@Undo Ah. Password resets.

Undo

@ArtOfCode don't work anyway :P

ArtOfCode

heh, true

Yeah, those are the two major reasons.

Ferrybig

Am I supposed to be able to see the mod newsletters? those that Andy linked a few messages back

ArtOfCode

15:54

@Ferrybig yeah

Andy

Yes.

We try to be as open as possible

yay! Transparency!

SmokeDetector

16:30

[ SmokeDetector ] Bad keyword in title, phone number detected in title: <18556394698> Windows {XP}<Suport> {Phone Number} by Smith john on askubuntu.com …

SmokeDetector

16:56

[ SmokeDetector ] Pattern-matching website in answer: Converting a Docx file to PDF without losing any formatting by Dnore Gen on superuser.com …

SmokeDetector

17:08

[ SmokeDetector ] Bad keyword in answer, bad keyword with email in answer, email in answer: How to deal with my teenager step daughter's rebellious behavior? by Carol Williams on parenting.stackexchange.com …

PhMgBr

@SmokeDetector f it seems like

@SmokeDetector Suport haha

Andy

> some testified that he restores Womb

SmokeDetector

[ SmokeDetector ] Phone number detected in body, phone number detected in title: identity theft protection 1-888-226-1322 - how to prevent identity theft 1-888-226-1322 - identity theft protection services 1-888-226-1322 by Karan Rawat on stackoverflow.com …

SmokeDetector

18:09

Restart: API quota is 2684.

PhMgBr

18:35

Can someone check if this is spam? chemistry.stackexchange.com/questions/49447/…

I don't have the temperament to turn adblock off.

Andy

spam. Goes to an adf.ly link

!!/report chemistry.stackexchange.com/questions/49447/…

SmokeDetector

[ SmokeDetector ] Manually reported question: Log in here you will see something: by Fikri Isaoui on chemistry.stackexchange.com (@PhMgBr) …

Undo

very much spam

PhMgBr

@SmokeDetector Thank you I'd've missed that.

@SmokeDetector K

@Undo What, you don't like your download to be ready?

Gone in under 2 minutes. Hugs @Charcoal

SmokeDetector

19:20

[ SmokeDetector ] All-caps answer: What happens when I place an ice cube into boiling water by shaquille raleselaga on physics.stackexchange.com …

PhMgBr

@SmokeDetector K

SmokeDetector

20:09

[ SmokeDetector ] Blacklisted website in body: .shooter .perspective .will .be .familiar .to .anybod by nolisterio on serverfault.com …

hichris123

SF spam? That's quite odd.

@SmokeDetector tpu-

SmokeDetector