Charcoal HQ

SmokeDetector

21:01

[ SmokeDetector ] Phone number detected in title: <b>Markdown works *fine* in here.</b> 18557092847 by dheeru90 on superuser.com …

Ferrybig

^seems abusive to me, but not really sure

Its just a copy paste of the editor help

ArtOfCode

shrug

SmokeDetector

[ SmokeDetector ] Phone number detected in body, phone number detected in title: <b>Markdown works *fine* in here.</b> Ellipse ++@18557092847 BROTHER printer Customer SUPPORT by dheeru90 on superuser.com …

ArtOfCode

now it's abusive

sd 2k

SmokeDetector

[ SmokeDetector ] Few unique characters in body, repeating characters in body: Incorrect output from user input based on conditional requirements by Covendunite on stackoverflow.com …

hichris123

21:13

@404 Yeah...

404

@ArtOfCode looks like spam to me.

ArtOfCode

aye

Easterly Irk

Did that just get reposted?

@SmokeDetector wtf happened to this

Undo

21:33

@ArtOfCode huh what?

ArtOfCode

@Undo okay first go sort this post out... stackoverflow.com/posts/36435456/revisions

there's a flag on it from me too

Undo

what the heck

ArtOfCode

serial vandalism happening there

He's vandalised his own username

Easterly Irk

^

ArtOfCode

In fact, just about everything he has is vandalised

Undo

21:39

okay, that's in the queue to be sorted out

So what's up with MS @ArtOfCode?

ArtOfCode

@Undo Not yours, mine. The posts/_post partial doesn't render, at all.

stage.artofcode.co.uk:8800/posts

I can guarantee you there is a post there

it's stage.artofcode.co.uk:8800/post/3

Undo

@ArtOfCode strange, it's not even trying

Anything in the logs?

Is it trying to hit a bad cache?

ArtOfCode

Still on dev, so most caches are off. Logs, let's see...

Started GET "/posts" for 97.121.36.155 at 2016-04-05 21:41:49 +0000
Cannot render console from 97.121.36.155! Allowed networks: 127.0.0.1, ::1, 127.0.0.0/127.255.255.255
Processing by PostsController#index as HTML
  SQL (0.6ms)  SELECT  DISTINCT `posts`.`id`, created_at AS alias_0 FROM `posts` LEFT OUTER JOIN `posts_reasons` ON `posts_reasons`.`post_id` = `posts`.`id` LEFT OUTER JOIN `reasons` ON `reasons`.`id` = `posts_reasons`.`reason_id` LEFT OUTER JOIN `feedbacks` ON `feedbacks`.`post_id` = `posts`.`id` WHERE `feedbacks`.`is_invalidated` = 0 ORDER BY created_at DESC LIMIT 100 OFFSET 0

Absolutely nothing.

Undo

@ArtOfCode usually there'd be something about 'rendered posts/post' in there

ArtOfCode

I just hit /posts on your server; what does that log look like?

And - dare I say it - if you restart your server, does it still render it?

Undo

21:44

@ArtOfCode yes

:P

@ArtOfCode hit it again for me?

ArtOfCode

huh, so it doesn't have anything to do with new versions of things

@Undo ding

Undo

got it

I, [2016-04-05T21:44:33.258444 #26210]  INFO -- : Processing by PostsController#index as HTML
D, [2016-04-05T21:44:33.260167 #26210] DEBUG -- :   User Load (0.6ms)  SELECT  `users`.* FROM `users` WHERE `users`.`id` = 7 ORDER BY `users`.`id` ASC LIMIT 1
D, [2016-04-05T21:44:33.271556 #26210] DEBUG -- :   Post Load (10.5ms)  SELECT  `posts`.* FROM `posts` ORDER BY created_at DESC LIMIT 100 OFFSET 0
D, [2016-04-05T21:44:33.284488 #26210] DEBUG -- :   HABTM_Reasons Load (0.7ms)  SELECT `posts_reasons`.* FROM `posts_reasons` WHERE `posts_reasons`.`post_id` IN (23951, 23950, 23949, 23948, 23947, …

@ArtOfCode um, have you made any changes to the code?

Because that LEFT OUTER JOIN feedbacks` ON feedbacks.post_id = posts.id WHERE feedbacks.is_invalidated = 0` doesn't look familiar

ArtOfCode

@Undo yeah, I'm trying to figure out which bit it is

=0?

oh, mysql

Undo

well there's your problem. It's not rendering /_post because there aren't any posts coming back

Which is evident from SELECT `sites`.* FROM `sites` WHERE 1=0

ArtOfCode

um

right

Context: I've tried to add the is_invalidated thing to feedbacks

Undo

21:48

It doesn't seem to be working very good :P

although I think you're close

ArtOfCode

So I've essentially added a .where('feedbacks.is_invalidated' => false) clause to anywhere the feedbacks table is joined or included.

Undo

I still need to get MySQL backups on a cronjob.

slaps self

ArtOfCode

In fact, I think that's literally what I've done.

Undo

@ArtOfCode default scopes

although that might not work in more complex queries

ArtOfCode

Shove that on the feedback model... let's see.

@Undo genius

appears to work

Undo

21:53

no way

like, globally? Even on the complex queries?

ArtOfCode

stage.artofcode.co.uk:8800/posts

Working everywhere I can find. Search, graphs, review.

Undo

sweet.

ArtOfCode

And while we're at having things working, the invalidation does too.

Here, PR coming your way in shortly.

Undo

Nice, thanks

ArtOfCode

wtf

or at least it would be if github would work

Aha, there it is

Job done.

Undo

22:00

was afk, testing...

ArtOfCode

Oh, GitHub is backlogged, that's why

Undo

I didn't even know you could backlog GitHub

ArtOfCode

apparently

Undo

$ git db:rollback STEP=1
git: 'db:rollback' is not a git command. See 'git --help'.

I really shouldn't be trusted near a computer

ArtOfCode

nicely done

pretty sure you want rake there :P

Undo

22:03

It's rails now, since 5

ArtOfCode

o.o

rake's still working for me

Undo

weblog.rubyonrails.org/2015/12/18/Rails-5-0-beta1

scroll down to "one rails command to rule them all"

@ArtOfCode So this doesn't actually change the behavior when you clear feedback, right?

ArtOfCode

heh, fingers will have to get used a new command

Undo

Are you going to do that or should I?

ArtOfCode

@Undo No, it disappears like normal, but it's still there rather than destroyed.

It's just marked invalidated.

Undo

22:05

you missed a change, then

ArtOfCode

Did I?

Undo

unless there's some magic I'm not seeing in github.com/Charcoal-SE/metasmoke/pull/16/files

ArtOfCode

Eh? I know I rewrote the feedback controller

Hang on, lemme do that

Undo

;)

Just push it to the same branch

ArtOfCode

Done

and wait for GitHub's backlog...

Undo

22:08

@ArtOfCode That's easy: alias rake="cowsay"

ArtOfCode

cowsay?

Undo

might have to apt-get it

» rake foo bar
 _________
< foo bar >
 ---------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

ArtOfCode

Heh

Undo

man, GitHub is being slow

ArtOfCode

yeah

Undo

22:11

I think this is hiding all the feedback

ArtOfCode

How so?

Undo

horrid antialiasing, but you get the idea

ArtOfCode

run update feedbacks set is_invalidated=0; on your DB

then see what happens

Undo

 ____________________
< db:rollback STEP=1 >
 --------------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

see? Very effective

ArtOfCode

damnit betsy

It certainly hasn't hidden it on my copy, you can see that

Undo

22:14

That works.

Adding it to the migration as a default value

ArtOfCode

Oh, that makes sense

Next thing I'm looking at working on is a small set of admin tools

starting with "recently invalidated feedback"

Undo

k, I'm gonna deploy this

ArtOfCode

8d21a2a...

Undo

> I know the answer is 19/6 - pi, I need the solution to it

ah, the old "I know the answer but the book says to show my work and I swear I didn't cheat" trick

ArtOfCode

gotta love it

sd f though

bf87063 has arrived for me.

So tell me, @Undo - I just nuked a bit of feedback on metasmoke.erwaysoftware.com/post/17503. Is it still there?

Undo

22:21

@ArtOfCode Yes, but there's a little gymnastics to see it even through the console

Feedback.unscoped.where(:post_id => 17503)

ArtOfCode

Does Feedback.where(:post_id => 17503, :is_invalidated => false) not work?

Undo

tried that

It asks SQL for records where :is_invalidated is true and false at the same time

ArtOfCode

Of course, direct DB queries would do it easily ;)

Each to their own. It's useful to know about unscoped though, I'll need that for the admin tools.

SmokeDetector

22:52

[ SmokeDetector ] Bad keyword in answer, bad keyword with email in answer, email in answer: Is it appropriate to disallow the players building the world? by vanella jones on rpg.stackexchange.com …

[ SmokeDetector ] Link at end of answer: google maps embed api not working on one page not on other by Remkop on stackoverflow.com …

404

sd f k

404

23:37

A theory featuring SmokeDetector!

It's fun to speculate on this stuff, @gnat, but quite honestly... There's rarely anything actionable with the results, so unless you just wanna hang out in The Tavern & speculate over drinks, I'm not gonna bother; might as well theorize that the level of spam is increasing on Quora because of the rise of SmokeDetector here; can't prove it, and can't do anything about it if we could. Oded's working on beefing up network-wide rate-limits, which won't do anything for this specifically but should help with the general "crap flood" problem. — Shog9 ♦ 52 mins ago

This last bit is welcome news for us...

Undo

I need more things on my desk

404

23:55

Like a coffee cup (to spill on other things), maybe?

At least they are mostly fun things to work with. Unlike, say, an equivalent volume of homework or committee reports.

Transcript for