Hmmm... I'm not sure if qualifying for Hacktoberfest is that it has to be merged in October or proposed and merged in October, or just any of proposed or merged in October and merged prior to them cutting things off. [Oh, and, of course, not marked "invalid" by the maintainers, but that's certainly not going to apply to this.]
@Mithical The last time I checked, it was only PRs. However, PRs into even your own repositories count, as long as the repository is public, and even if you approve the PR yourself.
@Mithical True. OTOH, personally, I prefer to create a PR and a merge commit for significant additions and/or releasing new revisions. I typically do so throughout the year (i.e. regardless of Hacktoberfest). I'm not that willing to change how I normally do things, just to avoid getting "credit" for a PR in Hacktoberfest.
@Mithical Yeah, there are things I just directly commit too, mostly to SD and MS. Basically, I'm not willing to change what I normally do for any particular commit/repository just to get, or not get, "credit" for a Hacktoberfest PR. If I did, I'd feel I was either cheating, or allowing the tertiary effects of something that really isn't directly associated with the repository to dictate how I organize commits in repositories 1/12th of the year.
Personally, I'd be a lot more comfortable with PRs which you both author and merge being excluded, or exclude all PRs into your own repositories, or even just exclude all PRs into repositories where you could approve them. Although that last might be a bit too broad, as substantial changes to public repositories are certainly desired, even if you control it.
Some weird interaction with the google translate plugin and the page html. Here's a screencap after voting fp. Note the red X at top is now "code" something, and there's no red x voting button.
It seems to work immediately after clicking "translate this page" but if you refresh while in "translate" mode it fails.
can't see how to "view source" of the translated page either.
@DanielWiddis I'd file a bug with whatever plugin you're using for Google Translate. The things you're having issues with it translating are ones which are non-translatable. It's really not up to us to tell the plugin that some things which are non-translatable shouldn't be translated. Informing translation programs that something shouldn't be translated is for things which have translations, but should not be translated (e.g. proper names).
I note that the actual Google Translate function appears to be OK on that page, so the issue appears to be in the plugin. While the actual Google Translate being OK might be a difference between the logged-in version and the not logged-in version of the page (you can test the plugin when not logged in), it's more likely to be an issue with the plugin.
@DanielWiddis As long as it's the HTML source of the non-logged in version of the page, it should probably be OK, as that's public. To be honest, I'd have to look it over carefully, but the non-logged-in version from a fresh profile or private window shouldn't have any private information.
If you post the HTML source for that page of the version with you logged in, then you've made your MS authorization public, which ... wouldn't be desirable.
What I'd recommend doing is trying the page from a new profile where you've never logged into MS or SO, but which includes that browser extension, and no other extensions. If you're still experiencing the problem on that, then you can direct people to the page as a repeatable test case. The HTML itself is usually a bit long to be posting in a bug report, although sometimes it will be desirable.
@Makyen I was able to remove my creds from the downloaded HTML and reproduce the issue. I'll continue to remove as much as I can for an MCVE, should be sufficiently anonymous by that point.
[:55679496] <skipped> [:55679459] Recorded answer as an NAA in metasmoke. [:55679456] Recorded answer as an NAA in metasmoke. [:55679452] Recorded answer as an NAA in metasmoke.
