Related:
What criteria do you use to upvote a question?
What makes a good question?
I feel that it is currently too easy to copy some code that you have written and put it up for review here on Code Review. My opinion is that if you want a review of your code, then you should also be able to ...
Say I have an array with 60 Elements, and I want to select 40 elements from this array. The subset should consist of elements with evenly spaced indices. In theory I would need to select every 1.5th point, which is obviously not possible.
I tried doing it with a recursive function, kind of a divide
I was going through the Project Euler problem #3 and made a program to solve it. The problem is as follows.
The prime factors of 13195 are 5, 7, 13 and 29. What is the largest prime factor of the number 600851475143 ?
My code is as follows.
#include<iostream>
#include<vector>
using std::cout;
...
Say I have an array with 60 Elements, and I want to select 40 elements from this array. The subset should consist of elements with evenly spaced indices. In theory I would need to select every 1.5th point, which is obviously not possible.
I tried doing it with a recursive function, kind of a divide
I am working on a price slider that is for a java environment. It is working correctly but I would like to optimise it as much as possible. Any tips/advice.
<div class="wrap">
<div class="range"></div>
<div class="amount min-amount left"></div>
<div class="amount max-amount right"><...
Things you could improve
Using Headers
Right now you are defining some items at the top of your source file.
#define RED "\x1b[31m"
#define GREEN "\x1b[32m"
#define YELLOW "\x1b[33m"
#define BLUE "\x1b[34m"
#define MAGENTA "\x1b[35m"
#define CYAN "\x1b[36m"
#define RESET "\x1b...
lets compare following code:
1)
public class MyClass
{
private object syncRoot;
public MyClass()
{
this.syncRoot = new object();
}
...
}
2)
public class MyClass
{
private object syncRoot = new object();
public MyClass()
{
}
...
}
What do ...
The purpose of the below code is to build a shape based on the user input, specifically:
Prompt the user to enter a shape - either a triangle or a square
Determine which "texture" to use for the shape - #'s for squares, *'s for triangles
Build the shape based on the selected texture
Sample ou...
Overall, your code is clean, well written and seems very consistent (and the comments also seem relevant). There is not much to say, so I will focus on some details since I don't see anything else to review:
First of all, Loki is right in his comment: your header guards names (UNIFORM_SELECTION...
public abstract class MWRequest
{
public static string WebServiceURL = "url";
protected XmlDocument xmlDoc = new XmlDocument();
protected MWRequest()
{
xmlDoc.LoadXml("<?xml version=\"1.0\" encoding=\"utf-8\"?><request/>");
}
Class name
I get the Request part of ...
Say I have an array with 60 Elements, and I want to select 40 elements from this array. The subset should consist of elements with evenly spaced indices. In theory I would need to select every 1.5th point, which is obviously not possible.
I tried doing it with a recursive function, kind of a divide
I have a project in school. This is the game that I've created, but I need to make some improvements. I put a swing.timer inside the action event to create a score/time decrements effects. But, I have a problem because there is a textfield inside the frame and I can't type any words there becau...
Hi the following code achieves what I require, reading 10000 rows at a time:
var query = repository.Subscribers.ToList().Skip(numberToSkip).Take(numberInBatch);
Is there an alternative which will make this faster?
Here's the full code:
protected static string ContactUrl = BaseUrl + "/api/con...
You can make these #defines:
#define SHA1_DIGESTLENGTH 20
#define SHA1_BLOCK_LENGTH 64
#define COUNTER_LENGTH 8
into a more concise enum:
typedef enum { COUNTER=8, SHA1_DIGEST=20, SHA1_BLOCK=64 } Length;
This could also be done with SECRET and COUNTER, but each hex value would need a name....
I feel like most things have already been said here so I'll just add a few small things.
What brings you to Code Review today, and why do you keep coming back?
I like the teaching-nature of reviewing code. In certain tags on SO like unit-testing it takes a few minutes before the first answ...
For full disclosure this is an assignment for my programming class and I just want tips or advice on some of the code.
Assignment details just for background information purposes.
Write a program that will read a number 1-100 from the user, and the name of a data file, and will tell the user wh...
I'll also contribute my bit here. I started on CR not too long ago by sometimes putting up interesting pieces of my code on this site in order to get more interesting views (answers) upon them, such that I could improve my own mindset.
Then I got a very kind invite to the chatroom, and I decided...
