I agree with @User1 about RB_pop() and would like to add on to it:
If you want to prevent the function from returning false as an unexpected return value, you can make the function void and have a second parameter for data that will update the argument passed into it. Also, by making it void, ...
Remove fields which we already have as properties in base class.
Change everything to use base properties
Change setter scope of base properties to protected
Let's start with PlayWithPet. This is doing the same thing in all subclasses except displaying a different message for each one of them....
You can make these #defines:
#define SHA1_DIGESTLENGTH 20
#define SHA1_BLOCK_LENGTH 64
#define COUNTER_LENGTH 8
into a more concise enum:
typedef enum { COUNTER=8, SHA1_DIGEST=20, SHA1_BLOCK=64 } Length;
This could also be done with SECRET and COUNTER, but each hex value would need a name....
I have had this keylogger code for a while now (a few years*), and I figured I would put it up for review. Here is what I would like reviewed (in order):
Portability - right now, this program can only work on Windows systems. In what ways can I make this more portable?
Bugs - when I built this...
I agree with @User1 about RB_pop() and would like to add on to it:
If you want to prevent the function from returning false as an unexpected return value, you can make the function void and have a second parameter for data that will update the argument passed into it. Also, by making it void, ...
saw your answer on the ugly VB conditionals/exceptions question, I mean, I saw your answer come up as I was writing my first draft (and then the question got closed a split second before I could submit it), glad you got a badge for removing it, but usually we like to have several answers to a post ;)
I have had this keylogger code for a while now (a few years*), and I figured I would put it up for review. Here is what I would like reviewed (in order):
Portability - right now, this program can only work on Windows systems. In what ways can I make this more portable?
Bugs - when I built this...
Go with #3, "Create a nice mock for mockOperationQueue." The only reason you're having to do that stubbing is that OCMock creates "strict" mocks by default. Strict mocks used to be the standard, but mock object frameworks have evolved. The problem with strict mocking is that they make tests more ...
Your #defines:
#define VK_VOLUME_MUTE 0xAD
#define VK_VOLUME_DOWN 0xAE
#define VK_VOLUME_UP 0xAF
can be made into a more concise enum:
typedef enum { MUTE=0xAD, DOWN=0xAE, UP=0xAF } VK_VOLUME;
There appears to be a syntax error here:
int isCapsLock(void)
{
return (GetKeyState(VK_CAPITAL)
I've been playing around with some gradients on a site I'm developing, and I'm really interested in the psychology or other meaning behind why certain colors appear more attractive than others.
Here's the site right now:
The gradients there look quite natural to the design. But if I start mi...
I followed this tutorial to set up my Bluetooth dongle and get it running. I have the same Bluetooth dongle that is in the tutorial, yet I can not seem to get it to work. I get to step "C" and then I run into problems. Here is some commands I ran to diagnose the problem:
$ hcitool scan
Device...
and triggered auto-protect by Community... which partially defeats the bounty.. could a mod un-protect it while the bounty is active? oh there are more bad /worse ones...
hmm yeah just saw that. Funny, I'd be at 10,512 without all those bounties I gave... and that would still leave me at the exact same spot on the users page!
This is my constructor to transform an Outlook contact into a Dynamics CRM contact:
public Contact(ContactItem contactItem)
{
LogicalName = EntityLogicalName;
FirstName = contactItem.FirstName;
LastName = contactItem.LastName;
//if no last name, use the first name
if (String....
Seriously, I hope CM's have seen the testimonials people are leaving on meta. It's... unreal. We should all be very proud, we've accomplished something utterly cool on this site!
On 2014-04-10, we got some feedback from Stack Exchange Community Managers @GraceNote and @Pops about our beta progress.
One of the concerns that was raised about the health of our community is that we have too many one-time contributors, and need more repeat customers.
So, I'd like to ask:
W...
@Jamal Would you mind if I edited my code to make it so it works? It's nagging me that I submitted non-compilable code, but I don't want to invalidate half of your answer either.
Whenever I would go to answer a question, I kept being greeted with a competing answer. Usually it was the same person, @retailcoder. It was actually starting to get on my nerves a little bit, along with long comment strings that were really giving everyone the wrong impression of each other. ...
So about a year and a half ago, me and my friend started on a game called Zombie Smack Down. It's a text based game written in Ruby. But we were both really new to Ruby when most of it was written. I realize lots of this code is probably really bad, but I'm kinda stuck in my ways.
I'd love to k...
@200_success have I told you, you've been doing an amazing good job as a mod, and I predict that this "Hi!" post is going to make history! Thanks for being there :)
@200_success I think "more active" should replace "good". The previous mods were good, they just weren't as active as @Jamal, and therefore didn't help as much.
@200_success Indeed, totally (more active is good) - @Jamal has been exceptional all along, and CR just wouldn't be the same without @rolfl. I find our mod team is simply... the best in the west!
I have had this keylogger code for a while now (a few years*), and I figured I would put it up for review. Here is what I would like reviewed (in order):
Portability - right now, this program can only work on Windows systems. In what ways can I make this more portable? (I feel like I would hav...
@nhgrif that was discussed before; it's actually better to post the improved version as a "follow-up" question (linking to the original code) - more answers, more votes, more rep, more happiness; to be considered a duplicate, the improvements over the original code would have to be very minor, enough to generate some very similar answers addressing the very same issues. — Mat's Mug15 secs ago
As far as answers go, I prefer reviewed material as a self-answer. For instance, if the OP eventually notices something that no one else has, then that can be an answer. It's still considered a review, and it shows that you've been looking through your code in the meantime. — Jamal ♦15 secs ago
Right... Lost about 35lb in the past 12 weeks.... in part, by not having any alcohol ... Wow, Friday glass of wine and I am merry .... ;-) (and look at that, a whole post without a typo)
It's a more high-level answer. I didn't write code this time because I think that the premise of the program is fundamentally flawed. However, I'm not familiar enough with Windows to tell you the right way to implement the keycode-to-symbol mapping.
has everyone seen the activity graph lately? I thought the December peak was impressive! 247 questions were asked last week, that's a new record, and 35.3 new questions per day! Weekly answer votes are approaching 2K (beat it once in March), ...we've grown quite a lot!
correct. Q's closed off topic are deleted after something like 6 days...
So, when the data is 'cut', there are a bunch of closed questions in it, but the last week's worth of data has all the questions that are not yet deleted.
So, for the 'current' week, it suggests there are 247 questions.... but, with the next data cut.... that will drop by the number of this week's close questions that are deleted.
I have had this keylogger code for a while now (a few years*), and I figured I would put it up for review. Here is what I would like reviewed (in order):
Portability - right now, this program can only work on Windows systems. In what ways can I make this more portable? (I feel like I would hav...
Nah. It just sticks with me as an obnoxious gimmick for a piece of shit. I have no idea if the phone is even decent or not. I've just assumed it's terrible.
And I'll remember it as terrible.
But I suppose for a lot of people that might work. I just have a weird hatred of cheesy commercials :p
I just get angry when I think about it. I wouldn't buy a M8 now just out of spite.
It pisses me off when companies try to be edgy and cool. Like, just tell me about your stupid product. Don't try so hard to be cool that it comes off as cringey.
I'm a beginner to .net and could you guide me to right direction. My problem is based on the following code. Here I have 4 variations of same method and all 4 variations are working fine.
I just want to know what is the recommended or standard way of doing this?
If none of these methods are no...
k, I kinda see it from your side now @rolfl. But sometime you should go into the Bridge. It's... exactly what gamedev was. So... why can't there just be a general off topic room?
I am not saying you are wrong, but with the system rules, as they are now, the conversations that were going on (and are now deleted) were not appropriate.
At the same time, it is a busy chat room and it has many (highly protective) owners, so if you do something that pisses people off, you can get flagged into suspension very quickly.
@rolfl Then why not get rid of those messages but keep the room open? I may be a bit naïve to all of this since I don't know specifically what went on, but... really?
None of the Above.
You've shown 4 different ways of mixing up presentation and data concerns; the 4 approaches only differ in minute implementation details and all suffer the same flaws - what you have here is a God class that knows everything about everything there is to know.
Let's think diff...
JavaScript Date Object
Mozilla Documentation on toLocalDateString
this code will give you the date in the format mm/dd/yyyy (at least that is what it gave me, because that is my locale convention)
var today = new Date();
document.write(today.toLocaleDateString());
Note: var today = new Date...
@Malachi I'm not sure I understand that answer. Why are you telling him he should depend on locale specifics? How did that even become involved? A Date object representing midnight today and a string with a specific format that indicates today are not the same thing. Am I missing something?
DateTime dt = DateTime.Now.Date(); gives him a DateTime Object with a Timespan of '00:00:00' but when you output to a display (to the console as a string) it doesn't show the timespan, because the .Date property outputs a string that only shows the date portion. that is what I did with the JavaScript with today.toLocaleDateString()
the toLocale is just to give the correct date format. it is the same concept of .Date()
Right, but new Date() doesn't have a 00:00:00 time component, so it's not the same thing. I think the string output was just his way of saying that he only cares about the date. Maybe I'm just being too picky though. This is why 1 line questions are frowned upon, I suppose :p.
Yes
the code will auto align to the user's browser window, as long as the browser window is greater than 1200px
Second Question
if you keep the files on your computer they will not be online, you have to host the pages on a web server and obtain a Domain name and all sorts of other stuff pert...
If case_letters() is just supposed to print something at the end, it should return void, not int. main() isn't doing anything else after calling the function.
A simple web-crawler
The crawler is in need of a mechanism that will dispatch threads based on network latency and system load. How does one keep track of network latency
in python without using system tools like ping
import sys
import re
import urllib2
import urlparse
import requests
import...
I need help optimizing my code to run faster (it works but I get Time Limit Exceeded) for this problem http://www.codechef.com/APRIL14/problems/CNPIIM , any help will be appreciated, thanks!
Here is my code: (Don't pay attention to readInt() function, its only used for fast input)
#ifdef _MSC_V...
Coming from the following post, http://meta.codereview.stackexchange.com/a/1749/32231, I'd like to address this as a feature request.
What is it about?
Lowering the threshold that people might experience when wanting to answer new questions. I have the feeling, and my own personal experience ad...
Coming from the following post, http://meta.codereview.stackexchange.com/a/1749/32231, I'd like to address this as a feature request.
What is it about?
Lowering the threshold that people might experience when wanting to answer new questions. I have the feeling, and my own personal experience ad...
I made a function for recursively reading a directory and it just seems kind of long and complicated. If you could take a look and tell me what's good or bad about it, that would be great.
Reading the directory synchronously is not an option.
Here is my code:
var dutils = require('./dutils');
...
Please feel free to comment on the accuracy / validity of the following wrapper source for processing signals using the new POSIX sigaction API. If you feel I'm doing anything wrong or potentially dangerous, chime in.
Note: syserr is a custom function not shown to exit gracefully.
Thx.
#incl...
It is often a good idea to edit the same tag's wiki on a different site (say Stack Overflow), and copy the markdown to this site, and revise/edit it so all the links are correct, references to other tags are valid, and anything StackOverflow specific is removed
2-player card fighting game
This is not about playing cards as in "Hearts, Diamonds, Clubs and Spades".
This is a game where 2-players (or more if you are really enthusiastic) can play/use cards or spells to do some effect against themselves or their opponent(s).
Minimum requirement:
Two pla...
It would be handy to have some kind of "Zen mode" here at Code Review.
Think about it, you develop code in a maximized IDE or side-by-side with the result or the specs (or both). I think Code Review needs this kind of feature. I even find myself scrolling up, read the post again, scroll down, ed...
I'm writing the data structures for my program (a toy compiler), and I'm trying to understand what's the best way to define the AST:
Current code
data RExpr = RExpr Location InnerRExpr
data InnerRExpr = RLExpr LExpr | RConstant Constant | RMathExpr MathExpr | FCall Id [RExpr]
Alternative A
d...
I agree with @User1 about RB_pop() and would like to add on to it:
If you want to prevent the function from returning false as an unexpected return value, you can make the function void and have a second parameter for data that will update the argument passed into it. Also, by making it void, ...
Remove fields which we already have as properties in base class.
Change everything to use base properties
Change setter scope of base properties to protected
Let's start with PlayWithPet. This is doing the same thing in all subclasses except displaying a different message for each one of them....
I have had this keylogger code for a while now (a few years*), and I figured I would put it up for review. Here is what I would like reviewed (in order):
Portability - right now, this program can only work on Windows systems. In what ways can I make this more portable?
Bugs - when I built this...
I've been playing around with some gradients on a site I'm developing, and I'm really interested in the psychology or other meaning behind why certain colors appear more attractive than others.
Here's the site right now:
The gradients there look quite natural to the design. But if I start mi...
On 2014-04-10, we got some feedback from Stack Exchange Community Managers @GraceNote and @Pops about our beta progress.
One of the concerns that was raised about the health of our community is that we have too many one-time contributors, and need more repeat customers.
So, I'd like to ask:
W...
Whenever I would go to answer a question, I kept being greeted with a competing answer. Usually it was the same person, @retailcoder. It was actually starting to get on my nerves a little bit, along with long comment strings that were really giving everyone the wrong impression of each other. ...
So about a year and a half ago, me and my friend started on a game called Zombie Smack Down. It's a text based game written in Ruby. But we were both really new to Ruby when most of it was written. I realize lots of this code is probably really bad, but I'm kinda stuck in my ways.
I'd love to k...
I'm a beginner to .net and could you guide me to right direction. My problem is based on the following code. Here I have 4 variations of same method and all 4 variations are working fine.
I just want to know what is the recommended or standard way of doing this?
If none of these methods are no...
None of the Above.
You've shown 4 different ways of mixing up presentation and data concerns; the 4 approaches only differ in minute implementation details and all suffer the same flaws - what you have here is a God class that knows everything about everything there is to know.
Let's think diff...
A simple web-crawler
The crawler is in need of a mechanism that will dispatch threads based on network latency and system load. How does one keep track of network latency
in python without using system tools like ping
import sys
import re
import urllib2
import urlparse
import requests
import...
I need help optimizing my code to run faster (it works but I get Time Limit Exceeded) for this problem http://www.codechef.com/APRIL14/problems/CNPIIM , any help will be appreciated, thanks!
Here is my code: (Don't pay attention to readInt() function, its only used for fast input)
#ifdef _MSC_V...
Coming from the following post, http://meta.codereview.stackexchange.com/a/1749/32231, I'd like to address this as a feature request.
What is it about?
Lowering the threshold that people might experience when wanting to answer new questions. I have the feeling, and my own personal experience ad...
I made a function for recursively reading a directory and it just seems kind of long and complicated. If you could take a look and tell me what's good or bad about it, that would be great.
Reading the directory synchronously is not an option.
Here is my code:
var dutils = require('./dutils');
...
Please feel free to comment on the accuracy / validity of the following wrapper source for processing signals using the new POSIX sigaction API. If you feel I'm doing anything wrong or potentially dangerous, chime in.
Note: syserr is a custom function not shown to exit gracefully.
Thx.
#incl...
2-player card fighting game
This is not about playing cards as in "Hearts, Diamonds, Clubs and Spades".
This is a game where 2-players (or more if you are really enthusiastic) can play/use cards or spells to do some effect against themselves or their opponent(s).
Minimum requirement:
Two pla...
I'm writing the data structures for my program (a toy compiler), and I'm trying to understand what's the best way to define the AST:
Current code
data RExpr = RExpr Location InnerRExpr
data InnerRExpr = RLExpr LExpr | RConstant Constant | RMathExpr MathExpr | FCall Id [RExpr]
Alternative A
d...