EDIT: All change... see below.
I can't reproduce your results on the x64 CLR, but I can on x86. On x64 I can see a small difference (less than 10%) between the conditional operator and the if/else, but it's much smaller than you're seeing.
I've made the following potential changes:
Run in a c...
Most of you already know me, please be brutal, and treat this code as if it was written at a top tech interview company.
Question:
Given a binary tree and a sum, find all root-to-leaf paths where each path's sum equals the given sum.
For example:
Given the below binary tree and sum = 22,
...
All of the Above.
Why restrict it to only one topic? Have a blog post about the evolution of Code Review, and the next one about Code Review itself, or when someone's inspiration pushes them to address language-specific common review issues, if it's good content it's content that we want, even i...
Don't write Objective-C as if it were Java/C#/C++/etc.
I once saw a team used to writing Java EE web applications try to write a Cocoa desktop application. As if it was a Java EE web application. There was a lot of AbstractFooFactory and FooFactory and IFoo and Foo flying around when all they ...
inline does two things:
gives you an exemption from the "one definition rule" (see below). This always applies.
Gives the compiler a hint to avoid a function call. The compiler is free to ignore this.
#1 Can be very useful (e.g. put definition in header if short) even if #2 is disabled.
In p...
I'm writing an enterprisey utility that collects Exception info and writes to the Windows Event Log, sends an email, etc. This util class will be used by all apps: web, BizTalk, Windows Services, etc.
Should this state class (please what's the phrase I'm looking for [like DTO]?) know how to det...
I want my socket class to be reviewed, including recommendations and optimizations.
Sokect.hpp
class Socket {
protected:
friend class SocketServer;
Socket(SOCKET s);
Socket();
SOCKET s_;
sockaddr_in sa_;
int* count_;
private:
...
What I'm trying to do:
Get user input for Google Play App page.
e.g. https://play.google.com/store/apps/details?id=jp.scn.android
Scrape 100 reviews from Google Play App and organize them into an array.
My JavaScript function:
function test() {
var urlAdd = document.getElementById('i...
I started to use Turbolinks gem in my Rails 3 application project.
I use //= require_tree . in my application.js
When using Turbolinks, I've just realized that some javascript codes stop working. According to the Railscast page, the solution is by adding the following codes to the js file:
rea...
The program is behaving like expected, but I think something better can be done since I'm a novice C programmer. I suspect that the interrupt handler can use some other way of calling the hardware instead of direct memory. Can you look and tell me what can be improved?
#include <stdio.h>
#inclu...
I have written a piece of code for removing duplicated values from an string. Any suggestions for improvement ?
`
public static String removeDuplicate(String s)
{
char [] temp = s.toCharArray();
int length =temp.length;
for (int i=0;i<length;i++)
{
...
All of your functions are missing return types. This also tells me that this code hasn't been tested, as this cannot possibly compile.
main() should return int as it should return error codes.
Based on the other functions' names and the fact that they're not returning anything, I believe they...
Issues with your code
You didn't put any effort into choosing good names. Given a code challenge, either stick to the variable names used in the problem statement (n, m, ...) or, preferably, choose explicit and descriptive names such as steps, digits and indices rather than z, y, etc.
Why shoul...
1) Create String Object & fetch value in it & use it
String attrName;
String attrValue;
while(itr.hasNext()){
MyClass obj=itr.next();
if(obj!=null){
attrName = obj.getAttributeName();
attrValue = obj.getAttributeValu...
I have a backup script which should backup a folder and send it to email. This should be done once a day. As this is on my laptop which is not online 24/7 I need to check that I am online and can send email. For this script I have an entry in crontab running every 2 hours.
Because the folder is ...
I am working in an inherited code (as in "everybody related to it left before I arrived at the job and left no documentation") and I have noticed an strange pattern.
Almost(*) each Struts (Struts 1.3.8) method that is invoked begins with a code such as
public ActionForward myMethod(ActionMappin...
I have been developing this plugin architecture, mostly for fun and education, its a simple Winform with some plugin logic and two plugins, i want to know if there is a better way of doing it.
Form1.cs
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Da...
