Two days ago I started reading about SignalR and today I started writing a simple application. I have written the code below so far, but I was wondering if you have some tips to improve my code.
Program
Desktop client will automatically create a random group (random) and displays the random ge...
I've found that a lot of the principles I've learnt about constructing programs also apply really well to constructing standard spreadsheets. SRP, naming variables ranges, splitting functions into multiple stages, dynamism etc.
bah, typical. Answering a question, provide better answer based on there comments(because there are cases they didn't tell) and when it's correct you don't hear them anymore
We're going to see if I can do anything else to help it today.. if not, I get to upgrade us to the latest stable versin of angular and kendo. And if that doesn't work, then we bring in a consultant
Readability
Naming
So, the first thing I would note is the poor naming. The way things are named right now makes it difficult to understand the code. So, to start, replace ws1 and ws2 with more meaningful names. The range variables are a little better, but could still use some improvement. I ...
Branches don't really have any affect on tags, they are literally just a folder inside .git/branches (I think) that contain a HEAD file that has a hash inside that points to the current commit on the branch
(which is coincidentally why you can't have more than one / in a branch name)
tags are more or less the same mechanic as branches, but they can be cryptographically signed
I was on 0.2-SNAPSHOT, ready to release 0.2, then I created a release-0.3 branch to release version 0.3, merged it with master and pulled release-0.3 into it, created v0.3 tag, all good, did a git tag --list and I see a v0.1 and a v0.3 tag in there... Am like WTF where is tag v0.2??? Realize I messed up and that I was supposed to create version 0.2, then force push reset hard master to be at v0.1, deleted release-0.3, restarted with creating release-0.2, merged with master, tagged it...
About to push the tags, doublecheck git push --tags, then realize there's still a v0.3 in there locally, deleted it, and now pushed all tags (which is v0.2) just fine
For any NET user who is interested: On 12th january the support for NET 4,4.5 and 4.5.1 will end. http://blogs.msdn.com/b/dotnet/archive/2015/12/09/support-ending-for-the-net-framework-4-4-5-and-4-5-1.aspx
ironically, I'd imagine it's getting to the point where XP users are safer than windows 7/10 users because XP is so old attackers won't bother to release new viruses for it...
@RubberDuck I was just going through the lowest-voted VBA questions. Saw that one and thought "This answer is criminally under-voted for the amount of effort that went into it".
Readability
Naming
So, the first thing I would note is the poor naming. The way things are named right now makes it difficult to understand the code. So, to start, replace ws1 and ws2 with more meaningful names. The range variables are a little better, but could still use some improvement. I ...
> Right now your goal is to create a shim to make it easier to unit test code that interacts with HttpContext.Current. Since you add methods to this interface as you need them, it must meet your needs in that regard. So, keeping it as is definitely improves your code, and you should not change it unless you need to.
TL;DR: The Problem
This keeps happening in chat:
Surprise at flags on vulgar messages. Language that would invariably get your comments deleted on the main site occasionally gets flagged and deleted in chat. Confusion reigns.
Controversial topics leading to bickering and name-calling. Folks b...
Im learning the mvc pattern and today i finished my first mvc routing class.
Hope you can give me some tipps and improvements.
Router.php
<?php
namespace System\Libraries;
class Router
{
/**
* Store the given parameters
*
* @var array
*/
private $_param = [];
...
There's a fifth type of flag: "I saw this line without the proper context, and it looks offensive". The classic being someone talking about killing their children -- horrible, if you don't realize they're working on a multithreaded web server. — Mark9 hours ago
@RubberDuck - back to that question. I agree that it is a well written, structured question, and it clearly asks a good question .... but, that question is a whiteboard question .... it should have been migrated to programmers, and the answers prove that.
For better improvement of your code, post it on the code review : codereview.stackexchange.com - plenty of good ideas over there. ElseIf I've always found unreadable(select Case does wonders instead in terms of readability) You can also jump a few lines to see better paragraphs. — gazzz0x2z42 secs ago
I would like to reimplement the current Futaba SBUS protocol in ArduPilot for Navio+.
It seems to be a relatively expensive protocol. So I changed the code from an existing git project and to make it a bit faster. At the moment I am already relatively happy with the result. Nevertheless, someone ...
Ooh. Fun (seriously). I'm currently taking apart the accounts of a substantial company (circa £40M/£5M Revenue/Profit, ~£3Billion in advised assets). It's like a giant logic puzzle :)
Plus, I decided to get what info I could by phoning up as a potential client (apparently, my name is Michael King and I'm about to get an inheritance of £500,000 ^^ )
I have function that build's different types of boxes.
namespace TestSome.ViewModel
{
public class OneBoxViewModel : ViewModelBase
{
private ObservableCollection<BaseBox> boxes;
public ObservableCollection<BaseBox> Boxes
{
get
{
...
Some users seem to deem this question unclear - feel free to edit your post to include a more detailed description of what your code is doing. — Mat's Mug ♦5 secs ago
I put together a jQuery plugin that displays a month of dates using underscore templates. When the template has been populated and displayed in the UI, a user can click on a date which sends a request to the api(with the selected date parameter) to give a list of available deals on that date. I t...
When I click on the browse button in various applications the following message comes up.
"Documents.library-ms" is no longer working.
This library can be safely deleted from your computer.
Folders that have been included will not be affected.
Here is a screenshot
I'm able to press "...
Well done for spotting the duplication and wanting to fix it! You are correct that you can use generics to solve this problem. Here's some approximate code to start you off in the right direction:
private void UpdateBoxes<T>(IEnumerable<string> ids) where T : BaseBox
{
var currentBoxAssetIds...
> I've also left the most difficult part to you because I'm evil it's an interesting learning opportunity for you :)
I'm not sure that is appropriate in a review. 2nd opinions?
It sounds patronising to me, and I don't think a reviewer should be giving 'home work'.
I'm of the opinion that you shouldn't be giving reviewee's homework; I don't think omitting a section of a review lends itself well to an "interesting learning opportunity" and (personally) sounds patronising. — Dan Pantry6 secs ago
I'm trying to map a dataset(let's call it Set1) onto another(Set2). The mapping is done by applying an operation to a subset of Set1 and placing the result to an object of Set2. I would like to know how can I structure the classes in an efficient and elegant manner (trying to learn OOP). Code bel...
Two days ago I started reading about SignalR and today I started writing a simple application. I have written the code below so far, but I was wondering if you have some tips to improve my code.
Program
Desktop client will automatically create a random group (random) and displays the random ge...
Readability
Naming
So, the first thing I would note is the poor naming. The way things are named right now makes it difficult to understand the code. So, to start, replace ws1 and ws2 with more meaningful names. The range variables are a little better, but could still use some improvement. I ...
TL;DR: The Problem
This keeps happening in chat:
Surprise at flags on vulgar messages. Language that would invariably get your comments deleted on the main site occasionally gets flagged and deleted in chat. Confusion reigns.
Controversial topics leading to bickering and name-calling. Folks b...
Im learning the mvc pattern and today i finished my first mvc routing class.
Hope you can give me some tipps and improvements.
Router.php
<?php
namespace System\Libraries;
class Router
{
/**
* Store the given parameters
*
* @var array
*/
private $_param = [];
...
I have function that build's different types of boxes.
namespace TestSome.ViewModel
{
public class OneBoxViewModel : ViewModelBase
{
private ObservableCollection<BaseBox> boxes;
public ObservableCollection<BaseBox> Boxes
{
get
{
...
When I click on the browse button in various applications the following message comes up.
"Documents.library-ms" is no longer working.
This library can be safely deleted from your computer.
Folders that have been included will not be affected.
Here is a screenshot
I'm able to press "...
Well done for spotting the duplication and wanting to fix it! You are correct that you can use generics to solve this problem. Here's some approximate code to start you off in the right direction:
private void UpdateBoxes<T>(IEnumerable<string> ids) where T : BaseBox
{
var currentBoxAssetIds...
