Reviewing code doesn't necessarily require actually building it, but it's often helpful to do so in order to evaluate fully. I usually create a CMake project and build from there. Since we're all about code here, naturally, I decided to automate part of the process. Specifically, here's how to...
Motivation
I'm very familiar with the pitfalls associated with reading in a line (string) in C++ and Java. Hell: library functions in these languages handle most of the issues anyhow. But in C, I've found it very hard to find print or online resources which outline known pitfalls and give a func...
What is the cleanest way to use dictionaries and protect against an unhandled ArgumentException if the key already exists in the dictionary?
I'd like to say that I can always guarantee uniqueness upstream, but I'm dealing with legacy code and mildly corrupt data from an old bug in the system.
I...
I would like someone to review my code and maybe give me some advice to maintain it because I'm still a beginner.
public static boolean NewTerrainCamPos = false;
public static String textVal;
public static String textVal2;
public static String resiveTex = "1";
public static String resiveTex2;
...
Is this a bad solution to the FizzBuzz thing?
I didn't come up with it all on my own, but I decided to make it print "Fizz Buzz" for the numbers divisible by 3 and 5 just for practice/understanding.
for (var n = 1; n <= 100; n++) {
var output = "";
if (n % 3 == 0)
output += "fizz";
if (n...
Including the full module, but the method I'm interested in is createIndex, feels more complicated than I think it should be. Still new at both node and elasticsearch
/*jslint node: true */
'use strict';
var EsConnect = require('./EsConnect');
var inet = require('inet');
function NetFlowStor...
Designing a Django app to receive and respond to requests from users within the company.
In my model I have the following:
from django.db import models
from django.contrib.auth.models import User
from django.db import models
from myapp import constants
# Create your models here.
class Task(m...
I'm a bit of a neophyte when it comes to C++, and so I'd like some feedback regarding a recent project.
The code sits on a Raspberry Pi and streams camera data over TCP on a specified port.
The MJPGWriter class:
#include <unistd.h>
#include <sys/time.h>
#include <sys/types.h>
#include <sys/soc...
I made a basic website to practice HTML and CSS that will display 3 fruits with their given scores in an Olympic podium sort of way.
Have I used any bad practices and what I should do instead?
What can I do to fully optimize and shorten my code?
How readable is my code? How can I make it more ...
Im using the following directive in a table to list the details.
directives.directive('kcInlineEdit', function ($compile, $parse, $filter) {
var templates = {
default: '{{filteredValue()}}',
text: '<a buttons="no" editable-text="modelVal">{{filteredValue()}}</a>',...
I try to find out two intersected rectangles. I find a code that calculates the total area of two rectangles and if they intersect extract that intersected area from total area. For given coordinates it should return 42 but it is still returning totalArea of two rectangles.
My code;
def re...
In an effort to create ever-improving code, I've written a DelegateCommand that takes a generic type parameter to be acted upon. It's pretty trivial, so it should hopefully be easy to review.
In order to do this, I had to create two interfaces: IGenericCommand and IWindowsUniversalCommand.
/// <...
I have this method that I would like to refactor to at least get rid of one nested loop level. I have been trying to do so for a while but can't seem to simplify it further.
private function addClassifiedTeams(&$document, $outrightOdds)
{
foreach ($document as &$table) {
if (isset($t...
I am working on a source line parse using PPI. After working a while, I realized that
it would be nice if the PPI API had included such and such functionality. As a very simple example, the PPI::Element contains a class method that returns the class name of the current element. This method must ...
First, I thought I'd mention that your code is stylistically really good - variable and function names make sense, indentation is great (with one small exception noted below), and the functions are focused and readable. Just one minor point:
The code under each Case in a Select Case is typicall...
Calling my dad lets me save my game and lets me know how much money is in my bank account. Calling my mom didn't seem to do much of anything. Why should I bother calling her?
I'm using dapper-dot-net for data access in my ASP.NET MVC application.
So in order to supply a connection string I've came up with the following pattern:
public static class ConnectionStringManager
{
private static readonly SqlConnection conn;
static ConnectionStringManager()
{
...
First of all, you must never fix a bug in the question just by editing the question. This is Code Review, not GitHub hack fest. (The only possible exception would be obvious trivial whitespace issues due to the author's inability to copy-paste the code correctly into the text box.)
If the que...
Looking to see how my code can be improved.
void QtReader::addPadding(const int& querybase, const int& answerbase, QString &target){
if (padding){
if (querybase >= 10){
target = "0" + QString::number(answerbase);
}
else if (querybase < 10){
t...
Why is Stack Overflow so negative of late?
I hate to pile on, but I couldn't resist summarizing the problem.
And I apologize ahead of time for any potentially offensive language that I might use.
Basically there are 4 camps of users on Stack Overflow:
The "caretakers" who want to keep the...
Given two rectangles, return the intersecting rectangles. This class is thread-safe. It takes rectangles in two different representations, and returns the intersecting rectangle in the respective representations.
Looking for code review, optimization and best practices.
final class RectangleWit...
I have a text file that contains following
https://git.centos.org/git/rpms/abc.git
https://git.centos.org/git/rpms/abc.git/
https://git.centos.org/git/rpms/abc
When I run the following command,
reponame=$(echo $url | awk -F/ '{print $NF}' | sed -e 's/.git\/$//' | sed -e 's/.git//')
echo $r...
I would like to use the following routines in my submission script for GAMESS calculations. Before I do, I would like to get some input if I can improve it somehow.
The three messaging routines (message,warning,fatal) are taken from my earlier review request, although I have chosen a more verbo...
This is a C++ program which outputs a Mandelbrot fractal image in a graphics window and lets the user zoom and pan around the image, generating a new image each time the user does so. I'm using SFML for the graphics part.
Because it generates a new image after every zoom or pan, it is pretty slo...
I read a lot of articles recently concerning XAML, WPF, data binding and MVVM. I also watched some MVVM tutorials and downloaded some MVVM samples. I finally got my first MVVM sample to work, but there seem to be different "flavors" of MVVM, or maybe there are just many people who get the whole t...
No you can't overload it; a static constructor is useful for initializing any static fields associated with a type (or any other per-type operations) - useful in particular for reading required configuration data into readonly fields, etc.
It is run automatically by the runtime the first time it...
I'm a PHP Developer. I'm trying to learn Python. So I tried to create a simple game, a Number Guesser.
I tried to comment out as much as possible without making super obvious comments.
I also made the attempts message color to be red.
Here's my code.
# 1. Print a message about the game
# 2...
There is a Popup in my application which I want to close automatically after a certain delay. And I want to have an attached behaviour which I could turn on/off and use with other popups. Google came out empty, so I implemented it myself:
public static class PopupManager
{
/// <summary>
...
It's been a year or two since I last dabbled in jQuery and have attempted to write a simple "on key press move to the next element" script. However my first attempt has a lot a repetition. I just know there is a more elegant way to write this, probably using a dictionary of elements or such.
...
