The 2nd Monitor

« first day (836 days earlier) ← previous day next day → last day (3479 days later) »

Heslacher

22:00

@Malachi The part about the return statement in your answer can throw an ArgumentNullException

Malachi

@Heslacher because of the length > 0 ?

TTGH, to be continued.... be back in a couple

Heslacher

If input is nothing a call to its property will throw

Malachi

@RubberDuck or at least a Variable....

Jeroen Vannevel

I let VSDiagnostics loose on codereview.stackexchange.com/q/101131/21028 and it found 25 warnings!

Granted, most are about naming conventions and encapsulation

still, that means it works

copy-paste as answer

Captain Obvious

Q: CSV parsing program that creates distinct header rows with transaction rows underneath

My code reads in the data using DictReader, then creates a header row that contains my composite key (PEOPLE_ID, DON_DATE), and then adds various values that are distinct to each section. The output looks like this: -01- PEOPLE_ID, DON_DATE, etc... -02- dataline -02- dataline -01- ... etc... ...

Q: Do you want to be a super (voxel) hero?

I have implemented an upgrades system in my Unity3d game, and I am pretty sure that I am not doing things in an optimal way. Any advice regarding best practices would be much appreciated. The idea is that when the player collects a powerup, their run speed and jump speed increases. Collect enou...

c# game unity3d

Vogel612

22:16

@JeroenVannevel question. VSDiagnostics is working with a mix of Syntax-Tree and source-code parsing, correct?

Jeroen Vannevel

Roslyn parses the source code into a syntax tree, yes

Vogel612

but for stuff like the Index analysis of format strings you parse the raw source code?

Jeroen Vannevel

In a way, yes. I have the entire syntax tree as objects and I picked out one part there: the first argument, which is of type ArgumentSyntax. This has in turn a property Expression which returns me the expression covered by that argument. Since it's a string it's of type StringLiteralExpression. Then I call GetText() on that and I get the textual representation of that node (which is in this case a simple string)

and then I do my voodoo on that string, create a new string, create a new expression with that string, create a new argument with that expression and replace the old argument with the new one

in the end I switch the two syntaxroots and boom: you have a code fix

Vogel612

I should really look into that...

~adds VSDiagnostics to the ever-growing list of "to research / work on"

Jeroen Vannevel

@Vogel612 github.com/Vannevelj/VSDiagnostics/issues

You can pick any!

Vogel612

22:27

hmm... I'd still need to learn from scratch...

and I won't have time before September

so... it's on the list

Jeroen Vannevel

So did @Hosch250 2 weeks ago

He already implemented 10-15 features

analyzers and code fixes follow a pattern which gets you going quickly. Once you know the important helper classes and you get used to how a syntax tree is built and its immutability, you're pretty much there

Hosch250

It is super easy.

Exactly - the easy ones are almost copy/paste.

Malachi

@Heslacher you shouldn't be able to call that function without an input... can a system array be nothing?

it's an extension method. it has to be called on an object.

Captain Obvious

Q: Find first SO chat message in Haskell

I have made some simple functions to find the first SO chat message. How can I improve my code? Even if there is a stackoverflow link that will get the job done, I'd like to improve upon my already written code. import Network.HTTP import Text.Regex.Posix type UserID = String type Message...

haskell stackexchange

Jeroen Vannevel

22:56

Aaaaand I learned something new

Pop quiz: what operators can you overload in C#?

No googling!

SirPython

@JeroenVannevel Would you like a list?

Jeroen Vannevel

Yeah

Ethan Bierlein

@JeroenVannevel I'm pretty sure that you can only overload mathematical, binary, and comparison operators

Morwenn

@SirPython That's not many compared to Python or C++.

Jeroen Vannevel

@EthanBierlein Which are, precisely?

SirPython

22:58

@Morwenn I apologize.

Ethan Bierlein

@JeroenVannevel -, +, *, /, %, &, |, ^, >>, <<, -, +, ~, !, --, ++, !=, ==, <=, >=, <, >

That took way too long to type

I think that's right

Morwenn

I think that the true and false operators are also overloadable.

Ethan Bierlein

Don't take my word on that though

@Morwenn I knew I missed something

Morwenn

Plus compound operators.

Jeroen Vannevel

@Morwenn We've got the winner ;)

Ethan Bierlein

23:01

lol I was close

Jeroen Vannevel

@Morwenn No, not them

But it's true: you can overload true and false

Ethan Bierlein

Why?

Morwenn

Oh. What about && and ||?

Ethan Bierlein

And how?

@Morwenn Nope

Jeroen Vannevel

void Main()
{
	var obj = new MyBoolean(false);
	if(obj)
	{
		Console.WriteLine ("true?");
	} else {
		Console.WriteLine ("false?");
	}
}

class MyBoolean
{
	private static bool _myBool;

	public MyBoolean(bool b)
	{
		_myBool = b;
	}

	public static bool operator true(MyBoolean x)
	{
		return _myBool;
	}

	public static bool operator false(MyBoolean x)
	{
		return _myBool;
	}
}

Ethan Bierlein

23:02

It's a shame that you can't overload the indexing operator (...[ ... ])

It could be useful for user-defined collection types

Jeroen Vannevel

@Morwenn Not them, but according to this you can do it with & and |

Morwenn

Honestly, I already find it strange that there are true and false operators. So... them being overloadable is not that surprising.

Jeroen Vannevel

yeah, I never realized these were considered operators

Morwenn

@JeroenVannevel Ok, now that sounds totally broken.

Ethan Bierlein

wot

Why did MSDN just translate itself to german

Vogel612

23:06

'cuz microsoft...

there's an extremely small box down in the footer

with a gear

you can change language there

Anyways, imma hit the sack, niters

Ethan Bierlein

night @Vogel612

Morwenn

@Vogel612 Sweet dreams ^^

Quill

Monking

Ethan Bierlein

Monking @Quill

Morwenn

@Quill Sweet dreams ^^

Ethan Bierlein

23:12

Starting to write a blog post on Batch

Quill

Cool, I look forward to it hitting my RSS aggregator

Ethan Bierlein

It's going to more of a PSA informing people of it's real purpose, and telling them what it shouldn't be used for.

Quill

What it shouldn't be used for: loop opening notepad.exe

Ethan Bierlein

Yes

Or making fake viruses

Or fake BSoDs

Or stupid text adventures

Quill

Fun times

 :a
 start
 goto a

SirPython

23:20

:a
start "" %0
goto a

Ethan Bierlein

Oh yeah?

%0|%0

Quill

 COLOR 0A

Making children l33t haxors since (Date)

Ethan Bierlein

Oh god, the worst is this:

color 0a
tree

I had a little cousin tell me he was a "hacker" after typing that

I laughed

And told him that he wasn't a hacker

Quill

oh well, everybody's gotta start somewhere

Ethan Bierlein

yes. I actually pointed him to some Python resources.

I don't know if he actually learned Python though.

« first day (836 days earlier) ← previous day next day → last day (3479 days later) »

all rooms

Transcript for

Aug17

Aug '1518

Aug19

General discussion about codereview.stackexchange.com - Welcom...

addicted-to-cr here-be-pedants just-saying-hi monkey-business my-code-is-compiling nice-people-room

join this room
about this room

00:00

06:00

12:00

18:00

all times are UTC