The 2nd Monitor

nhgrif

13:00

0

== false while found == false We'd prefer to see either this: while !found or this: while notFound (where in the second example, we reverse the boolean logic you've used) Vertical White Space A blank line between every line of code is not productive. It adds wear to my scroll whee...

> I wanted to emphasize Swift-style however, because I'm not sure how likely it is that any performance-related comments will be applicable to the next Swift code you write, but all of these style-related comments will absolutely be applicable

Nothing wrong with Heslacher's answer, but if the question is only a matter of performance, then the question is a duplicate of the numerous other PE#5 questions that have been asked (starting with my question which is in the same language).

EBrown

Is it rude to ask a co-worker not to "f--- up my code?"

nhgrif

Yes.

EBrown

Damn.

nhgrif

If you're not joking.

EBrown

I'm not joking. He has a tendency to turn all the code he touches (especially clean code that I write) into muck.

@nhgrif It depends on how he wants to solve it, I would suppose. Though, at some point, eventually we'll likely have exact duplicates of that problem.

Captain Obvious

13:10

0

Q: Delivery date checker for e-commerce website

I’ve made an e-commerce website where administrators can specify the number of deliveries they can make on any one day. I’ve written a SQL statement that then finds all delivery dates, finds any matching orders on those dates, and then returns any where the remaining “slots” are greater than zer...

sql

Malachi

Hey @EthanBierlein , you could help me gain Reputation on Programmers so I can help moderate over there..... I can start a chat so I can pimp some programmers answers. or you could post better answers on the questions I answered on, then I could upvote yours and you could help moderate.....

here is one that was migrated from Code Review --> programmers.stackexchange.com/q/236651/62519

Monking BTW.Normal

Morwenn

BTW.Coffee

Malachi

yes!

Morwenn

I added a value to the enum. I hope it didn't break the ABI.

EBrown

Windows needs to get rid of this auto-reboot shit.

I manage to lose work every time it does it.

Morwenn

13:22

Fortunately, there were already 9 values in the enum. The new shouldn't have broken the ABI.

Malachi

I am a little lost in the Acronym translation of ABI?

Mast

@EBrown Mine is never auto-rebooting. What version?

@Malachi It's an API for Binaries afaik.

EBrown

@Mast 8.1.

Mast

@EBrown Disable your auto updates.

Vogel612

@EBrown well... they did get rid of it.. in 10.

EBrown

13:29

@Mast Domain controlled.

Mast

@EBrown Nail the domain manager to the wall if he doesn't shut it off.

EBrown

@Mast Granted, I could login to DC01, add my PC to a new GPO and change the settings, but that's more work than I care for.

It irritates the hell out of me though. I'm working on some programming stuff, and then all-of-a-sudden Windows tells me it's rebooting in 15 minutes.

Morwenn

@Malachi Application Binary Interface

Mast

@Vogel612 I heard horror stories that the auto-updater can't be shut off in Win10 Home, but Pro and higher seem decent.

Malachi

OIC @Morwenn @Mast TY

all I need is 23 more rep on Programmers to access review queues..... anyone care to help me out --> programmers.stackexchange.com/users/62519/malachi?tab=answers

Dan Pantry

13:34

ho-ho-ho @Malachi

Mast

I sense a disturbance in the reputation.

You wrote an answer to this?

585

Q: My boss decided to add a "person to blame" field to every bug report. How can I convince him that it's a bad idea?

In one of the latest "WTF" moves, my boss decided that adding a "Person To Blame" field to our bug tracking template will increase accountability (although we already have a way of tying bugs to features/stories). My arguments that this will decrease morale, increase finger-pointing and would not...

teamwork bug-report

Malachi

thanks @DanPantry

Mast

I've seen the ' boss' version of the story on Workplace.

I need 7 more on CR to hit 1.5k.

Malachi

@Mast you don't like?

Mast

@Malachi I do, you got an upvote for it. It's constructive.

Malachi

13:37

@Mast thank you. too bad it is CW now...lol

Mast

lol

Malachi

I can see the value in knowing who wrote the code or who the backup is

Mast

@Malachi Wouldn't a commit history take care of that?

Such a field would allow linking the bug to the commit, which is great I think.

Malachi

it would, but I think they are talking about documentation for managers. people that might not be inclined to access such things

Dan Pantry

@Malachi a lot of version controls have nice user friendly GUIs which clearly link a change with the user though

Mast

13:40

Managers don't access commit histories? He shouldn't be bothered with bug fields then either.

2

Malachi

lol

I am just playing devil's advocate

Dan Pantry

in my work we use TFS (shudder)

Malachi

I agree with you all

Dan Pantry

and even that links user to commit

Malachi

I also use TFS with Visual Studio 2013

EBrown

13:41

TFS is great.

Dan Pantry

I hate TFS so much..

Mast

@DanPantry I stopped using VS because I can't get it to leave my repo's alone.

Malachi

@DanPantry but only holds so many commits

Mast

It's an abomination.

Dan Pantry

@Mast I have to use Visual Studio because the TypeScript project we have only compiles due to a quirk of VS. And everything uses TFS, so I can't use a text editor to check in text file changes without first opening visual studio and checking the file out..

wtf-is-this-shit

Mast

13:42

@DanPantry Run!

Dan Pantry

I have already decided that I am never touching .NET after this company

Vogel612

meh.

don't blame -NET for TFS.

Dan Pantry

I don't.

But there's a high incidence of companies that use .NET using TFS

Mast

@DanPantry True that. All M$ fanboys...

Dan Pantry

That's not the fault of .NET - or the companies - but Ir efuse to use TFS or Visual Studio due to how heavy weight

EBrown

13:43

Something tells me it's you that has the issue, and not TFS.

Dan Pantry

So you're telling me it's perfectly reasonable that I have to open VS to check out a file so I can modify that text file and then check it back in?

Compare this to git where I can just edit stuff. No checking in/out necessary.

EBrown

Yes, because that is your source-control manager.

Dan Pantry

Visual Studio is my source control manager?

No, Visual studio is my IDE that compiles C#.

I shouldn't have to use VS to use source control.

EBrown

Perhaps you should visit Stack Overflow: stackoverflow.com/questions/25128789/…

Especially that Accepted Answer.

Then, you no longer need Visual Studio to be your Source Control manager.

And you can use Windows Explorer for it.

Similarly to how GIT and SVN can integrate with Windows Explorer.

Dan Pantry

Awesome. Now I only need to install another program to use the source control I've already installed a program for!

Mast

13:45

I want VS not to interfere with my git repo. Every time I open the darn application I have to re-initialize the repo before committing.

Dan Pantry

I think the main issue is centrallized version control and I do not mix.

Also, I can't install software on this PC - it's a corporate PC.

EBrown

@DanPantry Then I go back to my previous statement: "Something tells me it's you that has the issue, and not TFS."

Talk to your Domain Admin about it.

Considering that it comes from Microsoft, they'll likely install it for you.

Dan Pantry

I'd much rather use source control that doesn't suck.

That actually has half decent merging and branching

EBrown

TFS doesn't, but I'm not going to bother trying to convince you otherwise.

Dan Pantry

In my experience, it does suck

Compared to git

but that's my opinion

it's probably a good tool with the right workflow in the right hands

EBrown

13:47

I'm merely trying to make it more pleasant for you to work with. This attitude is not going to help you. It's similar to the woman who works in the office next to me.

Dan Pantry

but those are not my hands

Mast

@DanPantry That's awful. Every company so far gave me n unmanaged laptop/desktop and it saved me a lot of paperwork.

EBrown

She was having major issues with VS2013, so I went in there, and it turns out her attitude that it "just doesn't work" was the issue.

Dan Pantry

@EBrown I don't care for making it more 'pleasant' for me to work with. I already have a local workspace, and I still have to check in/out of it.

EBrown

As soon as I showed her that it's possible to do what she was without having to go through all these steps, it was all better.

Dan Pantry

13:48

Merging is a giant pain in the ass, to the point where none of my colleagues will actually use the branch tool (which also sucks)

I'm sure TFS is fine and you reserve your right to enjoy using it.

But git is just superior in nearly every respect, IMO

Duga

[www.codereview.stackechange.com](www.codereview.stackechange.com) — Jordi Castilla 24 secs ago

Dan Pantry

git vs y source control is a holy war, though

Quill

@nhgrif Nice work

Mast

@DanPantry Indeed, so this will probably never end.

Dan Pantry

@mast which is why I said it, to try and draw the line in the sand :P I don't care about making my environment less arduous to work in. TFS is just the tip of the iceberg. But I refuse to use anything that 'requires' Visual Studio any more. Gah. Just give me a terminal and vim and I'll be happy.

EBrown

13:50

Well you have two options: continue complaining about TFS, or work with it and get used to using it. It seems you have chosen the former.

Dan Pantry

I do work with and and I am used to using it.

EBrown

Personally, I don't like it either. I hate all source control. I never use them on personal projects.

Dan Pantry

> I hate all source control

Alright, I'm not taking you seriously any more

Mat's Mug

cough

Mast

You can't hate source control.

Mat's Mug

13:50

hi!

Dan Pantry

Might want to get that cough checked out, @Mat'sMug ;-)

Mat's Mug

@DanPantry yeah, I'll just have another cigarette first

EBrown

Source control sucks, it's built to be cumbersome. Personally, I'd rather just have a separation of responsibilities to the point that people don't interfere with each other's parts of the project.

Also, @Mat'sMug I have a question for you.

Mat's Mug

I might have an answer for you

EBrown

Is it against best practices to have 25+ using statements in a C# file?

Dan Pantry

13:52

Having to use visual studio to use source control might well give you the impression it is cumbersome. git is far from cumbersome; it fits nicely into my workflow. All soruce control does, in the end. It's far too valuable to not use it.

EBrown

And upwards of 40 in some files?

Mast

@EBrown That's source control done wrong. Done right it's actually easy.

Dan Pantry

how are you using that many using??

EBrown

@DanPantry public class MainGame

Dan Pantry

@EBrown One Class to rule them all, and in the darkness bind them

EBrown

13:54

@DanPantry No, one class that interacts with many dozens of other classes.

At some point in any programme you will have coupling.

Dan Pantry

It was a joke. What does your MainGame class do?

EBrown

It's responsible for managing the entirety of the interaction between the user and the game objects. (Forms, Entities, etc.)

Mat's Mug

either you have too many namespaces

...

EBrown

@Mat'sMug Probably the case...

Mat's Mug

or the class is part of the app's composition root

Duga

13:57

@DangerZone I'm not getting errors. That thread is rather codereview than finding for bugs. — p__d 27 secs ago

EBrown

@Mat'sMug Definitely part of the case...

Dan Pantry

@Mat'sMug in which case, inversion of control container go go go

Mat's Mug

@Duga there is no thread

EBrown

@Mat'sMug So I shouldn't be worried about it if the latter is true?

Vogel612

@Mat'sMug I like the all-caps...

Mat's Mug

13:57

if you're in a part of the project that needs to know about everything in the project...

Dan Pantry

> One Class to rule them all, and in the darkness bind them

EBrown

@Mat'sMug Well, I think that's the case, unfortunately. And I'm not sure if there's any way to separate some of this out.

Dan Pantry

@EBrown try an inversion of control container, at least, that might help you some

otherwise you'll want to start splitting the functionality of MainGame up until different components

Vogel612

calling upon DI and automagic finding of eligible injections

Mat's Mug

@DanPantry what I have in mind is a Ninject module - that module configures the dependencies and is coupled with pretty much every concrete type in the project; that could explain and warrant 30 using statements

Transcript for