It's a good question but needs to be moved to codereview. — Bathsheba53 secs ago
I'm voting to close this question as off-topic because it belongs to codereview. There, You would need to post the code in your post rather than linking to your github. You only have to post relevant parts. — UmNyobe49 secs ago
@Quill I know that what is 'real' art for me is different from you, but there is a baseline that most of us can agree upon, and assume that what is in that baseline is intrinsically art.
@Anonymous I suggest you come join the Code Review regulars in The 2nd Monitor, then we can straighten things out (instead of littering the comments even more). — Simon André Forsberg44 secs ago
@UmNyobe This question, as-is, it totally off-topic. The website (CodeReview) is meant to review code. This question has absolutelly no code. Without code, it will be closed as off-topic. — Ismael Miguel54 secs ago
This would be more suitable for codereview.stackexchange.com. Without knowing what the content of Tag is though, it could be that the original coder was lazy. Why not write equipment.Select(it=>it.Tag[0]).ToList()? — Panagiotis Kanavos19 secs ago
First project is a Qt application, mostly QML stuff right now but also some C++ things, of which I both have no practical experience
But then again QML is quite easy, you just need to learn the framework and it uses Javascript which I already know
And for C++ I do know the syntax, etc. - I just think it's very difficult to create my own application withotu using a library, but maintaining an existing code base is way easier :)
@RubberDuck That's exactly where I'm stuck in... But at least here they know they did it wrong, but they just needed to get a beta version out before a deadline
When developing my own applications I might do it the other way around though, make some completely generic reusable component for something that gets used only once
@RubberDuck But it might not be bad that it happens on my own projects, as I'm learning as much as possible, unfortunately it does mean that I don't release often at all
i have a dropdownlist ,txtbox and a gridview.The dynamic data's are binded to it.I want to add a static value to the dropdownlist like "select" so that if i click on that select i should get all the values in gridview.i.e.,even if the textbox is empty and dropdownlist==select the gridview values ...
@IsmaelMiguel Here we have to log all work in our JIRA, related to a specific issue on the project you're working on (or a general project), and you get paid per hour at the end of the month
If you only effectively work 6 hours on an 8-hour day, you only get paid for 6 hours
You obviously still have deadlines when stuff needs to be finished, but say you work 12 hours on a day close to the deadline, then you'll get paid 12 hours
@jacwah There are recruiters who look at Stack Overflow. I told a recruiter that contacted me a while ago to also look more at Code Review. Hopefully they will learn to do that... (unfortunately I didn't get the job, but it was still quite an experience...)
Hmm... this is not a typical Code Review answer, but, if written as: "Your code is one big main method - you should extract logic blocks in to functions to make the code more readable and reusable", then it would be great. Oh, it's really close to that, so it's an answer. — rolfl ♦2 mins ago
When there is an answer you feel is 'bad', what are the correct actions to take?
For example, the question:
Similar methods using loops
has an answer:
If you always use both functions together it might be faster to run the code in one pass instead of two, but here it is perfectly fine to...
It's an old question and his answer is not answery enough to be a real answer As a comment, it would be fine. As an answer, it lacks body. It lack content.
The point of the exercise was to create functions, functions would be useful, and good practice, the answer points out these things..... not particularly well, but, it is a code review.
No other answer points out this basic flaw in the code.
Is there a way to make my code simpler/more pythonic?
Given a non-negative number "num", return True if num is within 2 of a multiple of 10. Note: (a % b) is the remainder of dividing a by b, so (7 % 5) is 2. See also: Introduction to Mod
near_ten(12) → True
near_ten(17) → False
...
I've severed interfaces from concrete implementations, please check out the screenshot below. I'm just thinking I kind of overdo the thing. Do you guys think it's a good practice?
So I need to use a feature from Angular 1.3 in my project with work.. a 3rd party has adamantly decided we must use angular-kendo. Fine, whatever. However, the code is currently in Angular 1.2 and Angular 1.3 breaks a lot of the things in kendo-angular. Whats worse is that Angular 1.3 has significantly better performance, something is app is lacking. :(
And, of course, we do not have the professional kendo licence, but the 3rd party does, so I can't get the most updated code. a 3rd party developer has - quote - "kendo framework script to fix some kendo bugs" and refuses to publish them in source control. What do
@Mast this seems basically what I'm going to have to do.
@jacwah I'm trying, however, the 3rd party has only one point of contact (and I believe developer working on our project) who does not seem to fully understand English and refuses to address the issue at hand.
In fact, he points out that he 'fixed some bugs in kendo' to make itw ork with angular 1.2. I suspect we're using a heavily monkeypatched version of kendo just with angular 1.2
Ever since I joined work on this project I tried extremely hard to push it away from Kendo and use the native Angular-UI components which are not proprietary and do not require a nasty 300kb jquery download... but the third party insisted on kendo. :( Guess I have to lay in this bed now.
@Mast No idea (pun intended). There used to be a page where you could see what changes were made, but now they're only showing what issues were closed - not as informative.
They have made tremendous progress on it over the years that I've been using Scala. In the beginning, there used to be massive amounts of incorrectly identified "errors".
Sometimes I run into code that IDEA says is fine, but doesn't compile, but it's uncommon anymore. I report it, they fix it.
@Donald.McLean currrently my visual studio sometimes decides it doesnt feel like running completely fine, 100% compiling code. It will compile it and then proceed to run an old version of the code because why not.
@Mast I only notice when I put a breakpoint in the code and notice the symbols haven't been loaded. It's like what the hell, I've just cleaned and builded you manually 3 times in a row now.
@Gemtastic The easiest way to learn Scala is to pretend that you're writing Java that has a whole bunch of great new libraries. Over time, you start to learn the Scala idioms and advanced concepts.
Once you understand how this works (or just avoid it entirely), I find JavaScript to be quite enjoyable. ES6 looks pretty awesome as well, and the async/await proposal for ES7 even moreso.
@EBrown there's a special place in my heart for statically typed languages, but I don't think I will ever write a web server (or IO of any kind, or CLI tool) in Java ever again.
Yeah, as I said; I'm a Java developer so I have a lot to wrap my head around with the asynch thing and amusingly the functions as parameters and inside of other functions were a little bit to get into as well...
@EBrown You can create full stack JavaScript applications and have been able to do so for 5 years. They are arguably the most well scaling server applications at the moment.
Also, there's something called isomorphic JS which shares the same code on the server and client. React and Meteor are examples.
@EBrown it doesn't - JavaScript has const and let as of ES6 and you can get typed supersets (TypeScript) that enable transpilation with a type checker and type annotations.
When there is an answer you feel is 'bad', what are the correct actions to take?
For example, the question:
Similar methods using loops
has an answer:
If you always use both functions together it might be faster to run the code in one pass instead of two, but here it is perfectly fine to...
Just use strtoll with a base of 0
Is there a way to make my code simpler/more pythonic?
Given a non-negative number "num", return True if num is within 2 of a multiple of 10. Note: (a % b) is the remainder of dividing a by b, so (7 % 5) is 2. See also: Introduction to Mod
near_ten(12) → True
near_ten(17) → False
...
I've severed interfaces from concrete implementations, please check out the screenshot below. I'm just thinking I kind of overdo the thing. Do you guys think it's a good practice?
