I am amateur Java Programmer.I wrote a class to return the number of whole weeks between months in the same year. Please need suggestions on my code.
public int year;
public String m1;
public String m2;
public Solution(int Y, String A, String B) throws ParseException {
this.year = Y;
t...
I have following code to extract results of an airline web service. I am wondering if this is any better approach to this? The code is supposed to ignore any flight that has more than 1 transit.
All retrieved results from Airline web service are in "AvailabilityRes" class.
for (int i = 0; i < a...
You need to ensure that every statement in the switch is one that ensures that sb != null holds, this is not the case currently.
You can fix this by throwing an exception instead of logging a message, like this:
default:
throw new IllegalArgumentException("input was invalid: " + userInput);...
Yay, I got an accept :D
I feel like I would recommend Groovy nowadays though
I have a chart with many series. And I want to colour all the bar in the chart (all series) with red if it has value<100 and with green if it has value>=100.
My code is
Private Sub CommandButton1_Click()
Dim chartIterator As Integer, pointIterator As Integer, seriescollectionIterator As Int...
A similar question answered with a nice suggestion, maybe useful for you too. İf you're good with cmd line, you can parse and check if any work item with type "Code Review" is there. query is: tf changeset /collection:[url] [changeset#] /noprompt — Beytan Kurt33 secs ago
@Mast Well, there is some validity to their complaint. Our roof stretches out as a platform so we can easily look into their yard
Still, it makes me salty. It's not like I'm interested in spying on 80y olds anyway
When we were setting up that wooden wall a few months ago, I would look into that part of the yard from time to time and EACH TIME our neighbour would be staring at us
I'm aware retirees don't have much to do, but damn it she took it to the next level
You try eating at the table when you only have to look up to see a grandma staring at you through her window
You can, but then they have grounds to take you to court
Same reason there was something in the news a few years ago about someone that put up a treehouse in his yard but had to take it down because it was too high
Maybe they'll become more lenient when our fruit trees are fully grown and covering more of their yard
To echo what Jubobs said, I would recommend having developers commit their proposed changes to a new branch, and have them make the appropriate changes after code review in that branch as well, then merge into the main branch when all is well. If you do not want the "pre review" code in the history, you can always flatten the commits as well. — David Deutsch35 secs ago
I have a class that creates user accounts and to avoid sql injection attacks, I am using the following functions to sanitize both the user name and password inputs:
$admUsername = filter_var($_POST['admUsername'], FILTER_SANITIZE_STRING);
$admPassword = filter_var($_POST['admPassword'], ...
Besides the obvious performance implications of doing so, what are good technical reasons not to set grails.gorm.autoFlush = true and grails.gorm.failOnError = true in Config.groovy?
Recently, I got a very interesting task, it is to realize the hash table that works in multi-process server in common memory, each element of which must have a TTL property. It was suggested to implement the TTL, as a additional process that walks through the table every second and corrects the T...
What if the default implementation of save() flushed, and you could call save(flush: false) to prevent the flush? Would you still have a problem with it?
But appareantly it then doesn't even trigger validation errors on unique constraints, so it's borked if you ask me
@nhgrif No, that's what I'm trying to achieve via the config setting
You also have the failOnError probably that's by default set to false, that means that if there's validation errors it will return null rather than throw an exception
For that one I have (succesfully) changed the default value to true, because having that set to false is insane
It is a good option to have as it prevents try-catch statements, but still insane to turn it on by default
Yeah, it's satisfying to solve a problem yourself; but if you're stuck, don't hesitate to ask. Also, when your code is already working but you still feel it could be improved, I recommend asking on codereview.stackexchange.com for feedback! — sloth21 secs ago
This is the section there the error appears to happen:
import groovy.swing.SwingBuilder
import groovy.beans.Bindable
import static javax.swing.JFrame.EXIT_ON_CLOSE
import java.awt.*
@Bindable
class UserInput {
String word
String toString() { "$word" }
}
def userInput = new UserInput(word: '')
Getting error like:
Caught: groovy.lang.MissingPropertyException: No such property: word for class: SwingForm
groovy.lang.MissingPropertyException: No such property: word for class: SwingForm
...
If I have two horses, will I more accurately determine which is faster by racing them or by posting on the Internet about my horses and having people make guesses as to which would be faster? — nhgrif12 secs ago
I am creating charts with origin(100,0) i.e, x axis value=100. At first I used,
ActiveChart.Axes(xlValue).MajorUnit = 10
and I got the x axis ... 70,80,90,100,110,120,130....etc
I thought it would be better if I had axis values as ...60,80,100,120,140... etc. So I edited my code as follows,
A...
Moreover, even if you do race your horses and find out which is faster, you're probably going to find out that in the specific case of UI, there isn't going to be much of a difference (if any) (your ability to write efficient code when you don't even know to just race your horses versus Apple engineers who wrote the Xib loading code...). And you'll have to retest it every time you change anything on the UI. And you'll have to retest it every time there's an OS update. And your hand-written UI code will be a PITA to maintain versus the interface builder UI setup. Consider everything. — nhgrif8 secs ago
The Xib file does have to be parsed... but the thing is, I can guarantee the UI isn't what's slowing him down. I've had extraordinarily complex UIs (even ones that actually have to parse several Xib files just for one screen) and never noticed a slow down.
His code is slow because of whatever else logic he's doing (which is probably poorly implemented).
And by the time he's done writing the manual UI code, it'll probably be even slowed.
I'll bet on Apple engineers over basically any individual iOS programmer...
There will always be some logic involved. But if you don't split them up (SRP style), you'll block stuff and make it your compiler unnecessarily difficult.
This complicated logic he's doing either needs to happen on the previous screen before this view starts showing up, or on this screen after the UI stuff is done
I am new to HTML and programming in general and am currently working on setting up my first website.
For this I created a couple of PHP pages with a separate file for each of them and in order to avoid duplicating code I tried to remove as much as possible from the pages header and saved this i...
The below python 3 program scans 4 files a.txt, b.txt, c.txt, d.txt and then outputs the read data into a file output.txt in a formatted way. (Never mind about the bad variable names)
def main():
with open('a.txt', 'r') as a, open('b.txt', 'r') as b, open('c.txt', 'r') as c, open('d.txt', 'r...
Every I/O driver must implement 5 functions read / write / open / close / seek.
This is a contract obeyed by any I/O driver.
For example, driver for a keyboard(say) or file(say) must implement these functions.
Below program(myProgram),
main()
{
int c;
while ((c = getchar()) != EOF)
...
I've been working on a safe inserting method for a while, and I think I've found a pretty secure way to do this. Would you Overflowers mind taking a look at it and maybe give me some tips to improve my script?
function dbRowInsert($table, $data) {
require_once('../config.inc.php');
$bui...
If you continue to include irrelevant links to your company, you will end up with a ban. This seems to be an otherwise okay review, but please remove the spam link. — RubberDuck20 secs ago
I have a program which exports the data directly from Cassandra to mongodb.It works fine But, It doesn't copies the counter type column from Cassandra to mongodb. It leaves it as blank.
My data in Cassandra Table :
public class CassExport
{
static String keyspace = "query";
static String ta...
The case: Somebody posts code for review then follows up with all the analysis and some of the answers is accepted.
The suggestion: Some kind of finalization post by the dev who is asking the question which is the corrected/final implementation according to all proper suggestions and analysis.
...
I have a dialog that houses 6 security questions and 6 security question answers.
I want to pass the data the user selects and enters from the view to the controller to save the data in session. Right now, the code works perfectly but it is a mess. I am passing 12 arguments to my controller act...
Also note, that an "answer" consisting of a code dump with the "final code" (...is code ever "final"??) will be downvoted and flagged as "not an answer" - please shape your selfie in the form of a review, as if you were reviewing your own code (which you can always do anyway); explain why changes are made (and/or link to answers that do). This site isn't about the "final code" after all; it's about understanding how code can be improved. Just dumping the improved code as an answer saying "thanks all, this is how it looks now" provides no value whatsoever. — Mat's Mug28 secs ago
@gamil No, it doesn't, it merely explains how to use it and why it should or should not be used, if you would have read my question, you would see that I have already set everything up. If it would help me (as you think), then point out how it would help me. — skiwi7 secs ago
I am amateur Java Programmer.I wrote a class to return the number of whole weeks between months in the same year. Please need suggestions on my code.
public int year;
public String m1;
public String m2;
public Solution(int Y, String A, String B) throws ParseException {
this.year = Y;
t...
I have following code to extract results of an airline web service. I am wondering if this is any better approach to this? The code is supposed to ignore any flight that has more than 1 transit.
All retrieved results from Airline web service are in "AvailabilityRes" class.
for (int i = 0; i < a...
You need to ensure that every statement in the switch is one that ensures that sb != null holds, this is not the case currently.
You can fix this by throwing an exception instead of logging a message, like this:
default:
throw new IllegalArgumentException("input was invalid: " + userInput);...
I have a chart with many series. And I want to colour all the bar in the chart (all series) with red if it has value<100 and with green if it has value>=100.
My code is
Private Sub CommandButton1_Click()
Dim chartIterator As Integer, pointIterator As Integer, seriescollectionIterator As Int...
I have a class that creates user accounts and to avoid sql injection attacks, I am using the following functions to sanitize both the user name and password inputs:
$admUsername = filter_var($_POST['admUsername'], FILTER_SANITIZE_STRING);
$admPassword = filter_var($_POST['admPassword'], ...
Besides the obvious performance implications of doing so, what are good technical reasons not to set grails.gorm.autoFlush = true and grails.gorm.failOnError = true in Config.groovy?
This video with Ray Wenderlich and friends is an interesting watch.
The below python 3 program scans 4 files a.txt, b.txt, c.txt, d.txt and then outputs the read data into a file output.txt in a formatted way. (Never mind about the bad variable names)
def main():
with open('a.txt', 'r') as a, open('b.txt', 'r') as b, open('c.txt', 'r') as c, open('d.txt', 'r...
Every I/O driver must implement 5 functions read / write / open / close / seek.
This is a contract obeyed by any I/O driver.
For example, driver for a keyboard(say) or file(say) must implement these functions.
Below program(myProgram),
main()
{
int c;
while ((c = getchar()) != EOF)
...
I've been working on a safe inserting method for a while, and I think I've found a pretty secure way to do this. Would you Overflowers mind taking a look at it and maybe give me some tips to improve my script?
function dbRowInsert($table, $data) {
require_once('../config.inc.php');
$bui...
I have a program which exports the data directly from Cassandra to mongodb.It works fine But, It doesn't copies the counter type column from Cassandra to mongodb. It leaves it as blank.
My data in Cassandra Table :
public class CassExport
{
static String keyspace = "query";
static String ta...
The case: Somebody posts code for review then follows up with all the analysis and some of the answers is accepted.
The suggestion: Some kind of finalization post by the dev who is asking the question which is the corrected/final implementation according to all proper suggestions and analysis.
...
I have the method.
public void AddNLogConfigurationTypeTagret()
{
var filePath = _loggerModel.file_path_pattern.Replace("\\YYYY\\MM\\DD", "");
var dateTime = DateTime.Now;
filePath += "\\" + dateTime.Year + "\\" + dateTime.Month.ToString() + "\\" + dateTime.Day;
...
I have a dialog that houses 6 security questions and 6 security question answers.
I want to pass the data the user selects and enters from the view to the controller to save the data in session. Right now, the code works perfectly but it is a mess. I am passing 12 arguments to my controller act...
