Sure Magnus. Here are the steps I have followed till now to setup my gerrit. 1. Created a mirror on AWS with AOSP 5.1.1_r3 branch 2. Added the review in default.xml to facilitate the code reviews. Now i am working on 3. Creating a separate branch other than -b android-5.1.1_r3 to facilitate our developers to work upon and push their changes — Brijesh Somu22 secs ago
I want to move the functionality from my cellcontentclick to be when a combobox's index changes.
private void dataGridView1_CellContentClick(object sender, DataGridViewCellEventArgs e)
{
if (cboQuantity.Text == "1")
{
tempn = 4;
}
if (cboQuantity.Text == "2")
{
tempn = 5;
}...
Here is my code:
#include <stdlib.h>
#include <stdio.h>
int sum(int *arr, int size) {
int sum = 0;
for (int i = 0; i < size; ++i) {
sum = sum + *arr;
arr = arr + 1;
}
return sum;
}
int sumx(int *arr, int size) {
int sum = 0;
for (int i = 0; i < size; +...
I Need to check your views on following.
I have a grid which has a calculated columns. The calculation is done using (Col A - col B) / SomeLabelAtTopofPage.Text
Question - Is it a good practice to have these calculation done in the grid declaration? (I personally do not like it, I like to keep ...
@Mast Is it considered bad habits do do it anyway? I've done it before where calling the script was actually the problem, not the script itself. But the implementation was technically broken since it didn't work as expected.
I'm working on a small library to help me format numbers easier as my current project deals with a lot of them.
I know the standard way of doing things with rjust() is:
print '{:.2f}'.format(123.456).rjust(10, '.')
# ....123.46
However with the library I'm working on, I want to be able to jus...
I have voted to keep closed this question. The comment of 200_success clearly state: Ensure that there are no trailing empty spaces in each line you print. — Heslacher6 mins ago
I am making an eCommerce web application using Laravel 5 framework.
I have created a Categories controller for the administrator where he can Add / Delete / Update / Delete Permanently the category(ies).
I want to know whether the created controller matches the standards ? If it doesn't, then h...
I need to change some array values in a 2-dimensional array for some cases. Sometimes the all values from an child array and sometimes only some values.
In this cases I should only change the variable $stamm which $stamm2.
My short old code:
$array[0][0] = $array[0][2] = $array[4][0] = $array[4...
Maybe. I suggest that instead of asking in hypothetical generalities, you post a question on Code Review with a concrete use case that solves a real problem. Then we can evaluate whether your approach is appropriate. Please read How to Ask first to make sure that you post the right kind of question. — 200_success16 secs ago
This code has to be run many time and in each round I want to process a certain row that is between start_a and start_b. the problem is the select statement is not correctly run? could you help me pls
for i=1:num_round
sqlquery='select * from IP_logs where rowid>=',num2str(start_a)'AND rowid<='...
@fayyazkl No idea, sorry. The git config diff.renames option is only used when computing the diff to display it, not when committing or pushing, so if you want it to be effective it should be added to the code review system... which is probably a bad idea in the general case. IMHO, you should just explain why this shows up this way in your PR, and hope that the reviewers understand how renames work in git... — Schnouki1 min ago
Is there any restriction as to what languages are allowed in SE chat rooms? I have seen many people speak in German, Russian or French in the English Language & Usage chat room, but whenever I speak in Persian (to a friend who understands me), some people start nagging that I should only speak in...
> I could see making exceptions to this in a few (specific and hopefully rare) scenarios, but by and large we're not set up to support moderating conversations in languages that the moderators, the SE staff, and the majority of users on the site do not understand. When there's any doubt as to the appropriateness of a conversation (for instance: it gets flagged) and it can't be understood, it should be deleted.
I want to collect my users data as array. Below you can find my ruby script.
h = {}
a = [["user_3", 765], ["user_1", 2], ["user_1", 1], ["user_2", 124],["user_1", 3], ["user_2", 223], ["user_2", 334]]
# Expected output :: {"user_3"=>[765], "user_1"=>[2, 1, 3], "user_2"=>[124, 223, 334]}
a.each ...
Let me first review this from an readability point of view, then answer your question and an proposed solution.
Naming
Your variable names could be more descriptive.
$array -> (maybe) $conjugations (german: $konjugationen)
$stamm -> $word_stem (german: $wort_stamm)
$zeiten -> $tenses (german:...
I am learning how to do object-orientated programming in JS. In particular, I am learning about the constructor pattern.
In an attempt to exercise what I have been learning, I made this:
var assert = require("assert");
var Book = (function() {
// Private static variable (why this exhibits...
@Nobody Thanks for answer. My script have already many lines. Unfortunately I think I can't change it the way you suggest it. It's a pity, because I want to use the script later for other languages, too.
Please provide more context surrounding this piece of code if posting it on Code Review. Code Review does not like code that has been stripped of context. — Simon André Forsberg28 secs ago
I have done the following to establish a connection with the DB...
private static IDbConnectionProvider CreateSqlConnectionProvider(DbConfig dbConfig)
{
return
new QcDbConnectionProvider(() =>
{
SqlConnectionStringBuilder csBuilder = new SqlConnectionStringBuilder();
...
@user2210535 I think Code Review is probably the best place for your question. I suggest you provide more context in your question though, include the HTML for example. — Simon André Forsberg1 min ago
Some university folk used JDOM as a test case on wwhich to build a commit-testing performance-monitoring subject.
> In the end, we found out that we were able to confirm lot of the assumptions about performance but there were also cases where the assumptions were not met, i.e. the developer thought that the commit improved performance while the opposite was true.
i have a simple c# mvc client that calls an external api..here is my attempt
public class ProductController : Controller
{
private readonly IProductService _productService;
public ProductController(IProductService quizService)
{
_productService = quizService;
}
pu...
It's probably more related to human psychology than anything else... people know their code has problems, just don't want to put it down in black&white
in a wayu that makes them seem.... OK. I am supposed to be doing things that have low probability of success, it's expected that I will not accomplish everything... yet, I still can't (easily) admit it.
@rolfl: I can relate. I am currently writing a summary report for my research lab and listing the failures made me rewrite part of the code. It was the same with my Bachelors thesis.
It's not failure if you definitively establish that some approach does not solve your problem — that's a successful step on the way to finding a viable approach. (If you didn't learn anything either way, that would be failure.)
Your code crashes when the length of the string is 0 or 1. That makes it a failure. Since the most important property of code is to be correct, and you made your code incorrect by doing a pointlessly complicated loop and getting it wrong, you failed. I leave it up to you to find the bug.
And it...
from Remove Nth Node from End of Linked List:
Bug: n < 0 leads to you removing the last node.
Your solution should have comments: I have NO idea how it works. And
that's after reading it a couple times. If this was production code,
I'd have wrapped it with unit-tests, thrown the impl...
The first thing I would have done in accomplishing this task is probably something very big that really cost you.
Each row in the table should contain: wiki title, wiki url, wiki thumbnail image
One of the absolute first things I would have done would be to create a class to represent the...
Also, I don't go out of my way to be nice to bad code...
I believe everything here could have been a comment, if written with a different tone, and that this doesn't actually review the code any more than saying, it's broken. — Lyle's Mug42 secs ago
I want to move the functionality from my cellcontentclick to be when a combobox's index changes.
private void dataGridView1_CellContentClick(object sender, DataGridViewCellEventArgs e)
{
if (cboQuantity.Text == "1")
{
tempn = 4;
}
if (cboQuantity.Text == "2")
{
tempn = 5;
}...
Here is my code:
#include <stdlib.h>
#include <stdio.h>
int sum(int *arr, int size) {
int sum = 0;
for (int i = 0; i < size; ++i) {
sum = sum + *arr;
arr = arr + 1;
}
return sum;
}
int sumx(int *arr, int size) {
int sum = 0;
for (int i = 0; i < size; +...
I Need to check your views on following.
I have a grid which has a calculated columns. The calculation is done using (Col A - col B) / SomeLabelAtTopofPage.Text
Question - Is it a good practice to have these calculation done in the grid declaration? (I personally do not like it, I like to keep ...
I'm working on a small library to help me format numbers easier as my current project deals with a lot of them.
I know the standard way of doing things with rjust() is:
print '{:.2f}'.format(123.456).rjust(10, '.')
# ....123.46
However with the library I'm working on, I want to be able to jus...
I am making an eCommerce web application using Laravel 5 framework.
I have created a Categories controller for the administrator where he can Add / Delete / Update / Delete Permanently the category(ies).
I want to know whether the created controller matches the standards ? If it doesn't, then h...
This code has to be run many time and in each round I want to process a certain row that is between start_a and start_b. the problem is the select statement is not correctly run? could you help me pls
for i=1:num_round
sqlquery='select * from IP_logs where rowid>=',num2str(start_a)'AND rowid<='...
I want to collect my users data as array. Below you can find my ruby script.
h = {}
a = [["user_3", 765], ["user_1", 2], ["user_1", 1], ["user_2", 124],["user_1", 3], ["user_2", 223], ["user_2", 334]]
# Expected output :: {"user_3"=>[765], "user_1"=>[2, 1, 3], "user_2"=>[124, 223, 334]}
a.each ...
Let me first review this from an readability point of view, then answer your question and an proposed solution.
Naming
Your variable names could be more descriptive.
$array -> (maybe) $conjugations (german: $konjugationen)
$stamm -> $word_stem (german: $wort_stamm)
$zeiten -> $tenses (german:...
I am learning how to do object-orientated programming in JS. In particular, I am learning about the constructor pattern.
In an attempt to exercise what I have been learning, I made this:
var assert = require("assert");
var Book = (function() {
// Private static variable (why this exhibits...
I have done the following to establish a connection with the DB...
private static IDbConnectionProvider CreateSqlConnectionProvider(DbConfig dbConfig)
{
return
new QcDbConnectionProvider(() =>
{
SqlConnectionStringBuilder csBuilder = new SqlConnectionStringBuilder();
...
i have a simple c# mvc client that calls an external api..here is my attempt
public class ProductController : Controller
{
private readonly IProductService _productService;
public ProductController(IProductService quizService)
{
_productService = quizService;
}
pu...
Your code crashes when the length of the string is 0 or 1. That makes it a failure. Since the most important property of code is to be correct, and you made your code incorrect by doing a pointlessly complicated loop and getting it wrong, you failed. I leave it up to you to find the bug.
And it...
from Remove Nth Node from End of Linked List:
Bug: n < 0 leads to you removing the last node.
Your solution should have comments: I have NO idea how it works. And
that's after reading it a couple times. If this was production code,
I'd have wrapped it with unit-tests, thrown the impl...
The first thing I would have done in accomplishing this task is probably something very big that really cost you.
Each row in the table should contain: wiki title, wiki url, wiki thumbnail image
One of the absolute first things I would have done would be to create a class to represent the...
