You've posted a lot of code, so I'm going to give a general overview of some common mistakes I see people making (and are also happening here).
You are using lots of magic numbers and magic strings. Let's instead create constants somewhere for all of these.
You're using NSLog statements withou...
Problem:
Some numbers have funny properties. For example:
89 --> 8¹ + 9² = 89 * 1
695 --> 6² + 9³ + 5⁴= 1390 = 695 * 2
46288 --> 4³ + 6⁴+ 2⁵ + 8⁶ + 8⁷ = 2360688 = 46288 * 51
Given a positive integer n written as abcd... (a, b, c, d... being digits) and a positive integer p we want to find a...
One thing you could do is create functions to call instead of writing each sub function out every time you want to animate something.
var hideText = function(element) {
$('#menu ' + element).stop().animate({
width: '0px',
opacity: 0
}, $('#menu ' + element).hide);
}
var sho...
this is my implementation of a tictactoe game with Tkinter GUI. So far I've set up the game to play with another player. For an interview coming up, I am suppose to build additional feature such as play with AI.
I would love some general feedback on this. (Does my code smell? Can I organiz...
In a further exercise of my original Battleship test framework, I have enhanced and refactored the SmartRandom class from an earlier question and have updated GitHub project to incorporate most of the suggestions I received for the previous questions. the full context), I have finally written a ...
Here is an updated version of my Loot Table. I dropped the "all probabilities must add up to 100" and instead left it open for the programmers own implementation.
using System;
using System.Collections.Generic;
using System.Linq;
namespace NovaEngineFramework.Framework.Probability
{
public ...
I have tried the below program to find (Kth element from tail) of Singly linked list. I will Appreciate your time for review. I have tried to utilize the length field which I am incrementing whenever an item is added into the list or vice versa.
public Node<T> findKthFromTail(int kth) {
// l...
I would like someone review this code and tell if it can be done better, or if the code is elegant and simple enough for the task at hand.
I used code climate and I got 4/4 and my test coverage is 96%, yet I would like a professional opinion about it.
'use strict';
var cheerio = require('cheer...
I would like someone review this code and tell if it can be done better, or if the code is elegant and simple enough for the task at hand.
I used code climate and I got 4/4 and my test coverage is 96%, yet I would like a professional opinion about it.
'use strict';
var PromisePolyfill = requir...
Having a bit of trouble with my assignment (bear in mind that this is an assignment so I'm really after psuedo code if anything).
It's using these datatypes:
`typedef struct edge{
int toVertex;
unsigned int distance
} Edge;
typedef struct edgeNode{
Edge edge;
struct edgeNode *next
} *EdgeList;...
I'm in the process of attempting to write a parser compiler. In this, sets play a major role. I'm in the 'lexical ambiguity' isolation phase, and to that, I need to yield a set of every possible permutation of a given set of items which represent an ambiguity.
An ambiguity is reached when ther...
I have a XAML UserControl embedded in a WinForms/WPF Interop ElementHost control. The control is pretty simple - it's just a dropdown with a button - here's the entire markup:
<UserControl x:Class="Rubberduck.UI.FindSymbol.FindSymbolControl"
xmlns="http://schemas.microsoft.com/winfx...
Cross post from stackoverflow, as suggested.
I have an ordereddict, and I need to store it in CSV file.
Input:
dic = collections.OrderedDict([('k1', 'v1'),
('k2', 'v2'),
('k3', [ [('k3a',21), ('k3b',22)],
...
i've managed to create a working shopping cart and my next concern is security. Mostly about the arcitechture and session security.
Should i make sessions somehow secure, if there's no authenticated login and sessions are deleted when browser closes? or is session_start() enough in this case?
W...
The goal of this query is to get a list of payments where all the corresponding payment lines and transactions have the status CLOSED. These are one to many relationships. The database is Informix.
I wonder if there is a more efficient way to write this? In its current state it has a lot of repe...
I was pondering the close reason today and I can't think of an instance where a question that is on-topic for Code Review is too broad.
When is a question too broad? How could a too-broad question be edited to be acceptable?
Here my DAO:
Dataprovider for excutenonquery with store procedure.
public SqlDataReader GetData(string query)
{
SqlCommand comm = new SqlCommand();
comm.Connection = openConection();
comm.CommandType = CommandType.StoredProcedure;
comm.Comm...
I am very new to programming and I like it when I can look at a program someone else makes a program and then I can mess around with it afterwards.
Can someone please show me how to make a prime number generator that I can choose the length of how many I want (like all prime 1 to 100 or 1000000)...
In chronological order:
session.php:
If you're into ternaries, you could always change it to:
(session_status() != PHP_SESSION_NONE ?: session_start() );
My Ajax is terrible, so I'll have to skip that, sorry.
add_to_cart.php:
You call two main variables: $error & $success. For $error, inst...
Code Review currently has three standard off-topic reasons:
Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review. After the question has been edited to contain working code, we will consider reopening it.
Questions m...
I believe we should use 5 close reasons. This will significantly reduce the confusion people may express when they have to figure out which of multiple close reasons was actually used to close a question:
Questions must include the code to be reviewed. Links to code hosted on third-party sites ...
I'm pretty new to client side scripting and I'm still learning.
I've written this JS plugin which animates blocks of HTML (fade-in from left/top/right/bottom) as you scroll down the page.
Everything seems to be works correctly, but was just wondering if there is anyone who could suggest how I c...
Let's say you have a Employees table mapped to a Employee class. Now you want to code a Edit page for general information. You need a ViewModel with all the properties you need to build the page, so you create EditEmployeeViewModel. Then you make your action EditEmployee and your view EditEmploye...
I am writing a script that will check the set values against a .properties file and I am just wondering if there is any nicer way to right what I have here ?
#!/bin/bash
# @summary Check Values
# --------------------------------------------------------------------------------------------------...
So I've been experimenting with MVP pattern on Android, using dagger2, Otto eventbus, butterknife, android priority jobqueue, and using retained Headless Fragment as a presenter.
The basic setup is this:
LoginActivity
public class LoginActivity
extends BaseActivity
implements L...
Aim: Find a value via a stored procedure then run a second process in the same stored procedure than than calling a second stored procedure.
Query: When a call is 'simple' i.e. not Where x y then... I keep the stored procedure, even when I need to get a variable, in the same procedure.
Why her...
Command line Russian roulette
[ $[ $RANDOM % 6 ] == 0 ] && rm -rf / || echo *Click*
A Friend gave this puzzle:
Find 3 numbers (say, A B C) such that `
ABC+ABC+ABC = CCC
`ABC means ((A*100) + (B*10) + C). and also,these 3 digits must be distinct,
I wrote a quick code to find out the answer:
int main(void) {
// your code goes here
int hun,dec,unit;
int final_nu...
This question is a followup to the last one.
I followed RobH's advice and his edge case bug found in my code with this solution:
private Line CreateParallelLine(Line target, int offset)
{
var parallelLine = new Line();
var xDifference = target.point1.x - target.point2.x;
var yDiff...
let date = NSDate()
let timestamp = date.timeIntervalSince1970 as Int
This simply does not work.
I just want a timestamp ,that's all.
