Factors::calculate() can be sped up by: casting sqrtInt to an integer type for-loops shouldn't increment towards a floating-point value incrementing towards an integer value is faster and proper starting the loop counter at 2 or 3 (if integer is even or odd respectively) fewer increments m...

I kind of like flagging obsolete comments. I have infrastructure I've built around flagging obsolete comments. Like, 50,000 row MySQL db's and queues and things. I flag so much that I was the main reason behind this feature request. It all is very, very good at finding the obsolete comments - bu...

So I'm trying to find the path of actors from an input actor to Kevin Bacon, via the Requests library and TheMovieDB API. I'm almost there. I've traced the input actor's ID, list of movies casted in, and all the actors in all of those movies. Except now I have to repeat that process, and My cod...

Wanted some opinions on something I have been working with, I've tried a few ways of structuring the way I retrieve and return data to my WebAPI, and I'm pretty happy with what I have so far, but I was looking for a comparison of the pro's and con's of using models vs entities for returning data ...

I've tried to improve the speed of my query in MySQL, but when condition IN clause happens too often, the query runs very slowly. Can anyone help me optimize the query? EXPLAIN SELECT bi.syouhin_sys_code AS syouhin_sys_code ,dwh_syo.name AS syouhin_sys_name ,dwh_syo.code AS syouhin_co...

Ruby is fundamentally more about simplicity (readability) than about time/memory efficiency. Otherwise you should choose another language. There are such high level languages, that can beat Ruby, like for example Javascript. And even Python handle strings faster than Ruby at the cost of eternal p...

Is _header.html.erb part of the layout? If so, i would advice you to move this logic to helper, if not all the controllers would need to set the @towns instance variable. module ApplicationHelper def town_names Town.all.collect(&:name) end end And in your view call the town_names. I th...

Well, I tend to agree on at least one count - this one is an eye-sore! Here are my 2 cents on what you need to do: Break your code into following files: config.rb: If you spend some time looking at open-source projects out there, you'd notice that almost all applications separation configurati...

This would be a start: Sub bindTableToControl(table as DataTable, _ control, _ Optional textField As String = "Name", _ Optional valueField As String = "Name") control.DataSource = table; control.DataTextField = textField; ...

This is a school project that I am turning in late. The prof suggested that i somehow prove myself by improving upon the basic code. This is really tough to do for someone who is just starting to learn to code. Is there something I can do to: add onto the code (have it do or ask something di...

I have a form that I feel I am overcomplicating because of the relationship between models that are involved. Can you let me know if there's a more elegant solution to what I have? (for reference) The form ultimately looks like this: The relationship between the involved models: user_relati...

One of the first things that you can to do improve the HTML is to remove the <br /> tags, and to replace the <label> tags with <span> tags. Labels in HTML should only be found in forms. To achieve the same effects that the line break tags gave you, you can use CSS with semantic class names (e.g....

I've change my data structure, so that the Huffman encoding procedure defines the combinations I need to test: class Node(object): left = None right = None weight = None data = None code = '' length = len(code) def __init__(self, d, w, c): self.data = d ...

Not answering your actual question, but offering a couple of code comments: use cd -- "$(dirname -- "$0")" if the script is in the PATH and someone just enters the script name, you will try to cd to the (probably non-existant) "script name" directory in the current dir. use grep -q $DEVICE ...

if time_slices[current_time_slice] == nil time_slices[current_time_slice] = Hash.new end It's more idomatic to write time_slices[current_time_slice] ||= {} In general don't use Hash.new if you can just write {}. You can rid of that statement alltogether though if you declare the time_slice...

You should be able to prevent casting to a string 100 times. First create all strings in a cell array, then just loop over the strings. Though it does not show up on the profiler, this looks higly dubious: i=num2str(i) ubs_str(i)=i/100; Now you will get the character code of 'i' and divide...

I attempt to create a reusable and scalable Cron Wrapper in PHP. I'm at the begining of the project and I wanted have some tips/ critics / improvments to make before going too far. The final objective is to have a complete cron wrapper which allows to lauch : 'one-shot' task (like huge DB exp...

Thanks to a question over at Code Review I got into a little disagreement (which essentially is an opportunity to learn something) about what exactly the Cyclomatic Complexity is for the below code. public static void main(String[] args) { try { thro(); thro(); thro()...

A number of questions have come up recently where the code is not the asker's own code, prompting a 'close' response. It would be convenient if there was an 'off-topic' close option that included: off-topic because the code you want reviewed is not your code. See the help (item 2) for on-topi...

There are two related items which I feel could be the cause of your problems, but I would have to see your code running to prove it. Still, it appears you may have 'stumbled' on the 'worst case scenario' for java.util.* ..... LinkedList. Unless you really need fast performance for head-insert, o...

You should absolutely use isEmpty(). Computing the size() of an arbitrary list could be expensive. Even validating whether it has any elements can be expensive, of course, but there's no optimization for size() which can't also make isEmpty() faster, whereas the reverse is not the case. For exam...

Metrics like the cyclomatic complexity are only useful when taken in the context of your code. For example, your retrieveHistory() method has numerous calls to JSONObject where it could throw a JSONException. Each of these calls adds one to the complexity (or should do). On the other hand, I thin...

Our main chat room is currently called Code Review General Room, with "General discussion about Code Review." for a description. I propose The Zombie Hunter's Lounge, but I'd like the community to post their ideas here (1 per post, include why it's the best name), the one with the highest number...