The 2nd Monitor

Hosch250

23:00

Lots of new people lately.

TanMath

I had a question for @Quill...how important do you think PEP8 is?

Hosch250

Very.

Mast

@Hosch250 It's at 100 now.

Hosch250

It really helps with readability.

@Mast Good.

Mast

@TanMath I agree with @Hosch250 it's very important. In Python, it's one of the most important rules.

Although I've seen companies relieving themselves of the 80 character limit.

Hosch250

23:01

I don't agree with everything, but for most of it, I do.

Mast

That ^^

Hosch250

Also, I don't think it is too bad if just a couple rules are broken, but your code is clear and readable.

TanMath

@Quill didn't make a big deal about my code not being in PEP8 format...

Mast

And the parts I don't agree with there are other parties who do. If I want my code to be readable for them as well, I'll still comply with the full PEP8.

Hosch250

Only PEP8 fanatics would complain at that point.

TanMath

23:02

@Hosch250 you sure? cause in the h Bar they were making a big deal my code is not in PEP8...

Mast

And new users are often given the benefit of the doubt. Unless you want to be scrutinized fully.

We can and will do that.

@TanMath h Bar?

Hosch250

@TanMath Depends how many, and which, rules were broken.

@Mast Physics chat, I think.

TanMath

yes... physics chat

@Hosch250 they were making a big deal about the import *

Mast

Oh, yes, that's quite bad practice.

Hosch250

Yeah, you should only import what you need.

TanMath

23:04

gist.github.com/TanMath/93f5f7b8b4f7dccd00aa

Mast

@TanMath That's not a CR question.

TanMath

@Mast that is the code we are discussing but...

Mast

@Hosch250 Or at least import x as y, so you don't pollute the namespace.

Hosch250

If you have a good reason, like you would literally have to import every module anyway, you should make a note of it.

TanMath

here is the question if you really need it:

1

Q: Open quantum system modelling

I have been working for a long time now on modelling an open quantum system using the Lindblad Equation. The Hamiltonian is the following: However, two other matrices are added to the Hamiltonian. One of them has all the diagonal terms equal to -33.3333i and everything else zero. Another is a ...

Hosch250

23:05

At that point, though, you should probably split the file up.

Mast

Oh, yea, 3 counts of import *

Quill

@TanMath correctly following PEP8 is a given in Python for most people, but I figured you'd rather hear about the how to work on the massive execution time rather than syntax

Mast

That would instantly raise red flags here.

TanMath

@Quill i know.. but see hereL

Quill

@TanMath however, in future, to check your code against PEP8 for most but not all of the PEP8 points, you can use PEP8Online

Mast

23:06

@TanMath Closed as off-topic.

TanMath

@Mast i know, so?

Mast

@TanMath That makes it explicitly off-topic at Code Review

You make it work, we'll scrutinize it.

TanMath

in The h Bar, yesterday, by DanielSank

A few other notes, @TanMath the code doesn't even adhere to basic python style guidelines. Many experienced (i.e. potentially helpful to you) programmers won't even begin to look at code that doesn't adhere to basic style rules.

@Mast I KNOW!

Mast

@TanMath And that's where they're wrong for Code Review. We'll take awful code, as long as it runs.

Runs as intended.

If it doesn't work as intended, we don't do it.

It doesn't have to be pretty, but it does have to work.

TanMath

@Mast so it is not a big deal here?

Mast

23:09

@TanMath As long as it runs.

TanMath

ok...

Mast

There are a couple of 'how to post a good question' questions on our meta as well.

11

A: Checklist for how to write a good Code Review question

Simon's Guide for posting a good question There are a lot of questions that appear on Code Review, and all questions are fighting for reviewer attention. This is a non-exhaustive list of items that I am looking for in a Code Review question when determining whether or not I should review it and ...

41

Q: How to get the best value out of Code Review - Asking Questions

I have a project I am working on, and I would like some, or all of it reviewed, how can I ask for this review on Code Review in a way that produces the best possible value? This is not about a question being on-topic, or off topic. Rather, this is about making on-topic questions great qu...

discussion faq asking-questions

Quill

@Mast we had a large conversation on this yesterday

Mast

Etcetera.

TanMath

It seems that DanielSank won't help until I fix the PEP8 or something...

Quill

23:10

Search PEP8 on Google and read it

TanMath

And he doesn't believe the problem with the code is the physics

Mast

@Quill That's not constructive.

@TanMath If you make it work, we'll make it shine.

Hosch250

python.org/dev/peps/pep-0008

Mast

But you need to make it work.

Quill

He had a like 3 hour execution time so he couldn't debug, and thanks to @Phrancis he got it down quite a bit

Mast

23:11

Perhaps with the work of SO, but we don't do in broken code.

Quill

Can an RO move this to Maths Is Hard please

Mast

Don't.

It's about what's on-topic on this site and what is not.

Site business.

TanMath

yeah... we should have been talking in Maths is hard

Mast

Anyway, I was just about to leave.

TanMath

@Mast I disagree... It is mainly about my code... Maths is hard is the room for hard...

@Mast bye then!

Mast

23:13

If you got your code working, feel free to ping me. It looks interesting.

Quill

Catch ya later @Mast \o

TanMath

@Mast sure!

Mast

@Quill Hah, nobody catches me.

4

Quill

Because you're the gingerbread man?

TanMath

@Quill what is your experience with physics...

Gustavo6046

23:18

I'm back for a short time.

Mat's Mug

@Quill no, an OutOfMemoryException

or StackOverflowException. Either can't be caught

Gustavo6046

or CodeReviewException? lol

If it were then it would be more topical for the 2nd... :P

DJanssens

Personal reminder for @JeroenVannevel: FOSDEM! :D

To all others: Evening!

Jeroen Vannevel

I've been getting my chrome reminders of it on a weekly basis

I've set the next reminder for tomorrow

DJanssens

Haha, I thought so, just wanted to make sure :D

Simon Forsberg

23:28

bah, I just had an off by one error...

Gustavo6046

no-badword-room

Just my guess...

Simon Forsberg

@Gustavo6046 Brainfuck? Nah. Java/Groovy

Gustavo6046

I am feeling bad for those that didn't use Brainf*ck just because of the name :/

Simon Forsberg

I'm feeling happy for them.

2

Gustavo6046

Fun fact: I never used Brainf*ck so the statement I just said shouldn't be starred.

Quill

23:37

It's pretty cool, good for studying stacks if you don't know much about them, I guess

Simon Forsberg

Fun fact: I knew you never had used Brainf*ck.

Gustavo6046

^^ I guess

Simon Forsberg

If you would have tried to do even a simple thing in Brainfuck, such as printing "Hello World!", you would have understood.

Jeroen Vannevel

so many overwhelming fun facts

Simon Forsberg

Did I miss the fun fact fest?

@Quill Good for studying stacks? I'm not sure about that...

Quill

23:41

well better than nothing

or maybe not, actually

it is brainfuck after all

Beko

hello

is this part of CodeReview?

Captain Obvious

-1

Q: Exchanging substrings

How do you replace a substring of one variable with a substring of another variable in java? ` for (intCount = 0; intCount < intlength; intCount++){ strSubstring = strHidden.substring(intCount2, intCount2 + 1); strword2 = strWord[intRand].substring (intCount2, intCount2 + 1)...

java

DJanssens

Hi @Beko. Yep

Beko

Thx. I have a question to ask. Let me explain

DJanssens

Go ahead :)

Beko

23:52

I'm currently in some kind of dip, not knowing what to do, so instead of doing nothing I decided to program a Tic Tac Toe game and see it through

I kind of have an idea of where I want to go

- start with pvp

- add artificial intelligence

- make a GUI

- refine the design, etc

as for the question

DJanssens

Sounds like a solid plan

Beko

I'd like to have my code reviewd after each step ...

is it OK to provide the code in form of a .zip?

DJanssens

Well, CodeReview is aimed for reviewing code that works.

I believe you can still review after each step and provide a link to the previous question you made in each iteration to keep track.

However perhaps @SimonForsberg better confirms that

I wouldn't use a .zip

Beko

hmm ok

I thought the text might get too long

DJanssens

You should try to show as much of the code as possible. You might add a github page for extra information.

Beko

23:56

ok, I guess I'll have to learn to use github as well then

DJanssens

That's definitely not time wasted ;)

GIT is awesome

and extremely useful.

Beko

Should I use it from the console, or from Eclipse?

DJanssens

BTW, this seems to be the rule: Your question must contain code that is already working correctly, and the relevant code sections must be embedded in the question. Please avoid stripping out key details that may be relevant to the review.

Beko

Ok, thanks. That's good to know

DJanssens

You can use both. Eclipse normally has some fancy/easy way to do it if you manage to setup the plugin

Beko

23:58

So basically I'll have to provide it all :D

DJanssens

I'm used to doing it in the console.

Beko

I should probably learn that first

DJanssens

try.github.io/levels/1/challenges/1

If you got 15 spare minutes, you can learn git ;)

Beko

Yeah, I'll get right into it

Thanks for your help

Transcript for