The 2nd Monitor

I just now updated with a question at the bottom.

This question is ugly:

-1

Q: Binding data to class

I wrote a simple string parser and few implementation came to my mind by I am unable to weigh them. First Implementation struct ParsedData { int version; string protocol; string address; // some more fields } class DataParser { private: ParsedData _parsedData; public: DataParser(); ~DataParse...

12:22 PM

Okay , sorry my bad, close the question. I thought I could ask conceptual question. Thanks anyways. — user1566277 21 secs ago

What gave him that idea...

And "unclear" close vote would also work here.

@nhgrif Python.

@nhgrif Indeed.

I mean, in general, this is one of the biggest reasons why I hate comparative reviews.

So many good reasons to choose from.

Users forget to benchmark their questions often enough, on comparative they almost never benchmark.

For a comparative review question to be okay, we have to start with two pieces of code that take identical inputs and produce identical outputs, for them to be different approaches at the problem, and then you have to define what "better" is

And at the end of the day... what value is there in the comparative review, really?

Your criteria for better is usually going to be something measurable, like speed or memory.

In which case... here isn't the place for measurement requests.

Go to Stack Overflow and find out how to benchmark code, then benchmark your code, and you have your answer.

12:27 PM

Comparative is usually for people who don't know what they want. Which is a problem.

And when it's not something measurable, it's something like "readable" or "maintainable"

Which... two separate implementations doesn't make sense really... and the readability or maintainability shouldn't be the deciding factor between two drastically different implementations, not really.

If the speed is around the same, I think those two are great factors.

If all other factors are the same, then perhaps.

But I don't think that makes for a very great Code Review question.

Because ultimately, it's asking "A vs B". It's a "yes"/"no" question, which isn't good for the Stack Exchange format.

@nhgrif While that's true, it's often asked and considered on-topic anyway.

It's only considered on-topic by some.

There are several of us who consider comparative review off-topic.

I don't vote to close every comparative review, because it'd be a wasted effort.

12:30 PM

Perhaps we should take it to meta for scope.

It's been done, several times.

I think there already is a meta...

But I encourage you to go find one of the posts and add your two cents.

It often leads to code understanding instead of review, which is another problem.

I don't really agree that that's a problem

Or rather, I don't think it's a problem for answers to spend time helping people understand code.

But if that's done in place of an actual review, then yes, that'd be a problem.

But actually, I think I see your point...

A comparative "review" can easily distract from an actual review happening.

12:35 PM

@Dee codereview, as the name suggests, is for asking people to suggest improvements to your code style/structure/correctness, while SO is strictly for problems that you're struggling with while programming — goncalopp 1 min ago

If we just posted CodeA, then CodeA would get reviewed.

If we post CodeA & CodeB, then we'll spend a lot of time explaining why CodeA is better than CodeB.

We may or may not even make any improvements on CodeA.

Indeed.

It would turn Code Review into Code Selection

No more reviewing.

I mean, in fairness, there are only 181 questions tagged comparative-review.

and there's stuff like this: codereview.stackexchange.com/q/98787/36366

Which isn't even a real comparative review...

The second set of code isn't even the authors...

@nhgrif VTC'd.

yea, I was writing a custom reason right now

I'm voting to close this question as off-topic because the author is not actually seeking a review of his own code. Instead, we're being asked to compare the author's code to someone else's code and tell the author which set of code to use. The author appears completely uninterested in improving his own code (he'd rather just use the other code if it's better). — nhgrif 8 secs ago

Hmm.

codereview.stackexchange.com/revisions/98787/2

@EthanBierlein is the one who edited in the other set of code..

12:44 PM

@nhgrif He pasted the content of the link in the question.

Something which is frowned upon by some and acceptable by others.

I know. Is Ethan legally capable of doing that? Stuff posted to SE is automatically put under CC-by-SA copyright.

Would it be worthy of a specific-question meta? There is so much wrong with that question, the edits and the author's intent.

Q: Rails - DRY similar methods?

If you want your code reviewed, re-ask your question on codereview.stackexchange.com. Please check their help center for guidelines on how to format your question before asking. Specifically, you should include the code in the question itself rather than linking to it. — Matt ♦ 33 secs ago

Captain Obvious

0

In order to reduce redundancy in my app, I have added the method self.find_or_keep(object) to many of my models in order to find existing records with the same values, so I can reference the already existing ones instead of creating new records. Basically, what the method does is checking most at...

ruby-on-rails

So, I've made one commit to my current project and already eliminated an entirely file.

12:52 PM

@nhgrif I'm not even sure, this bit: "Just now I found a math.SE answer. This answer do not discuss anything about gradient/slope technique. Why?" seems completely off-topic.

Eventually, I'll be adding files, because they have such big do-everything classes, but I'll also be eliminating unnecessary files along the way.

@nhgrif I would assume, that, by the blockquote it would have some special attribution? Perhaps when he posted that code he should have included the attribution to the source of it instead?

Everything on SE is under CC-by-SA. Adding any sort of attribution doesn't change that, and adding any other copyright notice is just confusing (and not even wholly applicable necessarily).

And unless Ethan is the original author of that code or somehow related to that code in a way we don't understand, he doesn't possess the legal right to put it under SE's CC-by-SA most likely.

Even if we roll all the way back to the original version of the code, it's just this guy's code, a link to the other code, and a request to compare.

So even at that point, I think the question is still off-topic anyway.

I didn't say it wasn't off-topic, just that I would assume quoting another's code in blockquotes would have some impact on the license.

No.

1:00 PM

It's as if I quote someone else's blog, and drop it in blockquotes and say something like, "According to x's blog: ..."

Sure, but...

All that does is potentially bring you into compatibility with the original license the code was put under.

I mean, the blockquote should imply that SE has no control over the license for that particular code.

No...

That's not how licenses work.

The block quote just puts it under compatibility with the original license (potentially, not even guaranteed... but best case scenario, that's the most it impacts)

If I quote someone else's code on my blog/whatever and indicate where it came from, it does not fall under the license of my blog.

It still goes under SE's CC-by-SA.

@EBrown Yes it does.

1:02 PM

Prove it.

Because I've seen time and time again where that is false.

In the form you posted it (which includes the attributions)

(The blog part)

No, all you've seen is that you don't understand licensing.

Posting it with attribution is okay because almost all licenses allow for copy with attribution

All that does is prevent you from violating the original license it was posted under.

That's all.

And in that sense: if you are really going to show code to receive comments on it .. why not turn to codereview.stackexchange.com? — Jägermeister 41 secs ago

It's like if you make use of some library that's open source.

1:05 PM

codereview.stackexchange.com — Andrey Deineko 1 min ago

Well, libraries are slightly different since they're different files

Regardless, the license that the site that code comes from is: creativecommons.org/licenses/by-nc-nd/2.5/in/deed.en_US

But if you copy-pasta'd some code into your library

In that case, then, maybe @EthanBierlein could legally copy it in here (with attribution) because that license is open.

That license does stipulate Non Commercial and No Derivatives as well.

I think the link to that site counts as the attribution bit.

The point is that no matter what license it is under, it didn't come from SE, so it's not SE's license, it's not the question author's license, and it's not Ethen's license.

1:09 PM

yup Kira i hear you. Will post a seperate question on codereview stackexchange as it is not allowed to be posted on SO — vignesh 21 secs ago

Also, this bit: "Just now I found a math.SE answer. This answer do not discuss anything about gradient/slope technique. Why?" bothers me.

Q: How to create a nested class when subclassing

@EBrown when it comes to licenses, I encourage you to know, not think. And when it doubt, don't copy&spare into another license (or at all)

Keep in mind that your profitability to any employer lies in code you can write that can be licensed.

Captain Obvious

0

I'm wanting to create a pair of classes. The second of the pair sub-classes the first, is nested within the first, and only has the addition of being an Enumerator. Like so: MyClass # this is the parent class MyClass::Enumerator # it has an Enumerator which...

ruby

Q: WIFEXITED always returning 1?

@vignesh No. This would be off-topic on Codereview.SE as the code is not working. — Ethan Bierlein 51 secs ago

Captain Obvious

-1

I am testing the WIFEXITED to see if a child process exited abnormally or normally, according to documentation, it should return non 0 status for a child process that terminated normally. However, I on purpose created a code which makes SIGSEGV on a child to test for WIFEXITED (this is or should...

c

StackOverflow

1:20 PM

1

Q: Git: How to protect develop/master branch in git-flow (from rookies) via access control?

The previous days I read https://www.atlassian.com/git/tutorials/comparing-workflows/forking-workflow to which I have a a question. If one uses the Feature Branch or the Gitflow Branch Workflows in a project: Is there an option that a user pushes a feature branch as a tracking feature branch to ...

git code-review access-control git-flow

@CaptainObvious off-topic

A: Desktop notifications for queue items

@Malachi:

0

This is mostly personal preference, but, I usually stack the @matches in descending size: // @match *://*.stackexchange.com/review* // @match *://*.stackoverflow.com/review* // @match *://*.superuser.com/review* // @match *://*.serverfault.com/review* // @match *://*.askubuntu.com/review* // @...

Donald.McLean

@nhgrif Closed.

monking

hey I will take a look at that in a minute @Quill I am adding another set of memes to Memer

@Malachi Cool! Which set?

1:28 PM

scifi

oooh

okay maybe not

Why's that?

I might let someone who is better at regex and manipulating statistics surrounding English usage handle that

because they are like ideas and not a simple phrase, the meme can have many many different forms.

Perhaps ping @IsmaelMiguel in the JavaScript room and get his regex skills to help you

2

1:36 PM

thank you @RubberDuck

Oh wow. That's what I get for writing code at 4AM... I suggest you take a look at the full context of the code and score some more rep there with an answer based on your first paragraph. Anyway this is a very educative answer here, thanks! — Mat's Mug 42 secs ago

Phrancis

SELECT 'Monking!' AS [Greeting];

While you can omit the radix argument from parseInt, MDN doesn't reccomend omitting it. — Ethan Bierlein 1 min ago

@EthanBierlein: recommend

Thanks for the comment, though!

@Phrancis hello

1:53 PM

@Quill have you installed that Desktop notification script?

@Malachi I can't

I have a bunch of plugins that rewrite the review page

and I already have a plugin that does notifications for post score changes, comments, achievements and messages

Ethan Bierlein

@Malachi Do you plan to add the desktop notifications script to the Chrome web store?

Simon Created the Base, but my version is slightly different, I guess I could

Ethan Bierlein

Chrome automatically disables the script even when I force it to turn on for a session.

@EthanBierlein why?

@EthanBierlein I run it in tampermonkey

@Quill is this what you meant document.title = 'Desktop Notifications - ' + document.title.split(' - '); ?

or this

1:55 PM

Tampermonkey or greasemonkey run it fine

document.title = 'Desktop Notifications - ' + .split(' - ');

@Malachi Neither

 var title = document.title.split(' - ')[1];
 document.title = 'Desktop Notifications - ' + title;

^ Is what I meant

Anyone care to answer a "what would you do in this scenario" question quick?

@EBrown Code related, or life related?

Work/code.

1:59 PM

Sure, shoot

@Quill I see!

Nevermind, I just answered it myself as I was typing it out...lol

RubberDuck

You're welcome @Malachi.

This might be better asked in codereview.stackexchange.com — pete the pagan-gerbil 59 secs ago

The problem, @Quill, is that I have a page in two folders in this project for work that is literally an exact copy of the page in the other folder. Like the only difference is a namespace name. Whenever I update code in one page (either, it doesn't matter), I have to update code in the other page.

It's required by a government agency as part of our product ordering process.

SirPython

2:04 PM

@Duga It looks like the question is about design, not code.

"Really I was looking for a bit of advice on how I can design the database according to what I have mentioned above?"

This question probably belongs on CodeReview as the OP wants a review of working code. — Micke 13 secs ago

The only difference between the two is the namespace.

I was trying to decide if I should find a way to merge them or not.

The underlying problem is that if I merge them I have to redirect users back to whichever site they came from on the merged page.

Phrancis

@SirPython I got that one :)