On the other hand, I would still not quite like moderating on SO. Have you seen that close queue?!?
@retailcoder: The first half seemed easy, and the last half hardly seemed doable. I wasn't going to pass this class anyway. Better luck next time (if I take this class again).
Can someone please tell me why r in downRight is always going up to 5 when I have said to record it's value as soon as downRight is given a value?
A = 5 16 18 4 9
9 10 14 3 18
2 7 9 11 21
3 7 2 19 22
4 9 10 13 8
for r = 1:5
if isempty(normal) == 0;
normal = s...
@Jamal just don't do what I did - I couldn't get calculus through my skull, dropped out. Now I regret it. (and I still couldn't get calculus through my skull)
@Jamal Yes I have seen that close queue. A couple of months ago I spent all my close votes every day trying to make it shorter. I've given up on that by now.
It'd take many people working on the queue at once to surpass the crap coming in at the same time. Even then, the queue will keep growing since it's such a large site.
@retailcoder: Am I being paranoid, or are we becoming the next Programmers (back when it apparently was a dumping ground for off-topic posts)? Many SO users already have sent off-topic code here, yet we don't do the same.
@Jamal I see it as a good sign: more and more people see us as a destination. It's only a matter of time until they realize we're a destination for what exactly.
@Jamal If you are paranoid, then I might be paranoid with you. I also feel like CR has gotten a whole lot of Off-Topic stuff recently. Feels like they are too afraid to post on StackOverflow (or even can't post there because of being question banned) and so they come to the friendly CodeReview community instead, hoping that someone can help them here (before their question gets closed).
I do understand the SO thing, but I still don't use it as an excuse to post off-topic questions. I also cannot tell if they're banned on the other site, so I just have to make assumptions based on their posts. We certainly don't have to be arrogant, but we still need to follow the rules. SO may be snarky at times (something I'd reserve for spam or zero effort), but we shouldn't follow suit. Even if the user is disappointed about being sent back, so be it.
@rolfl Not sure what effect your answers have on those posters. Hard to tell what causes what. But if they get a response once, I guess they are more likely to return.
@Jamal here's an example of a question that is off-topic, but was well worth a review none-the-less ... a case where you can still review a broken question:
This is a copy of a posting I made on SO, it was suggested I post it here all I've changed from that post is I'm now doing the bitwise AND using a decimal number rather than using bindec("111") to create the mask. The output is identical.
I have a 32 bit number represented as a HEX string that I...
I meant in the way the question is structured, not the state of the code. But yeah, it seemed like a good time to review that code anyway.
@SimonAndréForsberg: I still fail to understand how anyone would recommend another site without first reading that site's Help Center. Imagine if such users one day became moderators, having the ability to migrate questions to any site.
As I see it the question boils down to:
Is the code more readable in one of the two versions?
IMHO the version where the increment happens in the head of the for is more readable, because that is where you would expect increments to happen.
Another bonus is that there is a guarantee that t...
I'm trying to figure out jquery still and in my attempts I'm trying to figure out not only how to use various thing but why, I haven't tested any of this so not even sure it works; however, with jquery it seems like there is an unlimited number of ways to approach everything, so what's the best m...
@Jamal I think I suggested someone somewhere asking on programmers, I got a comment by another used saying to read the about page for the site before suggesting something like that. Since then I have learned. Unfortunately, everyone is a beginner some time.
@Malachi: Regarding your comment on my answer: The rationale to put the increment into the head was exactly for the reason that it is more robust towards changes in the body's control flow
of course this assumes that the increment should in fact be independent of the body's control flow
so this is my code and I just want to improve it, I'm a beginner so I think there are some better and short ways to do what I did here. Any Ideas?
The code:
class Table:
def __init__(self,path,sep):
self.path=path
self.sep=sep
self.g=[]
self.count=0
self.headlines=[]
...
you should not increment a variable that is not declared in the Declaration of the For loop.
that said, you could do it like this
for(int x = 0, int count = 0; x < max_x_index; x++){
for(int y = 0; y < max_y_index; y++, count++){
{
some2DarrayRepresentedBy1D[count] = ...;
}...
@Nobody, I didn't read the entire answer, I apologize for that.
@retailcoder, you know there is a way that you can change the name of the room, so that it shows up with that title?
@Nobody I am a really shallow, frivolous person... and I tend to be sarcastic and abrasive... it's just my nature .. ;p (you're not my boss, are you? I've heard she's started checking out SE sites and oneday I am going to make a joke that goes over wrong).
I'm trying to write a simple game. I have an Entity object, that has a list of Sprite objects. Each Sprite has a position property where it is drawn on the screen. Sometimes, an entity can contain a lot of Sprites in which case it is much easier to set the position property on the parent Entity.
...
The principle of least astonishment (POLA/PLA) applies to user interface design, software design, and ergonomics. It is alternatively referred to as the rule or law of least astonishment, or the rule or principle of least surprise (POLS).
A textbook formulation is "People are part of the system. The design should match the user's experience, expectations, and mental models." What is least surprising may however depend on the expected audience, e.g. end users, programmers or system administrators.
In more practical terms, the principle aims to exploit users' pre-existing knowledge as a way...
I don't mean what button do you push to select an answer - I know how to do that - but does it even make sense to select an answer to a code review question? Is there even such a thing as a correct answer on this site?
From my experience, the nature of a code review (e.g. this site) is completel...
@All I took the liberty of adding some of our "personalities" to the list of memes. Feel free to remove yourself if you don't want your identity to be known :P
Coming from an imperative background, I have written the following code in Scala. I need to attempt to find a value in a map. If the value exists, I need to pass the value to another function and return the result, otherwise I need to return None.
def foo(index: Int): Option[FooBar] = {
val ...
I am trying to create a class about birds with a few different methods. This is just theoretical code. Is there anything that is inherently wrong with the code from a syntactical or semantics point of view? If so, please fix.
class Bird(object):
def __init__(self, Height, Weight, HasFeathe...
I am trying to re-factor (Improve design of existing working code) with following principals.
Switch statements removal.
Encapsulate Field
Extract Class
Extract Interface
Extract Method
Extract Subclass
Extract Super Class
Form Template Method - Before
Move Method - Before
Introduce Null Object...
@retailcoder Wouldn't it make sense for this guy to use relative positioning on the inner sprites? Since I'm rep-maxed for today, there's no use for me in posting an answer :P (C# is not my best subject either, as you know...)
I am trying to re-factor (improve design of existing working code) with the following principals:
Switch statements removal.
Encapsulate Field
Extract Class
Extract Interface
Extract Method
Extract Subclass
Extract Super Class
Form Template Method - Before
Move Method - Before
Introduce Null Ob...
@Malachi practical star on your (theoretical star) on @retailcoder's (theoretical star)
You have no idea how much I would love that. To be honest, considering I've only ever learned Java in his particular class, I'm very interested to know what I'm being taught versus what I should be being taught. Makes me wonder. — JohnZ3 mins ago
The context is the weekend challenge ( poker hand ).
Hand.prototype.isStraight = function()
{
for( var i = 1 ; i < this.cards.length ; i++ )
if( this.cards[i].value + 1 != this.cards[i-1].value )
return false;
return true;
}
cards is a an array with card objects { suit : "x" , va...
Well for what it's worth, your review was far more helpful than any other feedback I've received in class. I will definitely be using CodeReview more often. — JohnZ5 mins ago
I'm still taking my sweet time on my Blackjack game. Specifically, I'm working on a more object-oriented version, with my new deck class. My first attempt at the game was bad. I'm tempted to throw out that code.
@Corbin weekend-challenge #2 wasn't very specific - as long as your code evaluates a Poker hand, it could be tagged with it (albeit it's a little late for weekend-challenge)
gotta love the first line being "using namespace std" lol
i typically did the assignments for this class the night of, and it shows lol
i need to find some recent C++ to post. i'm actually pretty curious to get a review. i have an info retrieval project i might post snippets of when i get a chance to clean them up.
Haha. Still, I'd rather have my new code reviewed, when it's completed. For this code, I'm okay with getting Loki's WTFs/minute. Let me go find that comic strip...
Eh, depends on the project, @Nobody. The longer projects, yes, certainly. But the projects that are one-off algorithmical programs... eh. There's a fine balance of "oh shit! shit shit shit! I have to get this done in 2 hours!" and design.
@Jamal your C++ classes didn't use OO at all? interesting.
This is one of my Haskell solutions to a variation of the N-Queens problem, where the queens can move like knights in addition to their normal moves. It has been optimised somewhat to avoid investigating redundant permutations.
place :: Int -> [[Int]]
place 0 = [[]]
place n = go $ take n $ repe...
codereview.stackexchange.com/a/37082/7308 that's rather interesting. i tend to have a "eww gross!" reaction any time i see bit ops in anything but low level code, but that's pretty damn clever.
I had to take two different stats courses - one for my AA (class was mostly business and psychology majors) and one for my BS (the serious version of stats for people in CS and Math).
I think universities use Java because there are certain kinds of intrinsically hard-to-debug errors that are more difficult to make in Java (compared to C++).
I've used both and I gotta tell you, debugging memory allocation errors is absolutely no fun at all.
yeah, universities' use of java definitely makes sense. i just hate that's often overhyped as some kind of magical language by universities.
there's definitely a value to getting down in the nitty gritty though for really understanding how computers work. but at the same time, CS degrees can often be highly theoretical and how exactly a computer works at a hardware level might be irrelevant.
I need to dynamically import Python source modules from a given directory.
I can't just use importlib.import_module or __import__, because it's a black box and I need to do some source-code-rewriting. On the other hand, I feel the PEP 302 Import Hooks to be overkill for what I'm trying to do (th...
@Corbin At least universities doesn't overhype jQuery
@Donald.McLean I think I saw a video where something was made with APL. I think it was Conway's Game Of Life or something similar. Seemed incredibly powerful, if you know how to use it...
In this case bit-wise manipulation is your friend .... (as it often is...)....
I believe the following solution makes the combination/permutation expense a 1-off setup problem, and using the Integer.bitCount(...) makes it almost trivial ...
The code I hacked up appears to have a time-complexity...
My Game class has a property of type Player, which inherits from Entity:
player = new Player( "knight.png" );
It also has a property of type World, which has a collection of Entities (Robot inherits from Entity):
world = new World( new List<Entity>
{
new Robot( "guy_1.png" ),
new Robo...
I need to dynamically import Python source modules from a given directory.
I can't just use importlib.import_module() or __import__(), because it's a black box and I need to do some source-code-rewriting. On the other hand, I feel the PEP 302 Import Hooks to be overkill for what I'm trying to do...
I started a chess in python for fun. i learned python on my free time but i've been doing it for a while. The code works but i just want to know if there's anything non-pythonic in my code. The functions calculate all potentially possible moves ( ignoring game state). Any advice is much appreciat...
@rolfl I will, but I have to make it more readable. It was the code I posted yesterday for that Code Golf challenge, so everything is kinda condensed and hard to understand.
C is like Java in that it is a programming language.
I have a simple algorithm that I'm using for code golf, and I'm hoping to find ways to golf it further. The algorithm is somewhat golfed in Python already, and works flawlessly. I asked on meta.codegolf.SE if a question about it would be on topic there, and per the discussion, the community think...
I'm confused! What questions are on-topic for this site?
Simply ask yourself the following questions. To be on-topic the answer must be yes to all questions:
Does my question contain code? (Please include the code in the question, not a link to it) Did I write that code? Is it actual code from a project rather than pseudo-code or example code? Do I want the code to be good code, (i.e. not code-golfing, obfuscation, or similar) To the best of my knowledge, does the code work? Do I want feedback about any or all facets of the code?
Can someone please tell me why r in downRight is always going up to 5 when I have said to record it's value as soon as downRight is given a value?
A = 5 16 18 4 9
9 10 14 3 18
2 7 9 11 21
3 7 2 19 22
4 9 10 13 8
for r = 1:5
if isempty(normal) == 0;
normal = s...
As I see it the question boils down to:
Is the code more readable in one of the two versions?
IMHO the version where the increment happens in the head of the for is more readable, because that is where you would expect increments to happen.
Another bonus is that there is a guarantee that t...
so this is my code and I just want to improve it, I'm a beginner so I think there are some better and short ways to do what I did here. Any Ideas?
The code:
class Table:
def __init__(self,path,sep):
self.path=path
self.sep=sep
self.g=[]
self.count=0
self.headlines=[]
...
you should not increment a variable that is not declared in the Declaration of the For loop.
that said, you could do it like this
for(int x = 0, int count = 0; x < max_x_index; x++){
for(int y = 0; y < max_y_index; y++, count++){
{
some2DarrayRepresentedBy1D[count] = ...;
}...
I am trying to create a class about birds with a few different methods. This is just theoretical code. Is there anything that is inherently wrong with the code from a syntactical or semantics point of view? If so, please fix.
class Bird(object):
def __init__(self, Height, Weight, HasFeathe...
I am trying to re-factor (Improve design of existing working code) with following principals.
Switch statements removal.
Encapsulate Field
Extract Class
Extract Interface
Extract Method
Extract Subclass
Extract Super Class
Form Template Method - Before
Move Method - Before
Introduce Null Object...
The context is the weekend challenge ( poker hand ).
Hand.prototype.isStraight = function()
{
for( var i = 1 ; i < this.cards.length ; i++ )
if( this.cards[i].value + 1 != this.cards[i-1].value )
return false;
return true;
}
cards is a an array with card objects { suit : "x" , va...
This is one of my Haskell solutions to a variation of the N-Queens problem, where the queens can move like knights in addition to their normal moves. It has been optimised somewhat to avoid investigating redundant permutations.
place :: Int -> [[Int]]
place 0 = [[]]
place n = go $ take n $ repe...
In this case bit-wise manipulation is your friend .... (as it often is...)....
I believe the following solution makes the combination/permutation expense a 1-off setup problem, and using the Integer.bitCount(...) makes it almost trivial ...
The code I hacked up appears to have a time-complexity...
