« first day (366 days earlier)      last day (3495 days later) » 

00:00
RELOAD!
[Cardshifter/HTML-Client] 1 commit. 151 additions. 249 deletions.
[retailcoder/Rubberduck] 3 commits. 366 additions. 85 deletions.
[Vogel612/TranslationHelper\‌​] 2 commits. 18 additions. 11 deletions.
00:14
@SirPython cool, it's quite easy you'll see, just really handy for making nice graphical layouts without having to reinvent the wheel
 
9 hours later…
09:39
hey
10:31
Another new idea for a mod: Let the player choose if they want to use "Taunt" ona minion or not, this might not even be relevant though if all minions have by default taunt
Maybe some kind of "Taunt counter" you can put on a minion (maybe at a certain cost?)
And one with highest counter needs to be attacked
10:45
Funny that I just realized that in HearthStone my decks are pretty much all kinds of random stuff thrown together, without a real theme in them
 
2 hours later…
12:53
Hey
hey everyone!
Hello, @Marc-Andre!
@Marc-Andre Hey how you been man?
@Phrancis I'm great thanks! My holiday were amazing! I'm feeling so good at the moment. It's a shame they were not longer but well what could I do :P
And you all? How have you been ? And Hello @SirPython!
@Marc-Andre Good, got a new job starting next Monday! And with @SirPython's help, we are starting on a browser-based GUI for Cardshifter, thought you might find that interesting :)
13:02
@Phrancis Yeah I've seen it added on GitHub but did not take the time to check it ! I've done no work at all for the past 2 weeks!
@Marc-Andre Hahah :)
@Marc-Andre Have you used jQuery much?
So I'll check it today at work :P That's what work is for right ? :P
@Phrancis Felicitations pour ton nouvel emploi! Je suis content pour toi!
Merci :D
Enfin on va me payer pour travailler sur des BD ;)
13:05
@Phrancis Ohh nice ! What type of company is it ? And what is your "title" ?
@Phrancis I've worked with it but I'm rusty :P
@Marc-Andre Software dev for home-based healthcare providers. Stack is mostly C# (they also have a Java team for Android mobile versions). The title is called "Software Technician" but it's very vague title. In the interview they asked tons of SQL questions and told me they needed someone with good DB understanding, so I fit the bill pretty well
@Marc-Andre Simon suggested jQuery could be good to use in part because it would let us assemble and insert/move/remove elements from pages "live", a bit like the Java controller system you made for the site but more dynamic
@Phrancis If we make a full-fledged web client with html, JQuery with not be enough IMO.
That might be the case. We are very early in the process, so options are wide open now. You're welcome to post any ideas/suggestions on the issues page :)
If we can make a decent, functional text-based web client for now I think it will be a step in the right direction. Then, we can start making UI elements and things like that
yeah I'll have to check it out ! I'm not super good in web yet too! So I guess we will see and post a bunch of CodeReview questions and hope konijn start to be active again
He's the JavaScript master isn't he? :)
13:15
Yep!
Last seen Jul 21 at 15:07
and May 4 was his latest post
@Phrancis I am almost finished with the problem I mentioned 19 hours ago. I should be able to resume work on the client afterwards.
Oh @Marc-Andre, we came up with an interesting game concept of a self-upgrading card which works
But for now, TTGTW :|
Nice :D
I'll jump back in here in a bit
Good thing is I can do JavaScript/HTML from work, so I'll play around some more with web client soon hopefully ;)
@Marc-Andre Starting new job next Monday, for now I'm in documentation mode at my old job, teaching all those newbies how to do basic data processing with Excel and stuff; fun.
I'll likely be able to give advice on the website once it's so far into development taht there's no point in changing it anymore :D
13:36
There could be a point in changing it, we always need to look at the technical debt when we see something that could be better.
The way I see it, the web client is our chance to make the game feel like a real game, so the more eyes we have to look at it and help, the better it will be
Jul 26 at 17:29, by Lokkij
So yeah, what do I think is the most important for cardshifter right now? Definitely the UI. Better UI --> better play experience --> more interest in the project and quicker/more fun playtesting
Indeed it is ! The JavaFx is well not suitable to be played by casual gamers!
Come on, SSRS... so damn slow :\
one more week @Phrancis!
:P
13:54
Let's hope they don't use worse systems at your new job ;)
Well, probably won't be getting away from SSRS, but at least I'll be able to write my own queries, instead of having to wait for someone else's queries to execute
@Duga you still alive?
Yay... then
14:54
github.com/Cardshifter/HTML-Client/blob/master/server_interface/… that file has some big lines which make it hard to read IMO
15:34
@Phrancis Maybe @Duga doesn't like you ;-)
@Marc-Andre Any lines in specific?
return "UseAbilityMessage [id=" + this.id + ", action=" + this.action + ", gameId=" + this.gameId + ", targets=" + this.targets.toString() + "]"; @Marc-Andre like that one?
yep like that one
@Phrancis That one was mostly entirely copied directly from the Cardshifter source. This could be split into multiple lines, however.
Indeed and end-line comments make it scroll too.
Like line 86
15:36
I did plan on re-organizing the API a little bit, just for the messages to be in a more practical order, so I'll do that at the same time
How's this?
return "UseAbilityMessage [id=" + this.id +
							    ", action=" + this.action +
							    ", gameId=" + this.gameId +
							    ", targets=" + this.targets.toString() + "]";
(minus the excess whitespace)
@Marc-Andre There aren't any comments on line 86.
Perhaps you mean 89?
var protocolAddon = (wsProtocolFinder.test(server) ? "" : "ws" + secureAddon + "://"); // if the protocl is not found in the string, store the correct protocol (is secure?)
[Cardshifter/HTML-Client] SirPython pushed commit 979f2bc3 to dynamic-page-allocation: made some toStrings more readable
@Marc-Andre Would you suggest to put the comment on it's own line, or to shorten the comment?
@Phrancis lol, so @Duga is still there
15:45
@SirPython Well I don't know what I would do ! It's just an impression about the length of line code!
Be back later!
@Marc-Andre I see. I apologize for asking.
Merge conflicts, will have to fix from home
[Cardshifter/HTML-Client] SirPython pushed commit aae3b55e to dynamic-page-allocation: moved long comments to their own lines
@Phrancis Should we copy the documentation from the Cardshifter source code into the server API file?
15:51
@SirPython From source API to JS API? If so, yes, we should
There seems to be only one message type with documentation.
So far, yes, I've only been able to write it for login message
For the others, for now perhaps just leave a link in comments to the original message in the source cpde, and we can update the docs as we move along.
Wow... cats must be evil
(I know, random comment)
@skiwi It looks like the cat in the cabinet is laughing at the end.
@SirPython Does JSDoc follow more or less the same syntax as JavaDoc, as far as you know?
15:58
@Phrancis I don't think I've ever used JSDoc before (sadly), but I think for the most part it does. I will do some quick research on it.
Read this.
messageTypes: {
    /**
     * Login message from Client to Server.
     * <p>
     * A login message from a client to add a user to the available users on the server.
     * This login message is required before any other action or message can be performed between a client and a server.
     *
     * @param   username  the incoming user name passed from client to server, not null
     * @example Message:  <code>{ "command":"login","username":"JohnDoe" }</code>
     */
    LoginMessage: function(username) {
@SirPython ^^ Something like that I think would work OK
I completely agree. That's what I had put down originally.
Super
@SirPython Are those message functions in the API all constructors?
Or are they calling the constructors in the Java API?
They are all constructors that correspond to the constructors in the Java source.
OK. Go ahead and include the @constructor tag as well then in the docs
16:13
Update LoginMessage.java

Clarified docs, removed @author tag
[Cardshifter/Cardshifter] build for commit 8e72e258 on api-documentation: The Travis CI build passed
Update RequestTargetsMessage.java

Add JavaDoc
[Cardshifter/Cardshifter] build for commit 63a66686 on api-documentation: The Travis CI build passed
16:33
@Phrancis Okay. I've finished that side work. Would you like me to start copying the JavaDoc over to the JS API file?
@SirPython If you want to, sure. Documentation is good to get out of the way early, IMO
Update ServerQueryMessage.java

Add JavaDoc
[Cardshifter/HTML-Client] SirPython pushed commit 6ff542e2 to api-documentation: added doc to LoginMessage and RequestTargetsMessage
@Phrancis Hows this ^^?
@SirPython No need to apologize, it's a good question! I just don't have an answer to it!
@SirPython Almost perfect! Can you please change Constructor to the @constructor tag? (JSDoc differs from JavaDoc in that regards, it looks like)
16:43
@Marc-Andre Ah, I misinterpreted the "!'s.
Well you'll get use to it :P I always use ! :P
[Cardshifter/HTML-Client] SirPython pushed commit 67761f15 to api-documentation: changed Constructor. to @constructor
Urgh, GitHub keeps messing up the indentation!
I set it to 4 in the editor, and it changes it right back in a second.
@SirPython Using the web client or console?
16:45
I'm editing in a JSFiddle tab (because there are some troubles with my VM) and pasting into GitHub.
[Cardshifter/Cardshifter] build for commit 214fe22a on api-documentation: The Travis CI build passed
@skiwi My cat was not evil at all. Cats in general have a particular way to express some emotions, but they are far from evil!
[Cardshifter/HTML-Client] SirPython pushed commit 57bcb651 to api-documentation: (hopefully) fixed indentation
nope...
Update StartGameRequest.java

Add JavaDoc
16:50
@SirPython I normally edit directly in the Github editor for indentation, seems to work OK...
@Phrancis If you have the chance, try fixing the indentation in that file. I'm outta luck today.
I think GitHub is changing the indentation of the file on the website (I'm really not sure). Just check that the checkout file has the correct indentation
[Cardshifter/Cardshifter] build for commit 296447de on api-documentation: The Travis CI build passed
I'm sure good cats exist aswell ;)
ahahah I can assure you they do exist :P
17:20
Update UseAbilityMessage.java

Add JavaDoc
[Cardshifter/Cardshifter] Phrancis pushed commit ae30cabb to api-documentation: Update UseAbilityMessage.java
@bazola Ping me then you're around. Got a question about TransformerMessage real quick
[Cardshifter/HTML-Client] SirPython pushed commit 54adc058 to api-documentation: copied some documentation
Oh so now the indentation works.
Real funny, GitHub.
@Phrancis sure whats up
[Cardshifter/Cardshifter] build for commit ae30cabb on api-documentation: The Travis CI build passed
17:27
@bazola That message class appears to be used to serialize messages to/from BYTE/JSON. I think I remember Simon saying that only libGDX uses serialized messages, can you confirm if that's correct?
yes I believe everything except libGDX uses JSON
[Cardshifter/Cardshifter] build for commit 7c0f285f on api-documentation: The Travis CI build failed
BUILD FAILURE!
> This doc needs to go with UseAbilityMessage rather than with TransformerMessage
@Duga Right, I forgot to skip that.
@Duga What now...
[Cardshifter/HTML-Client] SirPython pushed commit ba6ab234 to api-documentation: moved TransformerMessage doc to UseAbilityMessage
17:30
^^ Fixed.
@bazola So we probably could do away with this message entirely for the web client API then, do you think?
i would have to look at exactly what is calling it to say for sure. i can't really tell how that particular class is being used based on what i am seeing
@bazola OK. I guess we can leave it in for now, just in case
Update TransformerMessage.java

Add JavaDoc
[Cardshifter/Cardshifter] build for commit 6ca01ed7 on api-documentation: The Travis CI build passed
Update ChatMessage.java

Add JavaDoc
[Cardshifter/Cardshifter] build for commit ea6d4af8 on api-documentation: The Travis CI build passed
18:01
I think that Travis failure was an external issue with Travis, after looking at the report
[Cardshifter/Cardshifter] Phrancis pushed commit ee5c57be to api-documentation: Update ChatMessage.java
Update InviteRequest.java

Add JavaDoc
[Cardshifter/Cardshifter] build for commit ee5c57be on api-documentation: The Travis CI build passed
Update InviteResponse.java

Add JavaDoc
@SirPython If you get a chance, I think the JS API would need to have the 4 messages from api/both added. Don't know if you think those should be together in one file (with message sections documented)
@Phrancis The both messages are already there.
Oh. My bad.
No problem ;)
18:17
[Cardshifter/Cardshifter] build for commit 42222280 on api-documentation: The Travis CI build passed
[Cardshifter/Cardshifter] build for commit 46c56cc0 on api-documentation: The Travis CI build passed
Update PlayerConfigMessage.java

Add JavaDoc
@SirPython What about the client-bound messages from server? Do these need added to JS API?
[Cardshifter/Cardshifter] build for commit 1ed076da on api-documentation: The Travis CI build passed
@Phrancis I do not believe so: the server (as we know) is going to send the messages in the correct format, and the code (since we will write it ourselves) is going to access these as if they had the correct format.
@SirPython OK.
However, the API has messages for sending to the server because it makes it easier on the code.
18:25
@SirPython So that way we don't have to hard-code the JSON message string in the code right?
Exactly. Even if we did, I don't see how the code could benefit.
Update AvailableModsMessage.java

Add JavaDoc
@SirPython Gotcha
Although, if you find a use, please tell me.
[Cardshifter/HTML-Client] SirPython pushed commit 1d04ced2 to api-documentation: added the last of the documentation
18:29
@Phrancis Is this (^^) ready for a pull request, or are you still adding/editing documentation?
[Cardshifter/Cardshifter] build for commit ef52c4e1 on api-documentation: The Travis CI build passed
@SirPython Could you JSDoc your init and sendMessage functions, and perhaps just copy also the doc for TransformerMessage? I'd say after that it's good for a PR
Update AvailableTargetsMessage.java

Add JavaDoc
[Cardshifter/Cardshifter] build for commit cf0e06e1 on api-documentation: The Travis CI build passed
added doc and error handling

Added documentation for the TransformerMessage, and added documentation for the init and sendMessage methods. Upon writing the documentation for sendMessage, I realized that a potential error ould arise if the server had not yet been properly initialized, so I created a custom error NotInitializedException. Now thinking about it, there will probably be more errors in the future, like if the socket was not successfully created.
18:50
Hey, I've been reading through the docs under Documentation/ and found some things to fix, are you interested in a Jamalization of those files?
@jacwah Hey! You're welcome to fork it and make changes and submit a pull request. What branch are you looking at /Documentation, to be sure?
Update CardInfoMessage.java

Add JavaDoc
I checked out master on Github
I also ran into some bugs when trying to test the client
@jacwah Create some issues then.
18:57
@jacwah If you fork please do some from mods, that should have the most current doc
Ok, thanks!
[Cardshifter/Cardshifter] build for commit d6f2a778 on api-documentation: The Travis CI build passed
@jacwah I like to look at github.com/Cardshifter/HTML-Client/network to see where each branch is to have a good view of the project ;)
I see, so master is a release branch of sorts?
At least not for development
Master is the current "production" branch
19:03
^^
@Duga @Phrancis How does this look?
We don't update master very often, only on official releases. We update develop more often
@SirPython Looking now
@Phrancis You don't have a develop branch atm
@Marc-Andre We don't on HTML-Client yet, I meant for the main repo :)
oh
yeah indeed develop is the next release, the snapshot branch
19:07
Merge pull request #8 from Cardshifter/api-documentation

Added documentation to the message types
Does the card library language have a name?
@Duga ^^ @SirPython
@jacwah Um, not really. We just call it "the DSL" right now :)
Should it be referred to as that in the docs?
Well, that's not a bad idea at all. Perhaps we should call it "Cardshifter DSL" throughout
I can do that in my patch
19:12
Perfect
I think the docs are a bit unclear on the words properties, attributes and effects
Are attributes and effects types of properties?
Are modifiers a type of property?
Update ClientDisconnectedMessage.java

Add JavaDoc
@jacwah Good questions. Let me look at it again
[Cardshifter/Cardshifter] build for commit 7622cd01 on api-documentation: The Travis CI build passed
19:27
Looks like my intention was for [General] Attributes to apply to words that identify a card, then for Properties to be numbers or Booleans that are common for any card, and for Effects to be completely custom and applicable to that card alone
I'm certainly not against improving the way it is organized or worded, though, if you have better structure in mind
BBL, gotta give someone training at work
I don't know the DSL yet so I might come back to that later, right now I'm just editing as I read
Finally... it seems liek this HearthStone expansion is really going to open up deckbuilding
 
1 hour later…
20:51
And, back
@jacwah OK. The actual DSL code in the docs is what I am most diligent about, so I make sure everything that's in there works, and anything new is updated as we implement it
Update EntityRemoveMessage.java

Add JavaDoc
[Cardshifter/Cardshifter] Phrancis pushed commit da8c73cd to api-documentation: Update GameMessage.java
[Cardshifter/Cardshifter] Phrancis pushed commit da633211 to api-documentation: Update GameOverMessage.java
[Cardshifter/Cardshifter] Phrancis pushed commit fe8b28c2 to api-documentation: Update NewGameMessage.java
[Cardshifter/Cardshifter] build for commit 314960d6 on api-documentation: The Travis CI build passed
[Cardshifter/Cardshifter] build for commit da8c73cd on api-documentation: The Travis CI build passed
[Cardshifter/Cardshifter] build for commit da633211 on api-documentation: The Travis CI build passed
[Cardshifter/Cardshifter] build for commit fe8b28c2 on api-documentation: The Travis CI build passed
21:31
Update PlayerMessage.java

Add JavaDoc
[Cardshifter/Cardshifter] Phrancis pushed commit afaf94cd to api-documentation: Update ResetAvailableActionsMessage.java
[Cardshifter/Cardshifter] Phrancis pushed commit 01a23c78 to api-documentation: Update ServerErrorMessage.java
[Cardshifter/Cardshifter] build for commit c8dce18e on api-documentation: The Travis CI build passed
[Cardshifter/Cardshifter] build for commit afaf94cd on api-documentation: The Travis CI build passed
Update UpdateMessage.java

Add JavaDoc
Sorry for the spam, I'm nearly done
[Cardshifter/Cardshifter] build for commit 01a23c78 on api-documentation: The Travis CI build passed
[Cardshifter/Cardshifter] build for commit 6d18d13b on api-documentation: The Travis CI build passed
@Phrancis Have you changed all the docs?
@SirPython I'm just finishing going through the outgoing server message classes in the server API, only have a few more left
21:56
@bazola ^^ See the capitalization of gameId vs. gameid - Do you think this is likely to cause problems? AFAIK it's been like that the whole time... github.com/Cardshifter/Cardshifter/blob/api-documentation/…
no that won't matter
OK good
TTQW
 
2 hours later…
23:45
Mat's Mug vs. Simon André Forsberg: 387 diff. Year: +1277. Quarter: -227. Month: +51. Week: +74. Day: +45.
200_success vs. janos: 15540 diff. Year: -4060. Quarter: -1139. Month: -325. Week: -255. Day: -65.
Loki Astari vs. Simon André Forsberg: 2865 diff. Year: -2911. Quarter: -1315. Month: -15. Week: -20. Day: 0.
200_success vs. rolfl: 3061 diff. Year: +2315. Quarter: +2649. Month: +70. Week: +60. Day: +60.

« first day (366 days earlier)      last day (3495 days later) »