« first day (276 days earlier)      last day (3285 days later) » 
00:00 - 22:0022:00 - 00:00

10:08 PM
[Cardshifter/Cardshifter] build #898 for commit 04e9a435 on branch js passed
[Cardshifter/Cardshifter] Phrancis pushed commit 8f946118 to js: changed to
 
@Duga Eh, there goes my commit message :p
 
[Cardshifter/Cardshifter] build #899 for commit 6148e9ba on branch js passed
 
@Phrancis It shouldn't be like that.
 
Meant to read "changed denyCounterAttack: 1 to give: { denyCounterAttack: 1 }"
 
10:14 PM
but that's wrong
it should be denyCounterAttack: 1 for creatures
 
Ah, crap. Didn't realize that. How do I roll back the commit?
 
as it is already pushed, the best thing to do is to revert
there are some different ways
if you want to make it disappear from the git history entirely, use git reset --hard HEAD~1 (normally not recommended if people have cloned your branch, which no one has done so far)
otherwise, just undo the changes and make a new commit
 
[Cardshifter/Cardshifter] Phrancis pushed commit c1f5a83e to js: undid previous changes as they were wrong
 
OK easy enough to just undo, thanks for clarifying
 
[Cardshifter/Cardshifter] Phrancis pushed commit 8b289a74 to js: Added card information for creature cards. Issue #203
 
10:23 PM
@Simon does this read pretty good to you, so far?
 
is it really called POJSON?
> Determines the creature type of the card. The available types are explained below. If you wish for a new creature type to be created, please create a new issue and mark it with the "mod" label. Please be as specific as possible as to exactly how you want the new creature type to behave.
technically, there's nothing preventing modders today from adding new creature types simply by changing the string
 
> adding a new creature type is as easy as changing the string attribute. No need to create a new issue (unless you have a feature request for a specific ability that those creatures should have and don't know how to create the systems to implement that)
> all cards with a scrap value of > 0 can be scrapped, the creature type does not matter
[Cardshifter/Cardshifter] build #900 for commit 6148e9ba on branch js-load passed
> A create? typo
 
@SimonAndréForsberg lol, probably not.
Was mainly wanting a way to abbreviate it
 
[Cardshifter/Cardshifter] build #901 for commit 8f946118 on branch js passed
 
@Phrancis understandable. I think I would call them simply "JavaScript Objects" though
I added some comments on your commit, see @Duga above ^^
 
10:37 PM
[Cardshifter/Cardshifter] build #902 for commit c1f5a83e on branch js passed
 
OK
 
other than that it looks ok
 
[Cardshifter/Cardshifter] build #903 for commit 8b289a74 on branch js passed
[Cardshifter/Cardshifter] Phrancis pushed commit 81788d2c to js: Clarified some card documentation points
> this should probably say creatureType, and it is good to include the information about creature as well, because that is also needed.
> still one instance of POJSON, replace that with "JavaScript Objects" or similar
 
@Simon can you clarify what you mean by "it is good to include the information about creature as well, because that is also needed"?
 
@Phrancis let me know if you think I should edit things myself instead of complaining commenting
@Phrancis you removed the creature section. It is still required to have creature: true to define a creature
 
10:47 PM
@SimonAndréForsberg You're fine, it's less messy I think if we both don't make changes to the same file at the same time
 
@Phrancis ... YOUR NAME!!!!?
5
 
LOL
2
 
@rolfl HIS IMAGE!!!!? (still upside-down)
2
 
So @Simon... clarification... right now, the cards say creature: "Bio or whatever. According to your last chat comment, it should be creature: true, creatureType: "Bio"?
 
woops
I'm drunk apparently
you're right
creature: "Some type" is enough
apparently I don't know my own format
 
10:49 PM
So, as long as creature has some value, it will perceive it as a creature?
 
Ok, phew
 
Yeah one less person starting with the letter S :D thanks @Phrancis!
 
@Simon what file(s) should I look into to see the exact effect/trigger/action syntax, so I can document it?
 
10:57 PM
[Cardshifter/Cardshifter] Phrancis pushed commit 63e85b66 to js: Issue #203 - More clarifications
[Cardshifter/Cardshifter] build #904 for commit 81788d2c on branch js passed
 
@Phrancis those keywords are defined in the different keywords-****.js files. Their usage might not be very clear though
 
OK, I can probably figure it out. Should I add JSDoc as I go along?
 
> I don't find it very practical to have all the card JSON data into the main JSGame.js file. Is it possible to extract it to its own separate file?
> Apparently it is possible to have a creature with `-5` health in play. It isn't removed until it is dealt damage by something. This is not as it should be. Whenever a creature has -5 or less health, it should be removed.

Possibly use a form of `State-based actions` (MTG term) to scan for stuff like this
 
@Duga I am tempted at commenting "Yes" and then close the issue without taking any additional action.
2
 
11:10 PM
I can make commits too
2
 
\[[**Cardshifter/cardshifter.github.io**](https://github.com/Cardshifter/cardshifter.github.io)\] [**marcandregirard**](https://github.com/marcandregirard) pushed commit [**7f3a6e97**](https://github.com/Cardshifter/cardshifter.github.io/commit/7f3a6e97d2c318b211a70f11e3c0172b6fec8483) to [**master**](https://github.com/Cardshifter/cardshifter.github.io/tree/master): Merge pull request #49 from Cardshifter/update-css

Merge update-css into master
 
@Duga I've done nothing to deserve such a bad display of information :P
2
 
@Duga doesn't like \n apparently!
I suspect Mug and Ducky will be left in the dust today
 
[Cardshifter/Cardshifter] build #905 for commit 63e85b66 on branch js passed
 
@Simon Did the game logic pass the "use strict";?
 
11:35 PM
[Cardshifter/Cardshifter] Phrancis pushed commit b4db3062 to js: Added Enchantment info, issue #203
 
@Phrancis yup, absolutely
 
Awesome
 
[Cardshifter/Cardshifter] Phrancis pushed commit 8beb2fbe to js: Added JSDoc to keywords-enchantments
[Cardshifter/Cardshifter] Phrancis pushed commit dcab4fbc to js: resolved merge conflicts
 
I should probably start editing that .md file from Eclipse, so I'm not pushing commits from two different sources...
@SimonAndréForsberg Do you think we should go ahead then and replace var with let throughout?
 
Loki Astari vs. Simon André Forsberg: 3914 diff. Year: -1852. Quarter: -553. Month: -170. Week: -150. Day: -110.
200_success vs. rolfl: 331 diff. Year: -374. Quarter: -217. Month: +162. Week: +110. Day: +15.
 
11:48 PM
@Phrancis This is not a problem... you should just pull before making any change... since source control is exactly made for that : commits from two different sources... ;)
 
[Cardshifter/Cardshifter] build #906 for commit b4db3062 on branch js passed
 
@Phrancis No. That is not implemented. We need ECMAScript 6 for that.
 
[Cardshifter/Cardshifter] build #907 for commit dcab4fbc on branch js passed
 
@SimonAndréForsberg OK
####`noAttack`

Declares that a creature card cannot attack. Usage: `noAttack: 1`
I did not see the noAttack keyword anywhere in the JSON data. Coincidence, or am I missing something?
 
> It feels like these JSDocs really don't explain much... and keywords.cards.set is not a boolean, it is an object containing further information about what to set (resource and value).
 
11:55 PM
@Phrancis it's declared in keyword-noattack.js
 
Yeah that's the file I'm looking at. It is looking for attack: 0 perhaps?
 
I intend to separate such keywords more and more into their own JS files
keywords.cards.noAttack = function (entity, obj, value) {
shouldn't the Inside Man card have that property?
I think it has just disappeared away for some reason
 
> Error on my part, I will fix. I'm not sure what else to explain though, any recommendation just LMK and I will adjust as needed
> this should say addAttack
 
@SimonAndréForsberg Probably, could be that something was just overlooked. I'm guessing if attack: 0 is set, it should probably have noAttack: true as well right?
 
00:00 - 22:0022:00 - 00:00

« first day (276 days earlier)      last day (3285 days later) »