Funny though, that I have a project involving interfaces each with 10 implementations, a List class used in countless places, that this project would crash the previous resolver code and work 100% as expected with the rewritten one, ....while cls7.Foo resolves to some unrelated member in an unrelated class...
@rubberduckvba #Git integrated into the #VBA editor? Nonsense you say? No. It's real. Powered by @libgit2sharp
https://github.com/rubberduck-vba/Rubberduck/pull/669
because I hadn't explicitly excluded DeclarationType.Event from that method
it's basically picking up anything that's not a member - the intention was to pick up global variables, constants, enums, UDT's... but not events.
now there may be issues with that method still, because the resolver doesn't know if a class has a default instance or not, which makes a difference in how members are allowed to be accessed.
without the flag you need a Dim lst As New List declaration, to call it at instance level, like, uh... Set lst = lst.Create("foo", "bar") ...well that makes no sense, but you get the idea ;-)
so, moving on to that parameterized property shit
gets picked up as a member call as expected
c gets picked up correctly
(as Class5)
accessor is ContextAccessorType.AssignValue as expected, isTarget is True as expected
(that means resolver knows to look for Property Let)
[rubberduck-vba/Rubberduck]retailcoder pushed commit 2c03f0a4 to next: removed redundant ResolveIdentifier method; project-scope declarations now exclude event declarations, and member calls outside With blocks now resolve correctly.
I just realized that I already had committed my changes, and just needed to uncomment, so I copy/pasted from the current Next, and redid everything I'd undone: github.com/Hosch250/Rubberduck/commit/…
[Hosch250/Rubberduck]retailcoder pushed commit 2c03f0a4 to next: removed redundant ResolveIdentifier method; project-scope declarations now exclude event declarations, and member calls outside With blocks now resolve correctly.
private string GetReplacementLine(string content, string target, string newName, Selection selection)
{
// until we figure out how to replace actual tokens,
// this is going to have to be done the ugly way...
// todo: come back after the identifier references are fixed
//var contentWithoutOldName = content.Remove(selection.StartColumn - 1, selection.EndColumn - selection.StartColumn);
//return contentWithoutOldName.Insert(selection.StartColumn - 1, newName);
VBA Rubberducking
VBA Rubberducking