« first day (387 days earlier)      last day (2793 days later) » 

12:01 AM
RELOAD!
[Cardshifter/Cardshifter] 2 commits. 78 additions. 17 deletions.
[ckuhn203/Rubberduck] 6 commits. 812 additions. 175 deletions.
[rubberduck-vba/Rubberduck] 10 commits. 1 closed issue. 5 issue comments. 1214 additions. 353 deletions.
[skiwi2/BusinessSoftware] 2 commits. 53 additions. 1 deletion.
[Vogel612/TranslationHelper\‌​] 2 commits. 1 opened issue. 75 additions. 10 deletions.
 
@Hosch250 I do plan on inlining them that I know how to do it, but that's a good patch from the looks of it.
 
OK.
 
Can you make it modal too so the window doesn't get lost?
 
Modal?
Web says it is a sort of fabric.
I can set it to always be on top, yes.
 
THanks.
 
12:09 AM
Supper time, BBL.
Also, I'm assigning the Accept/Cancel buttons to their respective codes in the Properties.
And, there is a bug in New Branch, where the OK button isn't disabled at the beginning.
So, if you open it, then press OK right away, it will throw an exception.
 
[Hosch250/Rubberduck] ckuhn203 pushed commit 81bbc072 to next: exclude deletebranchform from coverage
[Hosch250/Rubberduck] ckuhn203 pushed commit be3b6a38 to next: Extracted common interface
[Hosch250/Rubberduck] ckuhn203 pushed commit 1caad283 to next: refactored to support, but did not implement, centralized error state notification #471
Merge pull request #660 from ckuhn203/sourcecontrol

Sourcecontrol - Clean up
[Hosch250/Rubberduck] Hosch250 pushed commit 02d5699f to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into next
[Hosch250/Rubberduck] Hosch250 pushed commit 30f35173 to next: Temp fix to block windows from being destroyed.
 
Supper, BBL.
Will patch the other issue afterward.
 
[rubberduck-vba/Rubberduck] build for commit 30f35173 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 30f35173 on ???: AppVeyor build succeeded
 
12:35 AM
@RubberDuck Mind if I ask you a question?
 
@Hosch250 of course not. What's up?
 
I found two options for ensuring the New Branch button is disabled when it is first opened.
First one is to set the OK button to disabled off the bat in the designer.
Second is to manually fire the event to update it when we show it.
Not sure which is more politically correct.
 
Either will work, but updating it will be more resistant against breakage IMO.
 
OK.
Then I'll submit what I have.
 
12:43 AM
[Hosch250/Rubberduck] Hosch250 pushed commit 57f33044 to next: Manually fire event to trigger OK button to turn off in Create New Branch
[rubberduck-vba/Rubberduck] build for commit 57f33044 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 57f33044 on ???: AppVeyor build succeeded
 
That was fast.
 
Yeah. I've noticed that it's been quick lately.
 
Maybe it started caching.
 
fixed.
 
problem was that I forgot to check whether the identifierName matches that of localScope before returning the result of FindFunctionOrPropertyGetter in FindLocalScopeDeclaration
@RubberDuck that's pretty nice
 
Thanks. It needs some tweaks, but I'm getting bleary eyed.
I think there's something wonky going on with switching branches though.
 
it just doesn't feel very WinFormsy - the idiomatic way would be to just pop a MsgBox
 
2:13 AM
Oh Shush!
 
lol
I think I'm ready to PR
 
Yeah. I'm rebasing and calling it a day.
 
[rubberduck-vba/Rubberduck] retailcoder pushed commit 158eaa93 to GrammarIsFun‌​: fixed parameter resolution in functions and property getters
[rubberduck-vba/Rubberduck] retailcoder pushed commit 551accff to GrammarIsFun‌​: fixed NullReferenceException in "copy inspection results to clipboard" feature
 
trying a parse+resolve of my monster MVP project for fun
 
[rubberduck-vba/Rubberduck] build for commit 551accff on GrammarIsFun: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 551accff on GrammarIsFun: AppVeyor build succeeded
 
2:16 AM
@Mat'sMug sick sense of fun
 
yeah
I'm somewhat expecting something to blow up anyway
there
 
I'd be surprised if something didn't.
 
it's a silenced InvalidOperationException due to a SingleOrDefault call matching more than 1 result
...but the interface listener is commented-out
I'll see if I can fix it
whoopsie, a NRE now
// localScope is a UDT
> except when it's not
// localScope is probably a UDT
var udt = ResolveType(localScope);
if (udt != null)
{
    callee = _declarations[identifierName].SingleOrDefault(item => item.Context != null && item.Context.Parent == udt.Context);
}
 
[ckuhn203/Rubberduck] ckuhn203 pushed commit 6cfe14aa to sourcecontrol: added collapsable split panel for displaying error states
 
2:25 AM
[assembly: AssemblyVersion("1.4.*")]
[assembly: AssemblyFileVersion("1.4.0.0")]
 
Not following
 
[rubberduck-vba/Rubberduck] build for commit 6cfe14aa on ???: AppVeyor build succeeded
 
@RubberDuck even grammar changes are in that commit. I know what happened. not sure why AssemblyInfo says 1.4, but that commit includes changes merged from GrammarIsFun.
 
2:29 AM
I updated the assembly info a week or so ago when we thought we were ready for 1.4
 
ok ok
 
[rubberduck-vba/Rubberduck] ckuhn203 pushed commit 6cfe14aa to next: added collapsable split panel for displaying error states
Merge pull request #664 from ckuhn203/sourcecontrol

added collapsable split panel for displaying error states
[rubberduck-vba/Rubberduck] build for commit 9fa53508 on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 9fa53508 on next: AppVeyor build succeeded
 
No idea what happened to that PR though... none.
Will figure it out tomorrow.
 
May 26 at 2:19, by Mat's Mug
can you merge that into GrammarIsFun? I'll pick up where you left off ;-)
wait no, not that
can't be that
...IDK
 
idk either.
1 min ago, by RubberDuck
Will figure it out tomorrow.
 
2:38 AM
            try
            {
                var parent = matches.SingleOrDefault(item =>
                    item.ParentScope == localScope.Scope
                    && !_moduleTypes.Contains(item.DeclarationType));

                return parent;
            }
            catch (InvalidOperationException)
            {
                // debug me
                return null;
            }
 
2:49 AM
ah, it's a parameterized property getter blowing up
both the getter and the setter have the same "scope" string, that's why SingleOrDefault is returning 2 matches
 
3:39 AM
ok I got a repro on the small-scale sandbox project
parameterized properties mess it up
I think my only option is to use localScope.Selection.Contains(item.Selection) to tell the property members apart.
and that worked
huge-ass project is now failing for another reason
it's triggering the ArgumentException I've set up in the main ResolveInternal overload, which means I have a bug
> 'ImplicitCallStmt_InStmtContext' is not an identifier context
named parameter is causing it
ah, missing a parameter, calling wrong overload
(again)
closing in
I have 2 classes (forms) that define a Private Type with the same name
Private Type tView
    Model As SqlResult
    Selection As SqlResultRow
    Callback As ICommandCallback
End Type
this is getting ugly
                return matches.SingleOrDefault(item =>
                    item.ProjectName == libraryName
                    && (item.Accessibility == Accessibility.Public
                        || item.Accessibility == Accessibility.Global
                        || item.Accessibility == Accessibility.Friend
                        || item.Accessibility == Accessibility.Implicit)
                    && (_moduleTypes.Contains(item.DeclarationType))
                    || (item.DeclarationType == DeclarationType.UserDefinedType
ladies and gentlemen, we have a resolver!
 
 
1 hour later…
5:25 AM
[rubberduck-vba/Rubberduck] retailcoder pushed commit 608a01d9 to GrammarIsFun‌​: major issues all fixed. doesn't resolve calls to default instance members ("static classes").
[rubberduck-vba/Rubberduck] build for commit 608a01d9 on GrammarIsFun: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 608a01d9 on GrammarIsFun: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 608a01d9 on GrammarIsFun: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 608a01d9 on GrammarIsFun: AppVeyor build succeeded
Merge pull request #665 from rubberduck-vba/GrammarIsFun

This should make 1.4 release-ready.
2
[rubberduck-vba/Rubberduck] build for commit af4736d1 on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit af4736d1 on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit af4736d1 on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit af4736d1 on next: AppVeyor build succeeded
 
uh...
 
[rubberduck-vba/Rubberduck] build for commit af4736d1 on next: AppVeyor build succeeded
 
ok we got it
 
[rubberduck-vba/Rubberduck] build for commit af4736d1 on next: AppVeyor build succeeded
 
...
 
5:48 AM
@RubberDuck I'm not going to be home much tomorrow (Sunday), but if you want to release 1.4, I'm fine with it. We're ready.
 
That monster project parsed and resolved without any issue. Ladies & gentlemen, we finally have a decent resolver! http://t.co/Ah4ufr4EmH
 
6:12 AM
@StackExchange Great going Duckies!!
 
 
4 hours later…
10:15 AM
@Mat'sMug okay. I'll see what I can do. I've never built an InnoScript installer. I might make a few more tweaks to Git integration first. I feel like it's almost there.
 
10:29 AM
Its not hard.
Just install Inno Script Studio.
and open the installer script in that program and find the menu option to compile it.
You'll just need to make sure you have built a Release build first (I think that's correct).
You'll just need to review whether the installer is picking up the required files. I.e. make sure that you haven't added new files which the script doesn't reference.
 
0
Q: Editing a VBA code: how to use loop appropriately

Abdul ShiyasI tried to use loop in this program to reduce it. But error: "byref argument type mismatch" is occur. How can we rectify it? My converts converts all csv files in the subfolders of folders 1,2,3. As of now I am converting using codes for each folders. I tried to club those into one using for loo...

 
11:01 AM
@Rossco okay. Thanks buddy. I'll figure it out sometime today.
 
 
1 hour later…
12:20 PM
@stackexhange that code was a mother lovin' mess.
 
1:05 PM
[Vogel612/TranslationHelper]‌​ Vogel612 pushed commit b114ccc2 to master: Created an acceptable layout for edit-view
[Vogel612/TranslationHelper] build for commit b114ccc2 on master: The Travis CI build passed
[Vogel612/TranslationHelper]‌​ Vogel612 pushed commit 645a797d to master: Added Tests for translation logic in presenter
[Vogel612/TranslationHelper] build for commit 645a797d on master: The Travis CI build passed
 
one issue left until german translation finishing time! :D
 
[ckuhn203/Rubberduck] ckuhn203 pushed commit 3583d9ae to sourcecontrol: fixed some resizing issues with the source control panel
[ckuhn203/Rubberduck] ckuhn203 pushed commit bf75502f to sourcecontrol: UI improvement closes #663
[ckuhn203/Rubberduck] ckuhn203 pushed commit 926f6636 to sourcecontrol: fixed NREs in Unsynced presenter
[rubberduck-vba/Rubberduck] build for commit 926f6636 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 926f6636 on ???: AppVeyor build succeeded
[ckuhn203/Rubberduck] ckuhn203 pushed commit e5162807 to sourcecontrol: updated appveyor build number and removed duga webhook
[rubberduck-vba/Rubberduck] build for commit e5162807 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit e5162807 on ???: AppVeyor build succeeded
 
1:31 PM
Hmm... wasn't the webhook
 
[rubberduck-vba/Rubberduck] ckuhn203 pushed commit 3583d9ae to next: fixed some resizing issues with the source control panel
[rubberduck-vba/Rubberduck] ckuhn203 pushed commit bf75502f to next: UI improvement closes #663
[rubberduck-vba/Rubberduck] ckuhn203 pushed commit 926f6636 to next: fixed NREs in Unsynced presenter
[rubberduck-vba/Rubberduck] ckuhn203 pushed commit e5162807 to next: updated appveyor build number and removed duga webhook
Merge pull request #666 from ckuhn203/sourcecontrol

Sourcecontrol - UI Improvements
[rubberduck-vba/Rubberduck] build for commit bf74639d on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit bf74639d on next: AppVeyor build succeeded
 
@Duga Someone made pull request 666?
 
1:50 PM
[Vogel612/TranslationHelper]‌​ Vogel612 pushed commit 05f37d13 to master: Implemented Save-Functionality, fixes #4
 
write tests? or translate?....
or write a CR question??
 
[Vogel612/TranslationHelper] build for commit 05f37d13 on master: The Travis CI build passed
 
good that JDOM makes this so damn easy...
 
> All that work building support for credentials and remote functionality and I forgot to prompt the user for their credentials.... I'll need to intercept the inner exception and prompt the user to login instead.

![image](https://cloud.githubusercontent.com/assets/2716800/8396611/b0337130-1d7b-11e5-9e51-359feebdf076.png)
 
What's the difference between "Outcome" and "Result"??
 
I need to go do something else.
 
> I don't know what else to say, it just doesn't work. It connects and queries the remote, but local unpublished commits don't show up.
 
Not sure @Vogel612. Unit tests???
 
hmm... I might need to take performance up a notch...
 
 
1 hour later…
3:31 PM
@Vogel612 one of them is showing the icon, the other shows a textual representation of the icon, with any message. IIRC "outcome" has the message, but I'm not at my computer atm
I think it's on screenshots on the website
 
I'm writing up my CR question right now, and I just translated them to the same ("Ergebnis")
 
3:49 PM
1
Q: Translating the Rubberduck - Übersetzen der Gummiente - Part 1: Modelling

Vogel612So I have committed to making a German translation for the guys over at Rubberduck, which is localized via .resx files. Now these files are basically XML-Files with a certain, rather simple document structure: <root> <!-- Snip --> <data name="Resource_Key"> <value>Resource Value</value

 
4:35 PM
[ckuhn203/Rubberduck] ckuhn203 pushed commit 636b9657 to sourcecontrol: fixes #668
[ckuhn203/Rubberduck] ckuhn203 pushed commit fa4de1be to sourcecontrol: added xlsx to gitignore
[ckuhn203/Rubberduck] ckuhn203 pushed commit 41bc9b43 to sourcecontrol: Fixed display of commits
 
5:06 PM
@RubberDuck might want to test @Hosch250's fix for the regex rename, otherwise we're releasing with a known issue in the rename refactoring
 
5:23 PM
@Mat'sMug what fix?
 
@RubberDuck he did something involving the target's and references' Selection instead of using refex to actually perform the rename, but I don't think it's merged yet
 
Okay... do you think it's buried in that pull request somewhere?
 
No idea....
I need to write something on RD news tonight. This release is HUGE, we're introducing things that are impossible without Rubberduck. I'm starting to think we have one of the best VBE add-ins out there.. and 2.0 will be even more like it, with SmartIndenter embedded.
...and the code base refactored ;-)
 
5:40 PM
And a solid version of git integration...
Soooo damn close.
This is the only thing holding up releasing it as an early version. github.com/rubberduck-vba/Rubberduck/issues/667
 
5:58 PM
@RubberDuck I've got that around somewhere, I think.
Pulling changes.
Darn, I lost it.
Let's see, might be in another branch.
Yep, still have it.
@Mat'sMug One issue:
Oh, wait, I'm still in the other branch.
 
[Hosch250/Rubberduck] Hosch250 pushed 405 commits to GrammarIsFun
[Hosch250/Rubberduck] Hosch250 pushed commit 53fe990d to GrammarIsFun: Rename fix
 
Don't pull that.
@Mat'sMug Just one issue.
Rename doesn't pick up the letter/calls for the getter.
 
@Hosch250 the references do now :)
Uh
 
I just pulled all the changes.
Rename is broken.
Sub Main()

    Dim c As New Class5

    c.Name("John", "M") = "Smith"

    Debug.Print c.Name("John", "M")

End Sub
Private firstName As String
Private middleName As String
Private lastName As String

Public Property Get Name(first As String, middle As String) As String
    Name = firstName & " " & middleName & " " & lastName
End Property

Public Property Let Name(first As String, middle As String, last As String)
    firstName = first
    middleName = middle
    lastName = last
End Property
Reorder works for the signatures.
It doesn't update the calls.
Rename only works on one (I manually searched for setter/letter in Remove/Reorder).
Top is Class6, bottom is Class5
 
You can't clall a setter from the getter, it's nonsense. You need to qualify it with Me to force that, and no it's not handled
 
6:12 PM
OK.
 
Rename worked A1 except for the regex replace issue
 
Well, I'll send you my changes.
 
Did you make any other changes to rename?
 
Nope.
 
6:13 PM
That particular issue. Check it out.
 
[Hosch250/Rubberduck] Hosch250 pushed 21 commits to next (only showing some of them below)
Merge pull request #664 from ckuhn203/sourcecontrol

added collapsable split panel for displaying error states
[Hosch250/Rubberduck] retailcoder pushed commit 608a01d9 to next: major issues all fixed. doesn't resolve calls to default instance members ("static classes").
Merge pull request #665 from rubberduck-vba/GrammarIsFun

This should make 1.4 release-ready.
[Hosch250/Rubberduck] ckuhn203 pushed commit 3583d9ae to next: fixed some resizing issues with the source control panel
[Hosch250/Rubberduck] ckuhn203 pushed commit bf75502f to next: UI improvement closes #663
 
@Hosch250 are you in sync with next?
 
[Hosch250/Rubberduck] ckuhn203 pushed commit 926f6636 to next: fixed NREs in Unsynced presenter
[Hosch250/Rubberduck] ckuhn203 pushed commit e5162807 to next: updated appveyor build number and removed duga webhook
 
No.
 
Merge pull request #666 from ckuhn203/sourcecontrol

Sourcecontrol - UI Improvements
 
6:14 PM
I had an existing PR.
 
[Hosch250/Rubberduck] Hosch250 pushed commit e31d1661 to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into next
[Hosch250/Rubberduck] Hosch250 pushed commit f053548d to next: Fix regex rename
 
I PR'ed a couple SC fixes last night that were never merged.
 
[rubberduck-vba/Rubberduck] build for commit f053548d on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit f053548d on ???: AppVeyor build succeeded
 
Ok. Don't make me panic with statements like "rename is broken" until you're running the latest code, please ;-)
 
Most of those zillion commits are from me pulling - don't know why they go back and forth like that.
LOL.
Why don't you fork my repo to test that last thing out.
I don't know why it shouldn't work, but...
I'm building a list of people to nominate for mod.
 
6:21 PM
I'm on my phone for a while
 
Mat'sMug, RubberDuck, Rossco, and Loki are a few.
OK.
Janos too.
  <data name="Key_InstructionsLabelText" xml:space="preserve">
    <value>Value</value>
  </data>
@Vogel612 ^^
 
6:38 PM
@Hosch250 /me confused...
xml:space is not actually relevant for the code, so I decided to snip it out :)
 
You left out the xml:space="preserve" in your question.
OK.
Just be sure you put it in when you save them.
 
6:50 PM
@Hosch250 so, how's the latest resolver code doing?
 
@msdev we should release Rubberduck 1.4 today, and enable #VBA devs to #refactor rename, remove/reorder params, find symbol, and much more!
 
7:10 PM
[ckuhn203/Rubberduck] ckuhn203 pushed commit 55232653 to sourcecontrol: extracted secondary panel concept to allow for #667
 
Not gonna get it done today @Mat'sMug. If you release. Release without SCI.
 
7:29 PM
Not home for another couple of hours anyway
 
7:47 PM
oh that's right
 
 
1 hour later…
9:00 PM
Anyone tested the edits to Rename?
@Mat'sMug It seems to have a few bugs.
In this code:
(Class6)
Sub Main()

    Dim c As New Class5

    c.Name("John", "M") = "Smith"

    Debug.Print c.Name("John", "M")

End Sub
And this (Class5):
Private firstName As String
Private middleName As String
Private lastName As String

Public Property Get Name(first As String, middle As String) As String
    Name = firstName & " " & middleName & " " & lastName
End Property

Public Property Let Name(first As String, middle As String, last As String)
    firstName = first
    middleName = middle
    lastName = last
End Property
It only identifies per file correctly.
So, all the c.Name's are linked, but not linked back the getter/letter in Class5.
Class5 from Class6 is found twice - the second time it selects "Class5" in the LoC correctly.
The first time, it gives this:
Peculiar - I restarted Excel, and the Class5 thing works.
Then I have this Class8:
Sub Main()
    Dim thisFoo As Class4
    Set thisFoo = New Class4

    Dim cls7 As Class7
    Set cls7 = New Class7
    Set cls7.Foo("Hi!", 9) = thisFoo

    Dim Goo As Class4
    Set Goo = cls7.Foo("Hi!", 9)

End Sub
The .Foo in cls7 is resolved to this Foo in Class1:
Public Event Foo(ByVal arg1 As Integer, ByVal arg2 As String)

Private Sub Bar()

    Dim test1 As Integer
    test1 = 3

    Dim test2 As String
    test2 = "test"

    RaiseEvent Foo(4, "Hi!")
    RaiseEvent Foo(test1, test2)

End Sub
On a better note (besides the bugs), this appears to be fixed: github.com/rubberduck-vba/Rubberduck/issues/495
 
9:27 PM
No. I've not tested anything. Been focused on getting SCI workable, but I gotta put in some family time now.
 
OK.
 
 
1 hour later…
10:39 PM
@Hosch250 I need to make events invisible outside their own class.
But something's not adding up, the member call cls7.Foo should be looking at members of Class7. Is there a public Foo in Class7?
The good news is that no one writes param properties like that, that code is nonsensical.
 
Doesn't it just wanna make you smack a language designer upside the head?
 
11:06 PM
lol
 
11:22 PM
@Mat'sMug Sorry, was reading. Here is Class7:
Private myFoo As Class4

Public Property Get Foo(Test As String, test1 As Integer) As Class4
    Set Foo = myFoo
End Property

Public Property Set Foo(Test As String, test1 As Integer, newFoo As Class4)
    Set myFoo = newFoo
End Property
@Mat'sMug Sorry, but it does compile.
 
@Hosch250 there's a caching issue
 
Oh, OK.
Wow, 17 votes on this answer:
17
A: Tic-Tac-Toe program in about 250 lines

Hosch250Boolean values C99 has Boolean values: #include <stdbool.h>. Variable names int x=0; int j=0; x and j don't describe what they do. Is j the turn number? Also, I don't see x used anyway except this commented out line: //turn[j] = x;. Repetition I would set up a variable name to reduce all...

 
Yeah the Q went hot
 
And the question is still in the hot network list.
 
@Hosch250 ok I don't get it. Member calls are scoped to the type, cls7.Foo should only resolve to Class7.Foo, or not at all.....
 
11:30 PM
It resolves to all the cls7.Foo in Class8.
It doesn't actually get connected back to Class7.
I've no idea what's up.
I don't know.
 

« first day (387 days earlier)      last day (2793 days later) »