[ SmokeDetector | MS ] Few unique characters in body, luncheon meat detected, no whitespace in body, no whitespace in title, repeating characters in body, +1 more (430): xXXXXXXXXXXXxXXXXXXXXXXXx ✏️ by Ronald M. on stackoverflow.com
@tripleee That pattern looks like it's already caught by Potentially bad keyword in body and Potentially bad keyword in answer Append -force to the command word(s) if you really want to add the pattern you provided.
@cigien As @tripleee indicated, the blacklisted websites reason does not currently check usernames. I'm not entirely sure of the reason behind not having it enabled in usernames, or if that's really the right choice, but it's the way it currently is. The setting is that for the create_rule function/decorator, the default is username=False, so the call to that function that's assigned to FindSpam.rule_blacklisted_websites would need to explicitly have username=True in order to run in usernames.
I'd note that it does get a bit more confusing because the default for the Rule class is username=True, but effectively all Rule instances are created by a call to create_rule or using create_rule as a decorator.
I suspect that at least a portion of the reason that the check for blacklisted websites isn't enabled in usernames is that it was thought there might be overlap between blacklisted websites and blacklisted usernames, but based on a really cursory first pass think about it, it doesn't really seem like there would be all that much overlap to me, or that we couldn't handle any specific overlaps by adjusting regexes.
I'd probably be more confident in there not being much overlap if we had some bookending on the blacklisted websites list, rather than just some bookending on a few of the individual entries.
However, if we do want most/all entries in the blacklisted websites list to be checked for in usernames, then we'd need to enable it. One alternative that seems like a bad idea would be to have to explicitly manually duplicate all entries in the blacklisted websites list in the blacklisted username list.
@Makyen Thanks for the explanation. Yeah, I think enabling the check in usernames as well makes sense. I can't recall seeing websites being used as usernames all that frequently, so I'm not too concerned with double-dipping, and as you mentioned, it's easily fixable when it does happen.
@SmokeDetector This has generated 1 fp per day since it was watched a week ago, and with over 3K hits on SE, that rate's not unlikely to subside. There's only 1 tp on MS that's caught by only this detection.
