@Undo Hmmm... sounds like we should be on the lookout for either other problems or another spammer that has started to do grace period edits. The only normal thing I'm aware of that would result in this situation is a grace period edit, but there's nothing we can do now to determine if that was the case for this post.
Maybe we should keep a hash of the post body and title so we can determine if there's been a grace-period edit. I don't think it would be all that expensive for us to keep a hash for every post for 5 minutes, then just include re-fetching data for every post in the next request we make from that site.
It not being expensive assumes that A) Our requests are less than ~60% full (i.e. we routinely request fewer than ~50–60 questions per API access). B) We use a length check then cheap/quick hash to determine if there's been a change to the post which isn't otherwise indicated. C) We only fully re-process those that have changed.
Doing this would double the bytes of data that we read from the SE API, but probably wouldn't increase the number of API requests we make by all that much, assuming we're including the second fetch in a request which is already going to be made.
As to processing capacity required, it really shouldn't increase it that much, assuming we're using a decent, fast hash algorithm and keeping the hashes for only several minutes. If so, we'd only be increasing processing by a hash on every post body/question title and a second hash on every unchanged post body/question title along with actually re-processing only changed posts.
@Makyen That pattern looks like it's already caught by Bad ns for domain in answer and Bad ns for domain in body; append -force if you really want to do that.
[ SmokeDetector | MS ] Blacklisted website in body, link at end of body, pattern-matching website in body, potentially bad ns for domain in body, potentially bad keyword in title (297): Best Offer Para Axe Plus by HowarInder on meta.SE
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body, body starts with title and ends in url, pattern-matching product name in body, +3 more (591): Alka Tone Diet Pills by dbjb2ch on stackoverflow.com
[ SmokeDetector | MS ] Url-only title, bad keyword in body, bad keyword in title, bad pattern in url body, body starts with title and ends in url, +6 more (686): medhush.com/provexum-reviews/ by winhga12 on askubuntu.com
[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, pattern-matching product name in body, pattern-matching website in body, potentially bad keyword in body, +1 more (491): The Good, The Bad and slim body by rubybode on astronomy.SE
[ SmokeDetector | MS ] Bad keyword in title, link at end of body, pattern-matching product name in body, pattern-matching product name in title, potentially bad ns for domain in body, +3 more (498): Tru Fuel Keto Reviews Weight loss by boycenevins on askubuntu.com
tpu- feedback received
[ SmokeDetector | MS ] Url-only title, blacklisted website in body, blacklisted website in title, pattern-matching product name in body, pattern-matching website in body, +5 more (795): walgreensdiet.com/slim-x-genie-keto/ by ifmacikrow on askubuntu.com
@Makyen That pattern looks like it's already caught by Pattern-matching website in body and Pattern-matching website in answer; append -force if you really want to do that.
@Makyen Now that I've popped the need to set GitHub username and email in Git config, it's been determined easy to also integrate them into the config file. I don't see much real need for that, however.
@iBug My concern has been that the GitHub username and password are set in the config file, but not effectively used by SD. That those credentials are not being effectively used by SD requires instance runners to do additional setup steps that are not covered by our instance installation documentation.
My issue is that setting github_username and github_password in the config file doesn't result in the credentials being used for pushes, even though the credentials are required for success. The first time someone installing an SD instance finds out that something more is needed is when commands like !!/watch, !!/blacklist-*, etc. fail to function properly.
Needing to set the GitHub username and email address in git using git config user.email "[email protected]" and git config user.name "SmokeDetector" has been a relatively minor issue. Those commands are in our setup documentation. Moving those to something that's configurable through the config file would be better, but it's not that big of an issue. Not having to use git config to set those would be nice, as it would make it a bit easier to do development/testing, IMO
@Makyen OK, I pushed that change. There are two new keys in the config file that'll be used by Smokey when committing changes (defaults to Smokey's GH identity).
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body, body starts with title and ends in url, pattern-matching product name in body, +3 more (492): Muscles are important to burn calories by zgzdr2ch on wordpress.SE
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body, pattern-matching product name in body, potentially bad ns for domain in body, +2 more (394): Keto Tone Avis - Offer only Today! by woxzoxz on drupal.SE
@SmokeDetector looks like a person with a legit question. I'm not able to easily identify what the official site is for the Tencent Gaming Buddy thing, so I'm not sure whether that link is legit or not
@SmokeDetector k According to moderator they think it is spam. However, in this case, they chose to do a normal deletion, and take further action on a second offence. For our purposes, I will mark as k.
@Makyen This is to catch a couple of spam messages from 8 to 10 hours ago. MS search
@Makyen This is a general watch for something similar. If the specific one moves the the blacklist, this should be adjusted to exclude detecting it. There is one other example of a spammer using words instead of numerals. MS search
@SmokeDetector Well, this is at least NAA. IMO, it's something that would be reasonable for us to block, so TP is fine. If using the analogy that the Q&A is in a room or conference where people are specifically there for discussing on-topic Q&A, then just speaking up with something like this would be rude, IMO. However, it's unclear to me that a moderator would consider an actual R/A flag as helpful.
