Charcoal HQ

Undo

22:09

I'm taking Smokey temporarily for a test.

(in a few minutes)

Jan Dvorak

!!/alive

SmokeDetector

@JanDvorak Of course

Jan Dvorak

FR: standby instances should reply to !!/alive as well (active/standby and location)

Undo

@JanDvorak technically difficult; standby instances don't have chat connections and probably shouldn't

Jan Dvorak

How are they awoken then?

Undo

22:13

If SE chat goes down and that causes us to error, we don't need all the standby instances to also die.

@JanDvorak metasmoke tells them to.

All they do is send pings every minute. If needed, metasmoke will respond with a failover code

SmokeDetector

[ SmokeDetector ] SmokeDetector started in reverted mode at rev eeaaad4 (Undo1: Sort arrays in debug printing) (running on Undo's Raspberry Pi)

Undo

!!/standby teward

SmokeDetector

teward/Aurora is switching to standby

[ SmokeDetector ] SmokeDetector started at rev 8539801 (Undo1: Merge pull request #523 from Charcoal-SE/auto-blacklist-1486709678.29 --autopull) (running on teward/Aurora)

Restart: API quota is 8569.

Undo

...

!!/standby teward

SmokeDetector

teward/Aurora is switching to standby

[ SmokeDetector ] SmokeDetector started at rev 8539801 (Undo1: Merge pull request #523 from Charcoal-SE/auto-blacklist-1486709678.29 --autopull) (running on teward/Aurora)

Undo

22:16

hrmph

still some kinks to iron out there

Jan Dvorak

Maybe MS could list the instances through the active one?

SmokeDetector

Restart: API quota is 8568.

Jan Dvorak

As in, "4 instances active. Foo/bar is active, foo/baz, quux/quux and xyzyx/xyz are on standby"

Undo

You could, but that's complexity

Thomas Ward

hm let me check something

SmokeDetector

22:20

[ SmokeDetector ] SmokeDetector started in reverted mode at rev eeaaad4 (Undo1: Sort arrays in debug printing) (running on Undo's Raspberry Pi)

Jan Dvorak

Whoa, that's a nice commit hash

Thomas Ward

@Undo there may be a logic error on nocrash.py

Undo

@JanDvorak Oddly satisfying, yeah

@ThomasWard I've thought there was, but I haven't been able to find it upon looking

Thomas Ward

@Undo it looks like it failed and did first_start

@Undo livetracking htop seemed to help a little

Undo

@ThomasWard what failed, though?

Thomas Ward

22:23

!!/location

SmokeDetector

@ThomasWard teward/Aurora

@ThomasWard Undo's Raspberry Pi

[ SmokeDetector ] SmokeDetector started in reverted mode at rev cdc7098 (Undo1: Fix KeyError) (running on Undo's Raspberry Pi)

Thomas Ward

@Undo i'm writing in debug code at the moment to see what happens

SmokeDetector

Restart: API quota is 9937.

Thomas Ward

with a printout of some messages, a true/false, etc.

@Undo I think i fixed the logic error but we'll see

Undo

@ThomasWard Feel free to commit, I'm not touching nocrash anyway so there won't be any merge issues

SmokeDetector

22:27

[ SmokeDetector | MS ] Repeating characters in answer: How do I collect loot stored in my town hall in COC? by Mike on gaming.stackexchange.com

Thomas Ward

@Undo already pushed, waiting for it to come back

with a CI Success

SmokeDetector

CI on a6add58 succeeded.

Thomas Ward

!!/standby undo

Undo

Looks like it worked

SmokeDetector

[ SmokeDetector ] SmokeDetector started in reverted mode at rev cdc7098 (Undo1: Fix KeyError) (running on Undo's Raspberry Pi)

Thomas Ward

22:27

uhm

Undo

... nope

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 8539801 (Undo1: Merge pull request #523 from Charcoal-SE/auto-blacklist-1486709678.29 --autopull) (running on teward/Aurora)

Thomas Ward

i think i broke mine

Undo

manually killed mine

Thomas Ward

just killed Aurora with a stick now

SmokeDetector

22:28

[ SmokeDetector ] SmokeDetector started at rev a6add58 (Thomas Ward: nocrash.py: Logic error fix, debug code) (running on teward/Aurora)

Restart: API quota is 8520.

Thomas Ward

!!/standby teward

SmokeDetector

[ SmokeDetector ] SmokeDetector started in standby mode at rev a6add58 (Thomas Ward: nocrash.py: Logic error fix, debug code) (running on teward/Aurora)

Undo

Worked, looks like

Thomas Ward

well I guess I did maybe fix it

let me check one thing

SmokeDetector

[ SmokeDetector ] SmokeDetector started in standby mode at rev a6add58 (Thomas Ward: nocrash.py: Logic error fix, debug code) (running on teward/Aurora)

Thomas Ward

22:29

oops I broke KeyboardInterrupt

DavidPostill

@SmokeDetector naa was strangely appropriate for an answer containing multiple 💩💩💩 characters :)

Undo

I've just been killing it in htop, it's easy anyway

SmokeDetector

ArtOfCode/EC2 received failover signal.

Restart: API quota is 9999.

Undo

Well that part works

!!/rev

SmokeDetector

@Undo 2a97cfe (Undo1: Reset last ping time during failover --autopull)

Thomas Ward

22:31

@Undo i'm going to launch locally, location name = teward/Overlord for a few moments

Undo

kk

Thomas Ward

because I need to not track shit over SSH :P

SmokeDetector

CI on efaa17c succeeded.

Undo

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started in standby mode at rev efaa17c (Thomas Ward: More logic fixes) (running on ArtOfCode/EC2)

Undo

22:32

@SmokeDetector that's broken

Thomas Ward

@Undo because Art never moved to the new codebases

for nocrash

Undo

oh, right

@ArtOfCode at some point, need manual pull to get nocrash fixes

SmokeDetector

ArtOfCode/EC2 received failover signal.

ArtOfCode

urgent?

Undo

nah

SmokeDetector

22:33

Restart: API quota is 9990.

ArtOfCode

k, it can wait then

Undo

!!/rev

SmokeDetector

@Undo efaa17c (Thomas Ward: More logic fixes)

[ SmokeDetector ] SmokeDetector started at rev efaa17c (Thomas Ward: More logic fixes) (running on teward/Overlord)

Undo

!!/standby art

SmokeDetector

ArtOfCode/EC2 is switching to standby

[ SmokeDetector ] SmokeDetector started in standby mode at rev efaa17c (Thomas Ward: More logic fixes) (running on ArtOfCode/EC2)

Restart: API quota is 9999.

Thomas Ward

22:34

alright, first...

!!/standby teward

SmokeDetector

[ SmokeDetector ] SmokeDetector started in standby mode at rev efaa17c (Thomas Ward: More logic fixes) (running on teward/Overlord)

Thomas Ward

OK so that's why that happened

Undo

afk for a while. Superping if you need something really bad @ThomasWard.

my Pi is down too

Thomas Ward

OK

SmokeDetector

ArtOfCode/EC2 received failover signal.

[ SmokeDetector ] SmokeDetector started at rev efaa17c (Thomas Ward: More logic fixes) (running on teward/Overlord)

Thomas Ward

22:35

!!/standby art

SmokeDetector

ArtOfCode/EC2 is switching to standby

[ SmokeDetector ] SmokeDetector started in standby mode at rev efaa17c (Thomas Ward: More logic fixes) (running on ArtOfCode/EC2)

Restart: API quota is 9998.

CI on e5caa59 succeeded.

Thomas Ward

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev e5caa59 (Thomas Ward: nocrash.py: Remove logic to 'capture' KeyboardInterrupt.) (running on teward/Overlord)

Restart: API quota is 9992.

[ SmokeDetector ] SmokeDetector started at rev e5caa59 (Thomas Ward: nocrash.py: Remove logic to 'capture' KeyboardInterrupt.) (running on teward/Overlord)

Restart: API quota is 9991.

[ SmokeDetector ] SmokeDetector started at rev e5caa59 (Thomas Ward: nocrash.py: Remove logic to 'capture' KeyboardInterrupt.) (running on teward/Overlord)

Restart: API quota is 9988.

Byte Commander

Did you break it?

Thomas Ward

@ByteCommander fixing a few errors in logic handling in nocrash.py

that's me ctrl+c-ing and restarting it a lot

Byte Commander

22:42

!!/blame

SmokeDetector

Restart: API quota is 9985.

Thomas Ward

!!/location

SmokeDetector

@ThomasWard teward/Overlord

Byte Commander

Might be better to use the signal module instead of just catching KeyboardInterrupt. More flexible.

Thomas Ward

@ByteCommander ctrl+c triggers KeyboardInterrupt

all other exceptions raise as they should

Byte Commander

22:44

But you can intercept the SIGINT or other signals by setting a signal hook, so that it doesn't throw a KeyboardInterrupt at all.

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 68103af (Thomas Ward: Keyboard Interrupt handling, round 2) (running on teward/Overlord)

Thomas Ward

@ByteCommander you want to make a pull req for that? I'm lazy :P

SmokeDetector

Restart: API quota is 9983.

Thomas Ward

it also needs to be handled in the try/catch that surrounds the subprocess

Byte Commander

If you tell me what exactly you want to achieve... maybe.

But probably not tonight.

Thomas Ward

22:45

well, it kinda works and just dies off which is fine

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 68103af (Thomas Ward: Keyboard Interrupt handling, round 2) (running on teward/Overlord)

Byte Commander

Here's the doc for signal: docs.python.org/3.5/library/signal.html

Thomas Ward

@ByteCommander buzzer

try again, we're Py2

Byte Commander

Phh... Upgrade it.

Thomas Ward

some things don't behave in py3 yet

Byte Commander

22:48

Same module, but uglier doc page: docs.python.org/2.7/library/signal.html

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 32ea01f (Thomas Ward: Remove debugging print outputs.) (running on teward/Aurora)

Thomas Ward

well, i think that fixes it.

SmokeDetector

Restart: API quota is 8519.

Thomas Ward

!!/standby teward

SmokeDetector

[ SmokeDetector ] SmokeDetector started in standby mode at rev 32ea01f (Thomas Ward: Remove debugging print outputs.) (running on teward/Aurora)

[ SmokeDetector ] SmokeDetector started at rev 32ea01f (Thomas Ward: Remove debugging print outputs.) (running on teward/Aurora)

Thomas Ward

22:49

yay

SmokeDetector

Restart: API quota is 8518.

Thomas Ward

@Undo for the record: fixed the logic check for whether we run in standby or not, and also poked some things to make keyboard interrupts like ctrl+c work right... sorta.

i might have to write it in ws.py actually to have a try/except around most of the code to capture KeyboardInterrupt and exit with a specific error code that nocrash.py can interpret better

but standby/active works again.

angussidney

@ByteCommander [status-planned-but-probably-not-going-to-happen-cause-its-a-big-job]

Byte Commander

Are you sure? Getting ChatExchange 2&3-compatible wasn't such a big deal either...

I guess it's more a question of mentality.

Thomas Ward

@ByteCommander i wasn't talking about CE in this case

but if you want to talk about CE, how about we figure why the debugger can't get the login cookie when it's being run in a debugger.

SmokeDetector

22:56

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title: What IDE options do we have, to choose from, when we are working in a software company in India? by Zakstar on stackoverflow.com (@dorukayhan)

Byte Commander

blame the debugger...

Thomas Ward

i'll blame someone else

!!/blame

SmokeDetector

@ThomasWard It's Byte Commander's fault.

Thomas Ward

oh lookit

Byte Commander

Can it be that the debugger breaks on exceptions, even if they would be caught later?

Thomas Ward

22:57

@ByteCommander nope, because then it'd 'suspend' and wait for me to do something

so yeah evil

ANYWAYS

i should probably head home, it's dark, and approaching the time of Reckoning

SmokeDetector

[ SmokeDetector | MS ] Pattern-matching website in answer: Embed Dropbox website to an HTML website by Rob on stackoverflow.com (@dorukayhan)

J F

o/

DavidPostill

@SmokeDetector Oh dear. I autoflagged this as spam. Its a FP :/

I have retracted my (auto)flag ...

Jan Dvorak

Are you sure it's not a seed?

DavidPostill

@JanDvorak Doesn't look like it.

@SmokeDetector why

SmokeDetector

23:12

Title - Position 80-96: company in India
Body - Position 32-48: company in India

ArtOfCode

that's... kinda what happens when you have 180 as a weight

it's probably still fairly accurate, but more FP's than something higher

@SmokeDetector f

Jan Dvorak

My strategy to not opt into autoflagging seems to be working out so far

DavidPostill

@ArtOfCode 180 is 99.73%.

ArtOfCode

so there's one of your 27 false positives per 10k posts

J F

Speaking of autoflagging, could someone set me up for it?

angussidney

23:21

Proposal: bump the required accuracy up to 99.5%

DavidPostill

Changed to 240 (99.92%)

angussidney

@JF have you got a MS account?

DavidPostill

@angussidney ? That is less than what I had it set to.

J F

@angussidney Yes. ID 65.

angussidney

@DavidPostill currently the required accuracy is 99%, which is a little to inaccurate IMO

@JF 2secs gotta give you the right permission

Okay, now go to the flagging button in the toolbar that should appear if it hasn't already

ArtOfCode

23:25

the flagging link is always there

angussidney

Next click the autoflagging conditions link and create a new condition

ArtOfCode

there's a guide through the whole thing in the wiki

angussidney

(recommended weight is 280, which gives you 99.98% accuracy)

@ArtOfCode can you get a link to that? It might be a little hard to get to on mobile

Undo

@angussidney Probably should bump it up, yeah

ArtOfCode

github.com/Charcoal-SE/SmokeDetector/wiki/Set-Up-Autoflagging

angussidney

23:28

@Undo done

SmokeDetector

[ SmokeDetector ] SmokeDetector started in standby mode at rev 32ea01f (Thomas Ward: Remove debugging print outputs.) (running on Undo's Raspberry Pi)

Undo

Now, we have an issue about existing conditions

Best option is probably to disable them if they don't meet the new condition

DavidPostill

Is this correct?
"There's a threshold of accuracy that all flagging conditions must meet before they're used to cast flags automatically. Currently, this is 99.9%"

Undo

@DavidPostill no

Probably shouldn't have a dynamic number in a static document

J F

Thanks all!

angussidney

23:30

Also @JF can you let us know whether or not the sitepicker appears when you go and set up preferences and conditions? We had a bug where it wasn't showing up, and were not sure if we have fixed it

If it doesn't show up, you can refresh the page and it should

J F

@angussidney I already set up preferences a while ago. It does work for conditions now.

Do I have to fill in all of the fields in conditions?

ArtOfCode

yep

280/1/1 is recommended

J F

23:56

[feature-request] make the fields default to 280/1/1

Undo

@JF probably a good idea

Transcript for