Charcoal HQ

tripleee

14:02

created a manual PR for the time being github.com/Charcoal-SE/SmokeDetector/pull/345

SmokeDetector

[ SmokeDetector | MS ] Few unique characters in body, no whitespace in body, repeating characters in body: How do i insert data with laravel? by asdflol12345 on stackoverflow.com

tripleee

@SmokeDetector vandalism

eager beaver

Thomas Ward

@Glorfindel I'd still have considered it naa, rather than Spam, because of the nature of Ask Ubuntu being "Not Windows"

but yeah possibly.

Thomas Ward

14:32

@Glorfindel I think we'll need to discuss uufix more in depth

because it's going to be a case-by-case basis I think

it links to two dodgy tools on their site

but some answers link to manual removal steps from there

Ferrybig

@tripleee Even if we pull that PR, its not going to work, because git refuses to pull if files are locally modified

Thomas Ward

@Glorfindel my two cents is I haven't seen enough on Ask Ubuntu to be relevant, but it'd be naa for Ask Ubuntu, or spam, depending on what they pulled from it

so we may wish to keep the uufix 'blacklist'

tripleee

just filed it to get it out of my system, but it's still stuck

ArtOfCode

@Ferrybig which is why we always have a human running this who can SSH in and fix merge conflicts :)

Speaking of, @ThomasWard, you may want to run a git reset --hard origin/master

Thomas Ward

oops

SmokeDetector

14:44

[ SmokeDetector ] SmokeDetector started at rev 407c3d3 (Undo1: HealthKit is an Apple thing; we don't need to catch it.) (running on teward/Aurora)

Restart: API quota is 5736.

Glorfindel

@ThomasWard OK, thanks.

Thomas Ward

@ArtOfCode already done, though I also had to kill off Smokey for a second anyways. (git security update I decided was critical)

ArtOfCode

!!/gitstatus

SmokeDetector

On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working directory clean

ArtOfCode

sweet

Thomas Ward

14:46

@ArtOfCode though, I think that should've had autopull added to the message, it would've automagically pulled

Though, I can always force a git reset :P

it's interesting watching the console logs heh

Glorfindel

Can we blacklist again now?

Thomas Ward

i'm glad this thing has 2TB of bandwidth lol

ArtOfCode

@Glorfindel cc @ThomasWard is the console showing ping messages from the websocket?

Thomas Ward

@ArtOfCode you mean these? {"type":"ping","message":...}

ArtOfCode

yep

Thomas Ward

14:50

then yes

ArtOfCode

if those are coming in every 3 seconds then the websocket is up

Glorfindel

OK, let me try.

ArtOfCode

so yes, @Glorfindel, blacklists work

Thomas Ward

yep it looks to be pinging every 3 seconds

Glorfindel

!!/blacklist-website beaufitreviews\.com

Thomas Ward

14:50

oops

hang on traceback

!!/logs

SmokeDetector

Restart: API quota is 5692.

ArtOfCode

Eh?

Thomas Ward

bleh

ArtOfCode

!!/errorlogs 50

SmokeDetector

    bytes_ = sock.recv(bufsize)


ErrorReturnCode_128:

  RAN: /usr/bin/git push origin auto-blacklist-1481295034.49

  STDOUT:


  STDERR:
fatal: could not read Username for 'https://github.com': No such device or address
2016-12-09 14:50:34.741113 UTC
  File "/home/smokey/SmokeDetector/excepthook.py", line 46, in run_with_except_hook
    run_old(*args, **kw)

  File "/usr/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)

  File "/home/smokey/SmokeDetector/ChatExchange/chatexchange/browser.py", line 703, in _runner

Thomas Ward

14:51

it broke

ooo

hang on

ArtOfCode

Yeah, you need to set git credentials

Thomas Ward

see, I did

copypaste from Undo

ArtOfCode

Ah, but are they set in both places?

Thomas Ward

that's what i'm checking now

ArtOfCode

They need to be in config for the GH API, and they need to be cached in the credential helper so that git commands work.

Thomas Ward

14:52

yeah that's what's missing standby

see i set that but it got lost >.<

ArtOfCode

git config --global credential.helper 'cache --timeout=5356800'

then do a git push on nothing so it asks you for the creds

Thomas Ward

@ArtOfCode yeah it's lagged though - damned campus internet

SmokeDetector

[ SmokeDetector ] SmokeDetector started in reverted mode at rev 407c3d3 (Undo1: HealthKit is an Apple thing; we don't need to catch it.) (running on teward/Aurora)

Thomas Ward

okay, now it should work...

SmokeDetector

Restart: API quota is 5689.

Thomas Ward

14:55

@ArtOfCode the evil thing is evil...

Glorfindel

!!/blacklist-website beaufitreviews\.com

SmokeDetector

@Glorfindel Not currently on master.

Thomas Ward

grrr wat

oh

Ashish Ahuja

!!/location

!!/alive

ArtOfCode

!!/master

Thomas Ward

14:55

@AshishAhuja down

SmokeDetector

[ SmokeDetector ] SmokeDetector started in reverted mode at rev 407c3d3 (Undo1: HealthKit is an Apple thing; we don't need to catch it.) (running on teward/Aurora)

ArtOfCode

git checkout master then :)

Ashish Ahuja

@ThomasWard okay then.

ArtOfCode

!!/master

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 407c3d3 (Undo1: HealthKit is an Apple thing; we don't need to catch it.) (running on teward/Aurora)

Thomas Ward

14:56

okay i need to kick my server it just nommed the process

>.<

SmokeDetector

Restart: API quota is 5686.

ArtOfCode

nom nom nom nom

Thomas Ward

!!/blacklist-website beaufitreviews\.com

SmokeDetector

@ThomasWard Blacklisted beaufitreviews\.com - the entry will be applied via autopull if CI succeeds.

Thomas Ward

@ArtOfCode all should work - lets see if nothing blows up :p

Glorfindel

14:57

yesterday, by Jan Dvorak

> Nobody said it was easy
> No one ever said it would be so hard

SmokeDetector

CI on 48f5453 succeeded. Message contains 'autopull', pulling...

Andy

watches for a mushroom cloud in the distance

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 48f5453 (SmokeDetector: Auto blacklist of beaufitreviews\.com by Thomas Ward --autopull) (running on teward/Aurora)

Restart: API quota is 5676.

ArtOfCode

works well enough

Thomas Ward

yay

throws git at the wall

@ArtOfCode looks like what happened was a git config reset. Guess I'll add that to the list of issues with the security patch

ArtOfCode

14:58

oh hey smokey down email

Thomas Ward

!!/status

SmokeDetector

@ThomasWard Running since 14:57:19 UTC (0 minutes)

Thomas Ward

!!/rev

SmokeDetector

@ThomasWard 48f5453 (SmokeDetector: Auto blacklist of beaufitreviews\.com by Thomas Ward --autopull)

Thomas Ward

!!/location

SmokeDetector

14:58

@ThomasWard teward/Aurora

Thomas Ward

good

ArtOfCode

@ThomasWard yeah that happens sometimes... you also need to remember to re-cache creds if you restart the server, that one's bitten me once or twice.

Thomas Ward

@ArtOfCode indeed. There's also the pure 'store' function

that perpetually stores the creds

Andy

Thomas Ward

though for obvious security reasons I don't use it except where restarts are so frequent...

Ferrybig

14:59

Do you use a password or a github api token at the moment?

ArtOfCode

@ThomasWard Yeah. I can't say I'm a great fan of caching credentials for such long periods of time, either, but there is no other way

Glorfindel

There were a couple more blacklist requests which weren't processed because of Smokey issues, see here.

ArtOfCode

@Ferrybig this is for git commands, so we have to use the password

Thomas Ward

@ArtOfCode the only time it'd be rebooted is during quarterly maintenance cycles where I throw every security update into play at once

@ArtOfCode SSH keys not an option?

ArtOfCode

@ThomasWard don't know, would have to look into it

Never used 'em for GH commits

Thomas Ward

15:00

Pretty much the same thing except for an HTTPS origin URL it's a git://... URL

Vogel612

note that the SSH key fingerprint may be setup to require password auth

Thomas Ward

pushes things over the SSH / SFTP protos I think

Ferrybig

@ArtOfCode No? help.github.com/articles/… "Personal access tokens are useful when it's too cumbersome to provide a client/secret pair for a full application, such as when authenticating to GitHub from Git using HTTPS, or within a command line utility or script."

Thomas Ward

@Vogel612 and we can use individual keys for individual servers, too, if we chose, so we can just knock off a key if it's bad

Vogel612

it's usually slightly quicker IIRC, because there's less overhead for each delta

Thomas Ward

15:01

but meh

ArtOfCode

shrug this is where my knowledge of git ends

Thomas Ward

!!/blacklist-website oraclefusionfinancials\.in

SmokeDetector

@ThomasWard Blacklisted oraclefusionfinancials\.in - the entry will be applied via autopull if CI succeeds.

Thomas Ward

!!/test star-writers.com

SmokeDetector

> Would not be caught for title, body, and username.

ArtOfCode

15:03

hang about there @ThomasWard - github.com/Charcoal-SE/SmokeDetector/pull/345

Thomas Ward

ok

SmokeDetector

CI on 455b494 succeeded. Message contains 'autopull', pulling...

[ SmokeDetector ] SmokeDetector started at rev 455b494 (SmokeDetector: Auto blacklist of oraclefusionfinancials\.in by Thomas Ward --autopull) (running on teward/Aurora)

Restart: API quota is 5635.

Thomas Ward

@ArtOfCode i'll halt on going through them. (Waiting)

SmokeDetector

[ SmokeDetector | MS ] Few unique characters in body, repeating characters in body: yfjhgkjhk hggggggg io oy by Mian Arfan on graphicdesign.stackexchange.com

ArtOfCode

shrug meh

Thomas Ward

15:04

@ArtOfCode note Glorfindel pointed at pirors

ArtOfCode

@ThomasWard wait, going through what?

Thomas Ward

4 mins ago, by Glorfindel

There were a couple more blacklist requests which weren't processed because of Smokey issues, see here.

Glorfindel

@SmokeDetector vandalism

Vogel612

@SmokeDetector somebody drop JohnB a note in the TL.

Thomas Ward

@SmokeDetector vandalism

oops

DavidPostill

15:05

@SmokeDetector vandalism

ArtOfCode

@Vogel612 that was a protect, not a lock

Thomas Ward

@Vogel612 protect != lock

Vogel612

yea I was just about to correct it :)

Thomas Ward

@ArtOfCode there were blacklist requests that didn't get included

ArtOfCode

@ThomasWard the general idea is check 'em on MS - we only need to blacklist a site if it's been used more than once

Thomas Ward

15:05

@ArtOfCode ACK

Glorfindel

@ArtOfCode the problem with star-writers.com was that the only reported post was a manual report.

ArtOfCode

@Glorfindel that's okay

We're pretty good at getting coverage even with manual reports. If it comes up again, I'd be confident of us getting to know about it

Glorfindel

OK, clear.

Thomas Ward

hrm, that's odd...

LOL it seems the service scanners have found that server by IP address xD

lotsa portscans

JohnB

I locked the post now, it is a legitimate question so I don't want to delete it. But I'll drop the hammer down on the user

ArtOfCode

15:11

Thomas Ward

^ mjolnir. The ultimate mod hammer.

Undo

!!/alive?

SmokeDetector

@Undo Of course

Undo

email from metasmoke a few minutes ago

ArtOfCode

Yeah, server reboot

Poll: favourite quick meal?

Undo

15:20

Pizza

The quick part might be hard, though

Good to keep a stash in your fridge for emergences

JohnB

I don't know if I'd call it quick but 80%ish of my dinners are <rotating meat> + frozen vegetable mix

Very low effort and you just add random spices to make it interesting, + you don't have to pay much attention to it while you cook it

ArtOfCode

@Undo or in the local shop's fridge. They do good quick pizzas. I did pizza yesterday, though.

Vogel612

@ArtOfCode leftover pasta + egg + seasoning ad lib into the frying pan

SmokeDetector

[ SmokeDetector | MS ] Pattern-matching website in answer: What are the best hours to sleep? by user7607 on health.stackexchange.com

Andy

@ArtOfCode Mac and Cheese

The Kraft kind though. The generic stuff is horrible

I think that's the only non-generic food I seek out in the grocery store.

Glorfindel

15:45

@SmokeDetector k

Ashish Ahuja

@ArtOfCode a sandwich. They can be really quick to make and you can just gobble them down.

Glorfindel

@ArtOfCode sushi. Also, the non-quick variant (making it yourself).

Thomas Ward

Well, fooey. My laptop died. :/

Jan Dvorak

Gordon Blue steak, but only if I don't have to prepare it.

Thomas Ward

@ArtOfCode My steaks - sirloin from the butcher's, dropped onto the extremely hot gas grill I have, with a peppercorn spice rub.

Cooks in about 4 minutes :P

4 minutes of prep

4 cooking.

8 minutes later, eight pieces of steak are done. Meal for two days :P

!!/alive

SmokeDetector

15:50

@ThomasWard Of course

Thomas Ward

@Undo yeah that was my fault.

it's back though

SmokeDetector

16:02

[ SmokeDetector | MS ] Few unique characters in answer: Is it okay to use parameters like that? by Andreas Rau on stackoverflow.com

Jan Dvorak

@ArtOfCode we seem to be having two different Smokeys in SOCVR

Thomas Ward

@JanDvorak There's two Smokeys running. One's for ELU (I think), one's the general

One's global smokey, on teward/Aurora, one's not.

the response hook is, unfortunately, identical for each, though you should only be getting the one smokey

Jan Dvorak

The latter shouldn't be sitting in SOCVR, or at least complaining when the other one's being talked to

Ferrybig

!!/location

SmokeDetector

@Ferrybig teward/Aurora

[ SmokeDetector | MS ] Bad keyword with email in answer, email in answer: How to make lots of money in Medieval 2: Total War by victoria goode on gaming.stackexchange.com

Thomas Ward

16:07

good point

@ArtOfCode anything we cna do to kick your Smokey from SOCVR?

Jan Dvorak

Apart from killing him entirely?

Thomas Ward

@SmokeDetector tpu-

Ferrybig

~~We can use the shutdown command, and then thomas can manually start his instance again~~

Thomas Ward

@Ferrybig no i can't

not without my laptop (SSH keys)

so please don't kill it

(laptop battery death due to my stupidly leaving my charger at home)

i might be able to in an hour

but that would affect the private / special fork of Smokey being run by Art

@Undo where was Art's special fork running, again?

is that for ELU or someone else?

yeah that looks to be for ELU if i'm reading transcripts right

ArtOfCode

Don't shut it down. Both instances need to be running

Ferrybig

16:13

@ArtOfCode May I ask you what your experiment is?

Thomas Ward

@ArtOfCode looks like SOCVR wants yours to stop replying in there then - any chance you can alter the fork for ELU to not be in SOCVR, or was that deemed impossible?

ArtOfCode

Unfortunately, commands use a reply call instead of send_message, which is identical whichever room it's in, so it's not easy to filter down to only the control room. My copy won't post its reports in SOCVR, but commands still work because of that

Jan Dvorak

The ELU instance doesn't seem to be finding anything right now, though

ArtOfCode

@JanDvorak not at the moment, but nothing's tripped its filters for a while

Jan Dvorak

@ArtOfCode then why did only one of them reply here?

ArtOfCode

16:15

and reports won't go to SOCVR anyway

@JanDvorak because my copy of Smokey isn't in here

its control room is a different room entirely

hack

Jan Dvorak

Can we get your copy to not be in SOCVR either?

ArtOfCode

I can't modify it so that SOCVR doesn't exist.

Jan Dvorak

O_o

ArtOfCode

I've tried to modify it so that it doesn't post there even if it does join, but I can't do that for command replies

Thomas Ward

16:28

@ArtOfCode so, there's no solution for SOCVR?

ArtOfCode

no easy solution, no

not without a large rewrite job that isn't worth it for a 7-day experiment

Thomas Ward

@ArtOfCode so this is a temporary experiment?

ArtOfCode

aye

it'll last only as long as ELU needs it

Thomas Ward

@JanDvorak ^

I should really stop by home to get my laptop charger

Undo

@ArtOfCode Why not just comment out github.com/ArtOfCode-/SmokeDetector/blob/master/ws.py#L165?

SmokeDetector

16:32

[ SmokeDetector | MS ] Bad keyword in answer, bad keyword with email in answer, email in answer: Co-Parenting with a Toxic Ex: How to Handle Poisoned Comments from Toddler? by Susan Morgan on parenting.stackexchange.com

tpu- by Undo

ArtOfCode

@Undo that would be clever

Jan Dvorak

Roger that then

Wai Ha Lee

16:55

sd notspam

Jan Dvorak

Seems there's an auto-hosting mechanism, and misleading links to imgur are always safe

Wai Ha Lee

unless the image itself is bad. n girls m objects, etc.

Jan Dvorak

I'd still exclude them from that filter, though

SmokeDetector

[ SmokeDetector | MS ] Link at end of answer: how to get Whois Database - Daily Update by Hasarinda Manjula on stackoverflow.com

[ SmokeDetector | MS ] Pattern-matching website in body: OAuth : Authorization URI : Under Armour by Satish Roddom on stackoverflow.com

fp- by NobodyNada

Ferrybig

@SmokeDetector k (spam seed)

SmokeDetector

17:14

[ SmokeDetector | MS ] Offensive body detected: jQuery throws an UNCAUGHT ERROR? I didnt change code at all by manga101 on stackoverflow.com

Wai Ha Lee

sd k

Jan Dvorak

undone

SmokeDetector

17:54

[ SmokeDetector | MS ] Misleading link in answer: Angular 2 intellisense in VS Code by badre429 on stackoverflow.com

Conflicting feedback on Angular 2 intellisense in VS Code.

NobodyNada

What in the world is going on with that link?

it's a GitHub-looking link...to a picture of some code.

DavidPostill

@NobodyNada OP has removed it after somebody else inlined the image.

SmokeDetector

18:10

Conflicting feedback on Angular 2 template intellisense in VS Code.

NobodyNada

sd remove - f

SmokeDetector

Conflicting feedback on Angular 2 template intellisense in VS Code.

ArtOfCode

18:23

no there isn't shush

Thomas Ward

heh

SmokeDetector

[ SmokeDetector | MS ] Few unique characters in body: Trying to connect SQL database, with PHP frontend by J. Doe on stackoverflow.com

Glorfindel

18:36

@SmokeDetector vandalism

SmokeDetector

19:34

[ SmokeDetector | MS ] Mostly non-Latin answer, non-English link in answer, non-Latin link in answer: Is it a breach of South African Law or International regulations to not do a full safety briefing on a commercial flight? by user166240 on travel.stackexchange.com

tpu- by Glorfindel

Restart: API quota is 3824.

Glorfindel

!!/alive

SmokeDetector

@Glorfindel Of course

Glorfindel

!!/blacklist-website el-harmeen\.com

SmokeDetector

Restart: API quota is 3813.

Glorfindel

!!/location

SmokeDetector

19:37

@Glorfindel teward/Aurora

Thomas Ward

it blew up?

checks

ArtOfCode

!!/errorlogs 50

SmokeDetector

  File "/usr/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)

  File "/home/smokey/SmokeDetector/ChatExchange/chatexchange/browser.py", line 703, in _runner
    self.on_activity(json.loads(a))

  File "/home/smokey/SmokeDetector/ChatExchange/chatexchange/rooms.py", line 81, in on_activity
    event_callback(event, self._client)

  File "/home/smokey/SmokeDetector/chatcommunicate.py", line 167, in watcher
    message_id=message_id)

  File "/home/smokey/SmokeDetector/chatcommunicate.py", line 234, in handle_commands

Glorfindel

Yep, I was already starting to ping you.

Thomas Ward

wat

html_url key error

wtf

Glorfindel

19:38

Apparently both of you are mind readers ...

Thomas Ward

@ArtOfCode did we break something in an update?

ArtOfCode

@ThomasWard check your console

the response JSON should have been printed

Thomas Ward

give me a minute

restart in progress

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 455b494 (SmokeDetector: Auto blacklist of oraclefusionfinancials\.in by Thomas Ward --autopull) (running on teward/Aurora)

Restart: API quota is 3795.

Glorfindel

!!/blacklist-website el-harmeen\.com

Thomas Ward

19:40

okay now i should have USABLE log data

since the rest of the output is being piped to a log file

SmokeDetector

Restart: API quota is 3792.

[ SmokeDetector ] SmokeDetector started at rev 455b494 (SmokeDetector: Auto blacklist of oraclefusionfinancials\.in by Thomas Ward --autopull) (running on teward/Aurora)

Thomas Ward

getting nothing from it lets try again

i'll get it

SmokeDetector

Restart: API quota is 3791.

ArtOfCode

drop the response JSON in here when you get it

Thomas Ward

!!/blacklist-website el-harmeen\.com

SmokeDetector

19:42

@ThomasWard Blacklisted el-harmeen\.com - the entry will be applied via autopull if CI succeeds.

Glorfindel

OK, so Smokey is just being mean to me only :(

Thomas Ward

uhm

ArtOfCode

Okay, so once this blacklist goes through, try again @Glorfindel

SmokeDetector

CI on 1823fa8 succeeded. Message contains 'autopull', pulling...

Thomas Ward

@ArtOfCode I wonder if it's a permissions issue?

SmokeDetector

19:43

[ SmokeDetector ] SmokeDetector started at rev 1823fa8 (SmokeDetector: Auto blacklist of el-harmeen\.com by Thomas Ward --autopull) (running on teward/Aurora)

Glorfindel

I have nothing to blacklist anymore :)

Thomas Ward

as in Smokey perms

@Glorfindel blacklist overwatch-network\.net

one of the many domains I never use on SE

ArtOfCode

@Glorfindel blacklist testy-test-test\.com

Thomas Ward

or a test domain

SmokeDetector

Restart: API quota is 3787.

ArtOfCode

19:43

tests are better because they're more easily recognised

Glorfindel

!!/blacklist-website testy-test-test\.com

Thomas Ward

yep

ArtOfCode

what's the JSON?

Thomas Ward

"bad credentials"

ahhh that's the key error problem there

SmokeDetector

Restart: API quota is 3783.

ArtOfCode

19:44

yeah, but what's the full JSON?

Thomas Ward

@ArtOfCode {u'documentation_url': u'https://developer.github.com/v3', u'message': u'Bad credentials'}

ArtOfCode

that's the one

Thomas Ward

wait a second, let me check something

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 1823fa8 (SmokeDetector: Auto blacklist of el-harmeen\.com by Thomas Ward --autopull) (running on teward/Aurora)

ArtOfCode

got the creds set in config?

Thomas Ward

19:45

@Glorfindel try again?

SmokeDetector

Restart: API quota is 3780.

Thomas Ward

@ArtOfCode yeah but there may have been stray ascii

Glorfindel

!!/blacklist-website testing-if-the-blacklist-works-for-me-now\.com

SmokeDetector

@Glorfindel You don't have code privileges, but I've created a pull request for you.

Thomas Ward

there you go

Glorfindel

19:45

yay!

ArtOfCode

\o/

Thomas Ward

@ArtOfCode was a stray control char, leftover from the copy/paste from Undo's mail

looks like it didn't get caught in vim, so I downloaded the file and fussed with it before reuploading

looks like we're good now

ArtOfCode

those cause problems, yeah

Thomas Ward

FYI another reboot in progress

ArtOfCode

lemme guess it was a carriage return?

Thomas Ward

19:46

screen didn't like scrolling so I had to off/on Smokey to a non-screen'd session

@ArtOfCode probably

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 1823fa8 (SmokeDetector: Auto blacklist of el-harmeen\.com by Thomas Ward --autopull) (running on teward/Aurora)

Thomas Ward

restarted, this should be the last one

SmokeDetector

Restart: API quota is 3769.

Thomas Ward

@ArtOfCode this always is a problem whenever emails are sent to me and not specified as plain text :/

it always throws spare chars in there

meh, it's working now, we're all good.

y'know, we could do a better try/except match, prevent the runtime crash and spit out useful errors

i'll have to poke things to find it

I need coffee though, back in a bit

Ferrybig

20:14

!!/alive

SmokeDetector

@Ferrybig Of course

[ SmokeDetector | MS ] Pattern-matching website in answer: What's the standard way for NSDocument to send events to NSViewControllers? by WhatsUpNSDoc on stackoverflow.com

Thomas Ward

sd why

SmokeDetector

@ThomasWard [:34020643] Body - Position 135-171: comp.sys.mac.programmer.help.

[ SmokeDetector | MS ] Bad keyword with email in answer, email in answer: What equity would I have when selling early on in mortgage? by Larry Puala Meddozal on money.stackexchange.com

tpu- by teward

Thomas Ward

20:52

@Undo @ArtOfCode would there be an objection to me adding a single try/except block to capture the "Bad credentials" response and throw an error? Like we saw here with the bad credentials reply causing things to blow up. (I hate runtime crashes!)

Undo

@ThomasWard Main issue is that it wouldn't trigger the auto revert if someone was to mess up the login code

Right now we're fairly protected against that

Thomas Ward

@Undo we do have runtime crashes when it gets a bad credentials reply

Undo

Yes, and that's at least partially desired

Thomas Ward

ok

I'm thinking it should still complain rather than just flat out crash IMO

Undo

I'm fine with making it more descriptive, but the auto reverter is fairly critical, especially around low-level login stuff

Thomas Ward

20:57

indeed.

we could do a 'test' API call to GitHub long before then to try and 'capture' the issue, back up where we check if username and pw are set anyways

Undo

Oh, this is a GitHub credentials thing?

Thomas Ward

potentially

@Undo yes

@Undo errant carriage return in the copy/paste from what you sent me broke creds

and the blacklisting earlier

Undo

In that case, I'm fine with catching the exception and doing whatever with it.

Post to chat, etc

Thomas Ward

@Undo this line specifically caused the failure for "Bad Credentials" in gitmanager.py:

Undo

Wondered about that spacing, inbox never likes pasting from the terminal

Thomas Ward

20:59

return (True, "You don't have code privileges, but I've [created a pull request for you]({0}).".format(response.json()["html_url"]))

because html_url wasn't present

(line 80)

Undo

Yeah, that's high level and we can handle it however. I'm fine with anything you want there.

Transcript for