Charcoal HQ

hichris123

00:56

@Undo I put some stuff in the cronjob. Need some help, though.

Undo

@hichris123 Oh, I have it almost done on my local copy.

hichris123

Oh... :P

Undo

Here, I'll commit what I have.

hichris123

Okay.

You saving my stuff? How decent of you. :P

Undo

There, how's that look?

@hichris123 I can't stand throwing away work :P

hichris123

00:59

@Undo I included instead of copying code. :P

Undo

@hichris123 oh, not a bad idea.

hichris123

I don't care which we use.

Whichever works. :P

Undo

Mine doesn't work yet, but it's close.

hichris123

Mine should work, but I don't know how to get the id from the array it returns.

Undo

@hichris123 You seem to be making one API request per comment - we can batch them in groups of 100

hichris123

01:09

@Undo Should now be bunched, comma separated

Undo

@hichris123 Semicolon seperated.

Uh oh, including context.php automatically runs the code in it, causing badness.

Let's move the curl method to base.php

hichris123

Okay.

You do it, please?

Undo

Did

hichris123

How do you get the response, and parse the id?

Undo

I think mine almost works except for the part of actually removing the ids from the array.

@hichris123 I get the response with this:

$obj1 = json_decode($response);
$items = $obj1->{'items'};

lol, the MathJax script catches that

Right now I'm trying to figure out how to loop through the returned id's and remove them from the array

I just managed to accidently make a thing that printed 'hi' to my console like 80,000 times :P

hichris123

01:27

+1

Undo

01:37

gtg, will work on cronjob stuff tomorrow.

hichris123

Okay.

Bye

ManishEarth

03:54

@Undo oh, btw, ping me when you get your swagbox.

Undo

04:14

@ManishEarth Why?

Did you plant a bomb in it and you want to know when to set it off?

(I always look for the worst thing that could happen. Then I am relieved when it doesn't happen :P)

ManishEarth

04:30

@Undo Because I need to pick up mine, and being in a hostel packages come to the office which is only open on certain times of the day

Best to only try to look for it when you know it's coming

Undo

@ManishEarth Well... we live in different parts of the world - who's saying mine comes slightly before yours?

But ok

ManishEarth

@Undo Yeah, but they will come around the same time

SE usually ships quite late. Though I think it won't this time

Undo

@ManishEarth Oh, ok.

ManishEarth

I can't put it past Tim to plant a bomb, though :P I bet Oded will ask him to. You seem to be breaking lots of things :P

Undo

I've only broken 1... 2 things this month!

ManishEarth

04:34

2?

Undo

And I swear I didn't read much!

ManishEarth

One was the sekrit thing

One was ....?

Undo

@ManishEarth Dev.SO plus the other thing

ManishEarth

What did you break on dev.SO?

Undo

@ManishEarth I got in

And I think I posted some comments.

ManishEarth

04:35

You broke in? That's been around for ages, you just need to tweak how you do it each time

Ah

yeah, but still kudos for finding a new method :P

Undo

I tried to cut a deal with Oded that I would leave if he gave me a dev.so diamond to play around with for a few minutes, and he destroyed me ;(

ManishEarth

haha

Welp, the other thing is not fixed

Undo

@ManishEarth Quit looking!

Too many scary sekrits.

ManishEarth

Nah, just opening the base domain

I assume if that is visible the thing is not fixed

Undo

@ManishEarth Oh, the base domain will stay around.

ManishEarth

04:37

But then again oded mentioned that that needs to stay up because it is actually used

yeah

...which hasn't been done yet

Undo

After they fix this I'm going to poke at it some more and try to get in.

For science!

ManishEarth

haha

Undo

They'll probably just slowban my IP or something :P

ManishEarth

dev.SO has been a nice thing to test skillz on for a while on. First, breaking in via HTML manip, then via some modified html manip, then via your question-visit method, and then via that who must not be named

I tried breaking in via a modified openid but no worky

Undo

It is fun.

ManishEarth

04:40

(I assumed the private beta was tied to email address, which is something an openid provider can spoof. But spoofing didn't work)

Undo

@ManishEarth Mods can't undelete messages?

ManishEarth

12 messages deleted

no

there, now it's harder to find :p

Undo

@ManishEarth Oh, you could have just migrated to the Trashcan, right?

ManishEarth

→ 13 messages moved to Trashcan

still can, I usually do both

Undo

There, that's cleaner.

@ManishEarth You would think that SEKRIT would be kinda high on the priority list, right? I doubt they, like, trust me with SEKRITS :P

ManishEarth

04:46

I think Oded trusts us enough to not abuse it, or even poke at it anymore. The only poking I do is to check if it has been fixed, which can be done without fetching sekrits

Undo

Ah, yeah.

Still, it's rather easy to find.

I have a hard time believing we're the only ones that found SEKRITS, we just might be the only ones to report it.

And if a 14 yr old can find it, someone who really wants SEKRITS can :P

My goodness, one SEKRIT is bad enough - how do you mods handle multiple sekrits, @Manish?

I suppose very carefully, but...

Is it a bad sign that we're within 1700 messages of passing the main chatroom?

Ryan Carlson

13:53

I think I just discovered a pr0blem: only two of the 25 supposedly obsolete comments on SO actually exist.

And only 5 on Programmers.SE exist.

15 on SF

etc.

Undo

16:00

@Ryan Yup, known bug. We've been giving mods lists of comments to just bulk-delete, and Charcoal doesn't know their gone yet. We're working on a cronjob that will fix that.

hichris123

@Undo Me sees that as our cue to work.

Undo

O

lol

@hichris123 I have an idea: You work on yours, I'll work on mine, and then we'll see which one runs the fastest with the lowest bandwidth.

hichris123

@Undo Okay, I need to redo mine. I realized that if all comments aren't from the same site, it will have problems. facepalm

Undo

Hehe

hichris123

16:46

@Undo Got most of it; one question, how do I submit a comment as valid without using AJAX but using submitValid.php?

Undo

@hichris it'd probably be best to just write the query manually.

hichris123

Okay.

Undo

because submitValid.php takes SESSION variables to figure out the site, etc, and you know the site and that user0 needs to be doing it.

hichris123

@Undo True. Is there a way I can test mine to see if it works?

Undo

@hichris123 Hmm

@hichris Push to dev and go to charcoaldev/cronjob.php

Just make sure you set handledBy to 0

hichris123

16:57

@Undo I did. Do you want me to just comment out the handling part, or what?

Undo

@hichris123 Nah, let it to the handling.

We can always just run a UPDATE flags SET handled=0... WHERE handledBy=0

hichris123

What the heck, GitHub?

hichris1234 in a few seconds Update cronjob_2.php

I did something in the future?

Undo

rofl

@hichris123 What is that API key from?

Oh, that's mine.

:P

hichris123

@Undo Yeah.

Undo

bonks self

hichris123

17:00

:P

So did it do anything?

Undo

Lemme look

Ehrm... nope

hichris123

Yeah, didn't think so.

Undo

It should show up in cm/flaghistory

And it doesn't show up in the DB either.

hichris123

Meh, back to the code I go!

Undo

@hichris123 So... are you going through all the flags each time the cronjob is run?

That'll probably get us API banned.

hichris123

17:03

@Undo Where handled = 0

Undo

Yeah

@hichris123 There's 116,000 of those.

I'd suggest we just go through 100 at a time.

hichris123

@Undo How?

Undo

The top 100.

@hichris123 In the flags table, select COUNT(*) from flags where handled=0 gives 116663

hichris123

Look at the top bar thingy, though.

Undo

@hichris123 Top bar thingy only shows where len(text)<40

To make it look more manageable.

hichris123

17:05

Oh...

We need to make a cronjob column.

That tells the last time we ran it for that comment.

Undo

@hichris123 Hmm...

I made one on the sites table, but a per-comment one would be nice too.

Yeah, let's do that.

`lastCronCheck` timestamp NULL DEFAULT NULL

hichris123

Yay!

Undo

gtg

adios

hichris123

See ya.

ManishEarth

@hichris123 why? Cron just ... runs

Or have the job timestamp>log.log and read from that

hichris123

17:12

@ManishEarth So we don't check every comment all the time.

Overkill + will get us API banned.

ManishEarth

@hichris123 ah

@hichris123 better: When I load a page, gimme a button that runs the check for all the comments on the page. You can batch up ids in the api, so that becomes one api request

hichris123

@ManishEarth Hm...

May involve a lot of refreshing, though...

Because I'd be willing to bet there are tons of comments that are deleted.

ManishEarth

Or make it cron, but also manually triggerable

@hichris123 api.stackexchange.com/docs/vectors

hichris123

@ManishEarth Are you talking on the review page? Because most of those 25 will have been deleted.

I'm saying to find a lot of comments that aren't deleted, you're going to have to refresh the page a lot.

ManishEarth

@hichris123 Yeah, but the workflow changes to this: Run the clearing thingy, use the review page till the deleted comments turn up again, wash, rinse, repeat

@hichris123 Or, add a third option next to the first two for each comment: "The comment was already deleted". That will trigger the script, and refresh the page

hichris123

17:21

@Manish The thing though is that the review page doesn't auto-load more comments, and out of 25 there's going to be at least 12 if not more deleted, so it seems easier just to run a mass cronjob.

ManishEarth

@hichris123 most of the times the cronjob will go to waste

hichris123

@ManishEarth Huh. That might be a good idea.

hichris123

21:33

@Undo

in Tavern on the Meta on Meta Stack Overflow Chat, 40 mins ago, by hichris123

status-delivery-prepared

For the Arduino.

Undo

hehe

hichris123

@Undo Did you see my screenshot?

Undo

@hichris123 Yup

Kinda disturbing, huh?

hichris123

Yeah, still showing that.

And still [status-delivery-prepared].

Undo

hmm

Transcript for