Charcoal HQ

Undo

00:09

@hichris123 Works now. No ajax, but it still works.

ManishEarth

01:30

@Undo scalability+easy-to-code+thats-how-you-should-have-done-it,yes. Stack Overflow's data might clutter up the rest though, and reduce performance. Ask some dbas

@Undo Ideally a common.php containing common magic would be good. PDOifying becomes easier

but not necessary

hichris123

02:06

@ManishEarth What was that post?

@Undo So can I take out the UI without functionality part?

Undo

02:43

@hichris123 Yes. I'm planning to AJAX it soon, make it prettier.

But yes.

@ManishEarth rofl

@ManishEarth Where might I find some of those?

@hichris123 Next step: Put in a destroy user button for CMs

@ManishEarth SO has ~30,000 rows - is that enough to significantly slow down everything else?

(and we should let CMs override flag rulings from the history page)

hichris123

@Undo Um.... why?

Undo

So that we can destroy test users.

hichris123

Oh, yeah.

Undo

(maybe just for devs, I dunno. Got tired of deleting them from the DB)

@hichris123 What do you think of moving the mod/cm menus to the right side? I thought I would model it after SE - how's it feel?

hichris123

@Undo I don't know, doesn't seem too different. I'm just used to it being on the otherside.

Undo

02:57

I am too.

hichris123

@Undo What would be the purpose, though?

Undo

@hichris123 For tuning the algo, and reverting obvious misclicks.

But I'm just thinking out loud.

hichris123

Good idea.

hichris123

16:17

I think my school's going to close tomorow! Yay!

Undo

@hichris123 Hehe

Yay!

hichris123

@Undo Not closed yet, though.

Undo

@hichris123 Oh. Maybe it needs to snow more.

hichris123

@Undo No more snow, but -20F with windchill of -40 to -50 F tomorow morning.

Undo

Ouch.

hichris123

16:27

Yeah, me no likey.

Undo

That's, like, really really cold

The internet should slow down when it gets that cold.

hichris123

I hope not.

That would be... terrible. :P

Undo

Hehe

I guess it will probably speed up, the electrons can move with less resistance.

But not enough for anyone to notice.

hichris123

Heck if I know.

Or the power might go out.

Undo

That would slow down the Internet.

hichris123

16:29

(It actually did for some time last night)

Undo

Or at least your corner of it.

Hmm

You should build a generator.

A little steam engine thing.

hichris123

Okay....

I don't know if I really need it, though.

Undo

I dunno how, but it would be fun.

You could build everything from scratch. Except the magnets, they might be problematic.

hichris123

They would be.

Undo

Let's make that cronjob.

Or...

hichris123

16:32

Options?

Undo

Maybe we should move all the flags into one table.

That would make cronjob-making easier.

hichris123

We could, or we could just manually run it with each site database.

Undo

Yeah, but we want this to be scalable.

hichris123

True.

Meh, I don't care, your call.

Undo

Let's put them into a big flags db table

4

A: Create a new table from merging two tables with union

You can use CREATE TABLE ... SELECT statement. CREATE TABLE new_table SELECT * FROM table1 UNION SELECT * FROM table2;

^ Aha!

SO is amazing.

hichris123

16:35

@Undo What do you see if you go into here? chat.stackexchange.com/?tab=site&sort=active

Undo

The Space.SE room

hichris123

Is it the site where you're most active?

I see SO.

Undo

It's the site where I have the most rep outside of mSO

hichris123

17:01

@Undo School closed!

Undo

@hichris123 Yay!

ALTER TABLE `apple` ADD `site` TEXT  NULL  AFTER `reason`;
UPDATE `apple` SET `site`='apple';

ALTER TABLE `physics` ADD `site` TEXT  NULL  AFTER `reason`;
UPDATE `physics` SET `site`='physics';

ALTER TABLE `programmers` ADD `site` TEXT  NULL  AFTER `reason`;
UPDATE `programmers` SET `site`='programmers';

ALTER TABLE `serverfault` ADD `site` TEXT  NULL  AFTER `reason`;
UPDATE `servefault` SET `site`='serverfault';

ALTER TABLE `stackoverflow` ADD `site` TEXT  NULL  AFTER `reason`;
UPDATE `stackoverflow` SET `site`='stackoverflow';

^ I hope this works.

hichris123

You can hope.

Undo

It worked!

Unified site table schema:

CREATE TABLE `flags` (
  `dbid` int(11) unsigned NOT NULL DEFAULT '0',
  `Id` int(11) DEFAULT NULL,
  `PostId` int(11) DEFAULT NULL,
  `Score` int(11) DEFAULT NULL,
  `CreationDate` timestamp NULL DEFAULT NULL,
  `UserDisplayName` text,
  `Text` text,
  `UserID` int(11) DEFAULT NULL,
  `wasObsolete` int(11) DEFAULT NULL,
  `handled` int(11) DEFAULT NULL,
  `handledBy` int(11) DEFAULT NULL,
  `wasValid` int(11) DEFAULT NULL,
  `handleDate` timestamp NULL DEFAULT NULL,
  `reason` text,
  `site` text

hichris123

Yay!

Undo

Now we must fix Charcoal to work with it

hichris123

17:10

Yep.

Okay.

Undo

I'm going to delete the individual site tables on the dev DB, so that it blows up where we haven't fixed it.

Done

hichris123

I'll do the numbers on the front page.

Undo

Ehrm... just did that :P

@hichris123 I'll fix the CM stuff, you fix the backend submitvalid/invalid/whatnot stuff

hichris123

@Undo That's the base.php. Not the homepage.

Undo

Oh

hichris123

17:15

I'll fix that.

Undo

ok

I'll go fix viewuser.php

viewuser.php fixed

hichris123

Front page fixed.

Undo

flagqueue.php fixed

hichris123

@Undo For submit valid, should I change UPDATE " . $_SESSION["Site"] . " to UPDATE flags?

Undo

@hichris123 Yes, with a WHERE SITE='" . $_SESSION["Site"] . "'

stats.php fixed

users.php fixed

hichris123

17:24

@Undo Am I doing something wrong on SubmitInvalid?

Undo

Lemme look

@hichris123 lowercase site

hichris123

@Undo Fixed that.

Still isn't working.

Undo

Hmm

What isn't working about it?

hichris123

Not showing up in the flag history.

Undo

Right, it's not getting registered in the DB even. Hmm

That did it. You need single quotes around the site.

hichris123

17:28

Oh, why?

Undo

I dunno

I just know that it works when you have them :P

hichris123

:P

Undo

@hichris Ok, what stupid thing am I doing in flagsformods.php?

Oh, it works now.

Hmm

Maybe the stupid thing was not pulling it :P

hichris123

I wonder why...

What else needs to be fixed?

Undo

Hmm

hichris123

17:30

I did all of the submits.

Undo

I did all the CM/mod stuff

@hichris123 I think we're done.

Wow

Let's push to main and see what happens.

Looks non-broken at first.

I'm deleting the individual site tables on main now.

hichris123

I'm going to take out all of the Select * from sites stuff, if you don't mind.

Undo

@hichris123 Why?

We need some of it, right?

hichris123

@Undo Which part?

Undo

Hmm

@hichris123 What are you going to replace it with?

hichris123

17:33

@Undo It doesn't need to be as for the ones I'm thinking of you fixed it with instead of siteTableRow or whatever, it's flags.

Like here:

   $sites = mysql_query("SELECT * FROM sites");
    echo "<span class='small'>Created on <strong> " . $creationdate . " </strong></span>";
    echo "</br>";
    while ($row1 = mysql_fetch_array($sites))
      {
          $aQuery = mysql_query("SELECT COUNT(*) AS number FROM flags WHERE handled=1
          AND handledBy = " . $userid . " AND site='" . $row1["siteTableName"] . "'");
          $bQuery = mysql_query("SELECT COUNT(*) AS number FROM flags WHERE handled=1
          AND handledBy = " . $userid . " AND DATE(handleDate) = CURDATE() AND site='" . $row1["siteTableName"] . "'");

Undo

We need it there, right?

Or I suppose we could do a GROUP BY site

But let's leave it for now.

hichris123

Okay.

Undo

We should see if our last big refactorifying breaks anything :P

hichris123

What's all of the stuff in login.php?

Undo

Not sure

:P

hichris123

17:37

:P

Undo

We can nuke it.

hichris123

We even use it?

Undo

Nope

Login still works without it.

hichris123

Yep.

Undo

@ThiefMaster Where's that link to that PDO tutorial again?

ThiefMaster

17:43

> Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial.

this one?

Undo

@ThiefMaster Yup, thanks.

@ThiefMaster Do you have that message on some kind of a keyboard paste shortcut or something?

ThiefMaster

in the canned comment userscript

Undo

Ah

Undo

18:05

Yay now my MySQL dbs get automagically backed up to S3!

Doorknob of Snow

[**Please, don't use `mysql_*` functions in new code**](bit.ly/phpmsql). They are no longer maintained [and are officially deprecated](j.mp/XqV7Lp). See the [**red box**](j.mp/Te9zIL)? Learn about [*prepared statements*](j.mp/T9hLWi) instead, and use [PDO](php.net/pdo) or [MySQLi](php.net/mysqli) - [this article](j.mp/QEx8IB) will help you decide which. If you choose PDO, [here is a good tutorial](j.mp/PoWehJ).

@Undo There's the source :P in case you need it later

Undo

Yay! Thanks @DoorknobofSnow

hichris123

18:19

@Undo How?

Undo

@hichris123 gist.github.com/oodavid/2206527

hichris123

Wow.

hichris123

19:12

@Undo Can we redirect the user from /cm to the login page if they're not logged in, so I don't have to remove the /cm/users out of the URL everytime I get automatically logged out?

Undo

@hichris123 If you want to, sounds good to me.

hichris123

19:23

@Undo Me got it on one. Doing it on the rest.

Should be good now.

Undo

Yay!

hichris123

Me likes the stuff we're doing to Charcoal! :P

Undo

Me does too

hichris123

Can I get rid of this? @Undo github.com/Undo1/Charcoal/blob/master/signupsubmit.php

Undo

@hichris123 yes

hichris123

19:37

Gone

Why was all of this stuff there?

Undo

@hichris123 From experiments.

(pre-github)

hichris123

Ah.

Should be a lot easier for the cronjob now.

Undo

Yes

hichris123

19:55

@Undo Can we make the show context link like it's clickable instad of the text input cursor?

I looked, but it's a <p> so I don't get why it's doing that.

Undo

20:06

@hichris123 The jQuery action is tied to it.

So that's why it's clickable.

No idea how to make it underlined.

hichris123

20:21

Meh, not that important.

Undo

22:27

I'm trying to figure out how we can extend Charcoal to posts.

hichris123

SEDE?

What do you mean?

Undo

I'm talking about the UI

Should we present things like they show up in the 10k flag queues?

hichris123

I guess, it isn't that different from regular Charcoal, right?

Undo

Right

Posts are longer, and thus need more room (and possibly a score indicator and whatnot)

Transcript for