« first day (1217 days earlier)      last day (2603 days later) » 

3:00 AM
uhm
@quartata i have concern.
you wrote queue_timings right?
 
no
art did
 
ah
@ArtOfCode i shall slap thee
 
What happened?
 
he's referencing a variable before it has any initialization
also python 3 and not python 2
though for queue_timings there's no syntax differences
well, there is, but...
 
!!/errorlogs 50
sd del
 
3:06 AM
!!/errorlogs 50
 
  File "ws.py", line 277, in <module>
    a = ws.recv()

  File "/usr/local/lib/python2.7/dist-packages/websocket/_core.py", line 293, in recv
    opcode, data = self.recv_data()

  File "/usr/local/lib/python2.7/dist-packages/websocket/_core.py", line 310, in recv_data
    opcode, frame = self.recv_data_frame(control_frame)

  File "/usr/local/lib/python2.7/dist-packages/websocket/_core.py", line 323, in recv_data_frame
    frame = self.recv_frame()

  File "/usr/local/lib/python2.7/dist-packages/websocket/_core.py", line 357, in recv_frame
 
no that's OK to keep in place
and I was reading that so blah
 
You can see deleted messages anyways..
 
not from my tablet I can't.
hey at least the warning capture is not exploding heh
 
Wait really?
se chat pls
 
3:07 AM
@quartata not easy to find post logs from the mobile interface
:P
but now i have my laptop so im switching to that
@ArtOfCode cPickle replaced with pickle module implementation changes instead in Python 3.x
also you had a variable you'd be referencing that had no value so you'd explode
 
CI on f604590 succeeded.
 
so i had to update queue_timings.
and why Python3?
 
@ThomasWard probably because Python 3 is newer, and since that code isn't actually run as part of the bot (and hence doesn't have any compatiabily issues), we may as well use the most up to date version
 
@angussidney then the fix I just uploaded has to be included for a run - cPickle will give an import error in most Python3
and there's still the "NoneType" object error I just poked to fix.
i'm not a fan of that but...
anyways time to keep poking the postdata part of the refactor heh
i'd love to test it, but... it looks like nothing's going on today
o.O
 
3:24 AM
Yeah it concerns me
 
what does
PostData() and Post() being pretty much the same object, except the second is far better handled / laid out?
or the fact we're not getting any Answers showing up?
 
What'd I break?
 
@ThomasWard The latter.
 
@Undo Thomas's !!/blame system :P
 
@Undo my brain
 
3:26 AM
@Undo Nothing. Thomas apparently had a better getter for parent in another branch
 
because you stole my coffee.
@quartata actually i thought you made other changes, all's good :)
mmmmmmm brownie pizza
mmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm
 
@ThomasWard This sounds hard to execute properly
 
@Undo basically dessert pizza with a metric ton of chocolate.
@Undo can you make sure Smokey is actually checking answers, via MS logs?
 
And I was just about to say welcome back to @hichris123.....
 
i want to make sure that it's working as intended.
 
3:28 AM
when he left
 
@ThomasWard No.
I have no data on that
 
I do have some cookie pie in the fridge but I can't say I have ever heard of a brownie pizza
 
hrm OK
oh i know what I can do
 
here, there's an easy solution
 
!!/standby ArtOfCode
 
3:29 AM
ArtOfCode/EC2 is switching to standby
[ SmokeDetector ] SmokeDetector started in standby mode at rev 13f9301 (ArtOfCode-: Ain't flake great) (running on ArtOfCode/EC2)
 
fuuuu hang on
 
Undo's Raspberry Pi received failover signal.
Restart: API quota is 19963.
 
!!/test-a quickbooks support number
 
> Bad keyword in answer
----------
Body - Position 1-26: quickbooks support number
 
Overlord time
 
3:30 AM
!!/standby ArtOfCode
 
!!/rev
 
crap
 
eww
TypeError: list indices must be integers, not str
 
I thought I fixed that?
Yeah I did.
 
3:32 AM
doesn't look it from the master code base
 
Also it was string indices or something actually
 
!!/pull
@quartata well...
TypeError: list indices must be integers, not str
2017-03-18 03:31:00.626484 UTC
  File "/home/teward/VCS Repos/GitHub/Charcoal-SE/SmokeDetector/excepthook.py", line 48, in run_with_except_hook
    run_old(*args, **kw)
  File "/usr/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/teward/VCS Repos/GitHub/Charcoal-SE/SmokeDetector/bodyfetcher.py", line 90, in add_to_queue
    self.queue[site_base][str(post_id)] = datetime.utcnow()
that's... in Master
so str(post_id) is exploding.
 
watch it explode here too
which would explain why things are blowing up
 
Oh not me. I assumed this was in FindInSpam since I got a similar error
earlier
!!/errorlogs
 
3:33 AM
  File "/media/sda1/SmokeDetector/ChatExchange/chatexchange/browser.py", line 311, in send_message
    {'text': text})

  File "/media/sda1/SmokeDetector/ChatExchange/chatexchange/browser.py", line 133, in post_fkeyed
    return self.post(url, data, headers)

  File "/media/sda1/SmokeDetector/ChatExchange/chatexchange/browser.py", line 113, in post
    return self._request('post', url, data, headers, with_chat_root)

  File "/media/sda1/SmokeDetector/ChatExchange/chatexchange/browser.py", line 102, in _request
 
!!/location
 
well, there we go.
kablooey
 
Anonymous
So... Unit testing? :D
 
just disable queue timing
@Mego We do
 
3:35 AM
[ SmokeDetector ] SmokeDetector started at rev 13f9301 (ArtOfCode-: Ain't flake great) (running on Undo's Raspberry Pi)
 
!!/standby Undo
@quartata i'd rather fix the issue first
 
Anonymous
Unit testing should be able to catch trying to use a str as a list index before deployment and subsequent kablooey
 
Do we have tests for body fetcher actually
 
wow 404 error xD
 
@quartata that's a difficult thing to unit test
 
3:36 AM
@Mego not everything has unit tests.
 
[ SmokeDetector ] SmokeDetector started at rev a46f747 (ArtOfCode-: Shorten site names) (running on Undo's Raspberry Pi)
 
@Undo Particularly this part.
 
[ SmokeDetector ] SmokeDetector started in reverted mode at rev a46f747 (ArtOfCode-: Shorten site names) (running on teward/Overlord)
 
ahhhh i see what's going on...
 
[ SmokeDetector ] SmokeDetector started at rev 33ab6fe (ArtOfCode-: Make analysis script python 2) (running on Undo's Raspberry Pi)
 
3:38 AM
i see what we need to do
We're expecting that the site ID list is in a dict
but it's really not actually doing that
it's creating lists of ints.
that is why queue timing fails
 
That commit is after the merge from time in queue by the way.
revert the pi to 92adc01
 
it'll get there eventually
 
[ SmokeDetector ] SmokeDetector started at rev 92adc01 (ArtOfCode: Merge pull request #599 from quartata/master) (running on Undo's Raspberry Pi)
 
there we go
 
3:42 AM
Restart: API quota is 19959.
 
hrm
@Undo I think that ArtOfCode failed to refactor this proper
i'll have to have an if statement to check the type of the item, and if it's not a dict convert to a dict.
this is going to be painful.
 
Honestly, if it's becoming work, then don't worry about it. This is a hobby project, no reason to be working on anything you don't want to
 
Restart: API quota is 19957.
 
!!/status
 
@Undo Running since 03:43:31 UTC (2 minutes)
[ SmokeDetector | MS ] Pattern-matching website in body: Map of neighbourhoods for Canada by Tom on gis.SE
 
3:48 AM
!!/errorlogs 100
!!/alive
 
i think something blew up
 
Restart: API quota is 19939.
 
I see it
AttributeError: 'dict' object has no attribute 'append'
2017-03-18 03:48:25.573244 UTC
  File "/media/sda1/SmokeDetector/excepthook.py", line 48, in run_with_except_hook
    run_old(*args, **kw)

  File "/usr/lib/python2.7/threading.py", line 505, in run
    self.__target(*self.__args, **self.__kwargs)

  File "/media/sda1/SmokeDetector/bodyfetcher.py", line 85, in add_to_queue
    self.queue[site_base].append(post_id)
Okay, don't touch the code. I'm reverting some stuff
 
erm, you're four minutes too slow
@Undo revert my change too.
@Undo though I was going to try and fix all these issues
oh wait that's a one-line fix in addition to my code
want me to fix?
 
I'm just going to batch revert everything between 95ee2 and HEAD
After that, you can revert the revert locally and do whatever
 
3:51 AM
OK
@Undo this 'work' is something i want to do :P
so it's not really 'work' per se
also keeps my brain sharp :)
 
k. Just trying to head off burnout
 
teward/Aurora received failover signal.
Restart: API quota is 19999.
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, link at end of body, pattern-matching product name in body, pattern-matching website in body: Did it is well known that there are amazing dietary supplements by kacasuj on meta.SE
 
LOL
or until i'm better
 
bah, git is hard
 
@Undo note that that 'append' isn't there no more. at least ,not in my code.
probably has something to do with the refactor/conversion
 
3:57 AM
@ArtOfCode After you're done figuring out what's going on up there ^ , here's that pickle run through panda's simple describe() and adding median
                     count        mean      median         std       min         25%         50%         75%         max
islam                  4.0  127.269991   74.985501  169.960406  0.000285    0.000376   74.985501  202.255116  359.108676
vi                     2.0    6.722596    6.722596    9.506857  0.000233    3.361414    6.722596   10.083778   13.444959
superuser              2.0    0.159724    0.159724    0.225348  0.000379    0.080051    0.159724    0.239396    0.319069
english                2.0  421.326939  421.326939  595.845718  0.000391  210.663665  421.326939  631.990212  842
 
code format is useful @Andy
just saying ;)
 
Yeah yeah, it didn't format the first time
 
blame SE
 
Obviously, that's a small dataset you sent me since only a couple sites are in it and even fewer have more than two items in the list.
 
tpu- by teward
 
4:00 AM
!!/location
 
@ThomasWard teward/Aurora
 
!!/rev
 
oh right that's not a recent pull
!!/standby Aurora
 
[ SmokeDetector ] SmokeDetector started in standby mode at rev 158e861 (Thomas Ward: Slight refactor of chat logon handling.) (running on teward/Aurora)
teward/ESXi received failover signal.
 
4:01 AM
seriously wtf Overlord
ValueError: invalid literal for int() with base 10: 'users'
!!/standby teward
 
teward/ESXi is switching to standby
 
osnap
 
Reverted a bunch of stuff. @ThomasWard you'll want to pull and revert 0177abf locally if you're trying to figure this out
!!/pull
aaaactually, maybe shouldn't have pulled that. Sorry if I messed up a debugging session
 
it's dead
it blew up with attribute errors later on
 
4:04 AM
Ah, okay.
 
@Undo did @ArtOfCode write this recent queue stuff
 
Which queue stuff?
 
the stuff you just reverted
 
Tentative yes
It's in the commit history
 
well permit me to yell at @ArtOfCode because lists and dicts aren't interchangeable objects.
and he's using lists everywhere for some unknown reason
 
4:05 AM
ArtOfCode/EC2 received failover signal.
 
!!/pull
 
[ SmokeDetector ] SmokeDetector started at rev 0177abf (Undo1: Revert a lot of things) (running on ArtOfCode/EC2)
Restart: API quota is 18163.
 
oh come on
!!/errorlogs 100
 
    return self._request('get', url, data, headers, with_chat_root)

  File "/home/ubuntu/Smokey/ChatExchange/chatexchange/browser.py", line 105, in _request
    time.sleep(0.1)


WARNING: Cannot update TLD names, due to `tld` being system-wide installed and not user-level installed.  Skipping TLD names update.
KeyboardInterrupt
2017-03-18 00:33:08.514255 UTC
  File "ws.py", line 277, in <module>
    a = ws.recv()

  File "/usr/local/lib/python2.7/dist-packages/websocket/_core.py", line 293, in recv
 
!!/status
 
4:08 AM
@Undo Running since 04:06:36 UTC (1 minute)
 
Stable now?
Maybe reverting wasn't necessary after your last fix
 
@Undo it'd fail later on with other attribute errors
the problem is dict vs. list
and they're really not interchangeable.
 
yeah
So when was that introduced?
 
@ArtOfCode, I'm gone all Saturday and most of Sunday. I'll poke again Sunday night. If you have ideas on what I should look at/for, let me know.
 
sometime since i went offline.
 
4:09 AM
@Undo A few hours ago
 
Ohhhhh
 
@Undo it was art of code who introduced all those changes
so beat him over the head
 
I know
Small thing.
 
[ SmokeDetector ] SmokeDetector started at rev 0177abf (Undo1: Revert a lot of things) (running on Undo's Raspberry Pi)
 
4:12 AM
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, link at end of body, pattern-matching website in body: Rocky Balboa Diet And Weight Loss Plan by Nitin Prakash on askubuntu.com
Restart: API quota is 19999.
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, link at end of body, pattern-matching website in body: Rocky Balboa Diet And Weight Loss Plan by Nitin Prakash on askubuntu.com
 
yeah, so @ThomasWard we'll just need to nuke bodyfetcherQueue.p, then current rev should work fine
!!/location
 
@Undo ArtOfCode/EC2
@Undo Undo's Raspberry Pi
tpu- by angussidney
 
!!/standby art
 
tpu- by angussidney
 
@Undo by 'current rev' we mean which?
 
my last push minus your revert?
 
@ThomasWard HEAD on master
 
[ SmokeDetector | MS ] URL-only title, bad keyword in body, bad keyword in title, blacklisted website in body, blacklisted website in title, +1 more: menintalk.com/zilotrope/ by gedwsctysedx on askubuntu.com
 
because that'll need changes too
 
Including the revert. It may also work without the revert, haven't tested
 
4:13 AM
tpu- by Undo
 
@Undo I'll test local
 
Sweet
 
And pulled in around here-ish
 
since I didn't merge your revert yet on Overlord
@Undo for queue timings, if we have a failure case, what do we want a 'default' queue timing to be, -1? 0? 999999999999? Infinity?
(there will be failure cases, which is unfortuante but eh)
 
@ThomasWard Might as well not record it
 
4:15 AM
@ThomasWard -1
 
@Undo I can set it to None, or just skip over.
 
@ThomasWard Just skip over
 
Noooooooooooo
 
I defer to Andy
 
i'll put -1 in place
 
4:16 AM
Actually, I take that back. First: What is this failure from?
Failure to input into the queue? Or failure from the API?
 
Pretty sure it'd be failure from the API, or from parsing something from the API.
 
Oh. Then yes, skip it.
 
[ SmokeDetector | MS ] URL in title, blacklisted website in body, blacklisted website in title: purelifegreencoffeebeanadvice.com/vitaClara/ by Zilpyf on graphicdesign.SE
tpu- by Undo
 
Well, I guess we're processing stuff
 
Over reacted with that wilhelm scream.
 
4:19 AM
@Andy the 'failure' would be where there's no 'add time' to compare with
which can happen in empty cases.
 
empty?
 
post_add_times = [v for k, v in new_posts.iteritems()]
if there's nothing in iteritems() here it's an empty list
 
But that should be rare, right?
 
@Undo yes, but i want to be totally sure :P
 
Yeah. If we have unusable data, I'd vote to skip it.
 
4:21 AM
Agreed
 
let me debug-run this as it was, so I can examine what data's actually in here
though I did just nuke all my pickles so probably nothing :P
 
@ThomasWard This'd be a good time to test the no-chat argument, if you're interested
 
!!/location
 
@ThomasWard Undo's Raspberry Pi
@ThomasWard teward/Overlord
 
4:23 AM
@Undo shortly
!!/standby Undo
 
k
 
i want it to emulate a normal run first
 
Restart: API quota is 19991.
[ SmokeDetector ] SmokeDetector started in standby mode at rev 0177abf (Undo1: Revert a lot of things) (running on Undo's Raspberry Pi)
 
i think there was an explode
 
Everything looks normal from chat, but you know more than I do from your debugger
(afk)
 
4:25 AM
yep
it breakpoints on certain errors being raised
so i see all the error failures
 
hence why it's called a debugger
 
Restart: API quota is 19989.
 
@Undo OK so if we nuke the existing pickle for the queue first, it properly has list objects without me messing with the code.
and that solves both the append error we had beofre which I refactored out
and other attribute errors later on.
so we need the instances to erase the pickles. Which means we need to kill Art's EC2 until he can do that manually so it doesn't come back online.
Or implement a one-time kill code for the queue pickle file.
@Undo so, how do we want to handle that?
 
4:41 AM
teward/Aurora received failover signal.
Restart: API quota is 19981.
 
@ThomasWard This'd probably be the best way to do it, yeah
 
OK I'll push that to ws.py after I test my revert of your revert plus my changes, with a clean pickle
... that sounded weird
 
Thanks for digging into that, good that it's a simple fix
 
eh not so simple, but we convert the general 'list' to a dict so we can use it earlier on which is what we were blowing up with
but we still need to nuke existing pickles and start again.
@Undo so what i'm going to do is this:
once i test this code and it works
i'm going to push to ws.py to delete that pickle file if it exists.
then cycle all the instances to pull in the new ws.py and also execute it.
then pull that 'kill the pickle' out.
and also cycle to everything and pull ws.py
that's a painful process but not as painful as fixing things
 
Yep, sounds sane
 
4:45 AM
any objections except for the massive standby/active/standby/active chain that'll happen?
actually
just turn them all to active
then pull
then revise and pull again
 
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, pattern-matching product name in body, pattern-matching product name in title, pattern-matching website in body, +1 more: Alpha monster advanced by gysw apos on apple.SE
 
MASS OVERLOAD
 
@ThomasWard Nope
 
nah i'll do it piecemeal
!!/standby teward/Aurora
 
[ SmokeDetector ] SmokeDetector started in standby mode at rev 158e861 (Thomas Ward: Slight refactor of chat logon handling.) (running on teward/Aurora)
Undo's Raspberry Pi received failover signal.
 
4:46 AM
Easy enough to failover all of them, then !!/pull
 
yup
 
[ SmokeDetector ] SmokeDetector started at rev bad35f0 (Thomas Ward: Revert "Revert a lot of things") (running on teward/Overlord)
 
!!/standby Undo
i haven't committed my latest changes yet
 
[ SmokeDetector ] SmokeDetector started in standby mode at rev 0177abf (Undo1: Revert a lot of things) (running on Undo's Raspberry Pi)
 
so i just need it to wait for a few
there we go it's got queue items now and NO ERRORS
waiting for the timing stuff to hit
 
4:48 AM
Restart: API quota is 19952.
 
... explosion
 
[ SmokeDetector | MS ] URL in title, link at end of body, pattern-matching website in body, pattern-matching website in title: platinumcleanserinfo.com/laveaderm/ by ewancollins on meta.SE
tpu- by angussidney
 
looks like I fubar'd a type check oops
 
[ SmokeDetector ] SmokeDetector started at rev bad35f0 (Thomas Ward: Revert "Revert a lot of things") (running on teward/Overlord)
Restart: API quota is 19948.
 
restarting it because I blew it up
oops
 
4:51 AM
[ SmokeDetector ] SmokeDetector started at rev bad35f0 (Thomas Ward: Revert "Revert a lot of things") (running on teward/Overlord)
Restart: API quota is 19946.
 
@Undo yeah i think i fixed it
everything looks to be behaving. I'm going to push this code up and then add the "Kill Pickle" in ws.py, and pull on every instance sequentially
 
teward/Aurora received failover signal.
CI on 10425ad succeeded.
Restart: API quota is 19963.
 
!!/pull
 
!!/standby teward/Aurora
 
4:57 AM
teward/Aurora is switching to standby
ArtOfCode/EC2 received failover signal.
Restart: API quota is 18145.
 
!!/pull
 
!!/standby ArtOfCode
 
ArtOfCode/EC2 is switching to standby
teward/ESXi received failover signal.
 
waits
!!/pull
 

« first day (1217 days earlier)      last day (2603 days later) »