« first day (1481 days earlier)      last day (343 days later) » 

1:00 PM
fp- by Mithrandir
[ SmokeDetector | MS ] Bad keyword with email in answer, email in answer, pattern-matching email in answer: Buying a car - advice needed by michael smith on money.SE
tpu- by Glorfindel
 
@Mithrandir change your keyboard
 
@SmokeDetector f
gah
@SmokeDetector k
 
This seems like a spame to me but I'll ask for second opinion before reporting: geodesic dome strut length with connector (Mathematics).
 
[ SmokeDetector | MS ] Manually reported answer: geodesic dome strut length with connector by maja on math.SE
 
1:04 PM
@SmokeDetector k
 
TL;DR: We get alpha access. We own our content; SE owns Channels; we license our content to SE to use within Channels. Any feedback (including usage data) we give or generate is not confidential and our ownership of it gets assigned to SE; SE has to ask if they want to use our logos or text feedback in public materials. Don't be a dick or our access gets revoked. No warranty; no liability; backup your data.
8
 
!!/watch geourbgroup\.com
 
@Mithrandir Added geourbgroup\.com to watchlist
 
Person signing must be authorized and legally able to do so; that basically means admins or someone else we can agree on, and over 18.
 
1:06 PM
CI on 9b575c8 succeeded. Message contains 'autopull', pulling...
Restart: API quota is 15426.
 
I meet those conditions, so I'm happy to sign it if nobody objects to the terms.
 
@ArtOfCode May i ask what this is about?
curious one I'am :)
 
@Videonauth sure, we're getting a Channel :)
specifically, alpha access to test channels, starting w/c Feb 12 '18
 
ohhhh nice, serious stuff getting serious :D
 
[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body, +1 more: The coffee and crushed refreshments by Owit1979 on askubuntu.com
 
1:11 PM
@Art any insight into why hichris1234 is no longer seen as a contributor by PullApprove?
@SmokeDetector k
 
sooooo... Email addresses, we need to get on top of those. Currently, the only authentication Channels supports is validation via an email on a specific domain (i.e. charcoal-se.org).
@tripleee changed his name
on GH
 
oh right
 
So: ADMINS: you should all have a charcoal-se.org email address; ping me if you don't
2
 
so the new user name is csnardi?
 
aye, think so
The rest of y'all... here is where we have fun. I can't allocate enough email addresses to cover everyone. We're probably going to have to do this with groups; I've given Kristina a couple of possible solutions so we'll see what they say.
 
1:14 PM
Good to know. How do I access it? :)
What is our email provider?
 
[ SmokeDetector | MS ] URL in title, bad NS for domain in body, bad NS for domain in title, bad keyword in body, bad keyword in title, +5 more: supplementlab.org/focus-zx1/ by user267026 on apple.SE
tpu- by Mithrandir
tpu- by Glorfindel
 
@ArtOfCode fine with me, i am anyways the youngest one here in terms of participation :) merely a day old
 
CI on 42313a9 succeeded.
[ SmokeDetector | MS ] Offensive answer detected: Oracle datasets from two different tables without joining by TheTruthTeller on stackoverflow.com
tpu- by Glorfindel
 
@Andy it would appear there's no address set up for you... I suspect you may have pleaded email address proliferation :)
I can set one up to forward to another address, if that's easier for you
 
1:26 PM
[ SmokeDetector | MS ] Username similar to website in answer: Stripe checkout.js with coupons by freecoupondunia on stackoverflow.com
tpu- by Glorfindel
 
!!/watch freecoupondunia\.com
 
@Glorfindel Added freecoupondunia\.com to watchlist
 
@ArtOfCode That'd be helpful.
Thank you
And that does sound like something I'd have said
looks at Google's quick switch Yup...there are 8 in there right now.
 
CI on 7713044 succeeded. Message contains 'autopull', pulling...
Restart: API quota is 15228.
[ SmokeDetector | MS ] Potentially bad keyword in answer, username similar to website in answer: Best way for printing (semi-)unique coupon codes by freecoupondunia on serverfault.com
tpu- by Glorfindel
 
Are we running NG right now, or did we roll back? Before I finally went to bed there was talk of rolling it back.
 
tpu- by Glorfindel
 
!!/watch clickpay24\.tv
 
@Glorfindel Added clickpay24\.tv to watchlist
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body, link at end of body, pattern-matching website in body, +1 more: Trembolex Ultra: Perform Longer & Stronger Workouts In Gym by marrysnwood on askubuntu.com
tpu- by Glorfindel
CI on 980ac04 succeeded. Message contains 'autopull', pulling...
Restart: API quota is 15185.
 
!!/watch hackmarvel\d*
 
@Glorfindel Added hackmarvel\d* to watchlist
CI on 6e37d12 succeeded. Message contains 'autopull', pulling...
Restart: API quota is 15141.
 
!!/watch 1\W*417\W*323\W*2635
 
@Glorfindel Added 1\W*417\W*323\W*2635 to watchlist
 
1:37 PM
would have a feature request for metasmoke, should I put it at GH?
 
yes, please
 
CI on 9892fc8 succeeded. Message contains 'autopull', pulling...
 
ok, think it would be nice to have a skip button on the review page, actually i have there one review pending and I'm not able to see the post anymore, in such cases it would be nice to skip this.
 
Restart: API quota is 15118.
 
1:41 PM
the review page shows any number of review items, just don't click any button on the ones you want to skip
maybe there could be an "I don't care button" to hide a review from your view for good without providing any feedback for it
 
@tripleee yes this is what I speak of more or the less.
cant always ask Glorfindel or anyone else to pluck them out of my review queue.
 
@tripleee I don't know could also be a feedback type.
 
or Not Sure :D
but maybe without the tattooing part ;)
 
@Glorfindel I don't know if I should reccomend LittleSnitch to that "iPad hacked" question. what do you say?
 
[ SmokeDetector | MS ] Few unique characters in body, no whitespace in body: Collection View terminates after cellForItemAtIndex by J.David on stackoverflow.com
 
1:51 PM
@SmokeDetector v
 
sd v
 
[ SmokeDetector | MS ] Few unique characters in body, no whitespace in body: Adding Photos to Array and Displaying to UICollection View error by J.David on stackoverflow.com
 
@SmokeDetector v
 
sd v
 
@Videonauth that's why we capture post text, so that you can review that
 
1:53 PM
@SmokeDetector rollback needed again :|
 
there is currently no ReviewResult model, so we don't actually have support for removing things from individuals' queues - it's the same review queue for everyone
not to say we couldn't make that happen, it's just not a minor thing
 
@ArtOfCode yes but hard to read in a case like this: metasmoke.erwaysoftware.com/post/96620
 
[ SmokeDetector | MS ] Link at end of answer: How can I recover my account password? by HELAL KHAN on webapps.SE
naa- by Glorfindel
 
@Videonauth that's a Google redirect URL. Someone copied the URL directly out of search results.
Spammers tend to link directly, so I'm gonna go BOD and F
 
1:56 PM
@Federico I have no experience with LittleSnitch.
(and too busy to do any research right now)
 
@ArtOfCode i agree with you i have partly read into the code of metasmoke :)
 
@Andy will do; send me an email address that you want it to forward to. Either here, or email it to me at the one of the usual addresses
@Videonauth yay more people who can make PRs for things :)
 
@ArtOfCode You can use my email address on hardware recs.
 
will do
pretty sure I actually know what that is without even looking it up
clearly I've looked it up many times before :P
 
@ArtOfCode i must confess tho I'm having zero experience with ruby, but beginner level python and have a little bit of C++ background so the basic concepts are easy to understand
 
1:59 PM
@Videonauth that's all you need :)
 
@ArtOfCode :)
 
If i can make sense out of the code i probably gonna for it instead of doing a git cloe for offline reading
 
2:13 PM
[ SmokeDetector | MS ] URL in title, bad NS for domain in body, bad NS for domain in title, bad keyword in body, bad keyword in title, +4 more: supplementlab.org/focus-zx1/ by juuuhtayz on apple.SE
tpu- by Glorfindel
 
2:30 PM
[ SmokeDetector | MS ] URL in title, bad NS for domain in body, bad NS for domain in title, bad keyword in body, bad keyword in title, +5 more: supplementlab.org/focus-zx1/ by ansel cassin on astronomy.SE
tpu- by Glorfindel
 
2:41 PM
[ SmokeDetector | MS ] URL in title, bad NS for domain in body, bad NS for domain in title, bad keyword in body, bad keyword in title, +5 more: supplementlab.org/focus-zx1/ by ansel cassin on physics.SE
 
@SmokeDetector k
 
@SmokeDetector k
 
[ SmokeDetector | MS ] Offensive answer detected: What happened to Boots, Tico and the rest? by thatguy on scifi.SE (@Mithrandir)
tpu- by Glorfindel
 
@SmokeDetector k
 
[ SmokeDetector | MS ] Few unique characters in answer, no whitespace in answer: Average speed checks for cars by tttttttttttttttttttttttttttttt on stackoverflow.com
tpu- by Glorfindel
[ SmokeDetector | MS ] Link at end of body: How to prevent laptop from sleep by Muhammad Yasser on askubuntu.com
fp- by Videonauth
 
2:58 PM
@SmokeDetector f
 
@Rob My fork still has the clean history so I'll work there
@NobodyNada Pretty sure you can repro it just by running any command that replies to you
@ArtOfCode define what?
 
[ SmokeDetector | MS ] Username similar to website in answer: Confusion about DNS settings in Ubuntu 17.10 by ookangzheng on askubuntu.com
naa- by Glorfindel
 
@Rob @tripleee thank you so much for getting it reverted
I'm fixing it now but first I need to make a PR to CE
@JeremyBanks are you around?
 
3:21 PM
Merged SmokeDetector #1349.
tpu- by DJMcMayhem
CI on 16c454d succeeded. Message contains 'autopull', pulling...
Restart: API quota is 13897.
 
@Andy no we reverted it because there's a bug left that I wasn't around to fix
it's a nuisance
 
!!/errorlogs 250
sd del-force
 
tpu- by Videonauth
 
!!/allnotificationsites 11540
 
@Nathaniel You won't get notified for any sites in that room.
 
!!/notify 11540 christianity-
!!/notify 11540 latin-
 
@SmokeDetector v
 
3:51 PM
naa- by Glorfindel
 
@quartata Hmm, I wasn't able to reproduce it. It was supposed to freeze up completely?
 
@Glorfindel User removed from blacklist (177903 on physics.stackexchange.com).
 
@quartata follow the reply chain
 
4:16 PM
@Undo I have a couple domains that are grandfathered in on Google's unlimited accounts too (unless that changed that in the last year or so).
If you don't want to use yours
 
4:29 PM
@quartata The only way I'm able to reproduce any sort of deadlock is by using mitmproxy to force a message post to fail.
Might I ask why we're using a custom message queue instead of letting CE handle that? I'm worried this might be a bit flaky -- there's a lot of things that could cause us to not recieve the message back, and websocket glitches aren't the least of them
 
We're actually guaranteed to receive the message back if it was posted
its weird but this is why:
basically when you post to /messages/new you actually get the message ID back right away, it's posted synchronously
the problem is that CE obfuscates this by then calling your message callback with the ID rather than returning it
it makes it seem like it's async but it's not
I literally found this out yesterday and I dont think anyone actually knew this because we've always been using a lock to wait for the message to "come back"
Now I think part of the actual problem might be that I don't call queue.task_done after retreving from the queue
even if that fixes it though I want to ditch the locks
(@NobodyNada)
 
4:55 PM
@quartata But on_msg comes from the websocket, does it not?
 
Normally yes. But CE calls it directly wth the newly posted message in this case
on the same thread that issued the _do_action I might add. I'm sure there's probably reentrancy problems up the wazoo
here half a moment I'll dig up the relevant line
actually wait a second
not sure that's the same callback
yeah that looks different from the room watch ones
so that's even worse: it just throws away the ID
although perhaps I can use that callback
hmmmmm
 
5:13 PM
@quartata yeah, we're not using that one, from what I could tell
 
yeah my bad
unfortunately it's also not really usable for my purposes, because I have to set the report data
 
@quartata What do you need that this callback doesn’t give you?
 
I mean I can use it
it's kind of a hack though
basically when I get the message ID back I need to put the report data in a dictionary with the message ID as a key
the report data is given to me as a parameter
so basically I need a closure
 
Can we take a step back and explain the problem for those that don't know CE that well? What is it doing in NG that it isn't doing in Smokey today?
 
so that the callback has the report data
 
5:25 PM
Or, if it's not CE, what does NG do different?
 
It's an issue in classic Smokey and NG, but classic Smokey had an easier time working around it because it didn't store the report data (just parsed it out of the message when it wanted it instead)
So here's the deal:
When you send a message via CE, it's done asynchronously in the sense that we don't get the message back (along with things like the message ID) until it comes down the websocket
When it comes down the websocket, the message that we posted goes into the callback for new messages like any other message
So what both versions of Smokey did was post the message and acquire a lock, then in the callback check to see if the new message was posted by SmokeDetector and if it is add it to our list of SmokeDetector messages and exit the critical region
Original recipe SmokeDetector didn't really think about the order the messages came back in (which was an oversight tbh), so it didn't acquire the lock until after the callback was called. In essence, the critical region was just the part where it was adding the message to the list
NG has one threading.Event for every room, and waits on it and then clears it before posting a message. The callback then sets it when it receives a message, which wakes up any threads that wanted to post another message to this room and was waiting
By waiting until we got a message back before posting another one, this tried to ensure that we got the messages in the order that they were actually sent
Of course, something is going wrong, and the event is not getting set causing a deadlock. What is causing that isn't important, what's important is that we shouldn't need the lock: when we post the message to /chats/{room}/messages/new, we get the ID of the message back immediately in the HTTP response. The only reason why we wait for it to come down the websocket is because CE discards the ID rather than returning it to us
@Andy does that flow kind of make sense?
 
sounds like a PR to CE to forward the ID
though it may do that because it handles it async
 
Yes, precisely.
 
@quartata But we can get the ID from on_message_sent, can’t we?
 
@ArtOfCode We're calling the synchronous _do_action_without_throttling
which by the way is a misleading name
it does actually respect backoffs and throttles like normal
@NobodyNada Yes, but that's a separate issue: we won't have the report_data when the callback is called
since it's in a separate function
If all we needed to do was append the message ID on_message_sent would do the trick
 
5:38 PM
Can we not use last_report_data like on_msg currently does?
 
I'm worried it could get overwritten if another message was sent
I dunno I haven't thought about it yet
 
Hmm...can that happen already though?
 
It shouldn't
report_data is set after acquiring the lock and then read before releasing it
see L143
 
Lemme give you a link to how I solved this in FireAlarm; just a sec
 
and then L185 for the end of the critical region
by the way thanks for actually reading chatcommunicate because it needs more eyes
I'm glad it's not totally unreadable since you seem to get what's going on there
@NobodyNada You kind of have more control since it's your own chat library :P
 
5:43 PM
@quartata Not a problem! It’s way better then the old one, thank you so much for doing this!
 
[ SmokeDetector | MS ] Misleading link: Mapfish Print Vector layer GeoJSON example? by TimD on stackoverflow.com
 
@quartata But since the on_message_sent synchronous, do we need to worry about this?
send_message won’t send multiple messages at once; if we’re worried about multiple instances of send_message running, we can just use a simple lock
 
fp- by Videonauth
 
@NobodyNada I love that Swift has strongly typed tuples
 
When reporting a post; I call SwiftChatSE’s postMessage with a completion handler that adds the message to an array. I use a semaphore to wait until the completion handler has been called for each room (postMessage is asynchronous), then store the report details (including the array of messages).
Not sure if that’s actually helpful...but it helped me to reason through this
 
Anonymous
5:58 PM
@quartata Partially around if still relevant.
 
@JeremyBanks You're able to merge PRs into ChatExchange right?
 
Anonymous
Yup.
 
Anonymous
Python 3's async stuff would make this so much easier than the threading mess we have in ChatExchange. :/
 
I should probably learn that
anyways the thing I might change is in this area of code right here
Rather than having a callback to consume the message ID I might add an option to just return it
like _do_action_despite_throttling(action, return_message_sync=True)
 
Anonymous
What you said above is the current code isn't actually async, it's blocking, just using a callback which is obnoxious and pointless? If so that sounds like a good change to me.
 
6:01 PM
Yeah, pretty much
 
Anonymous
cool
 
I don't know if anything is using the callback currently so I'll preserve the default behavior
but having an option to return the message ID since it's synchronous anyways would be really valuable to us
 
It looks to me like that method is designed to be called from a background worker thread, so the callback shouldn’t be removed in case others are using it/want to use it in that way
 
Anonymous
yeah, definitely don't break the existing behaviour
 
@NobodyNada yes, it's meant to be called from the usual queue worker
 
Anonymous
6:02 PM
but if it has no current return value, and we can add one without breaking anything, maybe worth having.
 
but we're skipping that since having our own queue lets us do the last_message stuff
 
@quartata Is there a reason it needs to be an option? Can’t it just return the message ID all the time?
 
@NobodyNada I was thinking in place of the callback but I guess there's no point in doing that
it has no other return value
it's a little weird to return something if the action was a send and not otherwise but eh y'know
although I suppose I can return response.json() always, that would make it more generic
 
CI on bb334c2 succeeded.
 
!!/pull
 
6:12 PM
[ SmokeDetector ] SmokeDetector started at rev bb334c2 (Glorfindel: !!/unwatch toster\.ru) (running on teward/Solar Flare)
Restart: API quota is 12081.
[ SmokeDetector | MS ] Bad keyword with email in body: Voice Analysis programming help wanted by Doc Alamo on softwareengineering.SE
 
[ SmokeDetector | MS ] Manually reported answer: Java API for convert DWF into PDF by Tarun Kumar Nayak on stackoverflow.com
 
!!/test nexacell
 
6:24 PM
> Would not be caught for title, body, and username.
 
!!/blacklist-keyword nexacell
 
@NobodyNada Blacklisted nexacell
 
17/17
 
CI on a077952 succeeded. Message contains 'autopull', pulling...
[ SmokeDetector ] SmokeDetector started at rev a077952 (SmokeDetector: Auto blacklist of nexacell by NobodyNada --autopull) (running on teward/Solar Flare)
Restart: API quota is 11932.
tpu- by FelixSFD
 
Anonymous
@quartata LGTM, I'll go review and merge in a second.
 
6:36 PM
who broke SE O_o ?
 
6:50 PM
[ SmokeDetector | MS ] Bad keyword in title, bad keyword in username, link following arrow in body, shortened URL in body: {Watch-Live}stade toulousain vs lyon live Stream European Rugby Challenge Cup 2017 Online Tv by Watch Free on drupal.SE
tpu- by Videonauth
 
7:05 PM
[ SmokeDetector | MS ] Username similar to website in answer: Use GCC compiler in Termux? by S D Rausty on android.SE
fp- by Videonauth
 
!!/blacklist-keyword (?:1\W*)?417\W*323\W*2635
 
@tripleee Blacklisted (?:1\W*)?417\W*323\W*2635
CI on f78da04 succeeded. Message contains 'autopull', pulling...
Restart: API quota is 11448.
 
!!/watch zeonpad\.com
 
@tripleee Added zeonpad\.com to watchlist
CI on a459325 succeeded. Message contains 'autopull', pulling...
[ SmokeDetector ] SmokeDetector started at rev a459325 (SmokeDetector: Auto watch of zeonpad\.com by tripleee --autopull) (running on teward/Solar Flare)
Restart: API quota is 11418.
 
7:23 PM
@Andy check yo inbox
 
@Videonauth when in doubt, blame @ArtOfCode
It's usually his fault somehow
 
naa- by DJMcMayhem
 
@SmokeDetector n
 
@Mithrandir this happened already two times today when i refreshed AskUbuntu:
 
7:27 PM
!!/help
 
@DJMcMayhem I'm SmokeDetector, a bot that detects spam and offensive posts on the network and posts alerts to chat. A command list is available here.
 
!!/AAAAAAAAAAAAAH
 
!!/BEEEEEEEEEEH
 
@ArtOfCode Why is "mevaqesh" a custom reason when that's only got one k result ever?
There's this and this but IMO neither are worth it
 
> Post matches pattern from a known troll
was probably asked to add it by a mod
 
7:35 PM
But with only 1 result?
I guess that kinda makes sense if it was only caught once after we added it
 
but yeah, most likely the trolling adapted or shifted form after things got done on our end
git blame shows Art as the author of the method
frankly, the biggest burden of these troll patterns is probably the archaeology we have to do to figure out why they are in the code
 
@tripleee Well if they're outdated/no longer hitting, should they be removed?
 
7:43 PM
I dunno, I tried to get another old troll pattern removed at one point but it was felt that the infinitesmal processing overhead easily trumped the trouble of not catching it if it ever happened again
looking at the cycles of some of the spam patterns we have, pruning stuff which is younger than two years is probably too aggressive if we can just keep up with the processing load
though the lists have been growing much more in the last six months, especially the watchlist which was only introduced in May
 
8:11 PM
[ SmokeDetector | MS ] Repeating characters in answer: Are minus-primorial-primes rarer than plus-primorial primes? by VincS on math.SE
tpu- by DJMcMayhem
 
!!/watch vincsmath\.com
 
@Mithrandir Added vincsmath\.com to watchlist
CI on 9867e5d succeeded. Message contains 'autopull', pulling...
Restart: API quota is 10805.
[ SmokeDetector | MS ] Misleading link: Как реализовать text-to-speech на Java? by sasvak on ru.stackoverflow.com
fp- by Videonauth
[ SmokeDetector | MS ] Link at end of answer, username similar to website in answer: icon is not in 3.00 format by macfreesoftware on stackoverflow.com
 
8:31 PM
sd k
 
@SmokeDetector k
 
8:47 PM
[ SmokeDetector | MS ] Username similar to website in answer: Do horse armor enchantments have an effect? by flufyskinwalker on gaming.SE
 
@SmokeDetector k
!!/watch flyfyskinwalker
 
@tripleee Added flyfyskinwalker to watchlist
 
Is that k or should we just edit it out? It looks like it (somewhat) answers the question
 
CI on ca2488a succeeded. Message contains 'autopull', pulling...
 
hmmm, it looked too VLQ to keep but you could be right
 
8:51 PM
Restart: API quota is 10415.
 
@SmokeDetector f
 
Conflicting feedback across revisions: current, #1
 
@SmokeDetector tp-
 
9:20 PM
tp- by J F
 
@SmokeDetector v
 
9:38 PM
New metasmoke user 'Philip Klöcking' created
 
!!/blame
 
@DavidPostill It's Mithrandir's fault.
 
tsk tsk
 
@ArtOfCode Two things: 1. The text message verification on zoho uses the same number as steam. Learned that when the message showed and and showed me a password reset I requested in January for Steam. 2. Now that I'm set up...now what? I currently get the emails that are sent to admins to my personal address. Do I just need this one for Channels? Will it forward? Can I make it forward?
Ok...I cheated and made #2 a multipart question
In completely unrelated news, if I could take a computer game AI out back and shoot it, I would do that in Stellaris right now. 100 years of peaceful coexistance down the drain. Apparently they wanted my metastructure and built up a giant fleet to take it from me. glares at computer I will destroy you later. First I must rebuild.
 
[ SmokeDetector | MS ] Few unique characters in body, title has only one unique char: ///////////////////////////////////////////////////////////////////////////////‌​/// by EvanDennehy11 on stackoverflow.com
 
sd v
 
ninja'd
 
@SmokeDetector I suggested an edit to that.
 
10:35 PM
tpu- by DJMcMayhem
 
Rob
10:57 PM
@quartata Yeah, but when you come to merge; bad things will happen
You'll need to merge the main repo into your fork, then revert my revert; and you'll be fine when merging in the future
 

« first day (1481 days earlier)      last day (343 days later) »