@ArtOfCode Possible API V1/V2.0 issue (potentially related to the other feedback issue): For feedbacks posted by FIRE, a couple fields/properties have null values. The two properties which are null, that I'd expect to be valid, are: post_link and user_name. These fields are valid with other feedback methods & don't appear to be feedback method dependent. FIRE appears to expect user_name to be valid in all cases, which implies that property shouldn't be null. Should these be valid?
@ArtOfCode Possible API V2.0 issue (possibly/probably related to the other 404 issue): I'd considered getting a list of users from /api/v2.0/users, but that also returns "No Route". I would use this to fill in the feedbacks where user_nameis null, but there is a valid user_id.
Those fields are null because they actually are null, in the database. We stopped keeping user_name on Feedback when we started linking metasmoke and SE accounts, because we can just keep a user_id on Feedback and the User model stores all the chat user data.
That does cause issues with the API, though, so - again when MS gets deployed - we're starting to fill in user_name again
@ArtOfCode OK. Sounds reasonable. Then that looks like, for the future, FIRE doesn't need to get the users from /api/v2.0/users and match the user name up to the ID in order to know which feedbacks were made by the current user.
@ArtOfCode Good. Then it's a no-op as far as updating FIRE. It should "just work" when MS is deployed. It's not unreasonable to just record the ID. Converting to a user name is something that it's not unreasonable to expect the client to do.
@Undo As-yet-unconfirmed - this literally happened about two hours ago. Ex-colleague started an online business and asked for various consulting help, so I stuck my head in the virtual door and she got back to me a couple hours ago saying yes please. Some sort of technical consulting - not sure if software or just general "make it work", but I'm getting paid either way so I'm not sure I mind
In the Suggested Edits queue, I just encountered (and rejected) an attempt by someone to add a spam link (a link to their own blog, with no disclosure of affiliation) to a tag wiki. The other reviewer who reviewed the suggested edit also caught the spam and also rejected it using the "Spam or Van...
@TetsuyaYamamoto That pattern looks like it's already caught by Potentially bad keyword in body and Potentially bad keyword in answer; append -force if you really want to do that.
> Potentially bad keyword in body, potentially bad keyword in title, potentially bad keyword in username ---------- Title - Position 1-23: valentinegifts2018.com Body - Position 1-23: valentinegifts2018.com Username - Position 1-23: valentinegifts2018.com
[ SmokeDetector | MS ] Bad NS for domain in body, bad NS for domain in title, blacklisted website in body, blacklisted website in title, pattern-matching website in body, +3 more: healthflyup.com/cbd-gummy-bears/ by user268384 on apple.SE
@TetsuyaYamamoto Post - Bad keyword Data Service in link text
[ SmokeDetector | MS ] Bad NS for domain in body, bad NS for domain in title, blacklisted website in body, blacklisted website in title, pattern-matching website in body, +2 more: healthflyup.com/cbd-gummy-bears/ by miss fatima on astronomy.SE
[ SmokeDetector | MS ] Bad NS for domain in body, blacklisted website in body, link at end of body, pattern-matching website in body, potentially bad keyword in body, +2 more: Press Free - Strengthened CBD Gummy Bears by pwjtglub on askubuntu.com (@ThomasWard)
[ SmokeDetector | MS ] URL-only title, blacklisted website in body, blacklisted website in title, link at end of body, pattern-matching website in body, +1 more: musclebuildingbuy.com/core-max-ultra/ by Nhtzsloi on askubuntu.com (@ThomasWard)
[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, bad keyword in title, blacklisted website in body, link at end of body, +1 more: How to Use it male onyx? by vachr on workplace.SE
[ SmokeDetector | MS ] URL in title, bad NS for domain in body, bad NS for domain in title, bad keyword in body, bad keyword in title, +4 more: x4up.org/best-cbd-oil/ by pzejtcwja on drupal.SE
[ SmokeDetector | MS ] URL-only title, bad NS for domain in body, bad NS for domain in title, bad keyword in body, bad keyword in title, +7 more: supplement4help.com/testx-core/ by mzwxdcvmv on askubuntu.com (@ThomasWard)
[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, bad keyword in title, blacklisted website in body, link at end of body, +2 more: Vitanoria will not mis by user772745 on askubuntu.com (@ThomasWard)
[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body: a nutritionist and bring by Ata ked on drupal.SE
[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body: So if you want to make the by user80965 on workplace.SE
