Charcoal HQ

2:00 PM

[ SmokeDetector ] Blacklisted user: Browsing OLAP cubes by João Pessoa on stackoverflow.com …

@SmokeDetector Hm, it discloses affiliation, and the question asked for product recommendations, so this is what it got.

undo

@zaq Feels like spam, but I'm just going to delete it and close the question.

sd n

because I don't feel like calling it an f

Petter Friberg

@undo 3 reports on this already metasmoke.erwaysoftware.com/…

undo

Aye, but in this case I can't really call it undisclosed self promotion.

Petter Friberg

oki just wanted to let you know

Magisch

2:14 PM

@undo Visiting metasmoke.erwaysoftware.com/post/26369 produces an error

undo

norepro

Magisch

@undo "We're sorry, but something went wrong."

Ferrybig

repro for me

undo

just a sec

Magisch

"If you are the application owner check the logs for more information."

undo

2:15 PM

I know

that message doesn't change much time-to-time

ArtOfCode

norepro

Magisch

@undo For what its worth, all 4 links of the metasmoke.erwaysoftware.com/post/<postid>; type I tried so far are erroring out for me

ArtOfCode

Ugh, did I break it by messing with admin stuff?

Magisch

And the entries of metasmoke.erwaysoftware.com/posts are now somehow center-aligned (the links)

and thats very irritating

undo

I, [2016-08-10T14:15:49.414666 #32068]  INFO -- : Completed 500 Internal Server Error in 26ms (ActiveRecord: 0.4ms)
F, [2016-08-10T14:15:49.415411 #32068] FATAL -- :
F, [2016-08-10T14:15:49.415442 #32068] FATAL -- : ActionView::Template::Error (undefined local variable or method `feedback' for #<#<Class:0x007f34d8a89580>:0x007f34d956c380>
Did you mean?  feedbacks):
F, [2016-08-10T14:15:49.415577 #32068] FATAL -- :      8:      <% end %>
F, [2016-08-10T14:15:49.415602 #32068] FATAL -- :      9:   </strong>

@ArtOfCode ^

ArtOfCode

2:21 PM

ugh, one character

Magisch

Short circuit evaluation

thats why it works for you guys

ArtOfCode

yeah

undo

@Magisch uh... screenshot? norepro here again

Ferrybig

@Magisch norepro

Magisch

@undo Went away after I closed and reopened my browser

ArtOfCode

2:23 PM

that commit should fix

Magisch

Heh

I get off work in 7 minutes

I'll be home in around 40

undo

@ArtOfCode I've got a few more going in, will bundle everything

ArtOfCode

sure

Andy

I can't repro any errors on the links above either

Magisch

@Andy Because you're an SE admin

The error happens for non-admins only

undo

2:25 PM

@Magisch no

Magisch

@undo (current_user.is_admin || feedback.where(:user_id => current_user.id).exists?) the part after the || is where the error happens, no?

undo

yes

ArtOfCode

@Magisch yes, but Andy isn't an admin

undo

Andy doesn't have special MS privs AFAIK

Magisch

So if current_user.is_admin evaluates true it short circuits out

Andy

2:26 PM

Sssssh...he just granted me SE admin.

undo

@Magisch yes

deploying now anyway

Magisch

How would a non-admin not get that error then?

Mhm ok

Ferrybig

Does that line gets problems if there isn't a user logged in? Or does current_user follow a null-object-design-pattern?

Andy

I am not logged in.

ArtOfCode

> ID Username Review-approved? Admin? Code Admin?
> 15 Andy Yes No No

undo

2:28 PM

deployed, anyone repro?

SmokeDetector

[ SmokeDetector ] Link at end of answer: How to get Google PageRank (from the toolbar) to increase from 0? by pankaj on webmasters.stackexchange.com …

undo

that was fast

Magisch

@undo metasmoke.erwaysoftware.com/post/36966 still erroring out -> metasmoke.erwaysoftware.com/post/36968 works

undo

F, [2016-08-10T14:29:26.596921 #3807] FATAL -- :
F, [2016-08-10T14:29:26.597004 #3807] FATAL -- : ActionView::Template::Error (undefined method `where' for #<Array:0x007f9128eefd20>):
F, [2016-08-10T14:29:26.597176 #3807] FATAL -- :      8:      <% end %>
F, [2016-08-10T14:29:26.597234 #3807] FATAL -- :      9:   </strong>
F, [2016-08-10T14:29:26.597281 #3807] FATAL -- :     10:   <% unless feedbacks.empty? %>
F, [2016-08-10T14:29:26.597324 #3807] FATAL -- :     11:     <% if current_user.present? && (current_user.is_admin || feedbacks.where(:user_id => current_user.id).exists?) %>

ArtOfCode

ffs

Why is that an Array, anyway?

undo

2:29 PM

Looks like it'd already been evaluated by the time it got there.

Andy

@Magisch No repro again. Both links work for me

Magisch

Well, I'm off work now

ArtOfCode

That should be an ActiveRecord::Association

Magisch

Catch y'all in half an hour

undo

cya @Magisch :)

Quill

2:29 PM

how did this pass review scifi.stackexchange.com/review/suggested-edits/88316

ArtOfCode

because sff

zaq

Also, the unconventional style of that answer provoked that.

ArtOfCode

@undo do I assume correctly that you're gonna do the Smokey-side of sending CI status through the websocket in a few?

undo

@ArtOfCode yes

ArtOfCode

sweet

undo

2:37 PM

have it locally, actually

!!/pull

SmokeDetector

@undo CI build is still pending, wait until the build has finished and then pull again.

undo

liar

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 0626f51 (Undo1: Test out CI integration) (running on Raspberry Pi)

Restart: API quota is 9270.

[ SmokeDetector ] Link at end of answer: How to find long term accomodation online in France? by user10124 on expatriates.stackexchange.com …

{u'status': u'success', u'commit_message': u'Test out CI integration', u'ci_url': u'https://travis-ci.org/Charcoal-SE/SmokeDetector/builds/151234655', u'commit_sha': u'0626f51236df11827f4c8f4043d33480383d009b'}

undo

So it works

or that part works

ArtOfCode

I'm not sure I'd call that working just yet...

undo

2:42 PM

semantics

Byte Commander

@SmokeDetector spam or not?

undo

@ByteCommander I'm calling it spam, the wording is really weird

ArtOfCode

@ByteCommander you just fed back on that

undo

lol

ArtOfCode

spam is recognized feedback :)

Byte Commander

2:43 PM

> no element found0656:1:1
Use of getPreventDefault() is deprecated. Use defaultPrevented instead.jquery.min.js:3:6598
no element foundevent:1:1
Use of Mutation Events is deprecated. Use MutationObserver instead.jquery.min.js:3:767
500 {"error_name":"failed","error_code":500,"error_message":"Feedback object failed to save."}8971:106:29

Had this in my dev console after flagging as spam and getting the red smokey userscript error box.

@ArtOfCode Okay? Good to know... :D

ArtOfCode

@ByteCommander was the post reported by Smokey?

Byte Commander

It was the one we were talking about.

@SmokeDetector this one

ArtOfCode

@undo can you look at prod logs for that please?

Byte Commander

Maybe it crashed because of double-feedback?

1. through my "spam or not" reply and second through the userscript...

ArtOfCode

@ByteCommander oh, that's probably it? Maybe. We'll see what the logs say.

It should reject dupe feedbacks from the same user, yeah

undo

2:47 PM

I, [2016-08-10T14:44:14.234442 #5935]  INFO -- : Processing by ApiController#create_feedback as */*
I, [2016-08-10T14:44:14.234493 #5935]  INFO -- :   Parameters: {"type"=>"tpu-", "key"=>"070f26ebb71c5e6cfca7893fe1139460cf23f30d686566f5707a4acfd50c", "id"=>"36969"}
D, [2016-08-10T14:44:14.235136 #5935] DEBUG -- :   ApiKey Load (0.1ms)  SELECT  `api_keys`.* FROM `api_keys` WHERE `api_keys`.`key` = '070f26ebb71c5e6cfca7893fe1139460cf23f30d686566f5707a4acfd50c' LIMIT 1
D, [2016-08-10T14:44:14.236385 #5935] DEBUG -- :   User Load (0.3ms)  SELECT  `users`.* FROM `users` WHERE `users`.`id` = 29 O…

@ArtOfCode ^ That's all I've got.

Byte Commander

I associated my metasmoke and my SE accounts.

undo

@ByteCommander Shouldn't matter

ArtOfCode

@undo yeah, that's enough, ta

Dupe feedback got rejected

Byte Commander

Ok, but got to go now...

cya

Quill

@undo I just signed up for a metasmoke account

pls activate. kthnx

undo

2:53 PM

@Quill account to activated, very done much welcome

Quill

sd f

Ferrybig

sd notspam

ArtOfCode

@undo is this post deleted to you?

Ferrybig

:31598773 still 500 error, cant see the source of the conflicting feedback

undo

@ArtOfCode Aug 2 @ 3:00?

yeah

ArtOfCode

2:56 PM

Yeah. Now look at its timeline or revision history.

undo

oh. undelete(1)

huh

ArtOfCode

But I certainly haven't undeleted it... calling bug

undo

I've seen deletions get queued weird before. Might ping Adam.

(Lear)

ArtOfCode

Yeah, I was debating it. I posted a bug on our meta, anyway.

Quill

is there another Adam?

undo

2:59 PM

@Quill The other moderator on HR

Quill

Ah, okay

Greg P

sd f

SmokeDetector

@GregP [:31599001] That message is not a report.

Greg P

@SmokeDetector f

Quill

;-; smokey pls

undo

3:03 PM

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev d9ecca4 (Undo1: Try to get autopull working) (running on Raspberry Pi)

Restart: API quota is 9079.

undo

Well, it's still broken but not critically so. Have to go afk right now, cya folks :)

shouldn't be too noisy

Greg P

4:51 PM

!!/alive

SmokeDetector

@GregP Of course

SmokeDetector

5:01 PM

[ SmokeDetector ] Link at end of answer: Xenial 16.04.1 LTS root filesystem mounted read only by user580433 on askubuntu.com …

Magisch

@SmokeDetector n

SmokeDetector

5:19 PM

[ SmokeDetector ] Few unique characters in body: Is there a correlation between Brownian motion and cosmic microwave background radiation? by Symmetry on physics.stackexchange.com …

Magisch

@SmokeDetector tp-

Greg P

sd tp- vandalism

rene

someone on Physics.se need to reject this: physics.stackexchange.com/review/suggested-edits/142226

Greg P

it's been rejected by a mod

rene

K

SmokeDetector

5:41 PM

[ SmokeDetector ] Bad keyword with email in body: we teach eachother ，I teach you chinese，you teach me other language！ by M.jason on chinese.stackexchange.com …

SmokeDetector

6:09 PM

[ SmokeDetector ] Blacklisted user: asymptotic - inverse series big o by misztsu on stackoverflow.com …

Andy

@SmokeDetector why

SmokeDetector

@Andy Blacklisted user - blacklisted for stackoverflow.com/a/38536748 (metasmoke.erwaysoftware.com/posts/by-url?url=//…) by chat.stackexchange.com/transcript/message/31230789#31230789

Brock Adams

@SmokeDetector f

!!/rmblu stackoverflow.com/u/6515669

SmokeDetector

@BrockAdams User is not blacklisted.

Brock Adams

^^^ Forgot that sd f removes BL now (in select circumstances).

TIPS

6:22 PM

Pretty weird.

These guys say "f" means "fp-", then add a "remove blacklist" feature.

So it becomes a "fpu-" but it doesn't mean "fpu-".

Ferrybig

"fpu" add its to the whitelist

TIPS

Whatever ┬─┬ ノ( ^_^ノ)

zaq

6:41 PM

sd f

zaq

7:04 PM

The MetaSmoke route /post/{id} throws "We're sorry, but something went wrong."

The rest of the site still works.

SmokeDetector

[ SmokeDetector ] Bad keyword in title: Where can I find product data (Images, Nutritional, ingredients, Descriptions etc.) for Vitamins & Supplements by Abraham on opendata.stackexchange.com …

Brock Adams

sd f

ArtOfCode

@zaq cc @undo because he needs to look at the logs again

SmokeDetector

8:02 PM

[ SmokeDetector ] Link at end of answer: Is there a free JQuery plugin for grids by Nick Thomsan on stackoverflow.com …

[ SmokeDetector ] Link at end of answer: Introducing money to a barter based economy by problem on worldbuilding.stackexchange.com (@QPaysTaxes) …

Byte Commander

@SmokeDetector not sure if this is spam

SmokeDetector

[ SmokeDetector ] Link at end of answer: Wysiwyg with image copy/paste by a deleted user on stackoverflow.com …

zaq

8:21 PM

@ByteCommander It isn't, the problem is with the question there (now closed)

Byte Commander

@SmokeDetector also not sure about this one

zaq

Both those SO posts already have fp feedback; generally I just don't worry about SO posts when it's hard to figure out what's going on.

Brock Adams

@zaq That "Wysiwyg" answer is link-only, so it's NAA. It's also non-malicious spam and doesn't address the question's concerns. ... Finally, the question should be closed as off topic -> recommendation.

Also, the answer was just nuked by a moderator.

zaq

And the question closed by him.

!!/pull

SmokeDetector

8:40 PM

[ SmokeDetector ] SmokeDetector started at rev a1f6c12 (Normal Human: appsforwin10) (running on Raspberry Pi)

Restart: API quota is 6803.

zaq

9:03 PM

@SmokeDetector f

undo

9:27 PM

@ArtOfCode Hypothetically, why can't we expose error messages?

Doorknob

undo is lowercase O_o

undo

@Andy Probably thursday. cc @ArtOfCode @Magisch

ArtOfCode

@undo no reason, we already expose the code

just take care of your environment variables

undo

As long as it doesn't show the console, we should be okay

@ArtOfCode there shouldn't really be anything important in them, but we'll see

ArtOfCode

@undo you mean tomorrow?

undo

9:31 PM

the very same

ArtOfCode

@undo check your vars, because I think the full error messages show env vars

It won't show the console to anything outside the whitelist (which is only LAN by default)

undo

deploy pending

@ArtOfCode See anything dangerous on metasmoke.erwaysoftware.com/reason/350?

ArtOfCode

@undo as long as the warden user key isn't feasibly decryptable, no

undo

@ArtOfCode Decryptable to the prod secret, right?

Pretty sure no one is going to guess that.

ArtOfCode

Also, what do the logs say about chat.stackexchange.com/transcript/message/31605693#31605693?

undo

9:38 PM

well... it'd be nice to have a specific post, but lemme look

ArtOfCode

@undo I think the prod secret is the encryption key, actually. I don't know what that contains, but if it's encrypted it's probably sensitive enough to care about

zaq

@undo Any one, like metasmoke.erwaysoftware.com/post/36981

undo

Same one that was getting us earlier.

F, [2016-08-10T21:39:28.953605 #6861] FATAL -- : ActionView::Template::Error (undefined method `where' for #<Array:0x00000002a36b08>):
F, [2016-08-10T21:39:28.953728 #6861] FATAL -- :      8:      <% end %>
F, [2016-08-10T21:39:28.953751 #6861] FATAL -- :      9:   </strong>
F, [2016-08-10T21:39:28.953765 #6861] FATAL -- :     10:   <% unless feedbacks.empty? %>
F, [2016-08-10T21:39:28.953789 #6861] FATAL -- :     11:     <% if current_user.present? && (current_user.is_admin || feedbacks.where(:user_id => current_user.id).exists?) %>

I'll look at it

heh

feedbacks = @post.feedbacks.to_a

I found your problem :P

ArtOfCode

...why was that there in the first place?

undo

@ArtOfCode Make things a little cleaner in other places.

I'm committing

however you spell that

ArtOfCode

9:41 PM

correctly

undo

@zaq Fixed?

zaq

yes

undo

yay

!!/pull

this'll crash

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev a4a7498 (Undo1: Temporarily remove error catching on metasmoke websockets) (running on Raspberry Pi)

Restart: API quota is 6430.

Restart: API quota is 6424.

undo

!!/errorlogs 100

SmokeDetector

9:54 PM

Restart: API quota is 6408.

undo

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 5185494 (Undo1: 'message' => 'commit_message') (running on Raspberry Pi)

Restart: API quota is 6404.

Restart: API quota is 6401.

undo

!!/errorlogs 100

I'm an idiot

4

SmokeDetector

Restart: API quota is 6393.

undo

!!/pull

SmokeDetector

9:59 PM

[ SmokeDetector ] SmokeDetector started at rev e88541c (Undo1: GlobalVars needs to learn how to send messages) (running on Raspberry Pi)

Andy

@undo Awesome. I love being proved wrong and this was a good thing to be wrong about.

SmokeDetector

CI on a4a7498d760022ae5abb86b2783e525fe998e79b succeeded.

undo

There we go

Might shorten that up a little

SmokeDetector

Restart: API quota is 6387.

ArtOfCode

@undo truncate to 7 chars like metasmoke and GH summaries do

SmokeDetector

10:01 PM

CI on 4a428d437a7d4edb78cb6c9712c5855ff5eb6717 failed.

undo

(manually pushing buttons)

SmokeDetector

CI on 574ba2663525f3d948bce2c4b403cef4c1a7eb8a succeeded. Message contains 'autopull', pulling...

undo

there we go

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 574ba26 (Undo1: Truncate commit sha --autopull) (running on Raspberry Pi)

Restart: API quota is 6355.

CI on 5185494 succeeded.

undo

That'll work

SmokeDetector

10:06 PM

CI on 574ba26 succeeded. Message contains 'autopull', pulling...

undo

um

So that's not supposed to happen

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 574ba26 (Undo1: Truncate commit sha --autopull) (running on Raspberry Pi)

Restart: API quota is 6352.

Ferrybig

Can't we migrate the tests from travis to circle ci, then we would only have 1 CI and would make the autopull much easier

undo

we could

they're the same tests

or we could do it right and not autopull if we're already on that commit

Andy

What's the difference between Travis and circle? I've really only used Travis before

undo

10:10 PM

Spelling, mostly

Andy

Ah

SmokeDetector

CI on a08e7c6 succeeded. Message contains 'autopull', pulling...

[ SmokeDetector ] SmokeDetector started at rev a08e7c6 (Undo1: Revert removal of error handling in metasmoke websockets --autopull) (running on Raspberry Pi)

Ferrybig

At the moment, !!/pull only need 1 CI to finish before pull works, while if using autopull, we probably need to wait until both platforms are done

SmokeDetector

Restart: API quota is 6316.

undo

@Ferrybig no

SmokeDetector

10:13 PM

CI on a08e7c6 succeeded. Message contains 'autopull', pulling...

undo

both platforms run exactly the same thing. We're mostly just racing them against eachother.

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev a08e7c6 (Undo1: Revert removal of error handling in metasmoke websockets --autopull) (running on Raspberry Pi)

Restart: API quota is 6309.

Andy

Regarding the discussion with SE tomorrow, can someone ping me when it starts? I will be traveling for portions of the day so may need the prod to know when it starts

2

ArtOfCode

I'm already pinging about 4 other people, so sure :)

undo

@ArtOfCode ping me too if I don't show up

ArtOfCode

10:15 PM

So let's see. Ashish, Magisch, GregP, Andy, Undo. Anyone else?

Of course, you're all assuming that I'll be here when it all kicks off :)

undo

well of course you will be

Your activity graph indicates that you rarely sleep