The check-list is a good one (Did I satisfy all requirements in my most recent post? I must check) and I endorse the Dagg comment but for an odd reason: the Rule of Three. The Rule of Three is that any list should contain three and only three items. If detail is necessary, each item should have t...
I have the following MATLAB Code which I want to optimize.
It's related to image matrix (2D) which I want to filter.
The problem is I'm trying to access neighbors of the pixel which might cause problems at the boundaries of the image matrix.
vWeightsCoeff = zeros((2 * numRows * numCols), 1);
we...
Whenever I needed something similar like a "Class" in Javascript, I wrote it like this:
function Point(x, y){
var self = this;
self.x = x;
self.y = y;
self.dist = function(){
return Math.sqrt( (self.x*self.x) + (self.y*self.y) );
}
}
var p = new Point(10, 20);
p.x = ...
I am very new to programming and this is my first time posting a question on Stack Overflow so please tell me if I am doing something wrong.
I wrote this program:
#include <stdio.h>
#define printS for(i=0;s[i];i++){printf("%c",s[i]);}
int i;
char s[] = "Hello World!\n";
void main()
{
printS...
> Should we even go one step up and make a flowchart on how to use the SE network during programming to get people to better understand when to post on CR?
@Mat'sMug: Yeah, but I meant something with decision points like: Did I research the problem on google for more then 15min? No -> Do some more research
Hello guys I have to generate the unique key having length 8 which should be comprised with some set of character {B,C,D,F,G,H,J,K,L,M,N,P,Q,R,S,T,V,W,X,Y,Z,2,3,4,5,6,7,8,9}
Now I have written a program that will generate it. but I am not sure it will generate the unique key. could you please re...
For a homework assignment, I made a web page that has a text area. The user inputs some text, hits the analyse button, and the output is supposed to be a list of the frequency of words of a given number of characters. For example, "one two three" would be two words of three characters and one wor...
I wrote this program:
#include <stdio.h>
#define printS for(i=0;s[i];i++){printf("%c",s[i]);}
int i;
char s[] = "Hello World!\n";
void main()
{
printS;
}
It outputs exactly what I want it to but I have no clue if this would be acceptable to use if I were working for a company.
Would this ...
> One thing I notice is that if I enter an expression like '1000000000000000000000000000000*100000000000000000000000000000', I get some result that is obviously incorrect.
This was my first attempt at making a C++ calculator. The user basically inputs an expression (I'll use 1+1*(9*(11-1)) as an example) and the program searches for and creates vector for parentheses (which is a class i made which records its position in the string), like so:
String:
[1][+][1...
public interface IMyInputProviderPlugin
{
IMyOutput Provide(IMyInput data);
}
This is an interface I need to provide so that I can dynamically load the dlls and not have them bound to my implementation.
However, upon reading this, it seems like this is an anti-pattern?
http://blog.ploeh....
I found myself looking for someplace to point a new user on why his answer wasn't a good answer. I couldn't find anything except the fairly unhelpful Help page's "How do I write a good answer.
So, I'm putting it to the community. What makes for a good Code Review? What are the essential parts? ...
When I was answering this question I wanted to insert a link to ideone.com - where the code I wrote was used as a demonstration - and I encountered a message that said:
Please make your answer complete by including relevant, formatted code inline(don't just link to ideone.com):
Screenshot:
...
Length is but a symptom of an actual problem with a post. Short posts are not bad, for instance, but oftentimes they miss critical details that make definitively answering a post extremely difficult. It's not that short is bad; it's a symptom.
Likewise, posts that are long may not be bad simply...
> Yet, posts that are long are more likely to lack the focus that accompanies conciseness and brevity. Long posts sometimes tend to be long because they contain unnecessary information, or because they contain more than one problem.
@DaggNabbit I actually removed a class from my latest question and just wrote a summary about that class instead. For big(ger) code projects, it's impossible to include everything..
I have a feeling that my next question will also be excessively long, which will be about my Minesweeper probability calculation code (which I bet @rolfl might be quite interested to have a look at by now)
You are going to get either partial reviews (small reviews on a subset of the code), or, you may get some general comments about the overall design, but not much detail.
For long questions, when they are 'dense' like Simon's normally are, it takes a large amount of background investigation to understand the context of the question... I have to 'immerse' myself in the problem.
@DaggNabbit If your question is in Java (or another reasonably understandable language) and it is about an interesting problem, then I am quite likely to review it. (It may take some time, but still)
I wonder if this is also where user-retention comes into play. If it's a "simple" review (like the question I've just reviewed), it'll take less time for someone to know how to answer. But for longer questions, it'll take more discipline (more of a "code review spirit" if you will) to read through the question and write a review. So, the user-retention issue may just be a core issue of ours, at least in terms of posting answers.
Simon, I had reason to browse my tag scores the other day. Despite earning 'generalist', I have only 1 language tag in my top 10 (Java), and my 'second' language is SQL at #12, and then, amusingly, I have C# at #13.
@Jamal But a "complicated" review (like my questions usually require) can be very valuable for the asker. And can also be helpful to the answerer (perhaps they learn a thing or two while reading the code).
@rolfl Is Android a language-tag? If not, I need 11 more C# upvotes.
@SimonAndréForsberg I agree. Again, it comes down to discipline. Many users may just want fast results, which we cannot always fulfill. That alone may drive some away, even though our intention isn't to have others want a long time.
@rolfl Just a couple of days or weeks after I joined the site and this chatroom, I was told (by @Mat'sMug) that we, the users, own the site. In a way, I still believe that.
@SimonAndréForsberg Well hello, welcome to CR chat! I was kinda scared to post anything on SO chat, but here.. it feels like we freakin' own this site! Actually, we do!
If you don't want the comment "just use the variant from boost", then say that you're using your own variant class. If you have a good reason for why you're using your own, then say so. If reviewers may or may not agree with your reason.
Just make it clear that you're aware of the existing libraries and that you know that those should be used. Surely that should keep people off your back about it. Worked for my recent question where I massively recreated the wheel... :p
The limited domain and the specific operators might actually make it worth having your own variant then. Although, one could easily still say that it should just be a wrapper around boost::variant :p.
I actually wrote my own variant fairly recently too for some bencoding with regards to torrent files. boost::variant just seemed way over kill compared to a glorified union :/ lol
(Well, that and I didn't want to have a boost dependency for 1 thing)
I'd be interested to hear Jerry or Loki's thoughts on it. There's still a little part of me saying "but... but... but... boost!" I think that's just because SO (and to a lesser extent CR) has drilled in my head "if a boost version exists, you should always use it."
And in all honesty, a boost version probably is going to be better than anything either of us is going to write. It's just a question of if it's worth it.
Hahahaha
Instead of a nice little note, the card just has a URL on it to a github repo :p
It's gonna be really funny if he sees the question later or sees later conversation about it and immediately is just like "you should use boost::variant"
Yeah, definitely kills the vibe of "just include it!" lol
Idk... You should post your variant, and that will tell a lot about if boost is worth pursuing.
I remember being surprised how hard it was to code a standards compliant variant. All kinds of alignment issues :/. Thank god for C++11 and it's aligned_struct or whatever it's called.
@Corbin: Care to take a crack at that C++ calculator question? It's quite messy, and I don't have the energy (nor the number of monitors) to give a very thorough review.
Yeah, the design is a big problem here (at least the OP acknowledges that). Someday I'll get two monitors, which should make it easier to handle larger reviews. All I have now is my laptop and trackpad. :-/
Eh, it could be much, much worse. If there was no proper spacing and inconsistent indentation, this may literally look like the aftermath of a hurricane.
In javascript, any function is basically an object on which you can call (function(){}).toString() to get it's underlying code as a string.
I'm working on a function aimed to do the job in PHP.
Looks like this so far:
function fn_to_string($fn, $strip_comments = true) {
static $contents_c...
I have the following MATLAB Code which I want to optimize.
It's related to image matrix (2D) which I want to filter.
The problem is I'm trying to access neighbors of the pixel which might cause problems at the boundaries of the image matrix.
vWeightsCoeff = zeros((2 * numRows * numCols), 1);
we...
Perhaps something like this could help situate CR in StackLand:
I am very new to programming and this is my first time posting a question on Stack Overflow so please tell me if I am doing something wrong.
I wrote this program:
#include <stdio.h>
#define printS for(i=0;s[i];i++){printf("%c",s[i]);}
int i;
char s[] = "Hello World!\n";
void main()
{
printS...
public interface IMyInputProviderPlugin
{
IMyOutput Provide(IMyInput data);
}
This is an interface I need to provide so that I can dynamically load the dlls and not have them bound to my implementation.
However, upon reading this, it seems like this is an anti-pattern?
http://blog.ploeh....
When I was answering this question I wanted to insert a link to ideone.com - where the code I wrote was used as a demonstration - and I encountered a message that said:
Please make your answer complete by including relevant, formatted code inline(don't just link to ideone.com):
Screenshot:
...
Length is but a symptom of an actual problem with a post. Short posts are not bad, for instance, but oftentimes they miss critical details that make definitively answering a post extremely difficult. It's not that short is bad; it's a symptom.
Likewise, posts that are long may not be bad simply...
In javascript, any function is basically an object on which you can call (function(){}).toString() to get it's underlying code as a string.
I'm working on a function aimed to do the job in PHP.
Looks like this so far:
function fn_to_string($fn, $strip_comments = true) {
static $contents_c...
